Skip to content
Snippets Groups Projects
Commit b0464c2a authored by Christian Kuhn's avatar Christian Kuhn Committed by Anja Leichsenring
Browse files

[TASK] De-mess EM InstallUtility a bit

Service classes in Extensionmanager\Utility
are a great example on "when class abstraction
goes wrong" - we're fighting with those for
lots of major versions already.

To tame this mess, this first patch applies a rather
straight streamlining to InstallUtility: Use constructor
property promotion, move public methods up in the class,
remove heavy-mocking and useless unit tests that
only check if certain sub-methods are called.

Resolves: #101643
Releases: main
Change-Id: If27bee98f22120ca739659c453c26fa1795c49d5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80499


Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 5eaa272d
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment