- Feb 02, 2023
-
-
Andreas Fernandez authored
When using drag&drop in the page tree, many style changes happen: * a shadow node is rendered that is moved around * the content within the shadow node changes depending on whether dropping is allowed * CSS classes are changed The previous implementation was not optimal in several ways: * the nodes wrapper (aka the "tree") was updated twice which each `dragover` event, being expensive on huge trees * adding and removing CSS classes may have become redundant in some cases, triggering a re-paint every time All these cases are handled in this patch by executing tasks only when absolutely necessary. Resolves: #99786 Releases: main, 11.5 Change-Id: Ibc8cbce2785e2de646e254590b4eddbdc42839c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77658 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
Resolves: #99791 Releases: main Change-Id: Ib72909d91fcf9f9ad46428b9c6272939607fb610 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77665 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
In a "form-check" container, the input element with class "form-check-input" must be placed before the corresponding label with class "form-check-label". This fixes a related display bug in Firefox. Resolves: #99785 Releases: main Change-Id: I2d856631d65d0b7edcf5053cb2da927f83ebac07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77663 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Feb 01, 2023
-
-
Chris Müller authored
Related: #99618 Resolves: #99788 Releases: main Change-Id: I826a40e306a77403dd06270eb83f5131920c219d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77661 Tested-by:
-
Jasmina Ließmann authored
Align columns within the table to ensure a consistent reading flow. Position the content and buttons at the beginning of the column. Also increase space between table and "Unassigned site configurations" area. Resolves: #99789 Releases: main Change-Id: Ida72a151766ef139ed1dfae1e44ccb5d8d5756ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77662 Tested-by:
-
Christian Kuhn authored
The user authentication classes are still pretty messy. A subset of properties and information of backend user state is intitialized by middlewares and set as aspect to the context object. However, we do not want to add the entire backend user as $request attribute object, to not surface another usage of this object. Instead, it is set as $GLOBALS['BE_USER'] throughout the core, which will eventually vanish at some point, by being substituted by something better. ext:reactions currently violates this. The patch sets $GLOBALS['BE_USER'], consuming reactions should retrieve it from there if needed, just like any other backend related class does it currently. FormProtectionFactory had a similar flaw, it accessed the attribute even though no middleware ever set this. Finally, .phpstorm.meta.php is cleaned up, to not declare this request attribute any longer. Change-Id: Iae4c48a1ccc41f7aeebdf753f9cae6515bb5f9e5 Resolves: #99751 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77638 Tested-by:
-
Benni Mack authored
This change is the next iteration of cleaning up SVG-drag/drop code. Handling of the "positioning line" to drag nodes between other nodes (page tree only) has been encapsulated in drag-drop.ts A lot of methods and variables are renamed and comments are added in order to understand the code better. A few methods regarding draggables (the shadowed content) have been centralized so the code is easier to read where CSS classes are modified. Resolves: #99783 Releases: main Change-Id: I9e28d0ca3d886afaa8b3e2cf274593d3e45c3fa5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77656 Tested-by:
-
Andreas Fernandez authored
The change in #98069 removed the Debug Console from the TYPO3 backend. This patch removes the language file `debugger.xlf` that was forgotten back then. Resolves: #99787 Related: #98069 Releases: main Change-Id: I64122596c29317955b803ba12078da85664173d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77659 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Kuhn authored
The module receives a similar treatment as "Active PageTsConfig", namely client side search and client side expand state persisting. This simplifies server side a bit, which is cleaned up. We're also avoiding the naming 'object browser' in file names and other places in favor of 'active'. A series of minor bug fixes is applied along the way. Resolves: #99782 Related: #99747 Releases: main Change-Id: Ibaef3123b3e6df316ef5e633582077fd0e702be0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77650 Reviewed-by:
-
Stefan Bürk authored
Support for json database field has been added basicly with #99062 and #99226. That popped up an issue with handling data of this field in DataHandler, which has been addressed within #99279. First real usage of this new field type has been added with the introduction of the new `ext:reactions`, which is also the first battleground for this field type. Using `ext:reactions` revealed an oversight regarding the proper representation and handling of the "json" field and data in the well known history&undo feature. To create "human-readable" data representation the `BackendUtilility::getProcessedValue()` method is used. This method expects to return string of the represented data, so it can compared by the diff utility. The value for json fields are the decoded value, and is therefore most likely an array. This change used `json_encode()` to prepare the value for the human-readable representation. This gives us a nice view and avoids the issue with the annoying array to string conversion warning. Resolves: #99277 Related: #98373 Related: #99279 Related: #99226 Related: #99062 Releases: main Change-Id: I4d9b80c86b4cc8fe3e1f65a7b8a62d9bcfa1ef4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77608 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Thomas Hohn authored
Sanitize the mountPointParameter in class constructor. Resolves: #99731 Releases: main, 11.5 Change-Id: Ic6fec228c462c7ec4a75a7efc934d7d17fc5c1e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77621 Reviewed-by:
-
Thomas Hohn authored
Added a guard around the calculation of $sameBeginEnd. Resolves: #99752 Releases: main, 11.5 Change-Id: I754b4e67b2b04db20dc9adb8ee26bbd2ab2651ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77639 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Benni Mack authored
This change reduces some redundancy in implementations for drag+drop for pagetree + folder tree, also adds some comments and adds some helper methods to make the code a tiny bit more understandable. In addition, to reduce our dependencies to d3-drag, the DragDropHandlers now receive the node and the original MouseEvent, as there is nothing else that the DragDrop handlers need for our solutions. Resolves: #99778 Releases: main Change-Id: Ia45a3ac5256d22ab38cf8c5d70fc4b939a53085a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77654 Tested-by:
-
Thomas Hohn authored
The variable sameBeginEnd should have the type bool, since the comparison calculation yields a bool. Resolves: #99776 Releases: main, 11.5 Change-Id: Iddbd04197b1b2f99bc96d365c0c4dde1615568da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77651 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
Used command: cd Build npm install "d3-drag@^3.0.0" \ "d3-selection@^3.0.0" \ "d3-dispatch@^3.0.0" \ "@types/d3-dispatch@^3.0.0" \ "@types/d3-drag@^3.0.0" \ "@types/d3-selection@^3.0.0 grunt build Resolves: #99779 Releases: main Change-Id: Ic38dc68123b475aa8f9fa1d71a7698db92891fba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77653 Reviewed-by:
-
- Jan 31, 2023
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #99773 Change-Id: Ife6196a387db61ab7d81506cd32d7adc14bf609d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77649 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Kees Sonnema authored
A new event is added to modify the preview image for online media providers. Resolves: #99312 Releases: main Change-Id: I67846fb5eefa2cfd5b41208bf4ef7ee4270ed1df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76994 Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Reviewed-by:
-
Christian Kuhn authored
With getRequest() in UriBuilder returning a extbase Request in the fallback chain, we need to have an extbase attribute when creating it. Also avoid another call to $GLOBALS['TYPO3_REQUEST']. Resolves: #99770 Related: #99650 Related: #99734 Related: #99757 Releases: main Change-Id: Ic59394172a0834efbd2caada23cbf776322a8e11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77648 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Jasmina Ließmann authored
* add search button to search field in 'Active Page TSconfig' to match unified search appearance * updated labeling of section headings in 'Active Page TSconfig' * hide option section in 'Active TypoScript' if no TypoScript record exists * move active conditions badge to the right side of panel header * use different wording in panel headers depending on whether there are one or more active conditions * move search matches badge to the right side of panel header * stricty use same colour for active conditions badge in panel headers * use h3 instead of h2 in the panel headers * remove square brackets around properties in 'Active TypoScript' tree * use default button layout to create a new 'Root TypoScript record' Resolves: #99758 Related: #99747 Releases: main Change-Id: I837e2715b8ef3c1ed356f55823b0ce8a78a8598b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77644 Tested-by:
-
Oliver Bartsch authored
In case a field change would trigger a form reload, a corresponding modal must be confirmed by the user. This modal does now disappear again, after confirming. Resolves: #99740 Releases: main Change-Id: I5ba5d10086c31adc08c552905cd812a151d92ce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77637 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #99728 Releases: main Change-Id: Iac26c64e009df4b5a2d5c86bdaebe9a4989bb56e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77615 Tested-by:
-
Chris Müller authored
The setRequest() method is necessary to be called to set the current request object when using the UriBuilder outside of an Extbase controller or a view helper. The according changelog also states in the migration section that the setRequest() method should be called. So, we remove the internal annotation, so the method is now considered as public API. Related: #99650 Resolves: #99734 Releases: main Change-Id: I45a2149d3215a7ea9abb2458da5eba922bed4cc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77630 Reviewed-by:
-
Josef Glatz authored
Removes last occurrence of an removed TYPO3 relict named "tstemplate_styler" Resolves: #99761 Releases: main Change-Id: I43c15f73dc2d3c98574569e0ceb6a2c17ede04ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77646 Tested-by:
-
- Jan 30, 2023
-
-
Christian Kuhn authored
We need unique identifiers in both TypoScript "AST" and "IncludeTree" to reference nodes in the backend modules. This has been established with #99537 for the include tree already, while #99747 came with a simplified approach for AST nodes. The patch changes the include tree approach to use the same simplified version as done with AST nodes, which avoids some runtime overhead in non-backend context. As drive-by, the HTML of "Active PageTsConfig" view is streamlined a bit. Change-Id: I2d3855ef260ea23bc43aebb199dd04d12de3ac0f Resolves: #99753 Related: #99537 Related: #99747 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77640 Tested-by:
-
Oliver Bartsch authored
The method `getContentObject()` might return null. This is now properly handled in the MenuProcessor and LanguageMenuProcessor. Resolves: #99722 Releases: main, 11.5 Change-Id: Iebaa2324c59032bd10610c2a63156168777070db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77613 Tested-by:
-
Torben Hansen authored
The "Edit TypoScript record" view looks slightly different compared to TYPO3 v11. This patch adds missing CSS classes in the template, so the table has a border again and the edit link has a button style. Resolves: #99741 Releases: main Signed-off-by:
-
Josef Glatz authored
This patch removes a duplicated source string of Ib52fa51295adff5470b8b62a702a236390410a7b. Resolves: #99750 Related: #99747 Releases: main Change-Id: Ie5377d6c832460aca05780e53d4cf17482499278 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77636 Tested-by:
-
Christian Kuhn authored
* Render "Available constants from site settings" if any * Render used conditions if any * Allow to show comments and constant substitutions * Improve client side search * Do not persist expand/collapse state when searching, to go back to previous expand/collapse state when clearing search term * Codebase overhaul avoiding of intermediate view helpers * Minor adaptions and cleanups in related modules Resolves: #99747 Related: #99563 Related: #99602 Releases: main Change-Id: Ib52fa51295adff5470b8b62a702a236390410a7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77599 Tested-by:
-
Nikita Hovratov authored
Includes a preparation patch for #99739 > composer u typo3/cms-styleguide Releases: main Resolves: #99748 Change-Id: If78dc21d1c6f28e001a308329112e900b5e1ea74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77635 Tested-by:
-
Annett Jähnichen authored
Use checkbox icons instead of eye icon to select show/hide columns in list view. Resolves: #99714 Releases: main Change-Id: If20c2dc1a6aba30346c1b96f869f3353b93162da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77603 Reviewed-by:
-
Torben Hansen authored
The change #99575 introduced a bug in formengine related to input fields with a "null" checkbox placeholder. This change fixes the bug by using the original CSS class in `initializeNullWithPlaceholderCheckboxes()` Resolves: #99743 Releases: main Signed-off-by:
-
- Jan 29, 2023
-
-
Lina Wolf authored
Releases: main Resolves: #99745 Change-Id: I54d8ef297acacbe9d45faf0f03ca2cf5cdaba9bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77631 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
- Jan 27, 2023
-
-
Andreas Fernandez authored
The class `PageLayoutController` has some custom methods to fetch data of localized pages: * `getLocalizedPageRecord()` * `getLocalizedPageTitle()` The same data can be retrieved using the standardized method `PageRepository->getPageOverlay()`, which replaces the aforementioned methods. Resolves: #99613 Releases: main, 11.5 Change-Id: I06a374411b34211ed45d57f30d142ead7c7e6fba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77475 Tested-by:
-
Eric Chavaillaz authored
This allows extensions to blind options from any site configuration (YAML) in the configuration module. This is achieved by dispatching the ModifyBlindedConfigurationOptionsEvent, which got introduced in #99717. Additionaly, the PSR-14 Event is extended to provide the identifier of the provider, dispatching the event. Resolves: #99713 Related: #99626 Related: #99717 Releases: main Change-Id: I1afbcec0af689747f6f8604a55f14daca51650d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77602 Tested-by:
-
- Jan 26, 2023
-
-
Thomas Hohn authored
If fe_groups are deleted building the labels for the fe_groups in titleAttribForPages will throw a PHP warning. Resolves: #99712 Releases: main, 11.5 Change-Id: I61a340b74096c0da6eccc2eb0cd425c9fe02b71c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77600 Tested-by:
-
Oliver Bartsch authored
The "titleLen" setting is now respected in the page modules' "language mode" to prevent overlapping of long page titles. Note: Overlapping might still happen, depending on the configured "titleLen" value, the current display resolution and the number of languages being displayed (when "All languages" is selected). Resolves: #99729 Releases: main, 11.5 Change-Id: I02458e5b7b0d136303499a83fb6c2fcb5bbc0ef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77616 Reviewed-by:
Daniel Goerz <daniel.goerz@b13.com> Tested-by:
-
Oliver Bartsch authored
When calculating the number of hidden elements for the currently displayed language columns in the page module, the corresponding language constraint is now properly set. Considering more then one language is now only done, in case language mode with a language > 0 is selected. Additionally, L=-1 is now properly taken into account. Some further cleanup of the method is done. The actually defined field names of corresponding enable columns are now used instead of the static ones. Resolves: #99720 Releases: main, 11.5 Change-Id: I751ea0d2f2de88d5eb208215bb81543fc01ca32b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77607 Tested-by:
-
Andreas Fernandez authored
The method `sendChangeCommand()` now builds a proper payload by pushing data into `params.data.copy` prior to the non-exisiting `data.copy` array. Resolves: #99726 Releases: main, 11.5 Change-Id: I96f279cb2f5eedc4a6658f89f0975c8a14bd42c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77610 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Bartsch authored
The backend user module contains of different sub modules. All those sub modules contain a "create new record" button in the doc header. This button does now contain the actual record to be created, instead of a general label. Additionally does this patch add the missing "resname" attribute to newly added locallang labels and cleans up LocalizationUtility::translate() usages in the BackendUserController. Resolves: #99707 Related: #99038 Releases: main Change-Id: I6eef95ab6dcf083faf1f0a0659c82c3a49bf485b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77594 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/backend/page-actions` module used in the Page module to hide "hidden" content elements completely. Since jQuery's sliding was used which has no native API, `requestAnimationFrame()` is used to achieve the same behavior. To have a fluent CSS-based animation, positioning of `.t3-page-ce` needs to be fixed, making futher adjustments necessary. Additionally, an unused class is removed. Resolves: #99716 Releases: main Change-Id: If520858db7dfe8c50d8cad477d169a1d8e896ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77510 Tested-by:
-
