[TASK] Simplify IncludeTree identifier calculation
We need unique identifiers in both TypoScript "AST" and "IncludeTree" to reference nodes in the backend modules. This has been established with #99537 for the include tree already, while #99747 came with a simplified approach for AST nodes. The patch changes the include tree approach to use the same simplified version as done with AST nodes, which avoids some runtime overhead in non-backend context. As drive-by, the HTML of "Active PageTsConfig" view is streamlined a bit. Change-Id: I2d3855ef260ea23bc43aebb199dd04d12de3ac0f Resolves: #99753 Related: #99537 Related: #99747 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77640 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
Showing
- typo3/sysext/backend/Classes/Controller/PageTsConfig/PageTsConfigActiveController.php 0 additions, 3 deletions.../Controller/PageTsConfig/PageTsConfigActiveController.php
- typo3/sysext/backend/Resources/Private/Templates/PageTsConfig/Active.html 8 additions, 8 deletions...kend/Resources/Private/Templates/PageTsConfig/Active.html
- typo3/sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php 6 additions, 4 deletions.../sysext/core/Classes/TypoScript/AST/Node/AbstractNode.php
- typo3/sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php 1 addition, 1 deletion...sysext/core/Classes/TypoScript/AST/Node/NodeInterface.php
- typo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php 0 additions, 8 deletionstypo3/sysext/core/Classes/TypoScript/AST/Node/RootNode.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php 6 additions, 1 deletion...es/TypoScript/IncludeTree/IncludeNode/AbstractInclude.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php 8 additions, 5 deletions...s/TypoScript/IncludeTree/IncludeNode/IncludeInterface.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php 0 additions, 2 deletions...core/Classes/TypoScript/IncludeTree/StringTreeBuilder.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php 0 additions, 11 deletions...Classes/TypoScript/IncludeTree/SysTemplateTreeBuilder.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php 0 additions, 35 deletions...sses/TypoScript/IncludeTree/TreeFromLineStreamBuilder.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php 0 additions, 3 deletions...re/Classes/TypoScript/IncludeTree/TsConfigTreeBuilder.php
- typo3/sysext/core/Classes/TypoScript/IncludeTree/Visitor/IncludeTreeConditionIncludeListAccumulatorVisitor.php 0 additions, 1 deletion...tor/IncludeTreeConditionIncludeListAccumulatorVisitor.php
- typo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php 0 additions, 3 deletionstypo3/sysext/core/Classes/TypoScript/PageTsConfigFactory.php
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/IncludeTreeObjectIgnoringIdentifierAndPathComparator.php 2 additions, 2 deletions.../IncludeTreeObjectIgnoringIdentifierAndPathComparator.php
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php 2 additions, 17 deletions.../TypoScript/IncludeTree/TreeFromLineStreamBuilderTest.php
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/UnserializedIncludeTreeObjectComparator.php 1 addition, 1 deletion...t/IncludeTree/UnserializedIncludeTreeObjectComparator.php
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ChildNodeTest.php 6 additions, 6 deletions...ext/core/Tests/Unit/TypoScript/AST/Node/ChildNodeTest.php
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/ReferenceChildNodeTest.php 6 additions, 6 deletions...Tests/Unit/TypoScript/AST/Node/ReferenceChildNodeTest.php
- typo3/sysext/core/Tests/Unit/TypoScript/AST/Node/RootNodeTest.php 4 additions, 4 deletions...sext/core/Tests/Unit/TypoScript/AST/Node/RootNodeTest.php
- typo3/sysext/core/Tests/Unit/TypoScript/IncludeTree/IncludeNode/RootNodeTest.php 66 additions, 0 deletions.../Unit/TypoScript/IncludeTree/IncludeNode/RootNodeTest.php
Please register or sign in to comment