- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Feb 24, 2017
-
-
Morton Jonuschat authored
Deprecate BackendUtility::getRecordsByField() as it has a flawed design due to passing SQL fragments. This contradicts the goal of using named parameters for all queries in the core and requires passing the original QueryBuilder object in addition to the stringified constraint. Replace all calls to the method with direct usage of the QueryBuilder and deprecate the method. Resolves: #79122 Releases: master Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003 Reviewed-on: https://review.typo3.org/51078 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 17, 2017
-
-
Morton Jonuschat authored
Enforce consistent ordering of deleted records. Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6 Resolves: #79800 Releases: master Reviewed-on: https://review.typo3.org/51732 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- Feb 16, 2017
-
-
Susanne Moog authored
Change-Id: Ib8b787980d90c686457155cbb6c15cd3cd7c0d61 Releases: master Resolves: #79851 Reviewed-on: https://review.typo3.org/51715 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Feb 15, 2017
-
-
Benni Mack authored
The Fluid namespace "core" is now available globally, making it obsolete to register the namespace manually in each file any core viewhelper is necessary. This is also a precursor for integrating Frontend Editing content editable ViewHelpers in all places of TYPO3 Frontend when fluid templates are in use. Resolves: #79817 Releases: master Change-Id: I7691107fa7c02e71b848cd8d0bb0eecdae5a8171 Reviewed-on: https://review.typo3.org/51688 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
-
- Feb 14, 2017
-
-
Wouter Wolters authored
Resolves: #79810 Releases: master Change-Id: I8325ad82a66d7a2c4c5028ecf63fea690c5b7ac0 Reviewed-on: https://review.typo3.org/51674 Tested-by:
-
- Feb 04, 2017
-
-
Susanne Moog authored
As the main test case files are now in subfolders, we need to correct the namespaces. Change-Id: Ie06edc099c5d3e42ff842eded03cde1ddf34c0ca Releases: master Resolves: #79629 Reviewed-on: https://review.typo3.org/51535 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Feb 03, 2017
-
-
Susanne Moog authored
- Removal of the CMS part from the namespace - Distinguish Classes / Resources For background information see https://decisions.typo3.org/t/testing-framework-extraction-next-steps/50 Change-Id: I3f73baeb16bbef82c9626add063c9edde41b47a6 Resolves: #79518 Releases: master Reviewed-on: https://review.typo3.org/51449 Tested-by:
-
- Jan 10, 2017
-
-
Benni Mack authored
In TYPO3 6.0 we introduced TYPO3.jQuery as a possibility to have jQuery run side-by-side with prototype.js in a no-conflict mode. Since TYPO3 7.5, prototype.js was removed, and $ can be used. PageRenderer now sets TYPO3.jQuery AND $ as shorthand-functionality and all places in the TYPO3 Core are replaced with the common $ functionality, so TYPO3.jQuery should be avoided. Resolves: #79221 Releases: master Change-Id: I9177d7d3ad618fa7bb3a7e2ea483f39d6d4231bc Reviewed-on: https://review.typo3.org/51212 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
-
- Jan 07, 2017
-
-
Andreas Fernandez authored
Added some files that were not updated with the original change. Resolves: #79165 Releases: master, 7.6, 6.2 Change-Id: If8298c220ca7171d34e21aff9e49917ac8618686 Reviewed-on: https://review.typo3.org/51175 Tested-by:
-
Wouter Wolters authored
Resolves: #79165 Releases: master,7.6,6.2 Change-Id: Ia3211ad00a3b6bd915b0a099bdb8d98a8b12dc7f Reviewed-on: https://review.typo3.org/51138 Tested-by:
-
- Dec 31, 2016
-
-
Benjamin Kott authored
Resolves: #79125 Releases: master Change-Id: I8fdfd139cad85e6d39586ee36e6c6dcc886525e0 Reviewed-on: https://review.typo3.org/51081 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Dec 22, 2016
-
-
Susanne Moog authored
Add testing framework component for independent usage Resolves: #79025 Releases: master Change-Id: I23cfd2ed42108d7d80ec776e778a1ac2d5293e55 Reviewed-on: https://review.typo3.org/50125 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Dec 21, 2016
-
-
Wouter Wolters authored
Resolves: #79055 Releases: master Change-Id: I09921a6c4fc013af2a01b498712d282559028b37 Reviewed-on: https://review.typo3.org/51009 Tested-by:
-
- Dec 03, 2016
-
-
Manuel Selbach authored
According to task #78437 queries should follow the prepared statement principle. Thus method BackendUtiltiy::getRecordsByField() has to be refactored to retrieve a queryBuilder which holds the parameter assigned to e.g. additional where clause, etc. otherwise the parameter and the dynamically generated placeholders in the queryQuilder will be reset. Change-Id: Id66d7b2fcfc5bcdca4d920b645c2285ded0c160a Resolves: #78704 Releases: master Reviewed-on: https://review.typo3.org/50664 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Dec 01, 2016
-
-
Wouter Wolters authored
Move languages files from the root of ext:lang to Resources/Private/Language/ Resolves: #78647 Releases: master Change-Id: I9271442c98f2fcf705a38a639a6d503caeba1759 Reviewed-on: https://review.typo3.org/50584 Reviewed-by:
-
- Nov 07, 2016
-
-
Christian Kuhn authored
The files were substituted with "Settings.cfg" a while ago and are now obsolete according to the docs team. Change-Id: I43f2a6fca83f839359d5c1b0c1bb4f0cf967e253 Resolves: #78595 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50524 Tested-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Martin Bless <m.bless@gmx.de> Tested-by:
-
- Oct 26, 2016
-
-
Manuel Selbach authored
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- Oct 19, 2016
-
-
Benni Mack authored
All extension icons of all system and test extensions shipped with the core are now located at EXT:.../Resources/Public/Icons/Extension.* instead of ext_icon.gif. This is one further step to make it possible to publish only public assets of an extension to the htdocs/ folder. Resolves: #78334 Releases: master Change-Id: Ic65036bb74d4a156c1a0a9fdfa0c8d4b5a28e9ed Reviewed-on: https://review.typo3.org/50233 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Oct 18, 2016
-
-
Wouter Wolters authored
Resolves: #78330 Releases: master Change-Id: I624b770a0c93fcc3f23607c9a09ba6cfadd8a255 Reviewed-on: https://review.typo3.org/50262 Tested-by:
-
- Oct 10, 2016
-
-
Christian Kuhn authored
* better regex finds more with less false positives * use grep instead of ack-grep * find exceptions without exception code * the script kills travis for unkown reasons and removed Change-Id: I6ae7c005bc9f493365d36f9602aebf389f1f7786 Resolves: #78221 Releases: master Reviewed-on: https://review.typo3.org/50150 Reviewed-by:
-
- Oct 07, 2016
-
-
Daniel Windloff authored
Use actions-document-select to select all values in a table. Wrap icon (btn btn-default). Resolves: #77973 Releases: master Change-Id: Iddb2c232e93736d504d2269ee4efeddc7b74705d Reviewed-on: https://review.typo3.org/49953 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Sep 01, 2016
-
-
Georg Ringer authored
The optional arguments of RecyclerUtility::getRecordPath are not used anymore and are deprecated. Resolevs: #75637 Releases: master Change-Id: I30b3c3d05ebf9b4961060106b4a02d5c7a4a5089 Reviewed-on: https://review.typo3.org/49682 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Aug 31, 2016
-
-
Wouter Wolters authored
Resolves: #77720 Releases: master Change-Id: I7187b477243a55f7a01a4477b5b2f300cd72242a Reviewed-on: https://review.typo3.org/49686 Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- Aug 22, 2016
-
-
Georg Ringer authored
To be in sync with all other modules, the recycler button in the toolbar is moved to the right. Resolves: #77570 Releases: master, 7.6 Change-Id: I6d681239d1d9dc10be356b576c0ac9cb1315a187 Reviewed-on: https://review.typo3.org/49541 Reviewed-by:
-
- Jul 05, 2016
-
-
Benni Mack authored
The sysexts' ext_emconf.php and TYPO3 version is raised after the release of TYPO3 v8.2 accordingly. Resolves: #76938 Releases: master Change-Id: I6d30eb0715dd40ff88cd16f79b54b87abf425c3b Reviewed-on: https://review.typo3.org/48803 Tested-by:
-
- Jun 20, 2016
-
-
Wouter Wolters authored
The "getMock" method is deprecated starting with PHPUnit 5.4 and must be replaced with the MockBuilder or the "createMock" method for simple cases. Resolves: #76647 Related: #76673 Releases: master Change-Id: Ib177969abc1c7e67f6033ba62c5e9b405dc00656 Reviewed-on: https://review.typo3.org/48588 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Elmar Hinz <t3elmar@gmail.com> Tested-by:
-
- Jun 03, 2016
-
-
Helmut Hummel authored
To make the set of restrictions that are in effect when creating queries with the QueryBuilder becomes more understandable, we need to remove the QueryContext and the magic applied to that and replace it with the following behavior: delete, hidden, starttime, endtime restrictions are always enabled and need to be removed if needed. Other restrictions need to be provided manually depending on the desired result. Resolves: #76167 Resolves: #76264 Releases: master Change-Id: Iaf0cb08475ed44966838c3fbdd5756d3ba6ebcc1 Reviewed-on: https://review.typo3.org/48049 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
- May 28, 2016
-
-
Valentin Despa authored
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3 Reviewed-on: https://review.typo3.org/48346 Reviewed-by:
-
- May 05, 2016
-
-
Michael Oehlhof authored
Resolves: #75718 Releases: master Change-Id: I27a14e694cd17132bf71d2687b8ea2366409fa27 Reviewed-on: https://review.typo3.org/47763 Reviewed-by:
-
- May 03, 2016
-
-
Wouter Wolters authored
Resolves: #76037 Releases: master Change-Id: I501308fa7d239bde0a2707bc2e394bf70754db07 Reviewed-on: https://review.typo3.org/48000 Reviewed-by:
-
- Apr 27, 2016
-
-
Michael Oehlhof authored
Resolves: #75636 Releases: master Change-Id: I49611c3d0e6a0ec56e05871c5beb7f7de4bce949 Reviewed-on: https://review.typo3.org/47682 Reviewed-by:
-
- Apr 19, 2016
-
-
Morton Jonuschat authored
This name change transports the intent of the query context better and makes it more intuitive to use. Instead of explicitly disabling all enable fields and the deleted flag using the following code: $queryBuilder->getQueryContext() ->setIgnoreEnableFields(true) ->setIncludeDeleted(true); the more descriptive predefined context can be used: $queryBuilder->getQueryContext()->setContext('unrestricted') Releases: master Resolves: #75751 Change-Id: I4d38a328c2b6707a32f26022b4abfc48e945c0ed Reviewed-on: https://review.typo3.org/47759 Reviewed-by:Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- Apr 18, 2016
-
-
Michael Oehlhof authored
Resolves: #75717 Releases: master Change-Id: I210f838568c47469eb9926b7b4b6774578a28732 Reviewed-on: https://review.typo3.org/47733 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #75713 Releases: master Change-Id: Ia82c7055e71ec154264f6b658addf49c5f9187a5 Reviewed-on: https://review.typo3.org/47730 Reviewed-by:
-
- Mar 23, 2016
-
-
Wouter Wolters authored
Resolves: #75230 Releases: master Change-Id: I44c34a7ddb804a28031395b7e100b33d43e12a76 Reviewed-on: https://review.typo3.org/47360 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
- Mar 14, 2016
-
-
Michael Oehlhof authored
The DocHeader has now a reserved area for the nprogress loading indicator for use within modules. The area has a fixed position to ensure visibility in every case. The code of the Recycler and Extension manager have been adjusted to use that element for the progress bar. Resolves: #71509 Releases: master, 7.6 Change-Id: I07cacf61a1634357d4da0fe292ea22ba34a6100e Reviewed-on: https://review.typo3.org/45199 Reviewed-by:
-
- Feb 23, 2016
-
-
Benni Mack authored
Remote XML entites can be loaded in places where TYPO3 expects only local files to be fetched. All places are changed so the option to load entities is disabled. Resolves: #61269 Releases: master, 7.6, 6.2 Security-Commit: 736a7ef0823893047843c6a7f5e72b220bfd4697 Security-Bulletins: TYPO3-CORE-SA-2016-005, 006, 007, 008 Change-Id: I26701fc2ffb5aed7ccbd96c168aef571d012091e Reviewed-on: https://review.typo3.org/46834 Reviewed-by:
-
- Feb 12, 2016
-
-
Benni Mack authored
A leftover old-school AJAX handler with an invalid endpoint (pointing to an actual Cleaner Scheduler Task) was removed. Resolves: #73351 Releases: master, 7.6 Change-Id: I953a50e7d381e894cc473e6bab1fbb854551bf5c Reviewed-on: https://review.typo3.org/46605 Reviewed-by:
-
