- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Frank Naegler authored
Resolves: #80507 Releases: master Change-Id: I5494a9a61829d6245fa2410c3bafe8c6bc4a9043 Reviewed-on: https://review.typo3.org/52206 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Georg Ringer authored
As the image field has been changed to FAL, also the model must be adopted. Resolves: #80437 Releases: master Change-Id: I09b6ef8db190467ee5dfea67e5e66ded12b99dcd Reviewed-on: https://review.typo3.org/52146 Tested-by:
TYPO3com <no-reply@typo3.com> Tested-by:
Nikolai Townsend <info@nikolaitownsend.de> Reviewed-by:
-
Benjamin Kott authored
For a more streamlined rendering this patch adds nessesary html tags with fluid namespaces to all indexed_search templates, unifies indention and adds an empty space before closing bracket of self-closing tags. Resolves: #80392 Releases: master Change-Id: Ia6bc46c8fb602b4f3592094ad963691bbf412d7d Reviewed-on: https://review.typo3.org/52119 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benjamin Kott authored
Resolves: #80484 Releases: master Change-Id: Ie17a8cc5cb118c9ecd381355b96d9e60cd278712 Reviewed-on: https://review.typo3.org/52183 Reviewed-by:
-
Benni Mack authored
There are some places where PHP comments have been done wrong (using doccomments) or where there is no comment at all. Resolves: #80503 Releases: master Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af Reviewed-on: https://review.typo3.org/52200 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80505 Releases: master Change-Id: I8188f7c9c63776a41a2f4e5c5077139e55312281 Reviewed-on: https://review.typo3.org/52202 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The protected property "AbstractXmlParser->charset" is set from the outside but never used anymore in either the abstract class nor in the subclasses. The protected method "getCharset()" is basically useless: a) it's never called or in use b) it has nothing to do with the XmlParser as it does not work with any properties / functionalities of the XmlParser itself. The protected method "initialize()" is called solely in the contructor which can be dealt with directly in the constructor (that's what a constructor is there for). The third parameter $charset within getParsedData() is now not needed anymore within the Parsers, as all expect UTF-8 for files. Resolves: #80486 Releases: master Change-Id: I929c3960fb5b94f5448a2d29f4a73fbb5d81a500 Reviewed-on: https://review.typo3.org/52185 Reviewed-by:
-
- Mar 27, 2017
-
-
Ralf Zimmermann authored
* Create 'grid rows' without 'grid container' wrappers * Disable 'grid containers' within the form editor by default because twitter bootstrap prohibits container nesting Resolves: #80455 Releases: master Change-Id: I3997943858ac3b235094b765697f724cb1e4c95d Reviewed-on: https://review.typo3.org/52166 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benjamin Kott authored
Resolves: #80499 Releases: master Change-Id: I820ac450c5bd32c9d992dcfd39983b20c304799f Reviewed-on: https://review.typo3.org/52196 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Benni Mack authored
The parameter of the $TSFE->whichWorkspace() method decides whether the UID of the current workspace should be returned or the actual "title" of the sys_workspace record. As this parameter is not in use anymore and clearly makes this function harder to understand why and when someone could use this, this property is marked as deprecated. Instead, fetching the workspace title should happen in the place where it is needed. Resolves: #80485 Releases: master Change-Id: I06512e40c48b35826c0d0a89cc8c4cdcdc8773e6 Reviewed-on: https://review.typo3.org/52184 Reviewed-by:
-
Oliver Hader authored
Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139 Resolves: #80494 Releases: master Reviewed-on: https://review.typo3.org/52190 Tested-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
-
Thomas Hohn authored
DataHandler does not need to force "live ID" processing to be enabled on RelationHandler when EXT:version is not loaded. Avoiding this saves some semi-expensive operations inside the RelationHandler class. Resolves: #78998 Releases: master Change-Id: If53cdd73db15352d6f4854a5aef4b407836cb6ce Reviewed-on: https://review.typo3.org/50970 Reviewed-by:
Claus Due <claus@phpmind.net> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Helmut Hummel authored
Due to usage of Fluid dynamic variable parts in the template, ratio IDs must not contain a "." Resolves: #80214 Releases: master Change-Id: I12dac926169c827c9e3022320dd90a058f72913b Reviewed-on: https://review.typo3.org/52194 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
The Frontend Controller (TSFE) does some initialization which should belong to the FrontendBackendUserAuthentication directly. Additionally, some further code cleanups are made for this area. Resolves: #80479 Releases: master Change-Id: I32d9c98bb511f1eaa1f56203c4678358107aa7bc Reviewed-on: https://review.typo3.org/52177 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
Resolves: #80492 Releases: master Change-Id: Id835329586bf0fa315dc46377bc195ace005da61 Reviewed-on: https://review.typo3.org/52188 Tested-by:
-
Benni Mack authored
The TypoScript Frontend Controller has a unnecessary dependency to a static call (which is made non-static !) of PageRepository which can be done exactly 1:1 by instantiating the cacheManager and fetching the "cache_hash" cache directly by storing and fetching the contents itself. Resolves: #80480 Releases: master Change-Id: If6f5976a6c07ea754915b9c612264d733a6b1a41 Reviewed-on: https://review.typo3.org/52179 Tested-by:
-
Frank Naegler authored
This patch adds a missing PHP version check to the /install/index.php file which exists only for the redirect to the install tool. Because of this missing version check an installation without PHP 7.0 will fatal with an parsing error. Resolves: #80496 Releases: master Change-Id: Iec97021fb18ac7a4cfa0dcf1961675c3d58305ee Reviewed-on: https://review.typo3.org/52193 Reviewed-by:
-
Markus Klein authored
FormEngineValidation is meant as integral part of FormEngine. The current dependency definition is inverted, such that FormEngine now depends on FormEngineValidation and not the other way around. Note that FormEngineValidation does not need any other feature of FormEngine, so this is safe. This solves a possible race condition with other modules. Releases: master, 7.6 Resolves: #80459 Change-Id: Ie2cb9dd90220b37a98bc8e3ca174fd074488cc8d Reviewed-on: https://review.typo3.org/52178 Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
-
Benni Mack authored
When the BackendController was just a plain backend.php file (back in TYPO3 6.2) there were some hooks available to load ExtJS components and JS/CSS files via include statements and relative paths. There are now better hooks within BackendController, so CSS and JS resources can be loaded via PageRenderer and within the BackendController scope. The obsolete methods and hooks are marked as deprecated. Resolves: #80491 Releases: master Change-Id: I9e0e72df7237ab958ec06f7d58a9fa41c75ba890 Reviewed-on: https://review.typo3.org/52187 Reviewed-by:
-
Benni Mack authored
The way of calling CLI scripts from within TYPO3 via the "cliKeys" functionality and the typo3/cli_dispatch.phpsh entrypoint have been superseded by the new Symfony Console integration. All code related to this functionality has been marked as deprecated. Calling the CliRequestHandler (which is the main entry point for the cli_dispatch.phpsh) will trigger a deprecation message warning. Resolves: #80468 Releases: master Change-Id: Ib72ab93bee27421163c9117ebedcc0e97e17d41e Reviewed-on: https://review.typo3.org/52173 Reviewed-by:
-
Benjamin Kott authored
Resolves: #80487 Releases: master Change-Id: I23db288f4592cc09fe183c32ec17931e99b4ea74 Reviewed-on: https://review.typo3.org/52186 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Markus Klein authored
This reverts commit b07bb2e9. The patch is replaced by a better solution. Revert is only done for master, backport was not done yet. Change-Id: Ibcabb095e0043dd21cd694142d93baea7dc8e8c5 Reverts: #80459 Releases: master Reviewed-on: https://review.typo3.org/52176 Reviewed-by:
-
Markus Klein authored
The code must not use the nested FormEngine.Validation module without specifying a dependency on this module as well. Releases: master, 7.6 Resolves: #80459 Change-Id: Iaea325a679ac8bae116b33b912e3e9e2f7cd9163 Reviewed-on: https://review.typo3.org/52168 Reviewed-by:
-
Benni Mack authored
This ensures to call extbase commands & command controllers automatically via the new CLI binary. Extbase now also overrides the help command by symfony to allow extbase custom HelpCommandController to come into play when an Extbase command was called. This patch is critical for v8 so all core-internal CLI commands are available via "typo3/sysext/core/bin/typo3", otherwise we'd need to explain every admin that there are two CLI entrypoints for v8 which are relevant, because Extbase is still solely using "typo3/cli_dispatch.phpsh" until now, while all other entry points have been migrated already. Resolves: #80452 Releases: master Change-Id: I70e56c2cbef993cf16dfb212ba1a11add0017a01 Reviewed-on: https://review.typo3.org/51886 Tested-by:
-
Benni Mack authored
The methods in Extbase's command controller to request the admin role for $BE_USER are not needed anymore, because CLI users are always admins nowadays. The methods are therefore marked as deprecated. Resolves: #79591 Releases: master Change-Id: I79865af20a45d455a9417ceca42e4068cc15dc3f Reviewed-on: https://review.typo3.org/51250 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Claus Due authored
This change prevents checkValueForInline from processing empty values. The existing check would process empty values since one of the true matches is when value cannot be interpreted as an integer. Change-Id: Iacd38363bcc23453da9fcc2eea359680c6b91175 Resolves: #79063 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51015 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Reviewed-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
- Mar 26, 2017
-
-
Benjamin Kott authored
In preparation for upcomming switch from bootstrap to SASS the backend style sources have been migrated to SASS. The autoprefixer configuration was corrected to match CMS8 LTS requirements and minification of CSS files is now enabled. Automatic style checks are now available through grunt. The tasks `grunt format` and `grunt lint` will now check sources files for consistency. Resolves: #80453 Releases: master Change-Id: I9ba23aea78014a1f0cce229db533a81d5ffcd02f Reviewed-on: https://review.typo3.org/52151 Tested-by:
Marco Christian Krenn <krenn@webconsulting.at> Tested-by:
-
Wouter Wolters authored
Remove the extension at the same time. Resolves: #79734 Releases: master Change-Id: I457f29b64596a91e612b0f99a020aea46f4a2425 Reviewed-on: https://review.typo3.org/51690 Tested-by:
-
Michael Oehlhof authored
When saving a new task, now only the extra fields of the selected class where submitted via post and no longer all extra fields of all possible classes. This prevents saving the wrong value if extra fields of different classes have the same id. Resolves: #25805 Releases: master Change-Id: I4f0ae67694fbc3b284e763e3edd123804d078350 Reviewed-on: https://review.typo3.org/51027 Tested-by:
-
Benni Mack authored
Resolves: #80443 Releases: master Change-Id: I3e9c2b3f984068f2ce4d1096cd14670700d77aa6 Reviewed-on: https://review.typo3.org/52155 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Christian Kuhn authored
Move the MonitorUtility to ext:compatibility7, implement the static call as eofe hook and move the reports system status to compat7, too. Change-Id: I152a726d9d47e9a1f38dc2416384551727bbcc88 Resolves: #80450 Releases: master Reviewed-on: https://review.typo3.org/52164 Tested-by:
-
Andreas Fernandez authored
The z-index for disabled input fields is decreased to a much lower value to avoid overlaying the module header bar. Resolves: #80428 Releases: master, 7.6 Change-Id: Ia6f861fc66269b843571720e31f4f935d5cc9614 Reviewed-on: https://review.typo3.org/52149 Tested-by:
-
Frank Naegler authored
Resolves: #80451 Releases: master Change-Id: I7ba0a97b3ca4bfb98b1f5072a830d10b66e640fd Reviewed-on: https://review.typo3.org/52163 Tested-by:
-
Marco Christian Krenn authored
changes colors and use the base variables set in the file. cleanup of pagetree svg icon and add class icon-color. Resolves: #80023 Releases: master Change-Id: I6809e7930c118d9e4cc55035f0cf687c02a5958b Reviewed-on: https://review.typo3.org/52162 Reviewed-by:
-
- Mar 25, 2017
-
-
Georg Ringer authored
Fluid escapes the header already, therfore there is no need to do it before in the controller. Resolves: #80288 Releases: master Change-Id: I7f16fb2aa1319cdfbc3a8c9226a86e98a8e8457a Reviewed-on: https://review.typo3.org/52147 Tested-by:
-
Frank Naegler authored
This patch adds the missing logDeprecatedFunction() call. Resolves: #76164 Releases: master Change-Id: I70da92799b6fe9345468b600b73ce30273c25836 Reviewed-on: https://review.typo3.org/52161 Tested-by:
-
Benni Mack authored
The method ArrayBrowser->wrapValue() only does a htmlspecialchars() call nowadays and can be replaced easily by PHP native functions. Resolves: #80440 Releases: master Change-Id: I1646adc0c501b386ed289f428420b3e6ec6a5000 Reviewed-on: https://review.typo3.org/52153 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The functionality to output a login link / logout link when coming from a certain IP address (set via TypoScript config.beLoginLinkIPList) was moved to EXT:compatibility7. Resolves: #80444 Releases: master Change-Id: I1b754cfd454abd3376642a290c056442c5be733d Reviewed-on: https://review.typo3.org/52156 Reviewed-by:
-
Benni Mack authored
The Freetype related method "GeneralUtility::freetypeDpiComp" has been marked as deprecated and moved to GraphicalFunctions where it belongs to. Resolves: #80449 Releases: master Change-Id: Iaa549051c38993a24415c2bfdb785715c1d6e74d Reviewed-on: https://review.typo3.org/52160 Reviewed-by:
-
