[TASK] Cleanup Localization Charset code
The protected property "AbstractXmlParser->charset" is set from the outside but never used anymore in either the abstract class nor in the subclasses. The protected method "getCharset()" is basically useless: a) it's never called or in use b) it has nothing to do with the XmlParser as it does not work with any properties / functionalities of the XmlParser itself. The protected method "initialize()" is called solely in the contructor which can be dealt with directly in the constructor (that's what a constructor is there for). The third parameter $charset within getParsedData() is now not needed anymore within the Parsers, as all expect UTF-8 for files. Resolves: #80486 Releases: master Change-Id: I929c3960fb5b94f5448a2d29f4a73fbb5d81a500 Reviewed-on: https://review.typo3.org/52185 Reviewed-by:Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/core/Classes/Localization/LocalizationFactory.php 1 addition, 11 deletions.../sysext/core/Classes/Localization/LocalizationFactory.php
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php 1 addition, 23 deletions...xt/core/Classes/Localization/Parser/AbstractXmlParser.php
- typo3/sysext/core/Classes/Localization/Parser/LocalizationParserInterface.php 1 addition, 1 deletion...asses/Localization/Parser/LocalizationParserInterface.php
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php 1 addition, 2 deletions...t/core/Classes/Localization/Parser/LocallangXmlParser.php
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-80486-SettingCharsetViaLocalizationParserInterface-getParsedData.rst 30 additions, 0 deletions...ngCharsetViaLocalizationParserInterface-getParsedData.rst
Please register or sign in to comment