- Apr 07, 2024
-
-
Christian Kuhn authored
The BE may crash when adding a 'keyword' to a page record using the indexed_search BE module: Field 'keywords' of table 'pages' may be null, the call to GU::trimExplode() has to be sanitized for this case since #101453. Resolves: #103542 Related: #101453 Related: #103541 Releases: main Change-Id: If8bdabd629f35a131b19de1bdd3ac5057c1d4c61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83676 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
-
- Apr 05, 2024
-
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-nodejs18 => 1.4 * core-testing-nodejs18-chrome => 1.4 [1] https://nodejs.org/en/blog/vulnerability/april-2024-security-releases/ [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/712e35c72cd7788d1d6311714b5a0dfe46e743a7 Resolves: #103518 Releases: main, 12.4 Change-Id: Ibaafbd465a21d631f6726064255241aa4b42e726 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83636 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
Sybille Peters authored
Doctrine dbal function fetchAssociative() was used in combination with accessing an array element without null colesce. Resolves: #103423 Releases: main, 12.4, 11.5 Change-Id: I6f5842f28722dc8b2716533e818fc40ed2fc25ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83582 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Andreas Kienast authored
The JavaScript module `@typo3/backend/document-save-actions` was introduced in TYPO3 v7 to add some interactivity in FormEngine context. At first it was only used to disable the submit button and render a spinner icon instead. Over the course of some years, the module got more functionality. After some refactorings within FormEngine, the module became rather a burden. This became visible with the introduction of the Hotkeys API, as the `@typo3/backend/document-save-actions` module reacts on explicit `click` events on the save icon, that is not triggered when FormEngine invokes a save action via keyboard shortcuts. Adjusting `document-save-actions`'s behavior is necessary here, but would become a breaking change, which is unacceptable after the 13.0 release. For this reason, said module has been marked as deprecated and its usages are replaced by its successor `@typo3/backend/form/submit-interceptor`. Resolves: #103528 Releases: main Change-Id: Ic4ee972eb79da2331213de624adf077a7e5b567c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83643 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Apr 04, 2024
-
-
Andreas Kienast authored
TCA for usage of `sys_file` may configure their allowed extensions by an array (e.g. EXT:bootstrap_package, "Media" content element) which failed as the Element Browser took only strings into account. The class `TcaPreparation` now takes `columnsOverrides` and their respective `overrideChildTca` configuration into account. Resolves: #103316 Releases: main, 12.4 Change-Id: Ie173a0e007ab44bcb9f090a5b7ae8b7eedd9d45a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83296 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Andreas Kienast authored
In the image editor, the "Cropped area" was configured with a `ceil`ed width and height. Since all other dimensions are `floor`ed, this might cause an overlap. Due to the configured cropping mode, defining that the cropping area must never exceed the image dimensions, the cropper library places the cropper to a position that's mathematically correct but not desired. To solve this issue, the `width` and `height` properties fed to the cropper are now `floor`ed as well, basically aligning with the rest of the coordinates. Resolves: #101520 Releases: main, 12.4, 11.5 Change-Id: I981bd185eaf0db60662a5a6b7b423d84112c2150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83644 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Stefan Bürk authored
To harden the Extbase LazyLoadingProxy implementation a new test has been added with #101400, which creates a proxy directly and using ObjectAccess::getProperty() to access a property of the not loadable child proxy class instance. Due to the use of magic methods`__get()` and `__isset()` methods in the `LazyLoadingProxy` class and some wrong assumptions of the Symfony PropertyAccessor simply null has been retrieved even if the concrete class could not been retrieved (property on a null value instead of an object). The property accessor is used under the hood within the Extbase internal ObjectAccess implementation. The Symfony Team recently declared that behaviour a bug and fixed it with releases `7.0.6` and `6.4.6` and now correctly throwing the `PropertyNotAccessibleException`. Failing nightlies with Symfony releases containing the bugfix revealed a incorrect test implementation, using a constructed and unrealistic construct. This change modifies the test to use a correct access on the LazyLoadingProxy without changing the scenario of the test. [1] https://github.com/symfony/symfony/releases/tag/v7.0.6 [2] https://github.com/symfony/symfony/releases/tag/v6.4.6 [3] https://github.com/symfony/symfony/pull/54194 Resolves: #103531 Related: #101400 Releases: main, 12.4 Change-Id: I5bdd52955af138c1e99b4492c9b5a43839c743cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83645 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
To regenerate a slug, the fields defined in the TCA "generatorOptions" configuration have to be present in the form. There are cases where those fields are added as hidden fields (e.g. using the "overrideValues" feature). Those fields are now also properly respected for the regeneration. Resolves: #103500 Releases: main, 12.4 Change-Id: I0ca7de4b7d7d09e62ece511aeb16615af3d3a1fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83622 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Georg Ringer authored
If a page uses a specific page layout, it must be used in the page module. To be in sync with v12 the change is also merged into v12. Resolves: #103501 Releases: main, 12.4 Change-Id: I91341249fd3f6142a9830bb594a8fe1d2d6ded7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83624 Tested-by:
-
Andreas Kienast authored
A new hotkey is introduced in the FormEngine scope that lets editors invoke "Save and Close" via `Ctrl/Cmd+Shift+S`. Resolves: #103529 Releases: main Change-Id: I530a1df54707eb69033c8a03ccf58517facf162a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83642 Tested-by:
-
Stephan Großberndt authored
Updated and renamed files and adapted paths and extension names. Resolves: #103497 Releases: main, 12.4 Change-Id: Ib79540d47a9112711d53373de2952203c41ded9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83618 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
- Apr 03, 2024
-
-
Andreas Kienast authored
This commit changes how the "Toggle all" and option and action button states are determined. Previously, the state was determined via JavaScript, leading to an unexpected rendering change when the module has loaded. To avoid this, the state is now calculated in the controller as the necessary metrics are already known. In the same run, `optionByType.checked` is now a simple bool flag instead of holding arbitrary HTML attributes. Resolves: #103454 Releases: main Change-Id: I2da39063dbb9161873274dadddcc3b0384e36321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83560 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benni Mack authored
This change adds a new cObject "PAGEVIEW" which has a much simpler usage than "FLUIDTEMPLATE", because it is meant to render a full page like this: page = PAGE page.10 = PAGEVIEW page.10.paths.100 = EXT:site_extension/Resources/Private/Templates Nothing else is needed by default, as a) the layoutRootPaths are resolved to be meant to be under "Templates/Layouts" or "Templates/layouts" b) the partialRootPaths are resolved to be meant to be under "Templates/Partials" or "Templates/partials" automatically are added. The name of the template is resolved from the Page Layout (Backend Layout) identifier, so add a "Templates/Pages/Mypage.html" if there is a backend layout with "mypage" added. In addition, the reserved variables * site (Site object) * language (Site Language object) * page (Page object) * settings (Page / TypoScript Settings) are injected automatically, so the View can work with this information directly. template folders for "pages", "layouts" and "partials" can start with an upper-case or lower-case in order to ensure maximum compatibility and avoid common mistakes. Why do we do this? We've found that FLUIDTEMPLATE is often used for page rendering, but lacks specific usages for pages to be worked directly without the understanding of Fluid internals and TypoScript code. This functionality will be further adapted to be used for further rendering of custom Content Elements and Content Blocks which will follow in subsequent steps. For this reason this API is considered experimental until TYPO3 v13 LTS. Resolves: #103504 Releases: main Change-Id: Ieb2b665945ad671fe7e7c195b3201dbc0dbd7076 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83626 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Georg Ringer authored
The menu generation must not reuse the page record from the current page but must use the data from the linked page. Resolves: #101883 Releases: main, 12.4 Change-Id: I491ed6d2f0d33f9bbe2ef934c4304adfae656808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80948 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Tested-by:
Ben Robinson <robinson2.ben@gmail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #103496 Releases: main, 12.4 Change-Id: I688540c91e85d28eec1951305d63028efa27eb82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83617 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Andreas Kienast authored
Executed commands: composer require --dev sokil/php-isocodes-db-i18n:^4.0.21 Build/Scripts/updateIsoDatabase.php Resolves: #103524 Releases: main, 12.4 Change-Id: I052c959bfa85de02f28dfa190b939adcda2207f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83640 Reviewed-by:
-
- Apr 02, 2024
-
-
Nikita Hovratov authored
While extracting dedicated TCA types from the god type `input`, the `valuePicker` option was forgotten for type `email`. Other types like `number` do have this option. An acceptance test is added to ensure this option will not be dropped by accident in the future. Resolves: #103510 Related: #97013 Releases: main, 12.4 Change-Id: I95c51d858ca9cb3caefa174cd8ce5946c8352aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83631 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Chris Müller authored
Resolves: #103514 Related: #99485 Releases: main Change-Id: I118c1c2473e0411425a634bed0f0f9618b57e371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83633 Reviewed-by:
-
Christian Kuhn authored
Fixes acceptance test database table fields being latin1 instead of utf8mb4. > composer u typo3/testing-framework Change-Id: If3cdb37cd57370237f3104031522baeb70b8b209 Resolves: #103517 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83635 Tested-by:
-
- Mar 31, 2024
-
-
Torben Hansen authored
Function argument types of the `resolveTree` function in the `DeleteRecords` class already use strict types, so the following typecasts can safely be removed. Resolves: #103506 Releases: main Change-Id: I332a2eabdc3727749ff25fbfeee476d0a6b6b39b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83627 Reviewed-by:
-
- Mar 30, 2024
-
-
Georg Ringer authored
The label changed by accident and must be changed back. Resolves: #103508 Related: #102834 Releases: main Change-Id: Ie7d2ada54d0224558e9cab558320b26d1fc79f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83629 Tested-by:
-
Sybille Peters authored
Releases: main Resolves: #103507 Change-Id: I571d99521ffa1e36b9cb18cb1621132d70f6382b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83628 Reviewed-by:
-
Andreas Kienast authored
In the test class `RotatingFileWriterTest`, the `MONTHLY` and `YEARLY` cases for `writingLogWithExpiredLatestRotationInTimeFrameRotates` may fail as it tries to create a mock file that needs rotation with a broken date. It is expected to create a file with a date of the previous period that's tested. However, at the end of uneven months or each Feb. 29th this will heavily fail due to PHP's automatic roll-over to the next valid date. We'd need a fallback to the latest valid date here. The aforementioned test now has a special handling in place in case either `MONTHLY` or `YEARLY` are tested – the date is modified to go back to the first day of the respective period and then either set the current day OR the latest days in that period, whatever fits. Resolves: #103509 Releases: main Change-Id: Ic60c3056ed31933ff7be3af196ba08ed92f04855 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83630 Reviewed-by:
-
- Mar 29, 2024
-
-
Torben Hansen authored
In ext:recycler, there is an open todo to move the function `getUserWhoDeleted` from `RecyclerAjaxController to `RecordHistory`. This change moves the function to `RecordHistory` and additionally renames it to a more appropriate name. Resolves: #103474 Releases: main Change-Id: Id49d2e42c6c2393ef6c0b888bf293cd835cca1ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83578 Reviewed-by:
-
Benjamin Franzke authored
The SiteConfiguration service is currently needed during installation phase for writing site configurations. This limits symfony dependency injection usage and basically requires that all services needed by SiteConfiguration need to be defined and manually wired in ServiceProvider php code. The writing part is now split into a separate service that can be used in EXT:install SetupService as before. Resolves: #103450 Releases: main Change-Id: I9cb579ade537c794ce7c1a844b3d7bec7c1b653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83557 Tested-by:
-
- Mar 26, 2024
-
-
Lina Wolf authored
You can try out the rendering locally with ``` cd typo3/sysext/core docker run --rm --pull always -v $(pwd):/project -it ghcr.io/typo3-documentation/render-guides:latest --config=Documentation ``` Resolves: #103484 Releases: main Change-Id: I3e0645fd8e0d27afeb9857945da444520b416a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83588 Tested-by:
-
- Mar 25, 2024
-
-
Oliver Bartsch authored
At various places, it's possible to edit the metadata of a file in the default language. However, users might not have access to the default language. To prevent moving to FormEngine and facing access permission errors, those places now use proper language access checks and do not display corresponding action if the user does not have access. Resolves: #103432 Releases: main, 12.4 Change-Id: I22c3755a17888cfc623ce05b25fd655b323cc553 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83573 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Lina Wolf authored
A backport to 11.5 is not possible due to too many issues in the Docs that cannot be backported automatically. Resolves: #103479 Releases: main, 12.4 Change-Id: Id52b3193cf270962f6d728d2dc012b5b1d5c2856 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83585 Tested-by:
-
- Mar 23, 2024
-
-
Benni Mack authored
This change centralizes Frontend's "PageLayoutResolver", used in TypoScript, and BackendLayoutView logic to find the used page layout, while also modelling more towards an object within PageLayout which can be used at a later stage in FE to retrieve more information. At the same time, some BackendLayoutView code is reduced now. Resolves: #103466 Releases: main Change-Id: I716fe7313894aac92e5519a6b725feefff908270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83567 Tested-by:
-
Christoph Lehmann authored
The ProductionExceptionHandler in EXT:core outputs error details, but not for every one. As a normal visitor you don't see any tracable error information. The ProductionExceptionHandler in EXT:frontend outputs "Oops, an error occurred!" followed by a timestamp + a hash. This is part of log messages. Whenever an error/exception is logged, the log message contains the request id. With this the request id is also shown in web output of error/exception handlers as public visible error reference. Releases: main Resolves: #103441 Change-Id: I6d6a68d2ea6a6978d3e977bece4336437e6a9890 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83499 Tested-by:
-
Torben Hansen authored
PHP CS Fixer is not able to detect unused imports, when the import is mentioned somewhere in the doc comments. Therefore we have several unused imports in our codebase. This change removes all current unused imports. Resolves: #103475 Releases: main Change-Id: Ibd190234a9c0f1519592ac715943a88e52cd17c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83579 Reviewed-by:
-
Stefan Bürk authored
It is possible, that the `SiteConfiguration` is retrieved from the `Dependency Injection container` by code executed before the test releated site configuration is written, which does not reset the instance based `SiteConfiguration->$firstLevelCache` property and later retrieving site configurations using the `SiteFinder`, for example in rootline and other operations, cannot find the test instance configurations. With #103470 this has been mitigated within the `SiteBasedTestTrait`, but `\TYPO3\CMS\Redirects\Tests\Functional\Service\SlugServiceTest` uses direct method for additional site configurations suffering from the very same issue. This change modifies the `SlugServiceTest` to retrieve the `SiteConfiguration` from the `Dependency Injection container` to ensure proper internal cache invalidation for SiteConfig write operations and additionally ensure cache invalidation by calling `SiteFinder->getAllSites(false)`. Resolves: #103471 Related: #103470 Releases: main, 12.4 Change-Id: I27075ad9f5640aaea07df81a97c8b0326fd76003 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83574 Tested-by:
-
- Mar 22, 2024
-
-
Christian Ludwig authored
Fixes the Doctrine error: Incorrect integer value: '' for column 'editlock' at row 1 Releases: main, 12.4, 11.5 Resolves: #103461 Resolves: #103462 Change-Id: I0e3f0344157f66c07681bd29a47f4f51e32e4225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83564 Tested-by:
-
Stefan Bürk authored
New core-testing-* images have been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below. * core-testing-php82 => 1.12 * core-testing-php83 => 1.13 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/ebdaefdb54a4fe970abf0cb1d32567bbd6339de5 Resolves: #103469 Releases: main, 12.4, 11.5 Change-Id: I35ffd10e7979d4fd59aab5a7fa5d52330e71e0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83569 Reviewed-by:
-
Benni Mack authored
Various places in smaller extensions were reported in phpstan that had some inconsistencies in their code style, which were unnecessary and are now avoided. Resolves: #103383 Releases: main Change-Id: I1d9653e62e753c87e20bf8f2f9ff299a85c8726e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83449 Tested-by:
-
Stefan Bürk authored
`SiteBasedTestTrait` created a instance of the `SiteConfiguration` using the PHP `new` keyword for writing functional test instance site configurations. It is possible, that the `SiteConfiguration` is retrieved from the `Dependency Injection container` by code executed before the test releated site configuration is written, which does not reset the instance based `SiteConfiguration->$firstLevelCache` property and later retrieving site configurations using the `SiteFinder`, for example in rootline and other operations, cannot find the test instance configurations. This change now uses the `SiteConfiguration` from the test instance `Dependency Injection container` which ensures that the internal first level cache is properly reset on `write()` actions. Resolves: #103470 Releases: main, 12.4 Change-Id: I70368e56abd10e55f06d3813371c4538ad704136 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83572 Reviewed-by:
-
Oliver Bartsch authored
When removeByType is used to remove restrictions from the container, it is now ensured that also cross classes are properly respected. Resolves: #103456 Releases: main, 12.4 Change-Id: I4841fe1cba7388358771cf01ee220afa4482349a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83562 Tested-by:
-
Oliver Bartsch authored
Unset non matching key arrays and additionally secure the array access with a corresponding check. Resolves: #102241 Releases: main, 12.4 Change-Id: If034faf04f52f6e8882dd0b610fa5dfdf9ec2298 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83559 Tested-by:
-
Benni Mack authored
BackendLayoutView is used to build the BackendLayout structure, and does a few things too much: a) it uses ArrayUtility over a simple isset() check for pageTsconfig b) it resolves LLL labels directly, even if MoveContent wizard and Page module handle that as well c) it re-builds logic only used in Move Content which is not needed due to a properly resolved colPos list already All of this internal code can be removed and thus reduced to a minimum, with Page module, FormEngine (pages+tt_content) and Move Content Wizard continue to work, because FormEngine and all other modules already use the proper API for rendering already. Resolves: #103463 Releases: main Change-Id: Ib3878d08936e60a9cbd2f405260f3badcefcf8ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83565 Reviewed-by:
-
- Mar 21, 2024
-
-
Torben Hansen authored
In order to ensure unique HMACs in TYPO3, all usages of `TYPO3\CMS\Core\Utility\GeneralUtility::hmac` have been replaced with the `hmac` function in `\TYPO3\CMS\Core\Crypto\HashService`. This change finally deprecates `GeneralUtility::hmac()`. Resolves: #102762 Relates: #102761 Releases: main Change-Id: I3624ea8e2d6ec91abddfa1580ad68c1189b9445c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83462 Tested-by:
-
