[TASK] Use `SiteConfiguration` from DI in `SiteBasedTestTrait`
`SiteBasedTestTrait` created a instance of the `SiteConfiguration` using the PHP `new` keyword for writing functional test instance site configurations. It is possible, that the `SiteConfiguration` is retrieved from the `Dependency Injection container` by code executed before the test releated site configuration is written, which does not reset the instance based `SiteConfiguration->$firstLevelCache` property and later retrieving site configurations using the `SiteFinder`, for example in rootline and other operations, cannot find the test instance configurations. This change now uses the `SiteConfiguration` from the test instance `Dependency Injection container` which ensures that the internal first level cache is properly reset on `write()` actions. Resolves: #103470 Releases: main, 12.4 Change-Id: I70368e56abd10e55f06d3813371c4538ad704136 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83572 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
Please register or sign in to comment