- May 31, 2017
-
-
Christian Kuhn authored
The ext:impexp functional tests are rather hard to read and follow. The patch untangles them to make them better maintainable: * Combine the two different import / export abstract classes into 1 class * Don't inherit from AbstractDataHandlerActionTestCase anymore * Give single test cases better file names and do not hide them in sub dirs * Move all fixtures to Fixtures/ dir * Use less helper methods to import and test things * File paths are more straight and with less helper magic Change-Id: Iae36771b94045f99444f394129cbcf183168b584 Resolves: #81393 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52980 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Georg Ringer authored
Use the term "Upgrade wizard" instead of "Update wizard" for the buttons of the single steps as the main menu item is also called "Upgrade wizard". Resolves: #81383 Releases: master, 8.7 Change-Id: I8047ae45101533a67fa4488af7040acc49af563f Reviewed-on: https://review.typo3.org/52973 Tested-by:
Elmar Hinz <t3elmar@gmail.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- May 29, 2017
-
-
Elmar Hinz authored
Support case sensitve file systems again. Releases: master, 8.7 Resolves: #80814 Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3 Reviewed-on: https://review.typo3.org/52939 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. This does not seem appropriate for URLs generated by TYPO3. Use the optional parameters of http_build_query() to get the desired functionality. Releases: master, 8.7, 7.6 Resolves: #81366 Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf Reviewed-on: https://review.typo3.org/52934 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Daniel Goerz authored
Resolves: #81272 Releases: master, 8.7 Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07 Reviewed-on: https://review.typo3.org/52863 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 28, 2017
-
-
Georg Ringer authored
Remove the last parameter of method makeEditForm_accessCheck in BackendUtilityHook as it is unused. Resolves: #81290 Releases: master Change-Id: I46a8d88273765762c6dbc8793b76e35b5a2b6653 Reviewed-on: https://review.typo3.org/52924 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 26, 2017
-
-
Georg Ringer authored
Escape the < > in the check of the Windows Apache ThreadStackSize. Resolves: #81134 Releases: master, 8.7 Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99 Reviewed-on: https://review.typo3.org/52925 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- May 24, 2017
-
-
Markus Klein authored
http_build_query() internally uses the PHP setting arg-separator.output to identify the URL parameter separator. Our code relies on having a simple ampersand as this character. If the PHP is set to a different configuration the code will fail. This is fixed by enforcing the ampersand. Moreover we force RFC3986 encoding to ensure that decoding with rawurldecode() does the right thing. Releases: master, 8.7 Resolves: #81293 Change-Id: I321c7bba03ee597adc29a2f8429b8fc9ac3b709d Reviewed-on: https://review.typo3.org/52922 Reviewed-by:
Carsten Falkenberg <office@limebox.de> Tested-by:
-
- May 23, 2017
-
-
Christian Kuhn authored
Some DB drivers are picky on their arguments not being objects. Add an explicit cast to string for a VersionState object just before it's fed to a query as argument. Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c Resolves: #81309 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52916 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
- May 22, 2017
-
-
Stephan Großberndt authored
Using the correct datatype "string" instead of a \Doctrine\DBAL\Schema\Identifier as TableDiff->name prevents exceptions if another SchemaEventSubscriber is registered. Releases: master, 8.7 Resolves: #81276 Change-Id: If273a165604ff3149d8e5aba2c0b5ccbdef8102d Reviewed-on: https://review.typo3.org/52872 Tested-by:
-
Stephan Großberndt authored
Using $connection->getSchemaManager()->listTableNames() instead of ->listTables() in Install Tool prevents a DBAL\Exception as the table details are not requested - which are not used anyway, so this is faster too. Releases: master, 8.7 Resolves: #81264 Change-Id: I35db1b6fa743ad4869bf2ba24717320f0f009995 Reviewed-on: https://review.typo3.org/52858 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
Stephan Großberndt authored
Re-enable the tests passing tests changeExistingColumn() and installDoesNotAddIndexOnChangedColumn() in SchemaMigratorTest. Resolves: #81302 Releases: master, 8.7 Change-Id: Idaf9d87c16d58864c6de3353ec68be46ae93024f Reviewed-on: https://review.typo3.org/52905 Tested-by:
-
Claus Due authored
This patch reduces the amount of time required to check CGL to less than 3% of what it was before when xdebug is loaded and the script is asked to check ~100 files. Time before: 17m Time after: 23.3s Change-Id: I533ac3bfd03922362ccd6180caf6df2bfecd5bac Releases: master, 8.7 Resolves: #80814 Reviewed-on: https://review.typo3.org/52417 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
Anja Leichsenring authored
Ext:core comes with a little testing framework for functional tests, that is pretty useful for all kind of DataHandler related tests. Those classes are better located in the testing-framework package to be available. Change-Id: I429e801b7318fda3a96acb4f5f63bb75050fb3e3 Resolves: #81154 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52728 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Anja Leichsenring authored
Resolves: #81284 Releases: master, 8.7 Change-Id: I59730f5807d27bbc7eb232917763daa89f41315a Reviewed-on: https://review.typo3.org/52879 Tested-by:
-
Thomas Hohn authored
Copying big sub-trees can benefit from caching the calls to doesRecordExist_pageLookUp in a run-time cache since there are a lot of identical calls to the database. In addition the signature was adjusted - see also the already merged issue #77391 which altered the signature. Resolves: #79610 Releases: master Change-Id: I2da164193f13759123d57c17985be46e7bd7667b Reviewed-on: https://review.typo3.org/51516 Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
-
Christian Kuhn authored
A basic acceptance tests clicking through installer using a mysql db connection, checking backend login and "blank" site frontend output works. Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c Resolves: #81285 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52880 Tested-by:
-
Christer Vindberg authored
Use quoted/escaped values embedded in the SQL fragment instead of named parameters in QueryGenerator::getSelectQuery. The values of named parameters get lost when the SQL fragment is returned and subsequently used in a query. Resolves: #80872 Releases: master, 8.7 Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a Reviewed-on: https://review.typo3.org/52472 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
Anders Kostending <aha@systime.dk> Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- May 21, 2017
-
-
Christian Kuhn authored
Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268 Resolves: #81289 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52889 Reviewed-by:
-
Christian Kuhn authored
A couple of bug fixes and a setup for acceptance tests of the installation procedure. Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9 Resolves: #81287 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52885 Tested-by:
-
Elmar Hinz authored
Releases: master, 8.7 Resolves: #81280 Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2 Reviewed-on: https://review.typo3.org/52877 Tested-by:
-
- May 20, 2017
-
-
Christian Kuhn authored
The components/ directory has been a temporary directory in v8 phase, does not exist anymore and can be removed from .gitignore. Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea Resolves: #81286 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52881 Tested-by:
-
- May 19, 2017
-
-
Anja Leichsenring authored
If the code given for PageNotFound_handling is a relative URL, the host determination gets skipped, resulting in a redirect of the markup of the page instead a proper redirect. Change-Id: Id9c26cba813c212438368cee031673dc59db360b Resolves: #81267 Relates: #81031 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52859 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
- May 18, 2017
-
-
Thomas Schur authored
Prevent duplicated special char conversion of page title in TYPO3 backend breadcrumb and fix title cropping Resolves: #81242 Releases: master, 8.7 Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16 Reviewed-on: https://review.typo3.org/52820 Reviewed-by:
-
Josef Glatz authored
Related: #81171 Resolves: #81258 Releases: master Change-Id: I2a07571bb45aefd5927498dee5604edb99ba271b Reviewed-on: https://review.typo3.org/52855 Reviewed-by:
-
Benni Mack authored
The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch the workspace record, then hands it over to BE_USER->checkWorkspace which has the same functionality - to fetch the full workspace record. As this is redundant code, the PageRepository code can be simplified a lot by just leaving the workspaceCache property. Resolves: #81187 Releases: master, 8.7 Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290 Reviewed-on: https://review.typo3.org/52754 Tested-by:
-
Oliver Hader authored
Tryign to determine workspace versions for a particular database table results in a very long process execution time and possible timeout due to the following reasons: * in general a bug was introduced during the Doctrine DBAL migration which leads to misbehaviors in resolving versions for pages * the SQL query implicitly creates an INNER JOIN with a huge result set that takes a long query time * invalid types leading to possible flaws when using prepared statements The SQL query has been split into using sub-queries now. Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a Resolves: #80898 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52506 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Daniel Windloff authored
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/50104 Reviewed-by:
-
Jochen Greiner authored
The comment was wrong because the TSFE-Controller takes care of setting this option internally. Resolves: #81219 Releases: master, 8.7 Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27 Reviewed-on: https://review.typo3.org/52800 Reviewed-by:
-
Marcus Schwemer authored
Currently the prepend option is rendered together with the options argument from select viewhelper. Using the option "optionsAfterContent" renders also the prepend option after the children. The preprend option is now rendered always in the first place. Resolves: #79584 Releases: master, 8.7 Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331 Reviewed-on: https://review.typo3.org/51501 Reviewed-by:
-
Thomas Maroschik authored
When the Typo3DBQueryParser converts Extbase queries to Doctrine queries, it creates subselects for certain relation constraints. It fails to wrap the subselect in braces for has-many relations which leads to sql exceptions. This patch introduces braces around those subselects. Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb Fixes: #81240 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52817 Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Georg Ringer authored
The public method Scheduler::log accepts an optional $code as 3rd parameter. Add this information to the parameter $details of BackendUserAuthentication::writelog as otherwise it will be casted to an integer and its information will be lost. Resolves: #80592 Releases: master, 8.7 Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c Reviewed-on: https://review.typo3.org/52553 Tested-by:
-
Andreas Fernandez authored
Triggering ext:t3editor out-of-bound of FormEngine is pretty tricky and blocks further development of t3editor. To streamline this, the current implementation of t3editor within ext:tstemplate is revamped and now uses FormEngine directly to edit "constants" and "setup" of template records. Some hooks are now obsolete and dropped along the way. Resolves: #81171 Releases: master Change-Id: Iab62a15828bfb82bc9f8ad11f705bb4529a38734 Reviewed-on: https://review.typo3.org/52696 Reviewed-by:
-
Elmar Hinz authored
Update the comment of the mehtod PageRepository::getMountPointInfo(). Add hint addressing to the usage of recursive mount points. Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc Releases: master, 8.7 Resolves: #81254 Reviewed-on: https://review.typo3.org/52842 Reviewed-by:
-
Benni Mack authored
By moving Bootstrap::loadBaseTca() to the configure() call of the TYPO3 Bootstrap, the global TCA variable is now populated very early and it is obvious that this logic is then part of the actual system setup, and does not need to be handled by any RequestHandler anymore. Considering TCA is necessary for a TYPO3 environment to run, this change might be very helpful. Please note that the Install Tool application does not call configure(), so this is not affected. This also removes some issues related to Extbase Command controllers in CLI handling. Side effects: - eID requests now have full TCA loaded as well at any time - TCA is now loaded BEFORE entering any request handler check - TCA is now loaded before e.g. BackendRouting initialization, and other Backend security checks Easy to test the current behaviour: - Clear all caches via install tool - Call CLI command extbase:help which will result in a Warning / Exception Resolves: #72222 Resolves: #81201 Releases: master Change-Id: I31a0de0d0b039eb6180123678c61d3f26435dd63 Reviewed-on: https://review.typo3.org/52753 Tested-by:
-
Fabian Thommen authored
Releases: master, 8.7 Resolves: #81253 Change-Id: I9920ba02349d51925610c2bd04fd8c3ea668e3a6 Reviewed-on: https://review.typo3.org/52832 Reviewed-by:
-
Helmut Hummel authored
DataHandler does a lookup in sys_log table after it performed its operations to find relevant error entries for the current request. It determines relevance by looking for entries with the same timestamp as $GLOBALS['EXEC_TIME']. However error log entries are written using time(). Now if the DataHandler operations take longer than one second, or the log entry is written directly before a next tick, it can happen, that errors will not be detected during the lookup process. Since such errors are exposed to the user, it can happen that an operation fails, but the users will not be notified. Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries. Resolves: #81244 Releases: master, 8.7, 7.6 Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e Reviewed-on: https://review.typo3.org/52822 Reviewed-by:
Felix Rauch <rauch@skaiamail.de> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- May 17, 2017
-
-
Gerrit Mohrmann authored
During the refactoring to doctrine in https://review.typo3.org/#/c/48574 a wrong expression was used. Use notIn() instead of in(). Resolves: #81246 Releases: master, 8.7 Change-Id: Icd1bf595fe3a75dc12d875a8a4c416c9b568c6c0 Reviewed-on: https://review.typo3.org/52825 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Daniel Windloff authored
In EXT:beuser -> Backend User Listing there is the possibility to add an user to the compare list. If the user is already in the compare user list, the user is removed from this list. Resolves: #81079 Releases: master, 8.7 Change-Id: If0d6c132cdb2dbbd524890c3c90f92877240a284 Reviewed-on: https://review.typo3.org/52660 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Christian Kuhn authored
Unit test: Fix namespace, test file location and class inheritance. Change-Id: Ida24b5adf747dc7c259a966fcddfdb7feb9f0951 Resolves: #80742 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52827 Tested-by:
-
