- Sep 08, 2020
-
-
Benni Mack authored
With the introduction of symfony/event-dispatcher-contracts in https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e4a1ae8762ee99712e4e5c9c2f8a3876bce97620 this change forced support for symfony5 in composer-based installations (although non-composer-based installations use symfony5 bundled already), as contracts v2 is only compatible with symfony v5, but contracts v1 is used for symfony4. This change allows composer-based installations to support both versions (v5/v4) again, so extensions like EXT:solr (which requires a package called solarium) to work with the dependency constraints of TYPO3 Core. - composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update \ --working-dir=typo3/sysext/core - composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update - composer update --lock Resolves: #92229 Releases: master, 10.4 Change-Id: I5f501e9ed9d6a844de942c2ca96c9d52e0bd5e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65635 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Daniel Windloff authored
After the removal of TCA [ctrl][thumbnails] in #92118, the method 'getVisibleColumns()' isn't used any more. Therefore, it has been removed. Releases: master Resolves: #92226 Change-Id: Iff0ad528e96a0f89fc1f59d9728d9a96374f793f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65629 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Daniel Windloff authored
The property `showIcon` was always 1. Therefore, it has been removed. Releases: master Resolves: #92211 Change-Id: I852bc2c007f77522b3b80423f92f28a5be3c22b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65591 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Daniel Windloff authored
Releases: master Resolves: #92210 Change-Id: Ie8c160fae548ae8cf013200e4a6d2e6344244f23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65590 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Sep 07, 2020
-
-
Christian Kuhn authored
Adding an image to a workspace content element adds two sys_refindex entries: One for the sys_file_reference t3ver_state=-1 and one for the t3ver_state=1 record. Deleting the image reference again in workspaces only sets one of the two to deleted in sys_refindex, leading to orphan sys_refindex entries. The patch fixes this by adding a 'redo refindex' call at the appropriate place. There are more issues when 'discard changes' is used together with multi-level relations (tt_content->hotel->offer->price): Discard does not properly cascade in those cases, yet. The patch touches this as a side-effect and does not improve the situation. The .csv files are marked with @todo accordingly and will be fixed with further patches. Those scenarios are more seldom than a broken sys_refindex for FAL images which is the primary goal of this patch. Analyzing the test scenarios, the patch actually removes various rows from sys_refindex where the left part of the relation is set to deleted. This is correct and wanted: In the end we don't want sys_refindex to contain reference to deleted rows at all. This strategy will be further followed with other patches. Resolves: #61917 Related: #67676 Releases: master, 10.4 Change-Id: I3246f263e393c6b384c2d98b0dbbcf4dbbeeccad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65510 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
HTTP responses having a status code not in 200-299 are basically still responses. In order to allow general response handling ResponseError is dropped in favor of AjaxResponse. Besides that `AjaxResponse.dereference()` has been introduced which allows to forward relevant data (status, headers, body) in events or broadcast messages to other `window` instances or frames. Resolves: #92222 Releases: master, 10.4 Change-Id: I3ac986980fe53bb528046f58bc19392744122ee7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65625 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Resolves: #92221 Releases: master, 10.4 Change-Id: Ic172280bfeb65e89c340b55330d345a9252a8838 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65623 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Nikita Hovratov authored
In some setups the conf array is null and throws an error. This patch adds the ?? operator with an empty array as fallback value. Resolves: #92216 Related: #91657 Related: #91834 Releases: master Change-Id: I95df9ad491f1284867a683a6980dbb1f6c3f3381 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65618 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
The PlainDataResolver is used to find overlay id's of live id's in workspace context. One usage is the ReferenceIndex. In scenarios 'modify content, discard content, modify again' with relations, the PlainDataResolver sometimes fetches rows that have been set to deleted (discarded) already together with the rows that should be fetched. Depending on the order of the result rows - which depends on the DBMS - wrong overlay rows are calculated sometimes. The patch adds a database DeletedRestriction at 3 of 4 places in the PlainDataResolver to only fetch correct rows. The last place triggers another side-effect that needs to be tackled with another patch and is commented as @todo for now. The tests add missing sys_refindex rows to the 6 tests that failed on postgres before. Additionally, for some other IRRE/CSV workspace tests, the sys_refindex changes slightly and is more correct now. Resolves: #92190 Releases: master, 10.4 Change-Id: I14f5211b5996d7f53738b9e086c3866aa1a4eaeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65617 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Oliver Bartsch authored
Furthermore the text constants are moved to the locallang file. Resolves: #92212 Releases: master, 10.4 Change-Id: I9fd33ce977879f5f2a4b515850a214d249b8d028 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65615 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92108 Change-Id: I9aa59588a183ee3cb43091fadd6eab2491a7cbdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65463 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
ext:extensionmanager This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92158 Change-Id: I6e5b182dde2a748312ccc39fe7cde262d331dc50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65537 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 06, 2020
-
-
Helmut Hummel authored
For building URIs using the Symfony routing, array URL arguments are deflated (foo[bar] -> foo__bar). In case the final URI contains a remaining query string, the arguments get inflated again. However the query string of the URI is currently only updated, when at least one of the remaining arguments require a cHash. In case remaining arguments exist, the query string needs to be always updated, whether the URI requires a cHash or not. Resolves: #92183 Releases: master, 10.4, 9.5 Change-Id: I1966b4b1e8e09716733b3357922cf857543c14e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65543 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
Helmut Hummel authored
In http://review.typo3.org/11011 a plain DB call that fetched the storage record was replaced with usage of StorageRepository::findByUid, which in turn calls ResourceFactory::getStorageObject again. This leads to all events also called twice. To avoid this a new internal method is introduced on StorageRepository, which only fetches the storage row again. Resolves: #92201 Releases: master, 10.4, 9.5 Change-Id: Ibce6e8d9a0b5ce7abb0f86d80ac42a1a86d47e35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65580 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io>
-
- Sep 05, 2020
-
-
Oliver Bartsch authored
Since #90854 the siteLanguages array also contains the -1 language which must be skipped because it otherwise falls back and generates another default language column. Resolves: #91986 Relates: #90854 Releases: master, 10.4 Change-Id: I5b1388bb9a8af7a3c14827d3aa714e23d670dcd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65545 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Daniel Windloff authored
The `fieldArray` related configuration has been moved to the `getTable` method. The configuration handling for the `fieldArray` has been changed, in order to avoid later unset on the `fieldArray`. The `fieldArray` is only in the `getTable` and subordinated render methods. Therefore, the implicit configuration transfer like `fieldArray[0]` for the label column has been replaced. Releases: master Resolves: #92154 Change-Id: I04287e90e8cffc2ab768bd5399a8155f823fdfe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65534 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92106 Change-Id: I089376b6b77a0ac5f67244a19e12994ce4cdecaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65462 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
CSV fixture files are a straight way to feed test database with stuff and to assert database state after operations. Script Build/Scripts/checkIntegrityCsvFixtures.php tests those files for integrity, making sure all lines have the same number of columns. Maintaining the number of commas when fiddling with functional tests however is annoying. The patch adds options to checkIntegrityCsvFixtures.php: * '--fix' simply fixes files with broken integrity * '--fixAll' goes through all files and looks for details like superfluous comma. While --fixAll is used once now to establish a good baseline on all .csv fixtutre files, --fix can be used whenever the integrity script mumbles about broken stuff: Build/Scripts/checkIntegrityCsvFixtures.php --fix It is also added to runTests.sh: Build/Scripts/runTests.sh -s fixCsvFixtures Change-Id: Idee2a97094f56d059b02f801ffecb50a7ce21a5c Resolves: #92207 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65584 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The functionality of "exchanging" a versioned record in a workspace with a live version, is not used, and has certain downsides (e.g. it is not clear what exchange happened, not event stream to understand when was what changed, and especially when swapping single/selected items multiple times it gets really messy). Also, swapping is conceptually not working (when activated) for newly created records and leaves an inconsistent state. For these reasons, the feature is dropped. What was removed: * The option sys_workspace.swap_modes * The option to only swap on auto-publish * The option to swap in workspace module In the future it would be really beneficial to rename internal "swap" variables to "publish" to streamline this logic. Resolves: #92206 Releases: master Change-Id: Ie153a890e5d0dc6ac0b8707a2739c89922e017d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65318 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
This is the second part to replace stdWrap calls where stdWrapValue is possible instead. The type int is now a possible return type for stdWrapValue. In addition stdWrapValue can return now the string "0" if returned by stdWrap operation. Resolves: #91834 Related: #91657 Releases: master Change-Id: I70749fdb9f9cd56b86ed602afc9b742c1ed0046c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65064 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Christian Kuhn authored
The backend shortcut / bookmark handlig API was designed to hand over relevant get/post arguments as key only (eg. 'id'). The underlying code then pulled values from GET/POST or from SOBE->MOD_SETTINGS. This is ugly, there shouldn't be such magic: Only controllers know relevant keys and values, so it should hand them over directly to the shortcut API. The patch changes this: * Old and unused ViewHelper f:be.buttons.shortcut is deprecated. * ViewHelper be:moduleLayout.button.shortcutButton deprecates argument 'getVars' and adds new argument 'arguments'. * Class ShortcutButton has a new setter 'setArguments' that accepts all relevant argument key/value pairs to create a shortcut. Existing get/set related methods are deprecated. * Helper methods 'makeShortcutIcon' and 'makeShortcutUrl' of class ModuleTemplate are deprecated and implemented in class ShortcutButton directly. * All core usages are adapted to new API. * Shortcut handling was the last core usage of SOBE, so last $GLOBALS['SOBE'] = $this assignments can be finally removed. Impact: * Shortcuts to modules not directly reachable via main menu do not work due to limits of the module registration API. An example is the 'create multiple pages' controller. This issue exists before the patch, affected controllers no longer render a shortcut button for now. * The old code usually added the 'route' argument twice for shortcuts. This has been resolved. As a side effect, the comparison if a shortcuts exists (yellow shortcut icon) fails currently for existing shortcuts when the patch is applied: The comparison relies on direct string equality since shortcuts always store the final url in the database. This storage strategy should be changed with another patch that will solve the 'no yellow icon' issue at the same time. Change-Id: I3ccd2b8f6adab8e7780c5f9911fdea013ccfa99b Resolves: #92132 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65503 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Anja Leichsenring authored
Since symfony/mailer:5.0.8 the message object requires valid content to be accepted, so a couple of unit test have to comply to this requirement. Resolves: #92204 Releases: master, 10.4 Change-Id: I2108eb031659817c67c1c28f84e5f30ebed078a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65583 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 04, 2020
-
-
Daniel Windloff authored
The method `listURL()` is used to set the `returnUrl` for all actions in the `DatabaseRecordList`. It replaces the usages of the method `makeReturnUrl`. Therefore, this method has been removed. Furthermore, `GeneralUtility::getIndpEnv('REQUEST_URI')` has been replaced by `listURL()`. This leads to a consistent behaviour after performing any kind of action in the `DatabaseRecordList`. Releases: master Resolves: #92192 Resolves: #83758 Change-Id: I2dc84a2c4e4103d5b4e77ebb646158e8c15f3202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65574 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
ext:linkvalidator This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92160 Change-Id: Ibef28b44294cd16b7fe83628490ebb556d13f083 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65539 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
By creating new records the EditDocumentController did not take the default values fetched via GET / Post variables into account. This led to multiple issues when defining columns to be readOnly, disabled or hideForNonAdmins as the values are then stored in defVals parameter but never added to the final datamap. The default values are now being added to the Datahandler prior to process_datamap call. Resolves: #92119 Resolves: #88456 Resolves: #75514 Releases: master, 10.4 Change-Id: I0975dfd2417711813e1701247e8b68d8805c890b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65536 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Loek Hilgersom <loek@netcoop.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Loek Hilgersom <loek@netcoop.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Markus Klein authored
This change corrects the Install Tool cookie handling in various ways: 1.) It is ensured that the cookie is removed on log off 2.) Session files (var/session/*) are always removed 3.) No cookie is set until it is really needed (during login) 4.) Session expire calculation is centralized into a single method This is done by adjusting the SessionService: - Move session_start() from the constructor to a dedicated method - Session existence check employs a cookie existence check before loading an existing session into memory and validating it - destroySession() now explicitly removes the cookie - renewSession() lets session_regenerate_id() deleted old session data The Install Tool is adjusted to separate action treatment for actions requiring session interaction and those not. Resolves: #92035 Releases: master, 10.4 Change-Id: Ie666831c3eb97279fad7870638b028a577fb68f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65358 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The divider element in the TCA option for "tt_content.imageorient" does not reflect the current state of the functionality anymore and can be removed, since the "no wrap" is not very appealing for editors to understand, and other options (e.g. above) are also without wrapping, so this div element is removed. Resolves: #50570 Releases: master Change-Id: If41b3baf2ca768521dcabc08b2e9287b9a792fa9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65579 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
Instead of using the be.widget.paginate widget, extensions are now paginated with a QueryResultPaginator and the pagination is build with the help of a SimplePagination instance. Since there is an ArrayPaginator in the core as well, the search result list is now paginated as well. Releases: master Resolves: #92003 Change-Id: I80f1d34b363d25176961139e3ded48e9ab2c165e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64524 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Timo Poppinga authored
Add mixed annotation of parameter $value in ExtensionConfiguration of method set. The static code analysis tools line phpstan can deal with it Resolves: #92181 Releases: master, 10.4 Change-Id: I9dc39737a7f6009c2dcb736c04131018a88ee36b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65541 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Christian Kuhn authored
To get a feeling of current state of sys_refindex handling in the core, the DataHandler functional tests now assert the state of this table. This is a pre-patch to fix reference index details later, so workspaces and FAL can eventually become friends. typo3/testing-framework needs a raise to deal with sys_refindex: composer require --dev typo3/testing-framework:^6.4.2 A couple of tests are left out since they trigger a bug if using postresql. Those are listed in #92190 and need a separate patch. Change-Id: I6f83971687409e31506cea0177ddf64d707307ad Resolves: #92189 Related: #92190 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65544 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Tizian Schmidlin authored
Precision of `uniqid()` on Windows systems without passing `$more_entropy=true` has only single-second-resolution which will lead to non-unique ids on subsequent calls. In order to mitigate this issue TYPO3 provides the function `StringUtility::getUniqueId($prefix = '')` which calls `uniqid()` with parameter `$more_entropy` always set to true. Using `uniqid()`, especially with `$more_entropy` set to true, is quite slow, but for the purposes TYPO3 is using it (i.e. creating unique field names for backend forms, path identifiers in some modules etc.) it is good enough and another solution would not provide any measurable benefit. Resolves: #91553 Releases: master, 10.4 Change-Id: Ib4443e72621eee6df2daf5bf23054e1a01325783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64652 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
The method "shouldExcludeTableFromReferenceIndex()" which also incorporates a PSR-14 currently only skips references FROM a specific table, but in order to keep consistency, they should also be excluded TO this specific table. Resolves: #89100 Releases: master, 10.4 Change-Id: I0bee4fb12cb461e51a97180addd0b0358fba8412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65572 Tested-by:
Claus Harup <ch@typoconsult.dk> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Claus Harup <ch@typoconsult.dk> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
-
Alexander Schnitzler authored
ext:scheduler This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92159 Change-Id: I8e6a06a81cc12ff4c1bbdb69611d1d1bfd48d109 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65538 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
This patch updates some tools used for our assets generation toolchain. Most notable changes: - Since typescript-eslint has been updated to a new major version, its configuration changes slightly - TypeScript is updated to 3.9 Executed commands: yarn add --dev \ "@typescript-eslint/eslint-plugin"@^3.8.0 \ "@typescript-eslint/parser"@^3.8.0 \ "@typescript-eslint/typescript-estree"@^3.8.0 \ autoprefixer@^9.8.6 \ eslint@^7.6.0 \ grunt-eslint@^23.0.0 \ grunt-lintspaces@^0.9.0 \ jasmine-core@^3.6.0 \ karma@^5.1.1 \ karma-coverage@^2.0.3 \ karma-jasmine@^3.3.1 \ terser@^5.0.0 \ typescript@~3.9.0 grunt build Resolves: #91952 Releases: master, 10.4 Change-Id: Ib6726998bea0faf68e71d8374ee0d729a34b0c1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65223 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 03, 2020
-
-
Henrik Elsner authored
This adds migration of the replyToAddress field of the email finishers in EXT:form Resolves: #92122 Relates: #80420 Releases: master, 10.4 Change-Id: If70b13cf04dbb708274a2ba59dda35b758ae5025 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65496 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
MonTea authored
Releases: master, 10.4 Resolves: #92185 Change-Id: I6f73180a29440caa87367f47d219955e51e08691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65547 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
When a newly created record in a workspace is added, two records are created: * t3ver_state=-1 (the versioned record NEW_PLACEHOLDER_VERSION which contains the data) * t3ver_state=1 (the placeholder NEW_PLACEHOLDER) When the record is now moved (= sorting or pid is changed) then the versioned record was previously not updated sorting or pid values. This change keeps both records in sync making it easier to have a consistent setup. This is helpful when working on versioned records (and not on the pairs = overlays) directly. Resolves: #92182 Releases: master, 10.4 Change-Id: Idc7632b12cc03a04eac1430f84cf67bf1ec24e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65535 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Andreas Fernandez authored
With this patch, the path resolving for certain assets is now completely handled by PageRenderer by using the EXT: prefix. Resolves: #91365 Releases: master, 10.4, 9.5 Change-Id: Ia23650244f70f5e4cdf8d953bfcb2f0fcf01ef6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64781 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
When adding a new record (or moving a record) in a workspace, the TCA[table][ctrl][label] field is filled with a static label (e.g. "[PLACEHOLDER, WS #1]") which only makes sense for TCA tables where the label field is an input field, otherwise label fields (in sys_file_metadata) which are numeric ("sys_file_metadata.file") will never be allowed to be translated. Resolves: #61689 Releases: master, 10.4 Change-Id: Ic115777c0b6adc6c98cac913cd7b74cfd126d479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65542 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Alexander Schnitzler authored
The Permission class unnecessarily had been implemented as Enumeration although the features of the Enumeration base class hadn't been used. As the Permission class only handles boolean flags, it is now implemented as bit set, which improves the performance in comparison to Enumeration classes. Releases: master Resolves: #89465 Change-Id: I73eff34090a7ea8e02f7d538e2db52045c86d438 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61099 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-