Skip to content
Snippets Groups Projects
Commit 2a702e2b authored by Markus Klein's avatar Markus Klein Committed by Benni Mack
Browse files

[BUGFIX] Do not create Install Tool cookie if not needed

This change corrects the Install Tool cookie handling in various ways:

1.) It is ensured that the cookie is removed on log off
2.) Session files (var/session/*) are always removed
3.) No cookie is set until it is really needed (during login)
4.) Session expire calculation is centralized into a single method

This is done by adjusting the SessionService:
 - Move session_start() from the constructor to a dedicated method
 - Session existence check employs a cookie existence check
   before loading an existing session into memory and validating it
 - destroySession() now explicitly removes the cookie
 - renewSession() lets session_regenerate_id() deleted old session data

The Install Tool is adjusted to separate action treatment for actions
requiring session interaction and those not.

Resolves: #92035
Releases: master, 10.4
Change-Id: Ie666831c3eb97279fad7870638b028a577fb68f7
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65358


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent a276ba3a
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment