[TASK] CSV integrity test script can fix fixtures
CSV fixture files are a straight way to feed test database with stuff and to assert database state after operations. Script Build/Scripts/checkIntegrityCsvFixtures.php tests those files for integrity, making sure all lines have the same number of columns. Maintaining the number of commas when fiddling with functional tests however is annoying. The patch adds options to checkIntegrityCsvFixtures.php: * '--fix' simply fixes files with broken integrity * '--fixAll' goes through all files and looks for details like superfluous comma. While --fixAll is used once now to establish a good baseline on all .csv fixtutre files, --fix can be used whenever the integrity script mumbles about broken stuff: Build/Scripts/checkIntegrityCsvFixtures.php --fix It is also added to runTests.sh: Build/Scripts/runTests.sh -s fixCsvFixtures Change-Id: Idee2a97094f56d059b02f801ffecb50a7ce21a5c Resolves: #92207 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65584 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- Build/Scripts/checkIntegrityCsvFixtures.php 117 additions, 11 deletionsBuild/Scripts/checkIntegrityCsvFixtures.php
- Build/Scripts/runTests.sh 7 additions, 0 deletionsBuild/Scripts/runTests.sh
- Build/testing-docker/local/docker-compose.yml 17 additions, 0 deletionsBuild/testing-docker/local/docker-compose.yml
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/TranslatedSubpages.csv 10 additions, 10 deletions...l/DataHandling/DataHandler/DataSet/TranslatedSubpages.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/DataSet/LiveDefaultElements.csv 28 additions, 28 deletions...nctional/DataHandling/FAL/DataSet/LiveDefaultElements.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/changeContentSorting.csv 12 additions, 12 deletions.../DataHandling/FAL/Modify/DataSet/changeContentSorting.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/copyContent.csv 19 additions, 19 deletions...unctional/DataHandling/FAL/Modify/DataSet/copyContent.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/copyContentToLanguage.csv 23 additions, 23 deletions...DataHandling/FAL/Modify/DataSet/copyContentToLanguage.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/createContentWFileReference.csv 16 additions, 16 deletions...ndling/FAL/Modify/DataSet/createContentWFileReference.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/deleteContent.csv 18 additions, 18 deletions...ctional/DataHandling/FAL/Modify/DataSet/deleteContent.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContent.csv 14 additions, 14 deletions...ctional/DataHandling/FAL/Modify/DataSet/modifyContent.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentNAddFileReference.csv 19 additions, 19 deletions...ing/FAL/Modify/DataSet/modifyContentNAddFileReference.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentNDeleteAllFileReference.csv 20 additions, 20 deletions...L/Modify/DataSet/modifyContentNDeleteAllFileReference.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentNDeleteFileReference.csv 18 additions, 18 deletions.../FAL/Modify/DataSet/modifyContentNDeleteFileReference.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/modifyContentWFileReference.csv 16 additions, 16 deletions...ndling/FAL/Modify/DataSet/modifyContentWFileReference.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/moveContentToDifferentPage.csv 12 additions, 12 deletions...andling/FAL/Modify/DataSet/moveContentToDifferentPage.csv
- typo3/sysext/core/Tests/Functional/DataHandling/FAL/Modify/DataSet/moveContentToDifferentPageNChangeSorting.csv 12 additions, 12 deletions...dify/DataSet/moveContentToDifferentPageNChangeSorting.csv
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_external.csv 3 additions, 3 deletions...res/expected_output_content_with_broken_link_external.csv
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_file.csv 3 additions, 3 deletions...ixtures/expected_output_content_with_broken_link_file.csv
- typo3/sysext/linkvalidator/Tests/Functional/Fixtures/expected_output_content_with_broken_link_none.csv 2 additions, 2 deletions...ixtures/expected_output_content_with_broken_link_none.csv
Please register or sign in to comment