Skip to content
Snippets Groups Projects
Commit 712302a5 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] CSV integrity test script can fix fixtures

CSV fixture files are a straight way to feed test database
with stuff and to assert database state after operations.
Script Build/Scripts/checkIntegrityCsvFixtures.php tests those
files for integrity, making sure all lines have the same number
of columns. Maintaining the number of commas when fiddling with
functional tests however is annoying.

The patch adds options to checkIntegrityCsvFixtures.php:
* '--fix' simply fixes files with broken integrity
* '--fixAll' goes through all files and looks for details
  like superfluous comma.

While --fixAll is used once now to establish a good baseline
on all .csv fixtutre files, --fix can be used whenever the
integrity script mumbles about broken stuff:

Build/Scripts/checkIntegrityCsvFixtures.php --fix

It is also added to runTests.sh:

Build/Scripts/runTests.sh -s fixCsvFixtures

Change-Id: Idee2a97094f56d059b02f801ffecb50a7ce21a5c
Resolves: #92207
Releases: master, 10.4, 9.5
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65584


Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent 2e1e235a
Showing
with 386 additions and 256 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment