- Dec 07, 2016
-
-
Patrick Kollodzik authored
Because the ShortcutToolbarItem has three different actions, every action has its own template. Resolves: #77800 Releases: master Change-Id: I054569376a0a5f62bb40e7d77f675350e0464423 Reviewed-on: https://review.typo3.org/49810 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Christian Kuhn authored
The patch changes the ajax result that delivers TCA tree items to the SVG tree from a nested list of items to a sorted flat list having a 'depth' argument to indicate the nesting level. This "flat" list is the native mode of the d3 tree, with this change the JS side can be streamlined quite a bit. Along the way, the item providing on PHP side is streamlined, documented much better and easier to understand now within the data provider of FormEngine. The main tree data backend is still a huge, convoluted, slow and insane mess that will eventually fully substituted with a much straighter and quicker approach later. Changes in this area are kept to a minimum for now. Change-Id: Ib64b7277f671b632be3977218e5465b534618d63 Resolves: #78905 Related: #76108 Releases: master Reviewed-on: https://review.typo3.org/50813 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
The CLI command to detect RTE magic images (images added within the RTE) and (as far as possible) remove unused RTE images as well as copy RTE images referenced multiple times, is migrated to Symfony Console to better structure the CLI command and get rid of dependencies of the old CLI command line tools (non-extbase). The command was previously available under ./typo3/cli_dispatch lowlevel_cleaner rte_images and is now called via ./typo3/sysext/core/bin/typo3 cleanup:rteimages and allows the following options: --dry-run - do not update the images and delete lost files, but just print them --update-refindex - update the reference index, do not ask the user Resolves: #78895 Releases: master Change-Id: I6e30b7a32fe14bc89cebd85167961ec8fa996c54 Reviewed-on: https://review.typo3.org/50650 Tested-by:
-
- Dec 06, 2016
-
-
Oliver Hader authored
Adjust acceptance tests for ISO-8601 date/-time values. Change-Id: Ib35af231f8f8b8150eb0e132543be060eeff67da Resolves: #77702 Releases: master Reviewed-on: https://review.typo3.org/50880 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Claus Due authored
This patch makes the TYPO3 DB cache backend capable of flushing tags using an array of tag names that is then turned into a CSV list and used in an `IN` query. It limits the number of cache flushes from $numRecords to ceil($numRecords/100). NB: the desired behavior is introduced by reviving the flushByTags() method as API for cache frontends and backends. The method was previously present but was dropped in order to keep sync with Flow - which then later added the method exactly because of performance concerns. TYPO3 however did not revive this method and obviously the sync with Flow is no longer a concern. So this patch restores the full API required to flush tags in bulk, adds an implementation for the TYPO3 DB cache backend and adds delegation to the old flushByTag method for backends not covered by this patch. It will be possible to improve other backends as well but this patch focuses exclusively on the DB cache backend for *NIX, which is where the bad performance was observed in the wild. Change-Id: I99d4dd8d0881c3bf9f6240e84b083b72b1831779 Resolves: #78596 Releases: master Reviewed-on: https://review.typo3.org/50537 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Dec 05, 2016
-
-
Mathias Brodala authored
Resolves: #78886 Releases: master, 7.6 Change-Id: I1e5922ed510f0f43a6374f9dde061356290b72d9 Reviewed-on: https://review.typo3.org/50884 Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Tested-by:
-
Mathias Brodala authored
Resolves: #78887 Releases: master, 7.6 Change-Id: Ifb6de078816e851915372d1c5611552fd58f2cce Reviewed-on: https://review.typo3.org/50885 Tested-by:
-
Markus Klein authored
We remove the iconv support in the CharsetConverter as the PHP internal implementation of some functions differ from their mb_string pendants. This gives us a real headache in edge-cases. We already have the mbstring-polyfill as an indirect dependency in the Core (by symfony), so we simply require it our own now and use mb_string all over the places. This renders quite a few methods of CharsetConverter useless and we therefore deprecate those. Resolves: #78670 Releases: master Change-Id: I88479f7939e0afb46f704d4e8f347abd2e10fc6d Reviewed-on: https://review.typo3.org/50607 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Dec 04, 2016
-
-
Michael Oehlhof authored
Resolves: #52286 Releases: master Change-Id: I875a6e7f70007c125408ec6c62c4fba1b2616233 Reviewed-on: https://review.typo3.org/50811 Tested-by:
Manuel Glauser <mail@manuelglauser.ch> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Benni Mack authored
Integrates CKeditor via bower/grunt as system extension "ckeditor". Loads and saves data for backend forms currently. Next steps: * contents.css * defaultconfig.js taken care of optimally * styleSets functionality * language / labels What needs to be done * Make editor configurable (height/width, etc) * Evaluate UI information based on TSconfig * Integrate plugin configuration in JS * Check out best defaults for new editor * Add labels by TYPO3, not from CKeditor * Integrate "Toolbar Configuration" into "Tools=>Configuration" Change-Id: Ia751436bf0ea4479d80e7bc0c7e97c229442dcf2 Reviewed-on: https://review.typo3.org/50788 Reviewed-by:
Johannes Goslar <jogo@kronberger-spiele.de> Tested-by:
Markus Sommer <markussom@posteo.de> Tested-by:
-
Alexander Stehlik authored
When the last line in the text passed to encaps_lineSplit() is empty a possible duplicate empty line is removed. Releases: master Resolves: #72050 Change-Id: I358ae5e1e6e9731d4649add7951c93e62df3bb7e Reviewed-on: https://review.typo3.org/45111 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Benni Mack authored
The TSconfig option to override the page creation wizard via `mod.web_list.newPageWiz.overrideWithExtension` is impossible to use anymore since TYPO3 v8, due to the limitation of the entry-scripts which are only allowed to be in typo3/index.php for the backend. The option `mod.newPageWizard.override` was introduced to register a custom route / module to be linked when adding new pages. Resolves: #78549 Releases: master Change-Id: I1c46c8facad83c0d561028e544f18238abe89f91 Reviewed-on: https://review.typo3.org/50560 Reviewed-by:
-
- Dec 03, 2016
-
-
Christian Kuhn authored
This reverts commit 36f8765a. Change-Id: Ida5c32b33e8953bd1172c9886af16b66e3c2297f Reviewed-on: https://review.typo3.org/50878 Reviewed-by:
-
Alexander Stehlik authored
Allow the the method CategoryRegistry->getCategoryFieldItems() to be used as itemsProcFunc for select fields in the TCA in arbitary contexts by introducing a new categoryFieldsTable configuration in the config section of a column in the TCA. This configuration key can either consist of a single string containing the name of the table or a configuration array to define additional conditions that need to be true so that a configured table is used. The condition matching is based on the displayCond functionality of the TCA. To make use of the existing functionality the code for matching the display conditions is extracted from the form data provider to a new DisplayConditionEvaluator utility class. Resolves: #53045 Releases: master Change-Id: I128cbeb6747a8f83e68cdaaaafbc3ab5901353d4 Reviewed-on: https://review.typo3.org/24968 Tested-by:
-
Oliver Hader authored
In case a content element and the accordant page have been deleted in separate actions and get published together, the workspace process will trigger an error message since the removed content element cannot be published anymore (since it has been processed already with the page). To avoid this behavior deleted records are collected and checked in the workspace swapping/publishing process. Change-Id: If04a198abf81efdc88e75da79da0c01cfaa361ff Resolves: #47384 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/23129 Tested-by:
-
Helmut Hummel authored
Remove the overhead that was added to avoid BC breaks for extension code that subclassed the form view helper. Enough time is now passed so that extensions can adopt their subclasses so that the security related hidden field is added as well. These adaptions will then be compatible with all TYPO3 versions so that this change here is not marked as breaking. Resolves: #78869 Releases: master Change-Id: I910bc26cd57b7629e57332fdab3d57032f0c2478 Reviewed-on: https://review.typo3.org/50863 Tested-by:
-
Markus Sommer authored
Resolves: #78874 Releases: master Change-Id: I56567b000ef156731f38e9945c234822fd926ced Reviewed-on: https://review.typo3.org/50869 Tested-by:
Alexander Rothmund <arothmund@snowflake.ch> Reviewed-by:
-
Tobias Adolph authored
UpdateWizards can now be chosen to be rechecked. If the criteria is met they are displayed as executable - otherwise not. Resolves: #77757 Releases: master Change-Id: I2dcd0e62c9ab3e5fe9d498a02dd9773090b110b9 Reviewed-on: https://review.typo3.org/49724 Reviewed-by:
-
Alexander Opitz authored
A sessionTimeout <= 0 means that a user will be logged out instantly after login. Resolves: #78822 Releases: master, 7.6, 6.2 Change-Id: I1890cb7d52347faab1fa3884eb46c9294d997da3 Reviewed-on: https://review.typo3.org/50797 Reviewed-by:
-
Daniel Windloff authored
In TYPO3 there are some recurring field definitions shared by a lot of records. These fields are mostly defined in the control section of TCA. These fields are used as well by the core as by records introduced by third party extensions. In order to get a consistent behaviour (from editor's perspective) these fields should have a generic position in tabs. Resolves: #78383 Releases: master Change-Id: I365538b8e6013e3911710b113bec7d41314809b2 Reviewed-on: https://review.typo3.org/50364 Reviewed-by:
-
Florian Mast authored
if $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['lang']['availableLanguages'] is set in AdditionalConfiguration.php, the language module will now respect that setting. Resolves: #78876 Releases: master Change-Id: Iec6a0f05db835ae949fbacdc2cdf500a0950d57c Reviewed-on: https://review.typo3.org/50871 Reviewed-by:
-
Markus Sommer authored
Remove HTML in language file Releases: master Resolves: #78877 Change-Id: I154b14530b54791c1b44d6862a4c3c6bb472129d Reviewed-on: https://review.typo3.org/50875 Reviewed-by:
-
Nicole Cordes authored
You can skip the dependency check if you want to enforce the installation of an extension. This patch ensures that dependencies which are available in the system but marked as not compatible are installed anyways. Resolves: #78677 Releases: master, 7.6 Change-Id: I552ff949524e884bfbb5b8e270cfee0dc4691187 Reviewed-on: https://review.typo3.org/50630 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Manuel Selbach authored
According to task #78437 queries should follow the prepared statement principle. Thus method BackendUtiltiy::getRecordsByField() has to be refactored to retrieve a queryBuilder which holds the parameter assigned to e.g. additional where clause, etc. otherwise the parameter and the dynamically generated placeholders in the queryQuilder will be reset. Change-Id: Id66d7b2fcfc5bcdca4d920b645c2285ded0c160a Resolves: #78704 Releases: master Reviewed-on: https://review.typo3.org/50664 Reviewed-by:
-
Michael Oehlhof authored
A "remove" button is added to the list of the installed languages. Resolves: #58637 Releases: master Change-Id: Ibd8911d2c58e449a026f52f4bd8b0b2d04bc2bbf Reviewed-on: https://review.typo3.org/50860 Reviewed-by:
-
Alexander Stehlik authored
The condition that checks for CLI mode in the ext_tables.php of the install tool is fixed. The EnvironmentStatusReport is now active in the Backend and not on CLI. The additional checks added in #78786 are not required any more and are reverted. Change-Id: I4d364fc08c68c7c25d9210c08b813247bee7d47f Resolves: #78854 Relates: #78786 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50825 Tested-by:
-
Sascha Egerer authored
Selecting a file an the RTE linkhandler works but reopening the linkhandler ends with a fatal error as a file object is passed instead of string. Change-Id: I56972ef8d25e9add0c51e1b72fd7034c1140bc01 Resolves: #78782 Releases: master Reviewed-on: https://review.typo3.org/50767 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Alexander Stehlik authored
The ext-lang-am.js now has unique linux linebreaks. Before it had a mixture of windows and linux linebreaks. Change-Id: I4f74677c66611e2ca2143cf249934cb69b5e5ea5 Resolves: #78871 Relates: #77808 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50867 Reviewed-by:
-
Johannes Goslar authored
The temppath for gdlib and combineImages is different then all other image tests The assets/images path is set in imageMagickConvert for other image tests Releases: master Resolves: #77851 Change-Id: I4fec0422595045cfb5ca67a48f8e6dae79fc08d7 Reviewed-on: https://review.typo3.org/49864 Reviewed-by:
Gleb Levitin <gleb.levitin@dkd.de> Reviewed-by:
-
Jan Helke authored
Moves most of the HTML from the PHP to an own Template. In fact in line 408 and in the function linkItemText are some remaining html tags, but removing those would require some major refactoring. Resolves: #73016 Releases: master Change-Id: Ie9859758885be0516ff8aeb58c473c5634848c81 Reviewed-on: https://review.typo3.org/46367 Tested-by:
Florian Mast <flo.mast@web.de> Reviewed-by:
-
Claus Due authored
This patch adds a check when processing the update reference index stack, in order to avoid calling the update function more than once with the same input arguments (which are $table and $uid). Saves around 100 SQL queries when doing a standard copy of 25 (nested) pages with 25 content elements. Change-Id: If162218d4eabb749a92270e18c7c39108fd15f34 Resolves: #78761 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50724 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
Anja Leichsenring authored
Respect the max length of 64 chars in sql if removing (renaming) an SQL table. Add unit test. Resolves: #78636 Releases: master Change-Id: I94f38c40f6539d5e53e2ac9bad5ed1c059836333 Reviewed-on: https://review.typo3.org/50865 Tested-by:
-
- Dec 02, 2016
-
-
Andreas Wolf authored
This changes the internal date processing for FormEngine and DataHandler to use ISO-8601 dates including a proper timezone. Dates are converted to ISO-8601 as early as possible and converted back to UNIX timestamps as late as possible. As before, the database values are always values in the server’s timezone, interpreted as UTC. Also, the client side inputs are interpreted as UTC. The main advantage is that once and for all we get rid of the timezone issues that may potentially arise if the server and client use different timezones. Additionally, the values are human readable (which is of course not so much of an issue for hidden fields) and we can directly use Moment.js for all heavy lifting. Another big advantage is that we can make the date formats configurable and decouple displayed dates and internally stored dates (by putting the Moment objects to the input fields). Change-Id: I3461915c2beaa96cd29c52c60e65a2e5005065b7 Resolves: #77702 Releases: master Reviewed-on: https://review.typo3.org/47124 Reviewed-by:
-
Claus Due authored
This patch fixes a problem where setting showAccessRestrictedPages setting in HMENU etc. did not result in the correct behavior according to documentation at https://docs.typo3.org/typo3cms/TyposcriptReference/MenuObjects/CommonProperties/Index.html. The patch changes the behavior caused by using `NONE` as keyword in the setting. Before: using the option renders `<a>Page title</a>` when page is inaccessible. After: using the option renders `<a href="index.php?id=123">Page title</a>` when page is not accessible. Change-Id: I4364f7ec9f44e1e0b70654830efc236f20e6bf30 Resolves: #17904 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/50696 Reviewed-by:
-
Andreas Allacher authored
IRRE records have to point to their specific localized parent record. This works in general for tables containing records of the default language as well as localizations. For the "pages" table this look-up has to be extended to query from "pages_language_overlay". Change-Id: I84b6ee9304f85222430a5bdf62bd2271aae68fd5 Resolves: #76174 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/48495 Tested-by:
-
Daniel Windloff authored
- Change "Show" button to btn-default - Use infobox for missing files - Streamline button order and groups - preview / edit - history - opens list module Resolves: #78864 Releases: master Change-Id: I1e74b5e5d75a0678ab385b40f53802a30028980a Reviewed-on: https://review.typo3.org/50851 Tested-by: -
Markus Hoelzle authored
Respect the max length of 64 chars in sql if removing (renaming) an SQL table. Add unit test. Resolves: #78636 Releases: master Change-Id: I5f5d4b239f467a205edfdceeac97da5625631a83 Reviewed-on: https://review.typo3.org/50583 Tested-by:
Alexander Rothmund <alexander@rothmund.ch> Tested-by:
-
Claus Due authored
This patch reduces the number of SQL queries and PHP calls which get performed when rendering menus. The patch has two parts: * Runtime cache is used to remember a generated link and is given a cache identifier which includes a hash of all parameters which may affect the link. * Runtime cache is used to remember the decision if a page is a submenu. The item rendering function is called every time the same page is rendered in any menu in the same request, and the decision function to check if page is a sub-menu is called at least three times with the same UID when generating a menu. Both of these implements together reduce the necessary re-calling of methods which generate the same output given the same arguments. Change-Id: Idd6225081e8fb3f8160270af3d865b48208b756e Releases: master, 7.6 Resolves: #78693 Reviewed-on: https://review.typo3.org/50652 Tested-by:
Daniel Alder <dalder@snowflake.ch> Tested-by:
-
Nicole Cordes authored
If a checkbox or a multiple selectbox is rendered, a hidden field is automatically inserted before to send an empty default value. Field information are stored within an own viewHelperVariableContainer variable. After a form is rendered, this information has to be reset to be able to render another form with same field names. This patch adds the missing reset of the hidden field information. Resolves: #78551 Releases: master, 7.6, 6.2 Change-Id: I3cde5618d07cae39b7841875504471cb2341dc17 Reviewed-on: https://review.typo3.org/50486 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Tested-by:
-
Michael Oehlhof authored
Resolves: #76408 Releases: master, 7.6 Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563 Reviewed-on: https://review.typo3.org/50786 Reviewed-by:
Kevin Ditscheid <kevinditscheid@gmail.com> Reviewed-by:
-
