- May 13, 2024
-
-
Stefan Bürk authored
Since #102793 the PageRepository respects `includeScheduledRecords` from the context `VisibilityAspect` setting in the `PageRepository` and added a runtime cache handling in the `init()` call. However, the cache identifier does not respect the same visibilty options for the cache identifier like it is used for preparing the property `where_hid_del` - and thus leads to invalid and unexpected record retrievement, depending on context switches in a request. This change extends the cache identifier to respect the scheduled record setting and removes the invalid page table except comment. Resolves: #103831 Related: #102793 Releases: main, 12.4 Change-Id: I2e7f038a04d957751bba1181c3d5324c6e0674b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84236 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Georg Ringer authored
It might be that pages are still available which are outdated regarding its language. This can be when a site language has been removed from the configuration. Therefore those pages should be skipped when checking the integrity. Resolves: #103801 Releases: main, 12.4 Change-Id: Ic5ca071ff8d2b5956365a432fa0f99da5772595f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84203 Tested-by:
-
Benjamin Franzke authored
When a content element (CE) gets edited or the visibility is toggled, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #103381 it was not possible anymore to click the "+ Content" button above such CE. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, `overflow: hidden` was removed to make the `box-shadow` of the CE visible, finally causing this bug. To solve this issue the pseudo element add it #97036 is replaced by the CSS option scroll-padding-top. It incorperates the maximum docheader size plus a slight margin that is slightly lower than the grid margin – but not equal to – to move shadows of adjacent elements out of sight. Resolves: #103672 Related: #103381 Related: #97036 Releases: main, 12.4 Change-Id: I8d5c9eadd45e5507e39b1fb728de65d31c1d6689 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84234 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to 1.11.0 and its related friends to their latest respective version. Executed command composer require --dev \ phpstan/phpdoc-parser:^1.29.0 \ phpstan/phpstan:^1.11.0 \ phpstan/phpstan-phpunit:^1.4.0 \ -W Resolves: #103823 Releases: main, 13.1, 12.4 Change-Id: Idc057895d503089c03a8cb5358be4ea7e3575e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84223 Reviewed-by: -
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2][3] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below - at least for the phpXY images. * core-testing-php82: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-php83: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-apache24: Minor version release thus raising version required. * core-testing-nodejs22: Minor version release thus raising version required. * core-testing-nodejs22-chrome: Minor version release thus raising version required. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/df1e05ed52e724e0934e552c214395930022413b [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/f754d7fbd2c3cbed98296c8a772869362487d073 [3] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/4f93c5e93eb4e00fc936c13280918e60e62be567 Resolves: #103821 Releases: main, 12.4 Change-Id: I085cc0ce80682dfd009e5648f236974a380b8176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84202 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Patrick Schriner authored
To circumvent race conditions where the cache is removed between `has()` and `require()` invocations, the return value of the cache result needs to be verified, as `false` is returned if the cache entry is not available. Resolves: #103720 Releases: main, 12.4 Change-Id: Iefede04108d3adf9bd6c77cb0600cdc994f6d0fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84216 Tested-by:
-
- May 11, 2024
-
-
Christian Fries authored
When addressing flexform fields in TSconfig, the dots of the field names have to be escaped with a backslash. Releases: main, 12.4, 11.5 Resolves: #103786 Change-Id: I6af70fcb80e9e155ba8259ec216c5199600c5a78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84199 Reviewed-by:
-
Garvin Hicking authored
An error was made in [1] where a wrong link anchor name (parseFunc) was used after refactoring the link format, which leads to a warning in the documentation rendering process. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84193 Resolves: #103819 Releases: main, 12.4 Change-Id: I9b0c8f1852e32174b2ce5b59dc45607fd403a06c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84212 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- May 10, 2024
-
-
Christoph Lehmann authored
In advanced query the operator "is in list" makes value be an array. Then switch the field to a non-array field type, and you get the following TypeError: ``` htmlspecialchars(): Argument #1 ($string) must be of type string, array given. ``` This resets the array value to an empty string. Resolves: #103487 Releases: main, 12.4, 11.5 Change-Id: Ifc6ef7e90d49a05ecb4b6d4869eea13c151b1b2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84198 Tested-by:
-
Willi Wehmeier authored
The add widget modal has a cancel button on the bottom of the modal now to match the other modal windows in the backend. Resolves: #103787 Releases: main, 12.4 Change-Id: I0c2c970b1148dfddadff1c3722d04dfcc939a69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84197 Tested-by:
-
Stefan Bürk authored
Hook implementation are configured with the well known $GLOBAL['TYPO3_CONF_VARS']['SC_OPTIONS'][...][] = ''; syntax since ages. Directly defining an anonymous callback function is undocumented and rarely used, but technical valid and supported by the `GeneralUtility::callUserFunction()` method. Due to the refactoring of the `ext:lowlevel` Configuration module for the revamped TypoScript parser with TYPO3 v12 the code in the `ConfigurationController` has been modified to do an array cast, which triggers the execution of the function - which can lead to some deep recursions and thus exceeding server resource limits. Direct callback function should not be executed within the backend Configuration module, which literally is a invalid execution of them. Following code in a extension `ext_localconf.php` file will lead to the resource limit issue: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['tslib/index_ts.php']['preprocessRequest'][] = function($parameters, $parent) {}; This change modifies the `ConfigurationController->renderTree()` to check if a value is a callable and display the information, and in case of an anonymous function (`Closure::__invoke`) add additional static information: Closure::__invoke (anonymous callback function: function() {}) Note: That does not make it obvious where the function is defined, but it avoids calling these callback methods. Resolves: #103813 Related: #99899 Releases: main, 12.4 Change-Id: I839d1668cf306100cf32af09ec9e24ad0120c43b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84196 Tested-by: -
Mathias Brodala authored
Resolves: #103812 Releases: main, 12.4 Change-Id: I467149ad6e93900cf917d3455b24dc01c97330f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84195 Reviewed-by:
-
Markus Klein authored
"Resources/Public" may occur also within an asset path. Path detection code must therefore only check for its first occurrence. Resolves: #101701 Releases: main, 12.4 Change-Id: I8e0b62f5164593e472113ea8d294593e93abfe6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84194 Tested-by:
-
- May 09, 2024
-
-
Garvin Hicking authored
The ViewHelper documentation for f:translate mentioned sprintf() from PHP, but did not link to it. This patch adds a link and also optimizes markup, plus a few more sprintf() examples with ordered parameters and number formatting. See forge issue for screenshots how this looks before and after the change. Resolves: #103808 Releases: main, 12.4 Change-Id: I237d4b668291ad68bf083e35c0bdf6510158b38b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84193 Tested-by:
-
- May 08, 2024
-
-
Albrecht Köhnlein authored
Resolves: #103807 Releases: main, 12.4 Change-Id: Ifc551dcd66bc88da8c57e7213ee80d960f365509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84192 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- May 06, 2024
-
-
Willi Wehmeier authored
The folder containing the charset conversion table files should have the unicode license.txt file. The license file is from https://unicode.org/license.txt Resolves: #103796 Releases: main, 12.4, 11.5 Change-Id: I2577fea6e1b5326cd45da622ec6fbbc563bc140a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84119 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Torben Hansen authored
One part of the classname in a `throws` doc comment in `MvcPropertyMappingConfigurationService` is wrong. Instead of `EXTBASE` it should be `Extbase`. Resolves: #103792 Releases: main, 12.4 Change-Id: I6be6e53640d82d39ff9f2ce99015877e693b8428 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84118 Tested-by:
-
- May 05, 2024
-
-
Andreas Kienast authored
Executed commands: composer require --dev sokil/php-isocodes-db-i18n:^4.0.22 Build/Scripts/updateIsoDatabase.php Resolves: #103791 Releases: main, 12.4 Change-Id: I624ce17a6abaa2cb5c0479744db43bdf17cd069a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84145 Reviewed-by:
-
- May 03, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/element/table-wizard-element` is tightly coupled to FormEngine's `TextTableElement`, therefore said module is moved to the FormEngine namespace. Additionally, the element gets renamed to `typo3-formengine-table-wizard`. Resolves: #103725 Releases: main, 12.4 Change-Id: I1c020a4ec6045007ab4c1f42289fe0a9c842f794 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84117 Reviewed-by:
-
Oliver Hader authored
Commands: composer req 'enshrined/svg-sanitize:^0.18.0' composer req 'enshrined/svg-sanitize:^0.18.0' \ -d typo3/sysext/core --no-update Resolves: #103722 Releases: main, 12.4, 11.5 Change-Id: I9a20a46b27b3abbfd18f7ca6027e4def9ce5b59b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84137 Tested-by:
-
Torben Hansen authored
With this change, the following changes have been applied to the toolbar of the CKEditor "full" configuration preset: * Remove superfluous `clipboard` toolbar item, since CKEditor 5 does not provide a UI for the clipboard plugin. * Rename wrong `find` toolbar item to `findAndReplace`. * Added `TableProperties` and `TableCellProperties` toolbar items. * Move the `findAndReplace` toolbar item before the `link` toolbar item, because we also have this order in the `default` preset. * Move the `selectAll` toolbar item to a dedicated group Resolves: #103745 Releases: main, 12.4 Change-Id: I021b8c2f990c8e302bf169c3e368bf04928dd200 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84139 Tested-by:
-
Georg Ringer authored
Allow the valid return type false which is returned by the function exec on failure. Resolves: #103778 Releases: main, 12.4 Change-Id: I8f0391efb6f890ebc0095ddb8a1f93ee9c36e18c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84116 Tested-by:
-
Andreas Nedbal authored
Newer rollup major versions feature optimizations in build output. The rollup source files are now natively parsed as ESM modules by NodeJS. Earlier rollup versions implicitly transpiled ESM to CJS and allowed a mixture of ESM and CJS imports (both `import` statements and `require()` calls) in one module. With the switch to ESM-only modules we now make use of `createRequire` utility method when node-require resolution is needed for CJS path lookups. Since our main project (Build/) is still in CJS mode by default (for grunt), we apply a sub-project module type overwrite for the Build/rollup/ folder via Build/rollup/package.json to ensure rollup configuration runs in native ESM mode. See https://nodejs.org/docs/latest-v18.x/api/packages.html > Node.js will treat the following as ES modules when passed to node as > the initial input, or when referenced by import statements or import() > expressions: > […] > * Files with a .js extension when the nearest parent package.json file > contains a top-level "type" field with a value of "module". Executed commands: npm install --save-dev \ rollup@^4.17.2 \ @rollup/plugin-commonjs@^25.0.7 \ @rollup/plugin-node-resolve@^15.2.3 \ @rollup/plugin-replace@^5.0.5 npm run build -- exec:rollup Resolves: #103775 Releases: main, 12.4 Change-Id: I6793bd9233b2907ce5ed06d68c7008b349237360 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84136 Tested-by:
-
Benjamin Franzke authored
The node version used for building TYPO3 assets is raised to 22.0. See https://nodejs.org/en/blog/announcements/v22-release-announce for further details. Resolves: #103780 Releases: main, 12.4 Change-Id: Ibc5b8c88ca5baedb7ae500adb5ef26a33617df4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84115 Tested-by:
-
- May 02, 2024
-
-
Stephan Bauer authored
An error was previously shown and is now removed if no backend type is selected. Releases: main, 12.4, 11.5 Resolves: #103766 Change-Id: Ia83552de40abffb880244e8b0eb0f4c28f0e6637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84112 Tested-by:
-
Frank Naegler authored
This patch addresses two key accessibility issues in the recycler module: it adds a caption element to the table for better context and provides labels for dropdown icons used in multi-selection, ensuring screen reader compatibility. Resolves: #103764 Releases: main, 12.4 Change-Id: Ia8b839cbc438396c8438969087d225c37a479bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84107 Tested-by:
-
Willi Wehmeier authored
The clear-input button now has a proper title and additionally an aria-label to guide visually impaired users. The button isn't read out by screenreaders when navigating the site linearly (due to tabindex="-1") but when hold-pressing the button with the mouse pointer, a screenreader will search for a human readable label. We therefore add an aria-label attribute. The title attribute is added for sighted users but will be ignored by screenreaders since it's value equals the value of the aria-label attribute. Resolves: #103417 Releases: main, 12.4 Change-Id: I4cbbe5200476a7d84ef1d675911ddd51f5899e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84106 Tested-by:
-
- May 01, 2024
-
-
Oliver Hader authored
The new factory method `HashValue::hash('test')` creates the hash from the raw payload `'test'`. This is a simpler shortcut for using `HashValue::create(hash('sha256', 'test', true))`. Resolves: #103772 Releases: main, 12.4 Change-Id: Id201e166eeabc856b8d8dc498cc73cde8d5eb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84114 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 30, 2024
-
-
Frank Naegler authored
This patch adjusts the flash message and notifications elements by removing the h4 tag to prevent incorrect header flow throughout the content structure, allowing for better flexibility based on different use cases. Resolves: #103762 Releases: main, 12.4 Change-Id: Ide330150145d5c4965410fbf61973ef682bb96b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84093 Tested-by:
-
Frank Naegler authored
This patch adjusts the infobox/callout element by removing the h4 tag to prevent incorrect ordering in the content structure, allowing for better flexibility based on different use cases. Resolves: #103761 Releases: main, 12.4 Change-Id: I2556ea0df0e55ffcdf752c9c0574b843ffea44ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84094 Tested-by:
-
Frank Naegler authored
This patch enhances the accessibility of the link validator module by ensuring proper relationships between table headers and content cells. Resolves: #103763 Releases: main, 12.4 Change-Id: Icef43369761f88705b491f3661252cc9a4b7ac0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84092 Reviewed-by:
-
- Apr 29, 2024
-
-
Jasmina Ließmann authored
The title of the linked page was missing a hover style, which is now ensured with this patch. An appropriate link title is also added. Resolves: #103715 Releases: main, 12.4 Change-Id: I4ec60ef43fd7ced6cdc5ede88445931a37e12c3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84058 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Apr 28, 2024
-
-
Torben Hansen authored
When an editor uses the suggest wizard, undefined array key warnings can occur, when certain array keys have not been defined. This change adds fallbacks for undefined array keys using the null coalescing operator. Additionally, the function `currentBackendUserMayAccessTable` is now covered with unit tests. Resolves: #103721 Releases: main, 12.4 Change-Id: I2b1a8af0883f7d34dde38f6f838df080f34ea87c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84057 Tested-by:
-
Andreas Kienast authored
With the update of Bootstrap to v5.3, the implementation of progress bars has changed for accessibility reasons [1]. This commit updates all usages of progress bars to the new markup. [1] https://getbootstrap.com/docs/5.3/migration/#progress-bars Resolves: #103718 Releases: main, 12.4 Change-Id: I208e3561b4943e382caa09e23e75d350bd702a6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84075 Tested-by:
-
- Apr 27, 2024
-
-
Jasmina Ließmann authored
With #103737 a new locallang key for the configuration heading was introduced, but it contains a typo. The patch now fixes this. Resolves: #103743 Related: #103737 Releases: main, 12.4 Change-Id: I5bcf5d2b792e1312daf813ec5d3347068d5ecbf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84056 Tested-by:
-
Jasmina Ließmann authored
In the "Localization overview" view, an incorrect title was displayed when hovering over a page icon. This was caused by both an incorrect and duplicate title attribute. This patch fixes this behavior. Resolves: #103739 Related: #102472 Releases: main, 12.4 Change-Id: Ibb2ce64d0313c24c6d1e3f1e6b5fc6f55b172622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84055 Tested-by:
-
Jasmina Ließmann authored
If there are no records or the filter/search does not return a result, an information is now displayed in the "Log" backend module. Resolves: #103738 Releases: main, 12.4 Change-Id: I388e1e4db0885a143d3a626cd35199728b5c395b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84054 Tested-by:
-
Jasmina Ließmann authored
Resolves: #103736 Releases: main, 12.4 Change-Id: Ia93d67fc49fd9b7a123494928a4360515fc76cb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84053 Reviewed-by:
-
Jasmina Ließmann authored
Resolves: #103737 Releases: main, 12.4 Change-Id: I83278a84037a4fe46b85a8570b7ff345eabeb0a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84052 Tested-by:
-
- Apr 26, 2024
-
-
Benjamin Kott authored
Both extensions core and linkvalidator do not ship css files. PostCSS cannot find any files to process here. Resolves: #103731 Releases: main, 12.4 Change-Id: Ibdfcecb4dd813b04e89bab5d2fcfe3a55b0bf4b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84035 Tested-by:
-
