- Jun 01, 2018
-
-
Tymoteusz Motylewski authored
Replaces hardcoded RTE configuration in BrowseLinksController with one resolved by Formengine when rendering a field. This takes into account e.g. column overrides. The RTE configuration preset name is now kept by Formengine in ['processedTca']['columns'][$fieldName]['config']['richtextConfigurationName'] Then it's being passed as parameter P[richtextConfigurationName] from RTE field to the BrowseinksController Resolves: #84943 Releases: master, 8.7 Change-Id: Id4f1c350f6eb6dfad4d49ec759a23939bbc45eda Reviewed-on: https://review.typo3.org/56881 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Susanne Moog authored
For SQLite inSet was implemented with a "like" substitution which had various bugs. That implementation has now been substituted with an "instr" implementation. Resolves: #85131 Releases: master Change-Id: Id4e8f7132800c991e49d4033d2b01f474b6aae3b Reviewed-on: https://review.typo3.org/57107 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 31, 2018
-
-
Nicole Cordes authored
Fetching a parent folder may throws an error if the user hasn't access to the parent. This exception needs to be caught and the search for an existing recycler folder needs to be stopped immediately. Furthermore the patch removes the comparison with the root level folder but checks the parent folder doesn't equal the folder itself. Another loop is fixed by calling moveFile on the correct ResourceStorge and not the current one. Resolves: #85079 Related: #81836 Releases: master, 8.7 Change-Id: I51f5e20d7fa7da9b350ac0ca60cab05866a4d337 Reviewed-on: https://review.typo3.org/57052 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Susanne Moog authored
Concerning the usage of Statement::rowCount() the Doctrine DBAL documentation states the following: Returns the number of rows affected by the last DELETE, INSERT, or UPDATE statement executed by the corresponding object. For default configurations using MySQL as platform, rowCount() is returning the expected value for SELECT statements as well. However, on other DBMS this value will be zero as mentioned in the documentation - for instance SQLite is a candidate for that. For retrieving the row count for given criteria, the count() expression has to be used explicitly. Resolves: #78129 Releases: master Change-Id: Id28d72a1a21e8615ec45b63d4aecc100d03a39a3 Reviewed-on: https://review.typo3.org/50083 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Tymoteusz Motylewski authored
The concept for custom UrlHandlers, introduced in TYPO3 v7 for extracting JumpURL into a TER extension has been deprecated in favor of PSR-15. These could be registered via $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['urlProcessing']['urlHandlers'] The methods related to that functionality have been deprecated. - $TSFE->initializeRedirectUrlHandlers() - $TSFE->redirectToExternalUrl() However, the core-internal calls have been marked with a property to ensure that no deprecation warning is triggered, but the functionality can be kept. Resolves: #85124 Releases: master Change-Id: Ie49d7200618d2b8ffdd5394ea9c649c123719b07 Reviewed-on: https://review.typo3.org/57096 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Jan Helke authored
Releases: master Resolves: #84720 Change-Id: If13dfe85fcb41ce3a361fbb184d95c5ddffaf958 Reviewed-on: https://review.typo3.org/56654 Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
CharsetConverter is still instantiated in some places and not needed at all times. The following places have CharsetConverter completely removed (as internal property): - PageRenderer - SearchController - Indexer The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion() has been deprecated, as drivers should instantiate the CharsetConversion themself. Indexed Search's Lexer has a public property "csObj" which has been switched to protected, where a deprecation message will be thrown. Resolves: #85125 Releases: master Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673 Reviewed-on: https://review.typo3.org/57097 Reviewed-by:
-
- May 30, 2018
-
-
Simon Gilli authored
Allow the usage of a value for --action argument of the CLI command cleanup:versions as mentioned in the documentation and the implementation. Resolves: #85085 Related: #79109 Related: #82653 Releases: master, 8.7 Change-Id: I6c07303728bcb527b44a6c5bf811870f25398a21 Reviewed-on: https://review.typo3.org/57055 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Tymoteusz Motylewski authored
It was decided to use .typoscript and .tsconfig The patch renames the files and adds little BC layer which allows you to include TypoScript files using old (.txt) file extension. Resolves: #81686 Releases: master Change-Id: Id6784e4f573e2e0b060f37d241c07216ac5678e1 Reviewed-on: https://review.typo3.org/57083 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
PageRepository has two public properties regarding fetching records for versioned records: - versioningPreview (bool) - versioningWorkspaceId (int) In order to allow previews of versions, a workspace ID has to be set - otherwise it fetches live records. Basically things like: $versioningPreview=false, $versioningWorkspaceId=3 will make things more confusing. Instead, versioningPreview is not in use anymore, and PageRepository solely relies on the parameter of the workspaceId set. Resolves: #85078 Releases: master Change-Id: I70f028854ebc1a83d6d5af18de507284ae89b2ac Reviewed-on: https://review.typo3.org/57047 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Harry Glatz authored
Releases: master, 8.7 Resolves: #85117 Related: #32030 Change-Id: I6af62c8337865e8a76c2dd8593f5afa38e0c2d26 Reviewed-on: https://review.typo3.org/57089 Reviewed-by:
-
Tymoteusz Motylewski authored
Currently selected page is remembered in the fsMod js object. The JS code responsible for handling click on the node text and node background is refactored. Now both uses node.checked property. Resolves: #85100 Resolves: #85106 Releases: master Change-Id: I08768e82a62e942c247d968df707bf64426e1dab Reviewed-on: https://review.typo3.org/57076 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Benni Mack authored
The following constants related to the Services in TYPO3 have been moved into AbstractService as class constants, effectively moving them in the right context. - T3_ERR_SV_GENERAL - T3_ERR_SV_NOT_AVAIL - T3_ERR_SV_WRONG_SUBTYPE - T3_ERR_SV_NO_INPUT - T3_ERR_SV_FILE_NOT_FOUND - T3_ERR_SV_FILE_READ - T3_ERR_SV_FILE_WRITE - T3_ERR_SV_PROG_NOT_FOUND - T3_ERR_SV_PROG_FAILED The Extension scanner will detect usages of these constants. The constants will be removed in TYPO3 v10. Resolves: #85123 Releases: master Change-Id: I9df12e51deda77903aff83769d4f2a532b2676fb Reviewed-on: https://review.typo3.org/57095 Reviewed-by:
-
Benni Mack authored
Due to native support and a polyfill for mb_string(), lot of functionality of CharsetConverter was simplified throughout TYPO3 in the last release to ensure faster charset conversion. Many methods and properties within CharsetConverter can be deprecated now: - CharsetConverter->synonyms - CharsetConverter->parse_charset() - Fourth parameter of CharsetConverter->conv() - CharsetConverter->convArray() - CharsetConverter->utf8_to_entities() - CharsetConverter->entities_to_utf8() - CharsetConverter->crop() - CharsetConverter->convCaseFirst() - CharsetConverter->utf8_char2byte_pos() Additionally the following public properties have been changed to have a "protected" visibility, as this only reflects internal state: - CharsetConverter->noCharByteVal - CharsetConverter->parsedCharsets - CharsetConverter->toASCII - CharsetConverter->twoByteSets - CharsetConverter->eucBasedSets Resolves: #85122 Releases: master Change-Id: Ic67dd1cffa36cd625c844ae82fdca8447a317efe Reviewed-on: https://review.typo3.org/57094 Tested-by:
-
Simon Gilli authored
Add the Site Configuration to the ConfigurationController to simplify debugging and enable its inspection at the backend. Resolves: #84709 Releases: master Change-Id: Ib0720f372a2d27873fda9931c8753c7ed6a98750 Reviewed-on: https://review.typo3.org/56644 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benni Mack authored
The JavaScriptEncoder class was superseded with GeneralUtility::quoteJSvalue() in TYPO3 6.2 and is not used anymore. It is marked as deprecated. Resolves: #85120 Releases: master Change-Id: I13cb97e3ff6bb23d937a5193d392f92eb759ba9d Reviewed-on: https://review.typo3.org/57093 Reviewed-by:
-
Benni Mack authored
Special Case Folding within CharsetConverter is not used anymore, and can be removed. The public property $caseFolding used as runtime cache is removed, as it was never possible to fill it either to have it accessed from the outside. The SpecialCasing.txt file has no meaning anymore and can be removed. Resolves: #85118 Releases: master Change-Id: Ib770fe99a97ac06c4f9c485e960c681ab21c9113 Reviewed-on: https://review.typo3.org/57090 Tested-by:
-
Benni Mack authored
Various CharsetConverter methods are there for initialization conversion, which are marked as @private and are only used within the class. The patch switches the method signatures from public to protected. The following methods are affected: - initCharset() - initUnicodeData() - initCaseFolding() - initToASCII() Resolves: #85116 Releases: master Change-Id: I153123068cbfbf0baee729aab7dc0946913d5d7c Reviewed-on: https://review.typo3.org/57088 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Georg Ringer authored
Use methods of BackendUtility to have a consistent look of date and time fields in the backend. Resolves: #85002 Releases: master, 8.7 Change-Id: I6f0b6aca1530524ff3f83922a1b4b2dd72b1ea84 Reviewed-on: https://review.typo3.org/57041 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Mathias Brodala authored
This expands the logic for forced absolute URLs to all cases and ensures HTTPS is kept for cross-domain links if possible. Resolves: #85111 Releases: master, 8.7 Change-Id: I7840a47d0ae9a3f9571ae8ddcf9cdc35b59cc4fa Reviewed-on: https://review.typo3.org/57082 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Benni Mack authored
The new Environment API allows to set the project path outside of the web root, also moving typo3temp/var/ to env:PROJECT_PATH + var/. However, the main method GeneralUtility::writeFileToTypo3tempDir() which is used for adding online media, charset conversion etc. is not adapted to allow files outside of typo3temp/ which needs adaptions wo also check for PROJECT_PATH + var/ in addition. Some generic tests were added to ensure the existing functionality still works. Resolves: #85077 Releases: master Change-Id: I664e152ecba39fbb86605af12e83f3ef10f878f9 Reviewed-on: https://review.typo3.org/57046 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
Petra Arentzen <typo3@pegu.de> Reviewed-by:
-
Susanne Moog authored
The admin panel can be disabled via the frontend UI by click. When the admin panel is disabled the initialize methods should not be called. This has been fixed. Resolves: #85104 Releases: master Change-Id: I966b5887b03b4fb8d3f63e9556b00a37384f9dfc Reviewed-on: https://review.typo3.org/57077 Tested-by:
-
Jan Helke authored
Releases: master Resolves: #85091 Change-Id: I501b401a7553e969324ff79821780944ce240e5f Reviewed-on: https://review.typo3.org/57062 Tested-by:
-
Jan Helke authored
Releases: master Resolves: #85089 Change-Id: Idb85307b51e609f147ccfeacce710256778f96a2 Reviewed-on: https://review.typo3.org/57060 Tested-by:
-
Mathias Brodala authored
Releases: master Resolves: #85039 Change-Id: I2e995aef69edd099d49b5915ab61c38e7d0af49e Reviewed-on: https://review.typo3.org/56999 Reviewed-by:
-
- May 29, 2018
-
-
Benni Mack authored
The third argument about catching errors can be achieved by building a try/catch block around the method. Resolves: #85105 Releases: master Change-Id: I42f2b66e1b6267376e9352e76b9e58e9bde028f9 Reviewed-on: https://review.typo3.org/57075 Reviewed-by:
-
Jan Helke authored
Releases: master Resolves: #85093 Change-Id: Ib5c8fbf7d4a69d05b0fb370440fba0bc755e5854 Reviewed-on: https://review.typo3.org/57064 Reviewed-by:
-
Benni Mack authored
The utility class was thinned out in the last TYPO3 versions and now is only used in EXT:install. The functionality can be moved into EXT:install, and PhpOptionsUtility can be deprecated, marked as deprecated and awaiting removal in TYPO3 v10.0. Resolves: #85102 Releases: master Change-Id: Ie45720ad70cd2bdd2949553c94fcec15806cb458 Reviewed-on: https://review.typo3.org/57071 Reviewed-by:
-
Tymoteusz Motylewski authored
Resolves: #85107 Releases: master Change-Id: I218ae9ae3a2eb6bcd23eef2073bf8b11139d58bc Reviewed-on: https://review.typo3.org/57078 Reviewed-by:
-
- May 28, 2018
-
-
Tymoteusz Motylewski authored
The statement does nothing so it is removed. Resolves: #85103 Releases: master Change-Id: Ib9b20392d837262bd3d98069d2998c8c6a372dfc Reviewed-on: https://review.typo3.org/57073 Reviewed-by:
-
Benni Mack authored
This patch handles several issues related to the new site error handling introduced in TYPO3 v9.2.0: 1. It adds unit tests 2. It adds a missing exception when an error handler is configured which does not implement the PageErrorHandlerInterface 3. It fixes one minor issue in PageContentErrorHandler where a wrong "InvalidArgumentException" was thrown 4. All PageErrorHandler logic was moved from EXT:frontend to EXT:core, as this would be a penalty across packages - the "Site" entity depends on them, so they must go to the same package (core). Releases: master Resolves: #85101 Change-Id: Ibdc05024abd7c719dd8d5dcb3388bf1679b69990 Reviewed-on: https://review.typo3.org/57057 Tested-by:
-
Benni Mack authored
The method arrayToLogString() within GeneralUtility is deprecated in favor of using own implementations, based on PSR-3. Still, the one place where this method was in use - ListSysLogCommand - moved the logic into its own protected method. Resolves: #85086 Releases: master Change-Id: If6815a5ea9e459258408458b97b7ee4ad901bd40 Reviewed-on: https://review.typo3.org/57056 Tested-by:
-
Mathias Brodala authored
Change-Id: I29159e835d362e3f0e06c2145e84c1119df152cf Resolves: #85083 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/57054 Tested-by:
-
- May 26, 2018
-
-
Benni Mack authored
EXT:t3editor has some AJAX controllers which can be simplified: - Unused properties are removed - Unrelated "LANG" calls can be streamlined, resulting in a lowered memory footprint - Rootline resolving is done directly via the existing class - Remove obsolete usage of PhpFrontend in phpDoc in T3editor base class Resolves: #85081 Releases: master Change-Id: Ia5669d161c59881e509d9b7e881cc555ef2b44c1 Reviewed-on: https://review.typo3.org/57051 Reviewed-by:
-
- May 25, 2018
-
-
Nicole Cordes authored
Ensure the test is executed as expected. Resolves: #85082 Releases: master, 8.7 Change-Id: Ia0dfbdc12eeefbb28996f69dade4298b1464afa6 Reviewed-on: https://review.typo3.org/57050 Tested-by:
-
- May 24, 2018
-
-
Björn Jacob authored
Resolves: #85048 Releases: master Change-Id: I7c0048c52c0fe4b8e76fbbef474e3093e7787c37 Reviewed-on: https://review.typo3.org/57010 Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benjamin Burse authored
- remove linebreak in root node -> instead use text-overflow: ellipsis - fix indentation of tree elements -> move triangles indicating subtrees to the left - changed tooltip message to only show "id = <element-id>" Resolves: #85042 Releases: master Change-Id: I2621974c2688ac5e03a7e39e8c4f6ad94e15e9a4 Reviewed-on: https://review.typo3.org/57007 Tested-by:
-
- May 23, 2018
-
-
Wouter Wolters authored
Resolves: #85065 Releases: master Change-Id: I0c9b151874acf0d4f725cff029ce5392ae054779 Reviewed-on: https://review.typo3.org/57040 Tested-by:
-
- May 22, 2018
-
-
Alexander Schnitzler authored
Non-namespaced classes will no longer be respected in Extbase. This affects all places where Extbase magic happens, like translating the model name to repository name (and vice versa). If you still use class names with underscores, especially models, repositories and controllers you need to act now. Releases: master Resolves: #85036 Change-Id: Ide5923159027802e723dff49729bba52a74c2639 Reviewed-on: https://review.typo3.org/56990 Tested-by:
-
Alexander Schnitzler authored
Controller action arguments have been validated on creation, which caused superfluous CPU cycles if the action controller later detected, that an argument should not have been validated at all due to an @Extbase\IgnoreValidation annotation. To fix this, arguments get an empty result on creation. When setting the argument value, only the validation results of the property mapping are merged with the argument result. ActionController::initializeActionMethodValidators does only create validator instances for method arguments that need to be validated, thus a whole bunch of checks disappears in callActionMethod(). Releases: master Resolves: #85012 Change-Id: Iaecf36718477a9216f8d36a993a137eb7b677227 Reviewed-on: https://review.typo3.org/56970 Tested-by:
-
