Skip to content
Snippets Groups Projects
Commit 6ddfb9c5 authored by Alexander Schnitzler's avatar Alexander Schnitzler Committed by Benni Mack
Browse files

[BUGFIX] Only validate method params if needed

Controller action arguments have been validated on
creation, which caused superfluous CPU cycles if the
action controller later detected, that an argument
should not have been validated at all due to an
@Extbase\IgnoreValidation annotation.

To fix this, arguments get an empty result on creation.
When setting the argument value, only the validation
results of the property mapping are merged with the
argument result.

ActionController::initializeActionMethodValidators does
only create validator instances for method arguments
that need to be validated, thus a whole bunch of checks
disappears in callActionMethod().

Releases: master
Resolves: #85012
Change-Id: Iaecf36718477a9216f8d36a993a137eb7b677227
Reviewed-on: https://review.typo3.org/56970


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewe...
parent 6dd9f1ae
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment