- May 22, 2018
-
-
Alexander Schnitzler authored
Controller action arguments have been validated on creation, which caused superfluous CPU cycles if the action controller later detected, that an argument should not have been validated at all due to an @Extbase\IgnoreValidation annotation. To fix this, arguments get an empty result on creation. When setting the argument value, only the validation results of the property mapping are merged with the argument result. ActionController::initializeActionMethodValidators does only create validator instances for method arguments that need to be validated, thus a whole bunch of checks disappears in callActionMethod(). Releases: master Resolves: #85012 Change-Id: Iaecf36718477a9216f8d36a993a137eb7b677227 Reviewed-on: https://review.typo3.org/56970 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
Resolves: #85060 Related: #84053 Releases: master, 9.2, 8.7, 7.6 Change-Id: I04dba093dc8e423adbf75e2198c31e5c013864cb Reviewed-on: https://review.typo3.org/57027 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Frank Naegler authored
With #81987 we have introduced code, which could cause PHP notices. This patch changes the check to prevent such notices. Resolves: #85057 Related: #81987 Releases: master Change-Id: I85e85501c2593b8abacac1d8296148d03d57f407 Reviewed-on: https://review.typo3.org/57019 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
- May 21, 2018
-
-
Christian Kuhn authored
Some first experiences with the new v9.2 site configuration show us that people think site configuration can be extended just like any other TCA, but that's not the case. The patch changes some details to make more clear site configuration is not just some other sort of TCA with the same feature set. * Do not prefix site_* with sys_ anymore to abstract better from db tables * Rename configuration folder SiteConfigurationTca/ to SiteConfiguration/ to make it more clear this is not straight TCA * Do not load SiteConfiguration into GLOBALS['TCA'] to distinct from TCA * Mark extending site configuration experimental, add a documentation example and explain what is not working. Change-Id: I87890ccd07ca73c4ef1f7690c61f8d2185baf575 Resolves: #85050 Releases: master Reviewed-on: https://review.typo3.org/57001 Reviewed-by:
-
- May 18, 2018
-
-
Stefan Froemken authored
Some digicams like iPhone do not rotate images by default. They add a direction entry into the exif meta data. ImageMagick can read this entry if -auto-orient is set. The patch add the rotation detection to the ImageInfo object and the IM/GD commands that read files. Resolves: #69274 Releases: master Change-Id: I4b1193daf1c321a3d4beb8d76974012ee42470f6 Reviewed-on: https://review.typo3.org/48079 Tested-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Alexander Schnitzler authored
Several methods and constants in the ValidatorResolver class are now marked as deprecated because they are no longer needed to resolve validators. As these methods and constants are to be considered internal api it is very unlikely that anyone is affected by this change. Releases: master Resolves: #85005 Change-Id: If5fdb34766c84de1b16854f14df23fc2ddaff750 Reviewed-on: https://review.typo3.org/56888 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Mathias Brodala authored
Change-Id: Ie2ca536b5e1bd6e28e46af8073aaff4e298ddecf Resolves: #85008 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/56962 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Björn Jacob authored
Since #80187 it is possible to use the confirmation message finisher within the form editor. This patch adds the missing possibility to override the finisher within the content element. Resolves: #85047 Related: #80187 Releases: master Change-Id: I55e91972e1eb5ce0b636a8286423f4af2202ca03 Reviewed-on: https://review.typo3.org/57005 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Mathias Brodala authored
We log this as debug to not fill system logs by default. Resolves: #85034 Releases: master, 8.7 Change-Id: Ica686e42fa7a2ef09f2f5c4bf9b91781f5c14dc9 Reviewed-on: https://review.typo3.org/56995 Tested-by:
-
Bernhard Kraft authored
Fix a typo in doc comments. Resolves: #85046 Releases: master Change-Id: I3b7674593288accd43b2d4779f878e0eceee63a2 Reviewed-on: https://review.typo3.org/57004 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Oliver Hader authored
In case TSconfig options.file_list.filesPerPage is not defined the resulting value falls back to 1 - however this should be the same as defined in FileList::$iLimit, which is 40 per default. Resolves: #85043 Releases: master Change-Id: I33b024b81697350aeae54251e1ea66a36efc4d43 Reviewed-on: https://review.typo3.org/57003 Reviewed-by:
-
Alexander Stehlik authored
Compare folder identifiers instead of folder objects because objects pointing to the same folder might still be different object instances. Change-Id: I78e21b9e68fbaae245d12ac4efb96312b246a847 Releases: master, 8.7 Resolves: #85019 Reviewed-on: https://review.typo3.org/56985 Tested-by:
-
Ralf Zimmermann authored
Skip adding child elements within the form factory if a nested form element is unknown. Resolves: #84833 Releases: master, 8.7 Change-Id: I1cbb87b4c460bd45b58aa6bcca27a88c61a7e92f Reviewed-on: https://review.typo3.org/56773 Tested-by:
-
- May 17, 2018
-
-
Björn Jacob authored
* introduce new role for inline YAML code styles * fix some internal and external links Resolves: #85037 Releases: master, 8.7 Change-Id: Ie5581bcc911914c49511ff86c5679f04c45c9f00 Reviewed-on: https://review.typo3.org/56997 Tested-by:
-
Daniela Pohl authored
- improved margin between field and hint for "special form" element - styled custom error message hint -> this also applies for "single select" element : "inactive option" - fixed validator and finisher margins - styled hints for required textareas Resolves: #82339 Releases: master Change-Id: I3cd215eb967ccd6f0901a72675513a2619521d11 Reviewed-on: https://review.typo3.org/56981 Tested-by:
-
Björn Jacob authored
The honeypot field now passes the accessibility tests WCAG 2.0 (tested with Google Lighthouse). Instead of inserting a label tag or a title attribute - which would be counterproductive by revealing the purpose of the honeypot - the patch adds an aria-hidden attribute. Resolves: #75591 Releases: master, 8.7 Change-Id: Ie4b0b7a245f5c0edf3e01ece60dcb638b2f9bdc1 Reviewed-on: https://review.typo3.org/56992 Tested-by:
-
Björn Jacob authored
The form framework supports setting a 'defaultValue' for most of the form elements. This patch adds some information about this setting and outlines the difference to the 'prependOptionValue' setting. Resolves: #82422 Releases: master, 8.7 Change-Id: Ic3bbe76ebe69ac0655e11ba501d62ee19b2d143f Reviewed-on: https://review.typo3.org/56991 Reviewed-by:
-
Mathias Brodala authored
The doc file was only added for v7, it must also be added to master and v8. Resolves: #85029 Related: #84843 Releases: master, 8.7 Change-Id: I2e372eae6bc90a0da0e441237b087b98319a183e Reviewed-on: https://review.typo3.org/56986 Reviewed-by:
-
Christian Kuhn authored
Manually configuring clear-text password storage in TYPO3 for frontend users by explicitly setting the ext:saltedpasswords extension configuration "FE.enabled = 0" has been a bad idea for a very long time already. The feature has been dropped for backend users in core v6.2 and is now finally dropped for frontend users with this patch, too. No third party service must rely on clear-text password storing in 2018 anymore, the TYPO3 authentication services provide an API to process credentials upon user login for authentication and authorisation purposes. Resolves: #85027 Related: #85026 Releases: master Change-Id: I600f598e969ac99a83f3b57362b251b48116fd58 Reviewed-on: https://review.typo3.org/56979 Reviewed-by:
-
Christian Kuhn authored
For now, we have to keep property modTSconfig public in RecordListController since it is used from DatabaseRecordList via infamous $GLOBALS['SOBE'] and otherwise shows deprecation notices in list module :( Resolves: #85030 Related: #85016 Releases: master Change-Id: I40bdd54a89e2282d8403b633fb08c505b214c338 Reviewed-on: https://review.typo3.org/56987 Tested-by:
-
Alexander Schnitzler authored
\TYPO3\CMS\Extbase\Mvc\Controller\ActionController::initializeActionMethodValidators registers a superfluous property validator for simple types. As these kinds of validators are added through method getBaseValidatorConjunction, the superfluous registration is removed. Releases: master Resolves: #84953 Change-Id: I02fe7863b9014aa6072653d536dfeed67a01deda Reviewed-on: https://review.typo3.org/56901 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Tim Schreiner authored
When useOrOverridePlaceholder mode is used for TCA input type, use opt-in for the checkbox when placeholder is empty. In some cases, the placeholder can be empty. Especially when the placeholder uses data from another field. When information is added to the corresponding field, the input field does not take this in account because the override checkbox is set by default. This can lead to problems for title and alternative fields in the sys_file_metadata table. When adding a file reference and setting the title or alternative field afterwards in the original file, the reference is still using the empty override from file reference. Resolves: #84563 Releases: master, 8.7 Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a Reviewed-on: https://review.typo3.org/56486 Tested-by:
Alexander Stehlik <alexander.stehlik@gmail.com> Tested-by:
-
Björn Jacob authored
This patch adds some documentation regarding the automatic inclusion of the honeypot and (static) site caching. Resolves: #83212 Releases: master, 8.7 Change-Id: I9e7b56a8e515172f6a91274512db13488b41eacb Reviewed-on: https://review.typo3.org/56983 Reviewed-by:
-
Anja authored
Provides Edit- and NewRecord[Link|Uri]ViewHelpers to be used in all places of the backend, also for extensions. Remove four dedicated classes from system extensions, that got replaced with the new implementations. Also: composer update typo3/testing-framework Resolves: #84983 Releases: master Change-Id: I7fc03db101d2f73b63b24e4175d2e02aafa06e95 Reviewed-on: https://review.typo3.org/56934 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
The localization wizard in the page module offers now a global translate action per page only. With this change, a user isn't anymore able to translate content on column basis. This streamlines the localization process as it lowers the risk of creating broken localization setups (a.k.a "mixed mode") and it will simplify the upcoming "Change mode" wizard that enables to switch between "Free" and "Connected" modes. Resolves: #84877 Releases: master Change-Id: Ibfd4641c5a8d3622c86b5a8657af00b2b3122503 Reviewed-on: https://review.typo3.org/56813 Tested-by:
-
- May 16, 2018
-
-
Guido Schmechel authored
While retrieving the list with begin as argument for a recursive call, getTreeList builds the comma-separated list correctly. Resolves: #83328 Releases: master, 8.7, 7.6 Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8 Reviewed-on: https://review.typo3.org/56139 Tested-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
Björn Jacob authored
This patch adds some documentation for the DatePicker form element and the available date formats. Resolves: #82508 Releases: master, 8.7 Change-Id: I1277c024112633ec7e38f4c8cbe30efb97375ce3 Reviewed-on: https://review.typo3.org/56978 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #85024 Change-Id: I623bff02e95056422c1faf859a7d34740ba6b60f Reviewed-on: https://review.typo3.org/56974 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Christian Kuhn authored
This patch is one step into merging the salted passwords extension code into the core extension, starting with removing obsolete stuff: The bulk update task is a use-once-throw-away task aimed to help upgrading systems older than 10 years. It is removed now. The patch includes an extensive important ReST file explaining details and alternatives. Change-Id: I2e9064438e0ac257e95bb0768860f587d8e29375 Resolves: #85022 Releases: master Reviewed-on: https://review.typo3.org/56977 Reviewed-by:
-
Christian Kuhn authored
Final patch to de-mess the user / page TSconfig related API. Page TSconfig can be overriden in user TSconfig by prefixing the path with 'page.' in user TSconfig. However, method BackendUtility::getModTSconfig() violated this principle and had a special merge strategy that allowed ommitting the 'page.' prefix. This has been marked as deprecated in the TSconfig docs for various years and has been lately removed in the docs altogether, but the code still existed. The patch moves this merge into BackendUtility::getPagesTSconfig() and properly deprecates this case. Usages of getModTSconfig() are changed to use getPagesTSconfig() directly, dropping the artificial 'properties' and 'value' sub arrays and omitting some rather expensive string operations at the same time. This obsoletes getModTSconfig() and a couple of related methods. Additionally, BackendUserAuthentication->getTSConfig() has been abused frequently to operate on different arrays than it's own userTS. Those usages are dropped with the patch. Handing over arguments to getTSConfig() is now deprecated, effectively reducing the method a getter. This reduces the API down to BackendUtility::getPagesTSconfig($pid) and BackendUserAuhtentiction->getTSConfig() both just returning the entire array. This simplified API can now be documented in the docs. Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d Resolves: #85016 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56968 Tested-by:
-
Mathias Brodala authored
If the class of a registered task is missing, e.g. because the related extension has been removed, the task itself will be unserialized into an __PHP_Incomplete_Class object. Checking the task execution is an invalid access in this case and must be avoided for such tasks to be deleted. Resolves: #84973 Releases: master, 8.7 Change-Id: Iaec8a5e346a0d6257a942cbead50b214036ed700 Reviewed-on: https://review.typo3.org/56959 Reviewed-by:
-
- May 15, 2018
-
-
Christian Kuhn authored
The configuration module gets a new entry showing the user TSconfig of the currently logged in user. Note it is not possible to show user TSconfig of a different user this way, this array is thus basically restricted to admin users. Resolves: #85017 Releases: master Change-Id: Ic078160b2da1f2f5e24f13f9ee9ee708bf9a267e Reviewed-on: https://review.typo3.org/56971 Tested-by:
Sascha Maier <sam@amedick-sommer.de> Reviewed-by:
-
Sybille Peters authored
This is a followup for issue #84987. The style that is now set by CSS file in rte_ckeditor should no longer be set by a PHP method. Resolves: #85007 Related: #84987 Releases: master Change-Id: Ie05ed7153802e6a655b3e6e473129a92db613714 Reviewed-on: https://review.typo3.org/56966 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Sybille Peters authored
The styling for broken page links that was added in RteHtmlParser::markBrokenLinks is by default removed by ckeditor so this functionality is no longer available by default. Page links which link to a non-existing page currently already get the additional attribute a[data-rte-error]. This patch adds CSS to visually style broken links with a red border and yellow background. This is the same styling that was previously used. This is done by adding the plugin showbrokenlinks. The style is still added in markBrokenLinks. These attributes will be removed by ckeditor by default. However, the functionality is kept to function as fallback. Resolves: #84987 Releases: master, 8.7 Change-Id: I63e1e1db248fb2c343cdd19b41424621b684e87e Reviewed-on: https://review.typo3.org/56943 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Christian Kuhn authored
Verify getValueByPath() can return a sub part of a given array. Resolves: #85009 Releases: master Change-Id: Idc77809b960534d2b2694002c792f42d710ffa81 Reviewed-on: https://review.typo3.org/56963 Tested-by:
-
- May 14, 2018
-
-
Alexander Schnitzler authored
This patch introduces the "TYPO3\CMS\Extbase\Annotation\Validate" annotation that replaces the @validate annotation which is deprecated from now on. Releases: master Resolves: #83167 Change-Id: I9a0a3804cfb7429eaf81ec2b3ffa21c3a3d84c63 Reviewed-on: https://review.typo3.org/54870 Reviewed-by:
-
Gianluca Piccolo authored
There were some advanced search fields in indexed search that disappeared after the last update. In SearchController, method processExtendedSearchParameters, there were some non-existing variables that were used in some conditions. With this patch, those variables are initialized before the conditions and all the advanced search fields in indexed search are shown again. Releases: master, 8.7 Resolves: #84995 Change-Id: I69aef4c7a3d869d519e84866929f4724c61eabd7 Reviewed-on: https://review.typo3.org/56958 Tested-by:
-
Peter Niederlag authored
formAction has set a bunch of variables that are required by the frontend for the extendedSearch Inside searchAction this parameters were not set resulting in the extendedSearch section being empty in frontend after searching. With this change the processing of the variables is extracted into a method and called from formAction and searchAction. Releases: master, 8.7 Resolves: #82064 Change-Id: Ia21c445ef0aa72e8e084e9bd021bc5caa7a1e74b Reviewed-on: https://review.typo3.org/55547 Reviewed-by:
-
- May 13, 2018
-
-
Helmut Hummel authored
Make it possible to add additional query restrictions, that will be applied to every query. Resolves: #84244 Releases: master, 8.7 Change-Id: I0d0a5546629587306e537da51d8a2557d7e95fce Reviewed-on: https://review.typo3.org/56341 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Christian Kuhn authored
The patch deprecates BackendUserAuthentication->getTSConfigVal() and ->getTSConfigProp() and adapts usages to rely on getTSConfig() without arguments. The array nesting is done directly within consuming code and is combined with ?? to a fallback value. Advantages: * Expensive and recursive string operations within getTSConfig() are not used anymore. * The weird 'value' / 'property' based sub array juggling is gone. * Full TSconfig path including fallback can be easily seen within consuming code * Notice free array access using null coalescence operator Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652 Resolves: #84993 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56953 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
