[TASK] Streamline TSconfig API
Final patch to de-mess the user / page TSconfig related API. Page TSconfig can be overriden in user TSconfig by prefixing the path with 'page.' in user TSconfig. However, method BackendUtility::getModTSconfig() violated this principle and had a special merge strategy that allowed ommitting the 'page.' prefix. This has been marked as deprecated in the TSconfig docs for various years and has been lately removed in the docs altogether, but the code still existed. The patch moves this merge into BackendUtility::getPagesTSconfig() and properly deprecates this case. Usages of getModTSconfig() are changed to use getPagesTSconfig() directly, dropping the artificial 'properties' and 'value' sub arrays and omitting some rather expensive string operations at the same time. This obsoletes getModTSconfig() and a couple of related methods. Additionally, BackendUserAuthentication->getTSConfig() has been abused frequently to operate on different arrays than it's own userTS. Those usages are dropped with the patch. Handing over arguments to getTSConfig() is now deprecated, effectively reducing the method a getter. This reduces the API down to BackendUtility::getPagesTSconfig($pid) and BackendUserAuhtentiction->getTSConfig() both just returning the entire array. This simplified API can now be documented in the docs. Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d Resolves: #85016 Related: #84982 Releases: master Reviewed-on: https://review.typo3.org/56968 Tested-by:TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/adminpanel/Classes/Service/EditToolbarService.php 1 addition, 4 deletions.../sysext/adminpanel/Classes/Service/EditToolbarService.php
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php 5 additions, 6 deletions...lasses/Configuration/TranslationConfigurationProvider.php
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php 10 additions, 11 deletions...kend/Classes/ContextMenu/ItemProviders/RecordProvider.php
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php 0 additions, 3 deletions...asses/Controller/ContentElement/MoveElementController.php
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php 1 addition, 1 deletion...Controller/ContentElement/NewContentElementController.php
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php 16 additions, 23 deletions...ext/backend/Classes/Controller/EditDocumentController.php
- typo3/sysext/backend/Classes/Controller/NewRecordController.php 8 additions, 24 deletions...sysext/backend/Classes/Controller/NewRecordController.php
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php 12 additions, 6 deletions...ysext/backend/Classes/Controller/PageLayoutController.php
- typo3/sysext/backend/Classes/Module/BaseScriptClass.php 8 additions, 3 deletionstypo3/sysext/backend/Classes/Module/BaseScriptClass.php
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php 21 additions, 7 deletionstypo3/sysext/backend/Classes/Tree/View/PagePositionMap.php
- typo3/sysext/backend/Classes/Utility/BackendUtility.php 41 additions, 19 deletionstypo3/sysext/backend/Classes/Utility/BackendUtility.php
- typo3/sysext/backend/Classes/View/BackendLayoutView.php 8 additions, 6 deletionstypo3/sysext/backend/Classes/View/BackendLayoutView.php
- typo3/sysext/backend/Classes/View/PageLayoutView.php 20 additions, 30 deletionstypo3/sysext/backend/Classes/View/PageLayoutView.php
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php 0 additions, 27 deletions.../sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php
- typo3/sysext/backend/Tests/UnitDeprecated/Utility/BackendUtilityTest.php 50 additions, 0 deletions...ckend/Tests/UnitDeprecated/Utility/BackendUtilityTest.php
- typo3/sysext/backend/Tests/UnitDeprecated/Utility/Fixtures/BackendUtilityFixture.php 4 additions, 2 deletions...UnitDeprecated/Utility/Fixtures/BackendUtilityFixture.php
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php 17 additions, 7 deletions...core/Classes/Authentication/BackendUserAuthentication.php
- typo3/sysext/core/Classes/Configuration/Richtext.php 1 addition, 12 deletionstypo3/sysext/core/Classes/Configuration/Richtext.php
- typo3/sysext/core/Classes/DataHandling/DataHandler.php 7 additions, 20 deletionstypo3/sysext/core/Classes/DataHandling/DataHandler.php
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php 3 additions, 6 deletions...re/Classes/DataHandling/Localization/DataMapProcessor.php
Please register or sign in to comment