Skip to content
Snippets Groups Projects
Commit 45c582a8 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[TASK] Streamline TSconfig API

Final patch to de-mess the user / page TSconfig related API.

Page TSconfig can be overriden in user TSconfig by prefixing the
path with 'page.' in user TSconfig. However, method
BackendUtility::getModTSconfig() violated this principle and
had a special merge strategy that allowed ommitting the 'page.'
prefix. This has been marked as deprecated in the TSconfig docs for
various years and has been lately removed in the docs altogether,
but the code still existed.
The patch moves this merge into BackendUtility::getPagesTSconfig()
and properly deprecates this case. Usages of getModTSconfig() are
changed to use getPagesTSconfig() directly, dropping the artificial
'properties' and 'value' sub arrays and omitting some rather expensive
string operations at the same time.
This obsoletes getModTSconfig() and a couple of related methods.

Additionally, BackendUserAuthentication->getTSConfig() has been
abused frequently to operate on different arrays than it's own userTS.
Those usages are dropped with the patch. Handing over arguments to
getTSConfig() is now deprecated, effectively reducing the method a getter.

This reduces the API down to BackendUtility::getPagesTSconfig($pid)
and BackendUserAuhtentiction->getTSConfig() both just returning the
entire array. This simplified API can now be documented in the docs.

Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d
Resolves: #85016
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56968


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarJan Helke <typo3@helke.de>
Tested-by: default avatarJan Helke <typo3@helke.de>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 28b65ab8
Showing
with 233 additions and 217 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment