- Apr 09, 2020
-
-
Tymoteusz Motylewski authored
Add test for TreeController, so we're safe when refactoring or doing performance optimizations. Besides that moved pages in a workspace were not considered when calculating permissions on the rootline due to missing workspace overlays. Resolves: #90831 Releases: 9.5, master Change-Id: Ic3ab08d2502e8c9a3f08e737552c2e1d2a56a66c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63848 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 08, 2020
-
-
Benni Mack authored
The master $GLOBALS[LANG] object should have a more streamlined API and some methods and public properties are now deprecated, in order to make this API much more stateless. Resolves: #90964 Releases: master Change-Id: I201cf1b7300e385e3b87ab282290aae8e27041da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64056 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Eßl authored
The changes in #18079 have a small, but nasty typo, that makes it impossible to correctly check if the page is a sysfolder. Resolves: #90975 Related: #18079 Releases: master Change-Id: Iec8d119a9d29adec742f322a66102ce77a6eb16a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64095 Tested-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
Christian Eßl authored
Resolves: #90976 Releases: master, 9.5 Change-Id: I3827e0796f7dc016b3095b5e8917905b85523712 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64096 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Christian Eßl authored
Resolves: #90960 Releases: master Change-Id: I71933b194a4c366914c9d462b91cf605ed454a76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64103 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Nikita Hovratov authored
The key should be 4 instead of 5 (index starts at 0). Resolves: #90982 Releases: master Change-Id: Iee33a74d8f569082aa495025892131acc0a392a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64101 Tested-by:
-
Georg Ringer authored
The row must only be processed if available. Resolves: #90979 Releases: master Change-Id: I0ce76b196c32d8528d0bce0467782c3da4daefba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64099 Reviewed-by:
-
Andreas Fernandez authored
This patch updates the Docker configuration to use mssql 2019 as mssql 2017 images don't get updates anymore. Additionally to the mssql update, the shuffled chunking to 50 jobs is reverted as it didn't bring any benefit but even more hassle as the stages failed earlier and more often. Instead, the jobs are now grouped by PHP version which allows smaller chunks and reduced the probability to clog the build queue. To workaround errors thrown by Gerrit on heavy load, the cherry-pick command is now executed up to five times, with a short sleep between each execution. Last but not least we check whether there is actually a dangling Docker container instead of hard killing non-existent containers which pollutes our log. Resolves: #90965 Releases: master, 9.5 Change-Id: Ied60297127b86c3375d310759bf441ad9e10aeed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64087 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel Siepmann authored
These changes in the SuggestWizardController allow users to override allowed tables in group fields with columnsOverrides. Typical usecases for this is to use the records field for tt_content elements. Resolves: #76661 Releases: master Change-Id: Ic566c793f8d953802f5f6ff670fde485c19ed9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59444 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 07, 2020
-
-
Daniel Siepmann authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 several @var annotations have been adjusted to reflect the actual used type of properties. This however led to the issue that several properties of Extbase models had one type as annotation but used more than one specific type internally. Adding the additional type made phpstan happy but broke the property mapper of Extbase, which expects just one type to be annotated via @var. Therefore, the @var annotations in the affected models have been reverted to their original state and the reoccurring errors have been put onto phpstans list of ignored errors. Resolves: #90969 Releases: master Change-Id: I91944a631b9e1ff300ada25953577d852a998270 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Georg Ringer authored
Force value to be a string instead of null in ConstantConfigurationParser to avoid exceptions. Resolves: #90900 Releases: master Change-Id: I968e86f95577eaa3d9d57e367cfb707f9a3e4ff5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64089 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90891 Change-Id: Ie0a00688422d7088816f80364e68cac7f7232950 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64016 Tested-by:
-
Patrick Broens authored
When a logged in backend user is entering the history/undo functionality for a certain page, which contains a deleted one, the backend user authentication will throw an error. This is due to the fact the pid field is not taken into account when fetching the pages to check if they are deleted. This pid field will be used to calculate the page access, but is now done with the value null. This patch will add the pid field when fetching the subpages which will be checked if they are deleted. Resolves: #90963 Releases: master, 9.5 Change-Id: I1b78d4a71fea35b5d55a1d8989e586f01e7d9280 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64088 Tested-by:
-
- Apr 06, 2020
-
-
Benni Mack authored
In times of PSR-7, TYPO3's RequestFactory API and the underlying Guzzle HTTP library, the wrapper method GeneralUtility::getUrl() is merely a lazy short-hand method for fetching the contents. It is recommended to use TYPO3's RequestFactory API for fetching remote URLs. For now, however, the additional arguments (sending alternative headers, only fetching HEAD requests and return headers or headers + content, fetching a report of what happened) are deprecated, as they have proven to be inflexible nowadays. Resolves: #90956 Releases: master Change-Id: Ic7631ccf61000d0853007cf9278db6e1bab09335 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64012 Tested-by:
-
Nikita Hovratov authored
Replace "TypoScript" with "TypeScript". Resolves: #90958 Releases: master Change-Id: I8eb5237b963957ad24af7b47f76d739a847be0f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64086 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90893 Change-Id: Icc339442cded9a268fb66fe932b0f13de292e3b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 Reviewed-by:
-
Christian Eßl authored
Allow including protocol-relative urls (urls that start with "//") in the new AssetRenderer in the same way as it is already supported in other parts of TYPO3. Keep in mind, that using protocol-relative urls is considered an antipattern nowadays and if you run your website solely on encrypted connections (which you should by now), you can and should always request all resources via https://. Resolves: #90933 Releases: master Change-Id: Iaf91091fca64fde889501f5ac55dbb943d4c116e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64069 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Susanne Moog authored
According to a report, items added by itemsProcFunc cannot be saved via datahandler. Adding a test case to test the behaviour. Resolves: #76509 Releases: master Change-Id: I2d5e34c6a9eff7a8fa0129106c9676307c5e3151 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63917 Tested-by:
-
Christian Eßl authored
The current solution for setting a fallback og:image/twitter:image in the docs of ext:seo would generate relative urls, which is not desired for these kind of resources. Improve the docs with a solution, that enforces absolute urls. Resolves: #90830 Releases: master Change-Id: Ibc254f2f157dfac0da2d748b475da1617ecee1c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64070 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Josef Glatz authored
Add related links for each upgrade documentation file at the end: - link to forge issue - link to rendered rST document This makes it possible to - read the documentation as rendered html with on click - easily share an upgrade document with others - open the related forge issue Resolves: #90923 Releases: master, 9.5 Change-Id: Iedf874e31b7026a55275d6073d645e875dab1b6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64044 Tested-by:
-
Markus Klein authored
If the pageIdSelector feature is enabled for the RTE the entered page UID needs to be formatted with correct link syntax. Resolves: #82942 Releases: master, 9.5 Change-Id: I93bc583ba279d0bde549582388791fc48150d933 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64064 Tested-by:
-
Markus Klein authored
TCEMAIN.linkHandler.page.configuration.pageIdSelector.enabled = 1 This configuration is adhered again and the pageIdSelector shows up. Resolves: #83056 Releases: master, 9.5 Change-Id: I1e03bfa180601a46c85e3c3b92ba9c7e980a4b8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64065 Tested-by:
-
- Apr 05, 2020
-
-
Claus Due authored
Creates a dedicated partial template which only contains the preview output, allowing global overrides of preview output without overriding the entire Record.html template. Releases: master Resolves: #90946 Change-Id: Ic3d9f9801476725bd37472f0266dfe0b69e8d653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64072 Tested-by:
-
Andreas Fernandez authored
When the RteLinkBrowser is opened, any active ranges are now backed up and reused later when an element gets linked. This fixes clashes with the browser's internal search feature that overrides the `Selection` object. Resolves: #90952 Releases: master, 9.5 Change-Id: I155157e808370cd5ff05076a6c82f09da3b0cb3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64078 Tested-by:
-
Anja Leichsenring authored
During refactoring of the class a method was removed, that was still mentioned in a mock creation. This raised a warning in unit test runs. Removing the mentioning (and the mock alongside with it) returns the tests to green. Resolves: #90943 Related: #90348 Related: #90839 Releases: master Change-Id: I558d0bcd31942aac6241c819c8bf011dba23fe2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64067 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
-
Anja Leichsenring authored
The accessibleMockForAbstractClasses is a discouraged concept anyways, and in this case the constructor definition in the interface caused a test failure. Moving the tests to concrete classes solves the failure and also gets rid of the abstract class mock. Resolves: #90942 Releases: master, 9.5 Change-Id: I902cabd3290761c1525b128eb18822199f337cb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64066 Tested-by:
-
- Apr 04, 2020
-
-
Georg Ringer authored
Integrators are now able to compare individual backend usergroups. Backend usergroups are used to split permissions into smaller parts which can be later assigned to a backend user. This feature makes it possible to compare the defined permissions including the ones inherited from sub groups. Resolves: #90826 Releases: master Change-Id: Ic2306be7091c0001c293bcc8622c4d6ea16776ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63890 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The patch for #88720 added a new entry in MethodArgumentRequiredMatcher to cover changes in the class AspectFactory. The entry misses the affected method name which broke the extension scanner. This patch declares the missing affected method. Resolves: #90950 Related: #88720 Releases: master, 9.5 Change-Id: Id7df9b3f75eef0bb67781d0b67e68dad330da495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64075 Tested-by:
-
Christian Benthake authored
The ArrayConverter has been extended to be able to handle more string formats. Previously, it was only able to handle empty strings. Resolves: #88389 Releases: master Change-Id: I418072cdb32118cfe4e81ff01930cabbc86fee16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61410 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
Benni Mack authored
The hook to determine if child records are used is re-implemented. This makes the fluid based page module behave like the legacy PageLayoutView when determining if a record was used, allowing third party extensions to override the core's "is used?" decision. Resolves: #90927 Releases: master Change-Id: Ia72cf7479e04ee9c5ae688cf9c37bed697ac4d3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64049 Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Benni Mack authored
Only disallow DOCTYPE_RECYCLER in rootline and cObj->checkPid(), instead of disallowing DOCTYPE_SYSFOLDER. This makes it possible to fetch content from sysfolder pages. At the same time, a hard check on accessing sys folders is added to TSFE. Resolves: #18079 Resolves: #20933 Releases: master Change-Id: Ieb54d139bc1e7fc489c35f70510800be8ff14fb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64038 Tested-by:
-
Benni Mack authored
In order to reduce the amount of data fetched, the PageTree loaded for editors will only fetch pages that the editor actually sees, reducing the actual amount of pages to fetch. If a pagetree has 80.000 pages, but the editor can only see 50, the tree only loads these 50 pages. Resolves: #90880 Releases: master, 9.5 Change-Id: I57985484ace07fbfb919573351c210b291697ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63570 Tested-by:
-
Benni Mack authored
The following hooks within ContentObjectRenderer have been marked as deprecated: * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClass'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['cObjTypeAndClassDefault'] Both concepts have been superseded in TYPO3 v6 with custom cObjects via $GLOBALS['TYPO3_CONF_VARS']['FE']['ContentObjects'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['extLinkATagParamsHandler'] * cObj->extLinkATagParams() is now also marked as internal, as it serves no purpose anymore once the hook gets removed. In addition * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_content.php']['typolinkLinkHandler'] is deprecated since the initial addition of LinkHandler APIs in TYPO3 v8. Resolves: #90937 Releases: master Change-Id: Iaa1ea741f0bfef472f51a8067d5cea2f9ffcb774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64055 Tested-by:
-
- Apr 03, 2020
-
-
Christian Eßl authored
The $key in ArrayBrowser can sometimes be numeric. Cast the $key to string before handing it to htmlspecialchars() to prevent type errors. Resolves: #90883 Releases: master Change-Id: If5303800a0b8ef25521a8eb028ac0f11f8c5f648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64005 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch removes the bootstrap-slider library used to render input sliders. Such elements have been replaced with HTML input fields using `type="range"` which provides the same base functionality some time ago. Since using bootstrap-slider with TYPO3 is neither documented nor propagated, removing this library isn't considered as breaking change. Resolves: #90897 Releases: master Change-Id: I8516e2a4b98125e02873fad43c44cb2bc034e783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64047 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
This is a pre-patch to separate crawler-specific implementation from the actual indexing configuration. This first patch unifies the configuration creation for the indexer, and places the configuration in each respective logic (see TSFE hook), where as the Indexer does not know about TSFE or "called from Backend" anymore, making the indexer just doing its work. The next iteration will then separate all indexing logic into smaller chunks again. Resolves: #90920 Releases: master Change-Id: I631ddd0839ee8f03d0a6c3c86d302b935e599a5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64039 Tested-by:
-
Georg Ringer authored
Use buttons instead of span tags to make the module more accessible. Resolves: #90872 Releases: master Change-Id: Id183fa8de13ec3bea992cb9cdbe851127b1bc15c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64000 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Georg Ringer authored
The Install Tool module "Manage Language Packs" is improved by the following changes: * If all language packs of an extension are available, the download icon is still shown to make downloads of a single language pack per extension possible. * The icon itself changed from refresh to download as there is no refresh possible. There is no lock on a specific date or version to reload language packs. Every download can contain new or changed translations. Resolves: #86535 Releases: master, 9.5 Change-Id: I130c169b933b6e4b13c533928a46984bcb93979e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003 Tested-by:
-
- Apr 02, 2020
-
-
Oliver Hader authored
SiteConfiguration requires configuration path to be defined. Since this class is a singleton it might happen that SiteFinder created an instance already. Resolves: #90929 Releases: master Change-Id: I99c891c7b48c11a79003b410c1efa4da82bcd817 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64050 Tested-by:
-
