- Mar 29, 2020
-
-
Helmut Hummel authored
Allow installation of version 3.0 of composer installers, which will be compatible with Composer 2.0. composer req typo3/cms-composer-installers:"^2.0 || ^3.0" Resolves: #90877 Releases: 9.5, master Change-Id: I5200b64b0d6402617bb355da9c7d2c59cdd54b03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63998 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Susanne Moog authored
Resolves: #90864 Releases: master Change-Id: I3936c3a0c51f8bd05a6388f07240fe0e7d530779 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63997 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Claus Due authored
Followup with minor corrections for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918 * Relaxes method signature of getSelectedBackendLayout to restore compatibilty with third party XCLASS. * Avoids parsing empty configuration strings (in use cases where configuration is passed to BackendLayout as array, not TS string). * Uses DrawingConfiguration instance provided from BackendLayout instead of creating a new instance to override the one returned from BackendLayout. * Fixes a method call with unused return value. Releases: master Resolves: #90839 Change-Id: If6fe1286d3ce6530de30ea4c534ac1799e63177e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968 Tested-by:
-
Andreas Fernandez authored
The "Import selection" button in the Element Browser is now disabled by default, as no selection is done yet. (De)selecting items toggles the import button accordingly. Resolves: #90869 Releases: master Change-Id: I55e30abe83bf189c2825c30551b357cbd0174f44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63992 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Eßl authored
The old, non-fluidbased PageLayoutView was missing the translate button for editors, even when they had the right permissions to edit content, because the property $pageinfo wasn't initialized early enough before the permission check. Resolves: #90874 Related: #90858 Releases: master Change-Id: Ie6f4d1c0a1c2867978de87082e2a31f2907e2cdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63971 Tested-by:
-
- Mar 28, 2020
-
-
Jonas Eberle authored
This adds phpdoc for the public AssetCollector::add...() functions and notes for users migrating from PageRenderer::add...(). Resolves: #90870 Releases: master Change-Id: I8896b83f172a0e70ff5bdae61106c3a66d29667c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63970 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Jonas Eberle authored
As boolean HTML attributes shall either have a value equal to the attribute name (e.g. async="async") or have no value at all (only allowed in HTML5), the ViewHelper reflects that now. All boolean HTML attributes on <script> (async, defer, nomodule) and <link> (disabled) have been changed to Fluid "bool" ("0" and "false" is false, rest is true). This allows using the ViewHelpers with e.g. async="1" which before would have output <script async="1">. Now it is registered as async="async" with AssetCollector. References: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link Resolves: #90871 Releases: master Change-Id: I5052ff6ad86e14a9b55f507ba0f3dcf7ea3010e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63996 Tested-by: -
Jonas Eberle authored
Although registered as "string" argument in the ViewHelper, an incoming string that is_numeric() is cast to an integer, leading to a TypeError. Resolves: #90873 Releases: master Change-Id: Ic2b0cd8df1a75c46a22a605d6f7e3a0e2438a1d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63993 Tested-by:
-
Benni Mack authored
Currently TYPO3 Core does trimming based on the user (AbstractUserAuthentication) but in order to allow third-party extensions to integrate users / passwords with spaces at the end and beginning, this code is moved to the Authentication Service which allows for custom services to trim or not to trim individually. Resolves: #77715 Releases: master Change-Id: Ie31a5b97293275d15513abfae39599f4462262c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63925 Tested-by:
-
Christian Eßl authored
The AssetCollector does not necessarily need a filled array with attributes for adding javascript or stylesheets. Make the $attributes argument optional and default to an empty array. Resolves: #90868 Releases: master Change-Id: I7a6e5dad8724f36c0450d13cda853e90b1929e71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63969 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Frank Naegler authored
The Fluid ViewHelper `<f:widget.autocomplete>` has been marked as deprecated and will be removed in TYPO3 v11. Resolves: #90856 Releases: master Change-Id: I4088f235f03a2545d90bf7abacc18afc174de7bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63954 Tested-by:
-
Susanne Moog authored
To allow the dashboard to be positioned out of the "Web" main module, we rebuilt the module menu to allow direct top level modules. Additionally, the styling for the module menu was adjusted to allow mobile and keyboard friendly navigation and layout. Resolves: #90862 Releases: master Change-Id: I1005bac37a214530fb9e304fec2406799fe92240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63718 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
Some minor details are changed within TSFE. - metaCharset is now evaluated at the same time as other TypoScript options making this option available earlier in the process - getFromCache() and headerNoCache() now optionally receive a PSR-7 request to evaluate serverParams from the PSR-7 request and not the superglobals Resolves: #90853 Releases: master Change-Id: I443925c5d056db10cafb4e81aa30fc7db91c3c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63948 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Georg Ringer authored
Migrate the mails in SystemStatusUpdateTask to FluidEmails. As the current content format is rather limited it is not changed and only plain mails are sent. Resolves: #90726 Releases: master Change-Id: I97fc5c01326d9997cacfd56b2b917e79fe0688d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63725 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Mar 27, 2020
-
-
Christian Eßl authored
Do not show the inline edit form, when double clicking the title in the pagetree, if the editor has no access permissions to the default language or is not allowed to modify a page. Resolves: #90855 Releases: master, 9.5 Change-Id: I51b34451043ce7abeb73250ea050bc084c23647b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63952 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Christian Eßl authored
When using c-style multiline comments in the ext_tables.sql of an extension, the SchemaMigrator would then ignore the subsequent "CREATE TABLE" statement, because the SqlReader also read the multiline comments into the statement array. This patch fixes this behaviour. Now the following comments are possible inside ext_tables.sql: /* Some comment text more text */ /* Same line c-style comment */ /* More multiline comments */ CREATE TABLE table1 ( header varchar(255) DEFAULT '' NOT NULL, bodytext text ); Resolves: #89714 Releases: master, 9.5 Change-Id: I49e687215d0b42d6ca5416c687fdbc19b44d237d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63951 Tested-by: -
Alexander Schnitzler authored
Releases: master Resolves: #90802 Change-Id: I84da713c7b8c68ae67b6b9c33ad66dcbac8d72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63810 Tested-by:
-
Christian Eßl authored
Add missing documentation to IconViewHelper and extend some of the already existing argument descriptions. Resolves: #90859 Releases: master, 9.5 Change-Id: Id681f796e94db5b5bc0727a4a68dd19fecf8af77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63955 Tested-by:
-
Andreas Wolf authored
This adds a similar condition that already existed in the old link generation for the new routing-based link building. The conditions are adjusted accordingly. Change-Id: I467f0ce9695fd33ab1e1545e1ba0728c037d3e93 Resolves: #89068 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61615 Tested-by:
-
Georg Ringer authored
Links with an invalid syntax or not supported type must not lead to exceptions for an editor or users. Resolves: #87792 Releases: master Change-Id: Ica0791e3400d5aff18ecc25a2e8d57edf55af40c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63942 Tested-by:
-
Markus Klein authored
If the URL cannot be calculated by the UriBuilder an empty URL is returned. In this case no a-tag is rendered to avoid links with an empty href-attribute. Resolves: #90857 Releases: master, 9.5, 8.7 Change-Id: I597a4b11d986a3b6155a695e6fd3c84a94588a1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63953 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Benni Mack authored
PageLayoutView now builds a "Configuration" model for both variants PageLayoutView is not set up via the DrawingConfiguration object, which is now based on a factory method. PageLayoutController now injects all RequireJS modules in one place, and not in fluid anymore. Minor bugs regarding "getLanguageColumns" are fixed. The main "pageLayoutConfiguration" is now injected and used where it does not differ from the backend module configuration. Resolves: #90858 Releases: master Change-Id: I16925488e0bff75ec73f9dddbfd047cca3bd2da1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63938 Tested-by:
-
Stefan Horst authored
Update the template to not generate a url containing & which results in not working ajax call. Releases: master, 9.5 Resolves: #90091 Change-Id: If164f1a4c5d4aa6bf7cb830b27ed5ac5d5d5d525 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62849 Tested-by:
-
Georg Ringer authored
Show the detailed information about how many orphaned records have been found in which table by default and don't hide it behind a verbose flag. Additionally also show the ids of those records. Resolves: #87777 Releases: master, 9.5 Change-Id: I112b3d128109ea9bab358d9cbe215c0f5d45a820 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63940 Tested-by:
-
Benni Mack authored
Resolves: #90851 Releases: master Change-Id: I472845920d31449164a632b0edae442dd2b56f7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63945 Tested-by:
-
Stephan Großberndt authored
The sys_file_processedfile.configuration column will contain a serialized object after saving an image with a crop definition in the image manipulation editor. Avoid an exception being thrown on PostgreSQL due to this string containing NULL bytes not saved properly in a "text" column by changing the column type to "blob". Resolves: #90844 Releases: master, 9.5 Change-Id: I9bb751f6e0622a042e2f1b40925d7070fe656285 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63935 Tested-by:
-
Andreas Fernandez authored
Disabled input fields now contain the `data-formengine-input-name` attribute. The slug creation is now able to determine disabled fields as well to take them into consideration. Resolves: #90141 Releases: master, 9.5 Change-Id: I153a2d8e3e3e67fd6d865bd4e72691c67ab18c3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63947 Tested-by:
-
Susanne Moog authored
ImageLinkWrap may not get a valid file object but will still try to access methods on it which will fail. This patch implements a null check resulting in simply not linking the image if the given file resource is invalid. Resolves: #88879 Releases: master, 9.5 Change-Id: I723596aa3b0a274a3565492b3d67a30b9d52389f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63914 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
With regards to https://typo3.slack.com/archives/C025BQLFA/p1585231067123500 there seems to be confusion in the paragraph about avoiding checks on TYPO3_MODE if `defined('TYPO3_MODE') or die();` should be used or if that is forbidden as well. Releases: master Resolves: #90843 Change-Id: If1ef849a72bd0aa5337c5c6e8758e69a2f53164b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63934 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Susanne Moog authored
The original implementation was meant to handle different variants of opcaches. As of now, only the native PHP opcache is still supported. This patch cleans up the settings and setup check and adds an additional check whether clearing is possible or deactivated via disable_functions. Resolves: #90838 Releases: master Change-Id: I12bde7cf160be548904737acee5c1d39faadeba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63932 Tested-by:
-
Georg Ringer authored
Workspace overlays modify the CSS classes which are used in the record list. However the class `t3js-entity` is also used for JS magic and needs always be applied. Resolves: #86933 Releases: master, 9.5 Change-Id: I0ea1f4ea0ed5bc3b48eee4563e75d2c1d013a32c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63943 Tested-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
Georg Ringer authored
Use "browser console" instead of "console" to clarify that it is about the browser and not the command line. Resolves: #88157 Releases: master, 9.5 Change-Id: I16070e244a71ed1a19ccae9d1d907e6003dd68a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63941 Tested-by:
-
Benni Mack authored
Resolves: #85427 Releases: master Change-Id: Id63f560ea4553ba56e6ae70c061e4f592b39bf47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63930 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- Mar 26, 2020
-
-
Daniel Goerz authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/63923/ the t3editor fields were fixed to respect the actual TCA configuration for the fields. The leads to smaller input areas at some places. The TCA configuration of those fields is changed so that the former size of the input area is preserved. Resovles: #90845, Releases: master, 9.5 Change-Id: I2ccb36ab991f697e2d740a4ceb2902d5da31b911 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63936 Reviewed-by:
-
Susanne Moog authored
Resolves: #88726 Releases: master Change-Id: Iafca49803a2f1494913d9417171bb5731667b64d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63931 Tested-by:
-
Benni Mack authored
Currently "typolink.JSwindow_params" allows to set custom parameters when opening a link within a JS-based popup. When linking an image, the custom parameters have been added as well. Resolves: #21302 Releases: master Change-Id: Ia3ec655d8fe5536fd14564383da41a3fdfbb86c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63921 Tested-by:
-
Alexander Schnitzler authored
Due to a missing functional test and a legacy extension configuration format in a unit test several issues with methods in the ExtensionService class have not been spotted. Although the registration of plugins changed in that manner that FQCN's are used instead of controller class names, the internal handling in Extbase still relies on controller names, which are internally named controller aliases. The internal Extbase mechanics must still work like before, passing the controller name around as this is unique in the context of a plugin. Therefore it's not necessary to expose or use the FQCN. Releases: master Resolves: #90822 Change-Id: Idd574bcbcddaa209337f73ad8526b2423ad9c786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63933 Tested-by:
Toben Schmidt <t4ss5t@posteo.de> Tested-by:
-
Benni Mack authored
This change moves the ConditionMatching back to the BackendLayoutView. The main goal is to make BackendLayout more of an entity class again, whereas BackendLayoutView should be the process to build the BackendLayout objects, and configuration and return them, and act more as a BackendLayoutResolver - this could / should be renamed in the future. This change thus reactivates runtime-caching for fetching a backend layout configuration again. In addition, the new method "getBackendLayoutForPage()" now actually returns a "ready-to-use" Backend Layout instance, which could also used for the Nested Content Grid in the future. The previous "configurationArray" is now defined as "stucture". A short-hand function "getUsedColumns()" is added. Resolves: #90839 Releases: master Change-Id: Ic6e65317a5faa6d70a181fc3f24b3716a1137c39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918 Tested-by:
-
Susanne Moog authored
While it was with good intentions, restricting the allowed child nodes of the view helper restricts developers / integrators too much in their usage as valid cases of using loops or conditions do not work anymore. These restrictions have been removed. Resolves: #87179 Releases: master, 9.5 Change-Id: I36c87a69902eb84bbe551f79d959f1869673e459 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63927 Reviewed-by:
-
Andreas Fernandez authored
T3editor now respects the configured `rows` attribute of its textarea. If the attribute isn't configured for the node in FormEngine, the attribute is omitted. To be able to achieve this, the enforcement of a value for "rows" has been removed. If the "rows" attribute is missing, the T3editor instance may consume as much space as available, which comes in handy in the filelist. Resolves: #86699 Releases: master, 9.5 Change-Id: Iccb152b7a747918cfc4459721c7f69a8f67cb03d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63923 Tested-by:
-
