- Jul 09, 2021
-
-
Oliver Bartsch authored
Since #92826, our own RenderingContext implementation, available in our view helpers, contains the getRequest() method, which was introduced to reduce the usages of ControllerContext. In this patch, the majority of the view helpers was changed to now access the request from RenderingContext. Unfortunately, by this time, the extbase Request was still not PSR-7 compatible. Therefore, some view helpers still had to access $GLOBALS[TYPO3_REQUEST]. Since #94428, the extbase Request finally implements the PSR-7 ServerRequestInterface, which now allows us to replace the global access in the remaining view helpers. Resolves: #94497 Related: #92826 Related: #94428 Releases: master Change-Id: I29080cf7fd27fb6e454ae2dee5867f60ae69dd8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69733 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Jochen Roth authored
After reset user preferences in settings module the Configuration Module shows undefined array key warning. An empty array has been added as fallback to workaround this issue and improved scrollTo behavior when the user opens a node in the configuration tree. Also extended tests to cover such issues in the future. Resolves: #94487 Releases: master Change-Id: I3e907a2618765d314ff1ad8bcab74f1af46765c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69724 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
- Jul 08, 2021
-
-
Patryk Miedziaszczyk authored
Basic test for Indexed Search backend module checking main modes are loading properly. Releases: master Resolves: #94467 Change-Id: I6a0276ba0b881e57ee256793e584f60312406b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69763 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
In #87974 the special _PATH_ field was added to FileList, to be displayed on the search result view. To be consistent, this special field is now also processed on building the directory listing, while it currently has no visual effect, since the _PATH_ field is only dynamically added to in a search context. Resolves: #94505 Releases: master Change-Id: I100ab601dcf28f7acdb9bf999cf08cfa350ffd4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69760 Tested-by:
-
Benni Mack authored
The File List now creates links through the UriBuilder, allowing to use actions (such as rename) while then keeping search parameter, or pagination parameters properly. In addition, some code is now cleaned up and streamlined (e.g. the styling of the buttons in the "multi-clipboard mode" is now correct). Resolves: #94506 Releases: master Change-Id: I0cf7dde9e94738b124818de724ec5e47dc1a8ac0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69761 Tested-by:
-
Jochen Roth authored
Add fallback for undefined array keys to make "DB Check" compatible with PHP8. Also basic tests have been added to check each page in the module. Resolves: #94498 Releases: master Change-Id: I98a598d0e809077cd89e7620efe31a498b3fbfa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69759 Tested-by:
-
Oliver Bartsch authored
Currently, the Backend module File > FileList has two main views: * The list view * The search result view Both are handled via an Extbase controller, even though no pure Extbase-related feature (validation, type-converting, persistence) is used. Instead, the list view is generated by a PHP-based code "FileList" (similar to DatabaseRecordList), where as the search result view is built on top of Fluid. The latter approach hinders flexibility, and also leads to inconsistencies, due to the nature of using two different approaches. Most notable: - The search result view looks different than the list view, also no additional icons are possible. - The search result view has a clipboard, but does not allow to expand. - The search result view does not respect the listing limit, nor is the pagination displayed. - The search result view changes the module headline to "Search: <word>", removing the context on which folder the search was performed. However, the search result view works with the SearchDemand object which is a clean way to put the query requirements into the File List to render the found files. Therefore, this patch merges both Search Result Fluid view and PHP-based view back into one, more flexible and consistent, view. This also means, FileListController is not longer registered as an Extbase backend module and some internal ViewHelpers and classes were removed. The main benefits: * Exchanging features between DatabaseRecordList and FileList are easier to achieve * Hooks for additional icons also work in the search result view * Numeric Clipboards also work in the search result view * Buttons in each found file row look the same now * The current folder is now also displayed in search result view * Bookmarking also works properly now and additionally also takes a possible searchTerm into account * The search results are now paginated, respecting the listing limit * Invalid folders do not longer lead to an exception in the search result view Resolves: #87974 Resolves: #89867 Resolves: #92247 Resolves: #92747 Resolves: #93185 Releases: master Change-Id: I259fe7f63ef8ea69f6bdf0c787330f4338d4bd5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69718 Tested-by:
-
- Jul 07, 2021
-
-
Benni Mack authored
Using the TranslationConfigurationProvider API returns an array of available languages for a given site (and on pid=0 returns the available translations as well), brings back the Language Switcher when editing sys_file_metadata records. Resolves: #93033 Releases: master Change-Id: Ia727d1ce326462629d7864d381187595a1da2502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69721 Tested-by:
-
Benjamin Franzke authored
As identified in #94491, ImageService may be used in installtool context and is therefore now defined as lowlevel service via a service provider, to ensure its dependencies are always available in install tool contexts. Resolves: #94493 Related: #94491 Related: #89892 Releases: master Change-Id: I76934bb48336adb654a82ec23a9b6a1584c5ced9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69727 Tested-by:
-
- Jul 06, 2021
-
-
Daniel Siepmann authored
Add missing pagination example to feature rst. Only paginator is not enough to actually create a new pagination. Relates: #89603 Releases: master, 10.4 Change-Id: Ie6852b76fb79f131d3b8553640ef29ab60e072de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69723 Tested-by:
-
Oliver Bartsch authored
The ImageViewHelper is used in install tool context, when sending the "login successful" or "login failed" email, while using the SystemEmail layout. Since DI is not fully available in install tool context, the ImageService can not be injected in the view helper. Resolves: #94491 Releases: master Change-Id: I7eb4e0dda0738346032cf550119c3503523df0eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69726 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Jochen Roth authored
The button "save and close" is removed because "save" button does exactly the same thing. To streamline behavior the save button also returns to edit file view instead of returning file list view. On top of that add a test to cover such redirect issues in the future. Resolves: #94481 Resolves: #91840 Releases: master Change-Id: I5656cdbdc31444f632e05577c34cee50daed71e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69717 Tested-by:
-
Jochen Roth authored
In the install tool the flash message is not visible when a user scrolls down. This has been solved by setting position to fixed. Resolves: #94479 Releases: master, 10.4 Change-Id: Id86c54bd7286567bd6fe95bb1aea21a9b4558fd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69714 Tested-by:
-
Torben Hansen authored
The PHP library `symfony/rate-limiter` has been integrated in order to provide a rate limiting API for the TYPO3 core and extensions. As a new system default, the TYPO3 backend and frontend login now uses a rate limiter, which prevents further authentication attempts for an IP address, if a configurable amount of login attempts is exceeded in a given time. The hardcoded wait time of 5 seconds after a failed login has been removed, since it offers no real protection against brute force attacks. The following dependencies are introduced: * symfony/rate-limiter "^5.3" Resolves: #93825 Releases: master Change-Id: Ib248b78b501a4d50556aa97938f4c51f12f7522a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68624 Tested-by:
-
Jochen Roth authored
Array key undefined has been fixed by adding a fallback value for array fields "doSaveFieldName" and "elementBaseName" Resolves: #94480 Releases: master Change-Id: I89d315924136b527147f1b31fd0d7940719fcc6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69716 Tested-by:
-
- Jul 05, 2021
-
-
Oliver Bartsch authored
In #94218, the show columns selection was already improved by relocating it to each tables' header, making it always available (not only in single-table view). Since the used dropdown leads to confusion and visibility drawbacks for records, having long labels, the selector now lives in a modal. Besides the columns to select, the new modal contains some selector options, such as "select all" or "toggle selection". Those options are fixed at the top, making them always visible, even for records with a lot of columns. Furthermore the checkboxes now use a more suitable "check" icon, the columns are sorted lexically and also management fields (e.g. `sorting`) are now displayed with a human-readable label. This label is now also used in the table header. Besides the UX, this patch also brings some technical improvements. The whole column selection logic is moved into a dedicated controller, which may allows reuse in the future (e.g. for the filelist module). Also the JavaScript part is extracted from the Recordlist JS-module into a dedicated web component. Finally some cleanup of the existing code is done, making it more readable and more efficient. Resolves: #94474 Releases: master Change-Id: I0f2f8711ee4b40c9e29e633b9fe790dcacae8bb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69691 Tested-by:
-
Jochen Roth authored
When trying to add a widget when events not applied caused the add widget button to throw "undefined array key 'widget'". This is fixed by removing the url from the affected buttons. Tests have also been added for "create dashboard", "add widget", "delete dashboard" and "remove widget". Resolves: #94396 Releases: master Change-Id: Ifa64da17c901145016f22a475e655ad475e46c37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69542 Tested-by:
-
Alexander Schnitzler authored
Issue #92815 introduced a regression which triggered an endless recursion in case of a validation error. A bit longer explanation: Given there is an extbase controller action with an argument whose properties have to validated, extbase maps the incoming data of the request onto the internally handled arguments object which then performs the validation on all given arguments. In case of an error, extbase tries to redirect to the referring request aka the current request with an updated set of arguments. The idea is to remove all arguments of the current request to not trigger the same validation error again on the next try. There was a condition in the past which eventually led to the overriding of current arguments which was refactored wrong. The solution is to simply always use the arguments of the ForwardResponse. Releases: master Resolves: #94457 Change-Id: I9ec815205481faf77ff30eef3b5d68eb00c776c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69680 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
This patch updates bootstrap to version 5.0.2, introducing several bugfixes. See https://github.com/twbs/bootstrap/releases/tag/v5.0.2 for further reference. Executed commands: yarn add bootstrap@^5.0.2 --cwd Build/ yarn add --dev @types/bootstrap@^5.0.16 --cwd Build/ Resolves: #94468 Releases: master Change-Id: Ib212aa0b784ae504b6c128ad91001926d2a4e0ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69687 Tested-by:
-
- Jul 01, 2021
-
-
Larry Garfield authored
The channel column is a text field intended to suppplant the type column. For now, all types map over to column based on a lookup table. Also, repurpose the level column to a string to store the PSR-3 level. Resolves: #94433 Relates to: #94356 Releases: master Change-Id: I295df69da7e21ff9650a3c0c2b4d0e70a8ca9566 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69656 Tested-by:
-
Henrik Elsner authored
Resolves: #94458 Releases: master, 10.4 Change-Id: Ief3e5f9ee91a15629f6254e4d56bd9050b642730 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69682 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Jochen Roth authored
Resolves: #94455 Releases: master, 10.4 Change-Id: I0a7009482c0797ebb0f138cc209d98d88d830654 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69681 Tested-by:
-
Benni Mack authored
This change moves the "Create New" button of each table within the List module to the top row, making space for further implementations regarding multi-selection. Resolves: #94456 Releases: master Change-Id: I3a2b30e614c0ec56a6fd905a29517bade50863f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69679 Tested-by:
-
Benni Mack authored
This change adds support for Welsh to be selected as TYPO3 Language and to connect to TYPO3 Localizations (XLF files, Site Configuration) by default. Welsh is the official language of Wales. Also see https://en.wikipedia.org/wiki/Welsh_language Resolves: #94447 Releases: master Change-Id: I3f3307fa7648379ba3a2637f9593ebb240a50d5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69673 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Benjamin Franzke authored
Account for the symfony deprecation in https://github.com/symfony/symfony/pull/35879 which deprecated the default alias for Psr\Container\ContainerInterface and flooded our deprecaton logs since #94269. This deprecation is intended to help with symfony service locators (which we do not use), but would break our usecases once we update to symfony v6 as TYPO3 core and extensions rely on service_container autowiring for the PSR ContainerInterface alias. Releases: master Resolves: #94453 Related: #94269 Change-Id: I0599b3a8a5640faf2fac5094175ae2a6fb37a0a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69678 Tested-by:
-
Benni Mack authored
This change is the first of a few areas to unify the selection and multi-action logic of lists in TYPO3 Backend. This change moves the checkbox to the very beginning of each row within the File Browser popup (e.g. Select a File in Pages > Media of Form Engine) In addition to the "toggle selection" button, there is now a "select all" and "select none" button. When an item is selected, the whole item is now marked as selected. This code now uses the TYPO3 icons instead of the Font Awesome icons. Resolves: #94452 Releases: master Change-Id: I96de693c8915b9078a956f601f356b160b31339b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69537 Tested-by:
-
Oliver Bartsch authored
Since #94193 calling ResourceStorage->getPublicUrl() with the second argument "$relativeToCurrentScript" set, is deprecated. This patch therefore removes this argument from a call in TypoScriptFrontendController. Resolves: #94449 Releases: master Change-Id: If1ef240bbcaf1bb9f31e9a4cc7c395b3702da5c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69675 Tested-by:
-
- Jun 30, 2021
-
-
Oliver Bartsch authored
Since #94428, the extbase Request implements the PSR-7 ServerRequestInterface. Therefore, all usages of $GLOBALS['TYPO3_REQUEST'] in core extbase controllers are now replaced by accessing the extbase Request object instead. Since the extbase RequestInterface does not yet extend the PSR-7 ServerRequestInterface, as this would be a breaking change, the property type annotation of $request is changed to the specifc Request implementation, to still allow IDE support. Resolves: #94448 Related: #94428 Releases: master Change-Id: Icc8697993eae55766c21bc98d0e1e222d974ebfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69674 Tested-by:
-
Oliver Bartsch authored
Since #92784 extbase actions require to return a PSR-7 Response. To ease the migration path, the convenience method htmlResponse() was added. This method creates a new PSR-7 Response with the correct header and status code. Furthermore, in case no $html content is given explicitly, the current view is rendered and the result passed as response body. Extbase however also features the JsonView, which is widely used in third-party extensions as well as in multiple core controllers itself. Also TSFE has to be respected when adding the content-type header with the correct charset. Therefore, a new method jsonResponse(), with similar functionality to htmlResponse(), is now added along with adaptations of all places in core controllers. Resolves: #94440 Related: #92784 Releases: master Change-Id: Ic591a8788f586050578db8b4187e29325d180f49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69664 Tested-by:
-
Oliver Bartsch authored
Somehow CGL stage was tricked and some unused imports sneaked in. This patch removes them. Resolves: #94444 Releases: master Change-Id: Ifa51845d524e212c8dacec4faf5aa31826fa6cbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69671 Tested-by:
-
Christian Kuhn authored
guzzlehttp/psr7 is not only an indirect dependency from guzzlehttp/guzzle, but also a direct core dependency since we extend LazyOpenStream in SelfEmittableLazyOpenStream. Declare that dependency directly, which also blocks upcoming guzzlehttp/psr7:2.0 which is currently incompatible with our core use. composer req guzzlehttp/psr7:^1.7.0 composer req guzzlehttp/psr7:^1.7.0 -d typo3/sysext/core --no-update Change-Id: I4968bc854545262ce0230ea71647463f5a332f54 Resolves: #94422 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69668 Tested-by:
-
Christian Kuhn authored
Some rather obvious sanitation around TYPO3 installation procedure. Resolves: #94443 Releases: master Change-Id: Icb358cafbf6216d436358b7b45273f907deba721 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69670 Tested-by:
-
Christian Kuhn authored
The patch changes the extbase Mvc/Request to implement PSR-7 ServerRequestInterface: The former extbase request details like 'controllerAction' are changed to an PSR-7 attribute and the Request class is now a decorator - it receives the original PSR-7 request as constructor argument, then implements both the extbase RequestInterface plus PSR-7 ServerRequestInterface. This way, the Request object itself does not hold state (except the original request), but channels all get* and with* calls to the PSR-7 request object. This avoids creating a new standalone object and moving all data from the PSR-7 object into the new object. The patch is relatively conservative. The extbase related set* methods are kept even though they're all @internal and violate immutability, and various method signatures are not adapted towards strict typing, yet. The reason for that are various chain- and loop dependencies especially in fluid view that should be solved with single patches before extbase Request can be streamlined further. Current usages also rely on fallback layers within __construct(), which can be solved when consuming places are adapted - The patch would have become much bigger if that would be mixed in. Change-Id: I218de0ee30d16245e7d562d0aba2795ccc439901 Resolves: #94428 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69545 Tested-by:
-
Oliver Bartsch authored
Resolves: #94442 Relates: #94441 Releases: master Change-Id: Iaebd23d0031917c5c5c121c4123cf24304c47169 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69669 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
The method getCollectionValueType() is deprecated since symfony 5.3 and has therefore been replaced by getCollectionValueTypes(). Resolves: #94435 Releases: master Change-Id: I05427349f738cb328d547b221ee0224aa04ca57a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69658 Tested-by:
-
Oliver Bartsch authored
Resolves: #94437 Related: #92784 Releases: master Change-Id: I759b39fe7b04365293f55a3847a071e7fbfe3308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69660 Tested-by:
-
Oliver Bartsch authored
Resolves: #94436 Related: #92784 Releases: master Change-Id: I98d1a8d08e44ebf3b9626d6ead686059acd95db2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69659 Tested-by:
-
Jochen Roth authored
Open the table wizard with empty test in the text area or a click on the save button on table wizard page thow undefined key warning. This will avoid php warnings by adding a fallback value or a check if the key is present. Added acceptance tests for the table wizard to make sure the wizard will work as expected. Resolves: #94417 Releases: master Change-Id: I9283c9203f71710c8bffcc74432781d2159dcde7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69575 Tested-by:
-
Christian Kuhn authored
This currently logs a deprecation entry since LanguageService shouldn't be injected any longer. The property is unused and can be dropped. Resolves: #94438 Related: #94414 Releases: master Change-Id: I2e56982eeb6b33c36de107199293244672b6bf4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69661 Tested-by:
-
Nikita Hovratov authored
The TCA option showRemovedLocalizationRecords was former used to enable showing 'dangling' records (localized records without parent). Because it was subject to a broken db structure, its usage was removed in patch f6f36d3f. But there was still code mentioning this key without using it. A TCA migration removes this option and logs a message which pinpoints the lack of usage. Resolves: #94441 Releases: master Change-Id: I8c32bb845512585a6314d92f8fcafffd959279ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69665 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
