Skip to content
Snippets Groups Projects
Commit c5290640 authored by Oliver Bartsch's avatar Oliver Bartsch Committed by Benni Mack
Browse files

[TASK] Avoid access of global request in view helpers

Since #92826, our own RenderingContext implementation,
available in our view helpers, contains the getRequest()
method, which was introduced to reduce the usages of
ControllerContext. In this patch, the majority of the view
helpers was changed to now access the request from
RenderingContext. Unfortunately, by this time, the extbase
Request was still not PSR-7 compatible. Therefore, some
view helpers still had to access $GLOBALS[TYPO3_REQUEST].

Since #94428, the extbase Request finally implements
the PSR-7 ServerRequestInterface, which now allows us
to replace the global access in the remaining view helpers.

Resolves: #94497
Related: #92826
Related: #94428
Releases: master
Change-Id: I29080cf7fd27fb6e454ae2dee5867f60ae69dd8b
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69733


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarJochen <rothjochen@gmail.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarJochen <rothjochen@gmail.com>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent 8482d77f
No related merge requests found
Showing
with 59 additions and 72 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment