[TASK] Avoid access of global request in view helpers
Since #92826, our own RenderingContext implementation, available in our view helpers, contains the getRequest() method, which was introduced to reduce the usages of ControllerContext. In this patch, the majority of the view helpers was changed to now access the request from RenderingContext. Unfortunately, by this time, the extbase Request was still not PSR-7 compatible. Therefore, some view helpers still had to access $GLOBALS[TYPO3_REQUEST]. Since #94428, the extbase Request finally implements the PSR-7 ServerRequestInterface, which now allows us to replace the global access in the remaining view helpers. Resolves: #94497 Related: #92826 Related: #94428 Releases: master Change-Id: I29080cf7fd27fb6e454ae2dee5867f60ae69dd8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69733 Tested-by:core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php 1 addition, 1 deletion...backend/Classes/ViewHelpers/Link/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php 1 addition, 1 deletion.../backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/MenuItemViewHelper.php 2 additions, 10 deletions...d/Classes/ViewHelpers/ModuleLayout/MenuItemViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php 1 addition, 1 deletion...sext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php 1 addition, 1 deletion.../backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php 1 addition, 1 deletion...t/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php 1 addition, 10 deletionstypo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php 7 additions, 7 deletionstypo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php 1 addition, 3 deletions...ysext/fluid/Classes/ViewHelpers/Format/HtmlViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php 1 addition, 11 deletions...sysext/fluid/Classes/ViewHelpers/Link/EmailViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/EmailViewHelper.php 1 addition, 5 deletions.../sysext/fluid/Classes/ViewHelpers/Uri/EmailViewHelper.php
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php 1 addition, 10 deletions...sext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.php 17 additions, 2 deletions...fluid/Tests/Unit/ViewHelpers/Link/EmailViewHelperTest.php
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/EmailViewHelperTest.php 12 additions, 0 deletions.../fluid/Tests/Unit/ViewHelpers/Uri/EmailViewHelperTest.php
- typo3/sysext/fluid/Tests/UnitDeprecated/ViewHelpers/BaseViewHelperTest.php 11 additions, 9 deletions...d/Tests/UnitDeprecated/ViewHelpers/BaseViewHelperTest.php
Please register or sign in to comment