- Nov 18, 2023
-
-
Benni Mack authored
This change is a prerequisite for splitting some parts within EXT:workspaces into separate parts for further refactoring. Resolves: #102393 Releases: main Change-Id: I6979484148818a46ed7f78ec7010f78321253140 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81745 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
FieldControl is required to set a title. To ensure this, the field control options can now be used to set a custom title. Additionally, a fallback is added to ensure a title is always set, even if a custom TCA type is used and no title is defined, using the FieldControl option. Resolves: #102366 Releases: main, 12.4 Change-Id: Id4b2bbb15d5e1d12fae6dbd287dbdeda7ba5b987 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81746 Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
The raw search in the DB check module now works reliable and consistent with other search functionality in the backend. Therefore the search now uses proper JS to: * Submit the form on browser clear * Monitor search term inputs * Toggling the submit button Additionally, the template got adjusted: * Display of proper info for search with no results * Display of proper info for an empty search * Usage of aria-labeldby * Usage of search icon in combination with the <button> tag for consistency * Resolving duplicated if clauses Resolves: #102394 Releases: main, 12.4 Change-Id: I6a4dd9f23920eb25f4c3cc2817f48a02182a6545 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81764 Reviewed-by:
-
- Nov 17, 2023
-
-
Simon Schaufelberger authored
Remove outdated "max" property. Resolves: #102351 Releases: main, 12.4 Change-Id: Ib64460a53d2dc6c00e45cfa66bf9891df7e08cf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81713 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #102387 Related: #102032 Releases: main Change-Id: Ic8fdf49def718945e3edca08dc40fcef4c48986c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81759 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
- Nov 16, 2023
-
-
Christian Kuhn authored
This patch is paired with the setup of a new CI [1]. The patch adapts runTests.sh to allow podman as container environment next to docker. New CI relies on podman. Locally, podman can be selected as container environment using the `-b podman` flag to runTests.sh. A "recent" podman version - at least around 4.x - should be used. docker is kept as default for now. The new CI setup comes with a series of improvements to speed up things. This makes the acceptance tests a bit more brittle again. The patch comes with some further stabilizations, and we may add even more with dedicated patches later. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/ Change-Id: I206c1577335bfbefb801eaababa4b713e1edda12 Resolves: #102385 Releases: main, 12.4, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80191 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Franzke authored
Backend responses must never be cached. The previously used Cache-Control instruction "must-revalidate" implicitly enabled caching in order to possibly reuse a response. While that could only happen when two requests to the same URL are invoked within one second (because the browsers `If-Modified-Since` header and our `Last-Modified` header match, causing the webserver to issue a 304 response), that is certainly possible in CI setups or fast user clicks. Use `no-store` in order to instruct browsers to not cache and try revalidation at all. Also remove hard-coded acceptance test waiters that were introduced to circumvent this (but only did sometimes because with 0.5s wait time there was still room for two requests within one second). Resolves: #102377 Releases: main, 12.4, 11.5 Change-Id: Ic05cad748f824e7a45a1740aca15cd2fc3595a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81754 Tested-by:
-
- Nov 15, 2023
-
-
Sascha Egerer authored
A "valuePicker" TCA configuration allows to either prepend, append or replace a preset for an input field. While "prepend" and "append" allow to continuously pick and choose elements to be inserted, the "replace" mode is single-use and always resets to a single chosen value. For the "replace" mode it could be helpful to keep the input field in sync with the ValuePicker especially if the value picker as a human-readable representation of the value that is added in the input field. Resolves: #102330 Releases: main, 12.4 Change-Id: I07a8c8ca29877f2a1f580f44ed572280e87dded4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81742 Tested-by:
-
Mathias Brodala authored
Resolves: #102374 Relates: #102140 Releases: main, 12.4 Change-Id: Ib3e1f60080c9e1c7a7839aa2fcb90f9d91d6a4ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81747 Reviewed-by:
-
- Nov 14, 2023
-
-
Oliver Bartsch authored
The enable fields of webhook records are now properly respected. Also the listing in the backend module is fixed, allowing to toggle the disabled state and also displaying the correct record icon (including a possible overlay icon). Resolves: #102341 Releases: main, 12.4 Change-Id: Ib866ce6dbb4524cf85cf6191fb2771e980be028a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81714 Tested-by:
-
Benjamin Franzke authored
See https://github.com/TYPO3/html-sanitizer/releases/tag/v2.1.4 composer req typo3/html-sanitizer:^2.1.4 composer req typo3/html-sanitizer:^2.1.4 \ -d typo3/sysext/core --no-update Resolves: #102169 Releases: main, 12.4, 11.5 Change-Id: I76edb7ff0dc66d3308d5c0875c2db56ca02addd7 Security-Bulletin: TYPO3-CORE-SA-2023-007 Security-References: CVE-2023-47125 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81737 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Franzke authored
Given that there are two sites `site-a.com` and `site-b.com` in the same TYPO3 installation, it was possible to reuse a session cookie that was generated for `site-a.com` in `site-b.com`. Since there are scenarios, where this is the expected behavior – when sharing sessions across sub domains, so that an explicit cookieDomain needs to be configured – user sessions signatures are now salted with the desired cookie domain, so that a cookie can only be used on the domain that the cookie was created for. Testing framework will need to be adapted in a subsequent patch, but for the time being – and for compatiblity with possible 3rd party authenticators – legacy tokens will be accepted, but not created by TYPO3 core. Resolves: #100885 Releases: main, 12.4, 11.5 Change-Id: I0d1c314c6e206ac12604ba6f859af78b958651dd Security-Bulletin: TYPO3-CORE-SA-2023-006 Security-References: CVE-2023-47127 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81729 Tested-by:
-
Markus Klein authored
Using the Install Tool in composer mode, the login displays a hint, where the ENABLE_INSTALL_TOOL file must be placed to unlock the Install Tool. This hint does not show the full path anymore. Only the path relative to the project root is shown. Resolves: #102242 Releases: main, 12.4 Change-Id: I1e9cbfe3ef7d4cc6af9635da71d0c7450fe44aa6 Security-Bulletin: TYPO3-CORE-SA-2023-005 Security-References: CVE-2023-47126 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81736 Tested-by:
-
- Nov 13, 2023
-
-
Torben Hansen authored
Properties in extbase `QueryResultPaginator` do not use strict types. This change introduces strict types for the properties in extbase `QueryResultPaginator`. Since the class is defined as final, the change is not considered breaking. Resolves: #102282 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I1f9ebeb98caae41a88a300a14b2301497ce86b2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81607 Tested-by:
-
Christian Kuhn authored
We're in the process of establishing a new core CI. This has more power and is better optimized. The resulting runtime changes reveal various flaky acceptance tests. Most have been problematic before already, but not as bad. The patch adds various guards to acceptance tests to reduce flakiness. Resolves: #102363 Releases: main, 12.4, 11.5 Change-Id: Iff2c79411b39fffe659c78a8e889f8a804939bc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81720 Tested-by:
-
Sybille Peters authored
TCA fields of type 'slug' can be configured with the property generatorOptions. Particularly, the short form of using a simple array for the fields instead of a nested array is a common source of confusion and the initially introduced changelog had incorrect examples. The changelog is improved as follows - Fix the examples. The examples 2 and 3 showed incorrect results - Use the multidimensional array in the source snippet - Clarify that ['nav_title', 'title'] is the same as [['nav_title'], ['title']], but not the same as [['nav_title', 'title']] Resolves: #89390 Releases: main, 12.4, 11.5 Change-Id: Ib1944c2a1eb9e2a69a0f169f316208cf46f9be84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81723 Reviewed-by:
-
Christian Kuhn authored
In AC tests it appears that popover instances are not available, either because the DOM isn't ready yet, or the element got removed meanwhile, leading to AC test failures. As a safety net, popover instances are now checked for not being `null`, and a warning is logged in the console. Also, the `@typo3/backend/context-help` module now waits for a ready DOM and only takes elements into consideration that existed on initialization time. Resolves: #102368 Releases: main, 12.4 Change-Id: Icffc6f7e144881ded56910d7cb6f75b80f9752e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81724 Tested-by:
-
Patrick Schriner authored
Resolves: #102358 Releases: main, 12.4 Change-Id: I6bab163fea7b186d1da713a764678d9a885122bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81715 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
- Nov 10, 2023
-
-
Thomas Hohn authored
If a HMAC cannot be `json_decode`d (possibly due to old saved pages or other outdated content), now a proper exception is thrown instead of issuing a PHP warning. Resolves: #97337 Releases: main, 12.4, 11.5 Change-Id: I12f5633a85508bf4099d72e474c24b5a0100498c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78002 Reviewed-by:
-
Benjamin Franzke authored
The bootstrap jQuery interfaces required a global window.jQuery variable to be set. The jquery drop-in is dropped in order to remove this non-optional jQuery dependency. As a side effect the window.jQuery global is removed as well. Note that global jQuery usage has already been deprecated in #86438 and removed in #97243 with the suggestion to use JavaScript modules instead. window.jQuery was basically left in place for bootstrap to operate and therefore only `window.$` was removed back then, while `window.jQuery` stayed for the time being. Resolves: #101820 Related: #97243 Related: #86438 Releases: main Change-Id: I6b46ceb3e3e3e3cf892925c4442255febdfb5a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74055 Tested-by:
-
- Nov 09, 2023
-
-
Patrick Schriner authored
Resolves: #102350 Releases: main, 12.4 Change-Id: Ieb5f0b952bb647b02fc3dff183f744b8f8cfd1f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81711 Tested-by:
-
Achim Fritz authored
The page types section of the Compare User View now displays the correct record type icon, which is already resolved from the record type items definition. Additionally, a fallback is added to prevent a possible undefined array key warning. Resolves: #102338 Releases: main, 12.4 Change-Id: I405b1933d01c1691fdcc10c15b323f92757365ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81701 Reviewed-by:
-
- Nov 08, 2023
-
-
Benni Mack authored
This change cleans up GifBuilder class further by adding types to all internal or protected methods. In addition, some cleanups are done: * Renaming of `$OFFSET` to `$offset` * Remove superfluous checks of `is_array()` Resolves: #102347 Releases: main Change-Id: I7888a4240f7702e3177011847f6c63a587c40c2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81705 Tested-by:
-
Andreas Kienast authored
Exected commands: npm install --save cropperjs@^1.6.1 npm run build Resolves: #102333 Releases: main, 12.4 Change-Id: I9be75686cb974a8c4288153e414bbbf2cc696859 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81699 Reviewed-by:
-
- Nov 07, 2023
-
-
Xavier Perseguers authored
When $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale'] is empty, a call to setlocale() may lead to a PHP crash. Resolves: #102343 Releases: main, 12.4 Change-Id: Icbb9d0118327c0303ae6d3fc98e1cbecfb704877 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81704 Tested-by:
-
Benjamin Franzke authored
The jquery interface $().carousel() has an implicit dependency on jquery being loaded, whenever bootstrap is loaded. To get rid of jquery, we migrate to the newer vanilla js interface. Resolves: #101821 Related: #101820 Releases: main Change-Id: I0426676fc00fd765bf21095f7dfeb2ed78614839 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80816 Reviewed-by:
-
Andreas Nedbal authored
Resolves: #101872 Releases: main Change-Id: I5b77bb2d7dacd18bb90002f50d710a3b3d5a4b52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80922 Reviewed-by:
-
Benjamin Franzke authored
With #99503 `cObjGet()` was implemented as a wrapper around the strictly typed cObjGetSeparated method, effectively enforcing the first argument to be an array, while previously non array values were returned as an empty string. Resolves: #102328 Related: #99503 Releases: main, 12.4, 11.5 Change-Id: I7c04307f14da5a93e12672b36de163071dad7359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81698 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
-
Andreas Kienast authored
When implementing #101912, a few case where FormEngine field validation is triggered with jQuery objects were overseen, triggering deprecation warnings. This patch fixes the remaining occurrences. Resolves: #102325 Related: #101912 Releases: main Change-Id: I22661a60e75d4d88bff652d640bc7a4ea46eca87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81694 Reviewed-by:
-
Benjamin Franzke authored
Symfony's AsCommand attribute encodes `hidden = true` into a trailing `|` for the name attribute. Drop that for our command list and mark the command as hidden in the command registry. Resolves: #102292 Related: #101567 Releases: main, 12.4 Change-Id: I6415e3f5525764aab336bab20432c032e0665632 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81617 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Nov 06, 2023
-
-
Imko Schumacher authored
Special characters (e.g. ") in argument labels of console commands are no longer displayed as HTML entity ("). Resolves: #102317 Releases: main, 12.4 Change-Id: Icd3c19e94002113823117f1666503ae277283d40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81685 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #102307 Releases: main Change-Id: Ie123eb853c34ad6bc451e29a73788787bffaf862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81672 Reviewed-by:
-
Torben Hansen authored
Function arguments for `addErrorForProperty()` in Extbase `AbstractValidator` do use PHP native types, so several typecasts in the function are not required any more. Resolves: #102321 Releases: main, 12.4 Signed-off-by:
-
Fabio Norbutat authored
This change use the correct variable to assign view variables in one example in WidgetImplementation.rst. Releases: main, 12.4 Resolves: #102318 Change-Id: I601d2589ec3a44ab77d8548d507b20969d4e11b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81688 Tested-by:
-
Fabio Norbutat authored
Invalid char encoding has slipped into an yaml example snippet for ext:dashboard. This change use the correct quoting to fix this. Releases: main, 12.4, 11.5 Resolves: #102319 Change-Id: I3dd2fd7a1aec51ad3f1ace7c6b914371e9e12342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81689 Tested-by:
-
Chris Müller authored
Resolves: #102284 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/297 Related: #99308 Releases: main, 12.4 Change-Id: Ia6035bce975eab7978348f4a027e8e1af21c30b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81608 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to the latest version and fixes one issue within `RedisSessionBackend` where the Redis API claims to return a `\Redis` object when calling `->del()`. This indicates a usage of multi mode, where the delete state cannot get determined. Also, multi mode is not supported by our session backend, therefore we handle this case as "not successful" now. Executed command: composer require --dev phpstan/phpstan:^1.10.41 -W Resolves: #102320 Releases: main, 12.4 Change-Id: I6f4edb746c6e23d92d5147cc7c711d8da0309f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81690 Tested-by: -
Jonas Eberle authored
This adds a line break between concatenated "inline" JavaScripts in order to keep JavaScript without trailing ';' valid. Resolves: #99503 Releases: main, 12.4, 11.5 Change-Id: Icf902679c715687c5be2e5f572526608ce31f882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77320 Reviewed-by:
-
Andreas Kienast authored
Resolves: #102305 Releases: main Change-Id: I3ce5dec038c93e8d0b8aa690396ece0adca875e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81647 Tested-by:
-
Andreas Kienast authored
The FormEngine feature that shows the amount of remaining characters that fit in a field has been extracted from the `@typo3/backend/form-engine` god module into a separate Lit element. Also, the `badge-*` classes are migrated to `text-*` to have a lot less "bulky" UI. Resolves: #102273 Releases: main Change-Id: I2f87d656ded8f31d9569762d3d68d2f46d861b69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81596 Tested-by:
-
