[BUGFIX] Verify Popover instances before usage
In AC tests it appears that popover instances are not available, either because the DOM isn't ready yet, or the element got removed meanwhile, leading to AC test failures. As a safety net, popover instances are now checked for not being `null`, and a warning is logged in the console. Also, the `@typo3/backend/context-help` module now waits for a ready DOM and only takes elements into consideration that existed on initialization time. Resolves: #102368 Releases: main, 12.4 Change-Id: Icffc6f7e144881ded56910d7cb6f75b80f9752e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81724 Tested-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- Build/Sources/TypeScript/backend/context-help.ts 3 additions, 2 deletionsBuild/Sources/TypeScript/backend/context-help.ts
- Build/Sources/TypeScript/backend/popover.ts 20 additions, 11 deletionsBuild/Sources/TypeScript/backend/popover.ts
- typo3/sysext/backend/Resources/Public/JavaScript/context-help.js 1 addition, 1 deletion...ysext/backend/Resources/Public/JavaScript/context-help.js
- typo3/sysext/backend/Resources/Public/JavaScript/popover.js 1 addition, 1 deletiontypo3/sysext/backend/Resources/Public/JavaScript/popover.js
Please register or sign in to comment