- Dec 10, 2021
-
-
Benjamin Franzke authored
Adapt testing changed in #96244. Resolves: #92859 Resolves: #92750 Related: #96244 Releases: main Change-Id: I0f0a4d5423eb22f674342ead62d56ef7d720f397 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72630 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benjamin Franzke authored
This file has been introduced in #94622 by accident (probably a left-over from a previous patchset). It is unused and no sources are present, therefore this file is removed. Releases: main, 11.5 Resolves: #96331 Related: #94622 Change-Id: I39d79fe560b9b1b5b8b640addba3a3bb26868a75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72625 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benjamin Franzke authored
The .done() Promise polyfill has been removed in #96263, therefore .then() needs to be used on promised. Also adapt the return type declaration in the global type declarations file. Resolves: #96328 Related: #96263 Releases: main Change-Id: Iba53393076285db1709ac3980eeb434862ee2952 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72618 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
TYPO3 has had a long history of linking to other pages in other pagetrees. Most of the issues were solved with the TYPO3 v9 Routing and Site Handling. Through this feature, it is now possible to easily create a page of type shortcut and link to a page in a different page tree. This was previously not possible because TYPO3 Core by default generated URLs like "/index.php?id=123" where people could simply add ?id=355 (where page 355 resides on a different page tree). Since this change has been resolved, links to other pages can be allowed and are automatically redirected. If we ever get rid of allowing to call pages with an `?id=123` query parameter, the $pageNotFound=3 case can be removed completely. Resolves: #92859 Resolves: #92750 Releases: main, 11.5 Change-Id: I16ccc3e5b0ccb1419ccd2a8d78443616e7627a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70432 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benni Mack authored
The TypoScript option "page.pageHeaderFooterTemplate" is removed. It was introduced in TYPO3 4.5, but never documented, and is actually overridden by the option "config.pageRendererTemplateFile" which IS documented, which was also introduced during TYPO3 4.x times. Both options behave the exact same way. Resolves: #96322 Releases: main Change-Id: Ifeec8faec7f28121f3135838bcaa82cac461cb60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72612 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
In #96318 the call to `$backendUser->start()` was removed in OpenDocumentService. This then led to an exception, in case a not fully initialized backend user object is used to call `getModuleData()`. This is fixed by no longer using an own backend user instance, but instead accessing the already initialized global object. Resolves: #96330 Related: #96318 Releases: main Change-Id: Ic887df324b2cea4eb79c48f4a50e2be28d8f0774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72623 Tested-by:
-
Helmut Hummel authored
To decide whether an error should be handled by the ErrorHandler or not, only three things must be taken into account. 1. The current error_reporting() level 2. Error levels that are ignored by configuration 3. Error level of the error that is just handled When combining the first two (with logical and), results in the error level for the errors that should be handled at all. When combining this with the error level of the currently handled error (again with logical and), we can determine wether the error should be handled or not. This always works with any PHP version and with suppressed errors and without. Therefore the PHP version check becomes obsolete and is removed. Releases: main, 11.5 Resolves: #96311 Change-Id: I96d440d9db05a3acf1f8a12664787e05a3e31254 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72603 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Albrecht Koehnlein authored
Make HTML parser more tolerant for single tags with ending slash but without white spaces. So `<hr/>` already was allowed and internally converted to `<hr />` while parsing the HTML. This patch extends this replace rule to all tags so that also `<br/>` can be used in RTE fields. Resolves: #96307 Releases: main, 11.5, 10.4 Change-Id: I7ba6c88e35804c6b5f991fb6b730fbc3d7a2514e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72597 Tested-by:
-
Oliver Bartsch authored
Installations in composer mode should always rely on the corresponding mechanisms for installing extensions. As consequence, all extensions, manually placed in `typo3conf/ext`, are no longer evaluated. Resolves: #96304 Related: #94996 Releases: main Change-Id: Ic25a7d69c564771cabbb5c240b010161f4b0aca6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72592 Tested-by:
-
Rémy DANIEL authored
If TSFE->set_no_cache is called, either a warning or a notice is triggered, depending if a BE user is connected or not. With this change, the preview mode will trigger a notice instead of a warning. This restores the same behaviour than before #86002. Resolves: #96306 Releases: main, 11.5, 10.4 Change-Id: I40b9b1d90d42f14de2977aca61c24a9fd698ced0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72596 Tested-by:
-
Benni Mack authored
The abstract AbstractTypolinkBuilder class change now requires all subclasses to require a LinkResultInterface. Resolves: #96317 Related: #94889 Releases: main Change-Id: Ic914373fe3ca744a4b96cf470d44f3abae5df6d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72611 Tested-by:
-
Benni Mack authored
This change introduces strict types for the TimeTracker class and its properties, and removes the legacy logging options in favor of PSR-3 LogLevels. Resolves: #96319 Releases: main Change-Id: Ifbd1366dee53ab34290c9f16d00d57b0c2a81926 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72602 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Dec 09, 2021
-
-
Benni Mack authored
This change modifies various places to always have a valid PSR-7 Request object handed in. Previously this was optional as part of the backwards-compatibility in TYPO3 v11. Resolves: #96318 Releases: main Change-Id: Idf46dec219cdbbdc97fbe745240770b364ecb38b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72601 Tested-by:
-
Benni Mack authored
Any database changes are now logged as info (same as clearing caches and changing file handling). Resolves: #96316 Related: #94433 Releases: main, 11.5 Change-Id: I22daefc7111eb9abdafa2f66c1d21b2fbfcaf011 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72608 Tested-by:
-
Nikita Hovratov authored
Due to dependencies to a TypeScript @types package for Sortable.js, the name to access this module had to be renamed. This patch removes the old name. Resolves: #96313 Related: #93454 Releases: main Change-Id: I0d5cf353cd93065e5a2b92c7578df30cacdbf940 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72606 Tested-by:
-
Helmut Hummel authored
Fix condition that checks the extension type, to only re-throw the exception when an extension does not define an extension key. Resolves: #96276 Releases: main, 11.5 Change-Id: Iacc0680f21cd3daa2f049f5ccfd25ea6d44bf241 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72600 Tested-by:
Altan Tosun <a.tosun@gmx.de> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Fabio Norbutat authored
a small typo in the "number range validator" section has been fixed. Releases: main, 11.5 Resolves: #96312 Change-Id: I3539129f2534bfb87bae55ee37b37e0543b13faa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72604 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Bartsch authored
The JavaScript for adding `linkTo_UnCryptMailto` to the `window` got obsolete with the removal of the f:uri.email ViewHelper and is therefore now removed. Resolves: #96202 Releases: main Change-Id: I7c958c6ad80fb654efae52c50afa73fe1786df5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72593 Tested-by:
-
Alexander Schnitzler authored
Calling \TYPO3\CMS\Extbase\Utility::configurePlugin(), \TYPO3\CMS\Extbase\Utility::registerPlugin() and \TYPO3\CMS\Extbase\Utility::registerModule() with first parameter $extensionName containing a vendor prefix like 'Vendor.ExtensionName' is deprecated since version 10 and will now fail. Controller classes must be registered with their fully qualified name. The vendor prefix must be ommitted. It's possible to simplify and streamline extbase bootstrap and request handling a bit more. This will continue with other patches. Releases: main Resolves: #96047 Related: #87550 Change-Id: If98f2f5a048fd9e62373490c23ee5b117ffd2534 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66219 Tested-by:
-
Oliver Bartsch authored
In favour of allowing content-security-policy headers, all single field configurations in user settings, dynamically creating inline JavaScript, are now removed. Resolves: #96303 Related: #91132 Releases: main Change-Id: I55ef6cf77678c1854d859666cbca735847aceffc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72571 Tested-by:
-
Oliver Bartsch authored
The DateTimePicker does no longer initialize fields, which define the `t3js-datetimepicker` class, automatically. This must be done by passing the corresponding `HTMLInputElement` to `DateTimePicker.initialize()`. Resolves: #96293 Related: #91606 Releases: main Change-Id: Ibec038c24fc8205bafd706875b98f900e36eb7c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72561 Tested-by:
-
Christian Kuhn authored
This patch removes a series of unit tests from the test sets that are often either skipped or flaky. * There is little point in testing chmod() / chgrp() operations of low-level methods. That's a system thing we shouldn't test in detail. * Some tests have been marked as "i'm mocking too much, make me a functional test". Most of these are oooold. Don't read it, delete it. * Some phpunit @requires annotations have been broken since introduction and always resulted in "skip test". Remove those. Change-Id: I82e04613c9b72712e279d0819ada8e073658968d Resolves: #96301 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72567 Tested-by:
-
Benni Mack authored
The database abstraction layer Doctrine/DBAL 3.2 is now used throughout TYPO3 Core. Some class names have changed, the original Doctrine\DBAL\Result interface is now an object which is used in TYPO3 Core. Our internal drivers are now wrappers around PDOStatement instead of extending PDO's internal APIs. > composer req "doctrine/dbal:^3.2" -W Resolves: #96287 Releases: main Change-Id: I817dbcddf6406e44c94abcd25b3eb805032aec68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72372 Tested-by:
-
linawolf authored
Resolves: #96302 Releases: main Change-Id: I96406ddf735b33dd773d8bf0b89c0ffeffcc4ae3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72568 Tested-by:
-
Oliver Bartsch authored
\Serializable was removed from CollectionInterface. The corresponding @deprecated annotation is now removed, too. Resolves: #96272 Releases: main Change-Id: Ia2001345c90517b29837b68cc8c0ed1099f858f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72569 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
The feature `runtimeDbQuotingOfTcaConfiguration` is now always enabled. This as a consequence also removes db connections before TCA is loaded, which is required since #96291. Resolves: #96300 Related: #96291 Related: #94697 Releases: main Change-Id: Ib91701adf451a3475da41eb5520ec7932115a253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72566 Tested-by:
-
Christian Kuhn authored
ext:extbase/Tests/Functional/Fixtures/Extensions/blog_example has been derived from the blog_example extension that has been used as a documentation example on how to do extbase based extensions. Nowadays, this test extension in the core hasn't much to do with the blog_example anymore ... the full set has never been merged, a lot of stuff is missing and various test related things have been added. The patch removes a bit of unrelated and outdated stuff from this fixture extension. Another patch may then rename the extension to clearify this one is just test related and not the real thing. Resolves: #96299 Releases: main Change-Id: I35ad26c5d1cc79c92b7898104bf98b33db0ddea3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72565 Tested-by:
-
- Dec 08, 2021
-
-
Oliver Bartsch authored
In favour of allowing content-security-policy headers, inline JavaScript invocation via `AbstractControl::setOnClick` is now removed. Resolves: #96296 Related: #91814 Releases: main Change-Id: Ie8f6ea3911ab682c9f4be0590b4f4183ef656135 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72563 Tested-by:
-
Oliver Bartsch authored
Using onChange callbacks in FormEngine was removed with #96158. This removes a left over. Resolves: #96158 Releases: main Change-Id: Ibcd44c3c40012a0d2031d6e6b278667c26b230a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72557 Tested-by:
-
Helmut Hummel authored
Allow composer installers ^4.0 and also enforce some constraints that could be violated with the new installers. 1. Do not allow duplicate extension keys Multiple packages could define the same extension key. When all extensions are then installed in vendor folder, there won't be any conflicts on the file system, so an exception is now thrown to make people aware of this misconfiguration. 2. Throw an exception if extensions of type typo3-cms-extension do not define an extension key Actually this exception is thrown in the installers package, but the artifact builder must propagate this exception to ensure it reaches the users. composer req typo3/cms-composer-installers:"^2.0 || ^3.0 || ^4.0" composer req typo3/cms-composer-installers:"^2.0 || ^3.0 || ^4.0" \ --no-update -d typo3/sysext/core/ Resolves: #96276 Releases: main, 11.5 Change-Id: Ib76e829f09dbf095fb01031389e301c6e7742103 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72546 Reviewed-by:
-
Helmut Hummel authored
Convert the deprecation that was introduced in TYPO3 11 into an exception. Also remove the now obsolete boot state "done" and make sure boot state "complete" is always set before ext_tables.php are loaded. The latter wasn't the case when using BootService, all other boot types already allowed database and cache manager access in ext_tables.php files. Releases: main Resolves: #96291 Related: #94979 Change-Id: Ic9514517f4123921c89aa8c523afbbfc1f930fb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72558 Tested-by:
-
Christian Kuhn authored
ExtbaseRequestParameters is the old extbase request, now a PSR-7 attribute. To continue with refactorings in related areas, the @internal attribute is now hardened with proper type hints and return values. The properties receive some documentation love to finally have a place where all the different state is documented including some hopefully meaningful examples. Resolves: #96292 Releases: main Change-Id: I731aac221d804d56a3efe67de9eac65f785b5ab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72559 Tested-by:
-
Christian Kuhn authored
There are two QueryInterface methods marked with @todo "See if we can get rid of these" for a very long time. It doesn't look feasible to get rid of QuerySettings any time soon, the construct will survive for the time being and may only be tackled when we have a broader look at the extbase query logic. Remove the todos. Resolves: #96295 Releases: main Change-Id: I5b57774b17ddebc0ecb6754b43e239880f631e4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72562 Tested-by:
-
Jochen Roth authored
In #96158 ac tests have been adapted to the current state but accidentially removed the fix for the splitter. The code for the splitter has been added again. Resolves: #96158 Releases: main Change-Id: I1c884a83d4e7c5e5b40e29fd1924cd93249b3597 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72560 Tested-by:
-
Oliver Bartsch authored
The global JavaScript variable `top.fsMod` is superseded by the ModuleStateStorage component and therefore now removed. Resolves: #96289 Related: #94762 Releases: main Change-Id: I366e6ea72f9f8789942e60c8bbac37f13667bcc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72556 Tested-by:
-
Oliver Bartsch authored
Due to the introduction of URL rewrites for backend links in #93048, the `route` parameter got superfluous and is therefore no longer added to backend urls. Resolves: #96281 Related: #93048 Releases: main Change-Id: Ibbbea03873fa955be5fd0113ca37bf9821aabfcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72552 Tested-by:
-
Oliver Bartsch authored
The extTablesPostProcessing hook was migrated to a PSR-14 event and is therefore now removed. Resolves: #96280 Related: #95065 Releases: main Change-Id: Ic4f472637e6cd026d4d75312e00a59848fac2b76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72550 Tested-by:
-
Jochen Roth authored
Some acceptance tests did not run in CI due to the splitter not taking tests without doc comments into account. Theses tests have been adapted to work with the current state. Resolves: #96284 Releases: master, 11.5 Change-Id: I3b37f8678ef60fe654464b423865e654cfb69577 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72554 Tested-by:
-
Christian Kuhn authored
Extbase "switchable controller actions" have been deprecated with core v10. They are removed now. Resolves: #96282 Related: #89463 Releases: main Change-Id: Id3108bc2f75e7675a36d6b97d12d06c05a17431e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72553 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Benni Mack authored
This change adds the new createSchemaManager() to our Doctrine DBAL Connection subclass to make it forward-compatible with Doctrine DBAL 3.x. createSchemaManager() is introduced with DBAL 3.x and is replacing getSchemaManager() which will be removed in Doctrine DBAL 4. Since this is a very lowlevel change, the method can be added without most notice for extension authors. Resolves: #96286 Releases: main, 11.5 Change-Id: Ifdccc2b0dff443bfe38d23a1bd1333b5c7c5db40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72551 Tested-by:
-
