- May 25, 2022
-
-
Oliver Bartsch authored
If a table in recordlist only contains records which do not provide a checkbox, the "toggle all" action should be disabled as well, since using this action would have no effect. Resolves: #97685 Releases: main, 11.5 Change-Id: Id87bb5dd9df10c33acd03d0c5dbca179bb7f1cdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74744 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Ensure to properly typecast optional parameters of throwStatus() before passing them to type hinted methods. Resolves: #97666 Releases: main, 11.5 Change-Id: Ifb6d43cffc97899cdd4ab72d48703bc3db23f0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74756 Tested-by:
-
Oliver Bartsch authored
When creating bookmarks to the "new" view in FormEngine, those bookmark previously did not show up in the toolbar list, because the parent page access check failed. This is now fixed by also resolving the parent page for new record bookmarks properly. Additionally the shortcut title for those use cases does now match the title, displayed in FormEngine. Resolves: #97655 Releases: main, 11.5 Change-Id: If62391bffe4126c746b6c5650d1aa9d0821f2960 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74741 Tested-by:
-
Oliver Bartsch authored
Occurred on accessing the record history for records on pid=0. Resolves: #97682 Releases: main, 11.5 Change-Id: I041fd9c2dfa8f8cfda4f89c47d320e5bfa6e7f3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74734 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Larry Garfield authored
The code in ConjunctionValidator can be greatly simplified by taking advantage of the fact that an empty result object can be merged with a future one. That eliminates an unnecessary code path as well as phpstan warnings. Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97623 Releases: main, 11.5 Change-Id: I6f10c25562044adb5cbe283255ea07e71effa9cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74740 Reviewed-by:
-
Helmut Hummel authored
When generating the identifier for the package artifact, not only the hash from the composer.lock must be taken into account, but also whether packages have been installed in dev mode or not. Since dev mode does not change the lock hash, it otherwise can happen that a stale DI cache with invalid set of packages is used, which obviously leads to fatal errors Releases: main, 11.5 Resolves: #97688 Change-Id: I29461c133a866fcbf16848a4540eef33aa52d450 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74755 Reviewed-by:
-
Simon Schaufelberger authored
GIFBUILDER processing doesn't return a processedFile Resolves: #97651 Releases: main, 11.5 Change-Id: I24964ec640636dc88b10a5433517bed0ce576ed0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74754 Tested-by:
-
- May 24, 2022
-
-
Rudy Gnodde authored
Resolves: #97686 Releases: master, 11.5 Change-Id: I0228126e4b7dd091b6eddc70bbbd8aade6142dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74753 Tested-by:
-
Torben Hansen authored
This patch fixes a typo in the description for BE.compressionLevel. A single `s` is missing in `_.htacces` Resolves: #97683 Releases: main, 11.5 Change-Id: I6ceab51140c8cad68d724cb13b5947d1ea38dba1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74752 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- May 23, 2022
-
-
Christian Kuhn authored
A couple of left overs from a phpunit 8 compat layer. They can be safely removed since v12 and v11 require phpunit 9. Resolves: #97680 Related: #94706 Related: #92461 Releases: main, 11.5 Change-Id: I4815c631fe2903d67a1f15591cca3a4fa6de3338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74726 Tested-by:
-
Stefan Bürk authored
Update testing-framework to incorporate latest changes. Some phpstan-baseline ignore-patterns are added and will be addressed with dedicated patches. This change is a manual backport of #97677. Used commands: > composer req typo3/testing-framework:^6.16.5 --dev > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97679 Related: #97677 Releases: 11.5 Change-Id: I4decfc4ceb9bacc59e81669443dd4a06ed1b0a72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74724 Tested-by:
-
Oliver Klee authored
The new version finds some new possible bugs and removes some incorrect ones. Used commands: > composer req --dev phpstan/phpstan:^1.7.0 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97678 Releases: main, 11.5 Change-Id: I0359ab80b0a6afc907f76bee328fb32c1e0655b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74723 Tested-by:
-
Stefan Bürk authored
Raise phpstan to include latest phpstan bugfixes. See: https://github.com/phpstan/phpstan/releases/tag/1.6.9 Used commands: > composer req phpstan/phpstan:^1.6.9 --dev > Build/Scripts/runTests.sh -s clean ; \ Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97668 Releases: main, 11.5 Change-Id: I61298c1696b14a6e89ddc98043de13acb127c6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74720 Tested-by:
-
- May 20, 2022
-
-
Larry Garfield authored
These values are already nullable according to the code, so document that. Resolves: #97656 Releases: main, 11.5 Change-Id: Ic1411e565d056d29febfb6a4af6a8ab1506a8189 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74690 Tested-by:
-
Simon Schaufelberger authored
H needs to be used because the datepicker is in 24h mode and i stands for minutes with leading zero Resolves: #97650 Releases: main, 11.5 Change-Id: Id3e37fdf08f34eda8b9e2a40e877e611996c2404 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74689 Reviewed-by:
-
Torben Hansen authored
It is possible to register a dedicated icon for a plugin in ExtensionUtility::registerPlugin(). This icon is used in the plugin select field, but not for the content element preview where always a default icon is shown. With this change, a possible configured plugin icon is used in content element preview, if the icon is registered using the TYPO3 icon API. Additionally the indexed_search plugin now uses 'mimetypes-x-content-form-search' as plugin icon. Resolves: #97635 Releases: main, 11.5 Change-Id: I8e688c7e4c75f92c35f9f82f32b8434d44829e05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74697 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Larry Garfield authored
ftok() doesn't return false, but -1 on error. The $resource property may be null to indicate no lock is active, so allow that. Resolves: #97644 Releases: main, 11.5 Change-Id: I88eb20b2399c119390c7e6c34c985a87706db4d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74696 Tested-by:
-
Christoph Lehmann authored
This displays the total time spend for sql queries and the total amount of sql queries in the Admin Panel. Resolves: #97493 Releases: main, 11.5 Change-Id: I4167ca6c85e6b6bb71f5b2f3682c39d44f26e6f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74698 Tested-by:
-
- May 19, 2022
-
-
Sybille Peters authored
The note about jumping to a previous version of the page is obsolete, because you can switch no further than version 8.7 with the version selector and the older version is in v7.6. In any case, if someone needs the information for version 7.6 and below they must use other means anyway (e.g. use Git repository and render locally) since these older versions are no longer rendered on docs.typo3.og. Resolves: #97632 Releases: main, 11.5, 10.4 Change-Id: Iedbb482c4086ed4740410acc3c6e82f47607ec52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74695 Tested-by:
-
Stephan Großberndt authored
Use the correct middleware name 'typo3/cms-frontend/authentication' in the changelog instead of referring to a non-existing name. Releases: main, 11.5, 10.4 Resolves: #97660 Change-Id: I5ebb586689f3173e1cc2a06049fd4b4d40430972 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74693 Tested-by:
-
- May 17, 2022
-
-
Oliver Klee authored
This helps static analysis. Resolves: #97631 Releases: main, 11.5 Change-Id: If06aea0d310fa56333d93c99f1400db8d74706fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74692 Reviewed-by:
-
Larry Garfield authored
Mostly these are due to SimpleXML not casting cleanly to strings, so making the casts explicit resolves them. Resolves: #97643 Releases: main, 11.5 Change-Id: I036ba8bf08d2a96f5f58b352b82991eeadded990 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74672 Tested-by:
-
- May 16, 2022
-
-
Oliver Klee authored
This is only possible with PHPUnit, not with Prophecy, and it is bad practice as there is no way to do type analysis on classes that do not exist. Also avoid using mocks where an `stdClass` instance does just fine. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97634 Releases: main, 11.5 Change-Id: I2a92678a60df7bd762688e3b7571b18f861340d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74621 Tested-by:
-
- May 13, 2022
-
-
Larry Garfield authored
There are several PHPStan Baseline exceptions for misuse of the ?? operator. Many of them are no longer necessary thanks to either other code evolution or PHP evolution. This patch cleans those up. Resolves: #97456 Releases: main, 11.5 Change-Id: I47c23157398e80eb63e17455f820df3a6d756724 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74619 Tested-by:
-
Oliver Klee authored
Resolves: #97425 Releases: main, 11.5 Change-Id: Ie3679f8a0f51ee2000ce45dfab1ea82bdc67c0ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74618 Tested-by:
-
Oliver Bartsch authored
Resolves: #97619 Releases: main, 11.5 Change-Id: Ib1812d04264cab9bf867891f8cc06d7dafeace99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74617 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
Jochen Roth authored
Currently, only SysFolders are excluded in the SiteConfiguration overview which allows to add a SiteConfiguration to pages where it is superfluous. This has been fixed by adding doktype spacer, recycler, external link to the list of excluded doktypes in the queryBuilder statement. Resolves: #97609 Releases: main, 11.5 Change-Id: Idfb5a97c8780117b5b478c14e0d2e2946dfbca8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74639 Tested-by:
-
- May 12, 2022
-
-
Česlav Przywara authored
Also fixes a non-existing link that is generated: https://forge.typo3.org/issues/#93436 becomes https://forge.typo3.org/issues/93436 Releases: main, 11.5 Resolves: #97617 Change-Id: Ic30261223d0cbe5d48a2e88fa87713ba3a698db2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74616 Tested-by:
-
rintisch authored
The screenshots of the UI shows the word `Levels` while the text used `Layers`. Releases: main, 11.5 Resolves: #97613 Change-Id: Ib539d01496d83c6eef65683aeac306302ed5b9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74615 Tested-by:
-
Christian Kuhn authored
TCA ctrl title for tx_blogexample_domain_model_dateexample and tx_blogexample_domain_model_dateexample is set to not existing field 'title'. Use uid instead. Resolves: #97615 Releases: main, 11.5 Change-Id: Ie11a0c6771f2ec2e840a2cc86b66b162519c6c2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74614 Tested-by:
-
- May 11, 2022
-
-
Christian Kuhn authored
Brings a multibyte fix when dealing with word-based diffs, which is our default usage. composer req lolli42/finediff:^1.0.1 Resolves: #97611 Releases: main, 11.5, 10.4 Change-Id: I601842ed75917f9a6d438191273e602238d3edda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74606 Tested-by:
-
- May 10, 2022
-
-
Georg Ringer authored
Resolves: #97592 Releases: main, 11.5 Change-Id: I95246d9720609e138d19bb8e60ad4ebcfe23564a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74613 Tested-by:
-
David Gurk authored
If a TypoScript sub-template is missing, because it is disabled, it is necessary to check for the existence. Resolves: #97601 Releases: main, 11.5 Change-Id: Iaca27df294f4c3c3ea890defc4ccd3b5b6feb671 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74612 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: If249fa2af484ba4582d3f850062c25c0433b7858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74597 Tested-by:
-
Oliver Hader authored
Change-Id: I8bd3e7ec4fce5774412920a93f297fb94178d090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74596 Tested-by:
-
Christian Kuhn authored
A series of minor TF fixes, nothing fancy. composer req --dev typo3/testing-framework:^6.16.4 Change-Id: I3b8fcec5d16398ba0b1b88379c3dc54b129252d3 Resolves: #97600 Releases: 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74592 Tested-by:
-
- May 09, 2022
-
-
Christian Kuhn authored
We restricted the default retry of single jobs a while ago to do that only for acceptance test related jobs. This does not work out well: There are simply to many things that occassionally false-negative due to network, timing or other issues. The patch adds general retry:1 for all jobs for mental sanity. Resolves: #97597 Related: #96999 Releases: main, 11.5 Change-Id: I408b7ef1b6c6145dc1b5b12bc4550c00dfdaa930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74585 Tested-by:
-
Nikita Hovratov authored
Not all tables have tstamp defined in their ctrl section. Resolves: #97588 Releases: main, 11.5 Change-Id: Ibddaab2e313bc2511b1f9aa903ed312d3cf7f9bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74556 Tested-by:
-
Oliver Klee authored
This helps avoid breakage when GeneralUtility will switch to strict mode. Resolves: #97579 Relates: #97578 Releases: main, 11.5 Change-Id: I813075a74805b72781a493278e45aa1e9a1e2cc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74555 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- May 08, 2022
-
-
Oliver Klee authored
In tests for `GeneralUtility` that explicitly violate the contract (and test the correct error handling in those cases), PHPStan errors about the contract violation are not helpful and rather clutter the PHPStan baseline. So these errors are now silenced with an annotation in the corresponding tests, allowing us to focus on PHPStan errors about actual issues. Note: We only use this annotation in tests, not in production code, to avoid silencing errors about actual problems. Resolves: #97574 Releases: main, 11.5 Change-Id: I2586dd77a4e3f9d801e24af68ab29984ad8d02c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74551 Tested-by:
-
