- Apr 18, 2023
-
-
Helmut Hummel authored
Extbase ConfigurationManager as stateful singleton object is updated within extbase bootstrap for each plugin call. This is ugly, but since ConfigurationManager can be injected to other extbase services, which can be injected itself, it is very hard to get rid of. However, ConfigurationManager is also abused to "park" the current ContentObjectRenderer instance in this "convenient" singleton. The current content object renderer instance can then be retrieved at extbase runtime using getContentObject(). The form extension uses this at a couple of places to move the ContentObjectRenderer data around. The ConfigurationManager should however not be a source of such data, and our main "state" object in the framework is the request (which ConfigurationManager needs as well, but that's a different patch). To allow a deprecation of getContentObject() in ConfigurationManager, the patch changes the codebase to attach the current content object as request attribute instead. This is a bit fiddly as well since ContentObjectRenderer can be recursive (cObj rendering other cObj again), but the change at least makes this state more obvious, and we're pretty confident the situation will further relax and become more transparent with continued ContentObjectRenderer refactorings. Some of these have been prepared in v12 already and we'll see more on this with v13. The patch does the main refactoring, deprecating getContentObject() will follow with another patch. The patch does not add the attribute at all places where ContentObjectRenderer instances are created, more may follow later. The main goal of this patch is to create the main infrastructure and to not break the form extension. Resolves: #100623 Releases: main Change-Id: I3de7f53244c0b438ef54940d87a169068f1a832e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77252 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com>
-
Torben Hansen authored
The feature toggle `security.usePasswordPolicyForFrontendUsers` introduced in #97390 was added to allow TYPO3 administrators to still use the deprecated TypoScript validators in ext:felogin for the password reset process. In order to have a consistent setup, the feature toggle must also be respected for frontend users in DataHandler and FormEngine, so it is possible to set any password, if the feature is turned off. With this patch, a possible configured password policy for frontend context (fe_users table) is ignored, if `security.usePasswordPolicyForFrontendUsers` is set to `false`. Resolves: #100300 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I47f5284202b46d8e621adadb16fe6396afaea31c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78346 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Andreas Fernandez authored
The UserTS options `createFoldersInEB` and `folderTree.hideCreateFolder` were used in the past to control the existence of the "Create folder" form in Element Browser instances. With the migration of the "Create folder" view into a separate modal used in EXT:filelist, which is based on Element Browser as well, those options became useless and are therefore dropped. Resolves: #100658 Releases: main Change-Id: I100dceeffa262db8f7211bb9678d3162b2b16677 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78728 Tested-by:
-
Benni Mack authored
Because RTE was not always possible in all browsers in TYPO3 v3.x, a flag to deactivate the RTE (for Netsacpe users) was added. Since then, HTMLarea and now CKEditor4 (or with v12: CKEditor 5) work properly across all browsers and the setting has no effect anymore, is therefore removed from the UI. Resolves: #100634 Releases: main Change-Id: Iff80f250b2db05394f48ee2b303583cfbf193746 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78681 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
The method `DebugUtility::debugInPopUpWindow()` renders a modal with a debug dump, if applicable. The content will always contain markup, which is rendered as plain text in the modal, was intended by the modal component. To have the dump correctly rendered, the markup is passed as a fragment to the modal component. Resolves: #100652 Releases: main Change-Id: I1cd1a97a5cd794e941f1a5830d8fd0cd97d8b1cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78718 Tested-by:
-
Christian Kuhn authored
As feedback from translators: Setting BE/languageDebug=true clutters the backend so heavily, that the feature is of little use nowadays. The patch deprecates the toggle. Resolves: #100657 Releases: main Change-Id: I8283a780375b05630aa7050a8e2415ea1bdbc860 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78727 Tested-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
With the migration to native ServerRequestInterface, EXT:form isn't able to detect uploaded files anymore. The `arguments` property from the underlying Extbase request object is obtained, which contains information about uploaded files in a wrong structure. Therefore, the arguments are merged with the uploaded files array instead. Since uploaded files are converted to a `UploadedFile` object, EXT:form's `UploadedFileReferenceConverter` is adapted to be able to handle said objects as well. Resolves: #100362 Releases: main Change-Id: I07f8ce47b9cdd2334a8bb665df82d83789c9bf19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78336 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Oliver Bartsch authored
In case an export is created based on e.g. an invalid preset, no PHP TypeError should be occure. This is now fixed by properly typecasting the input data. Additionally, two possible undefined array key access warnings are fixed. Resolves: #97403 Releases: main, 11.5 Change-Id: I994391909b44247879099ce92d61911c56ca7e39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78723 Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
It's now ensured that ResourceFileExtensionMatcher properly compares the file extensions using only lowercase chars. Additionally, the in_array checks are set to "strict". Resolves: #100250 Releases: main Change-Id: I687d69d1b2b550f45245ddeac5b09bf3581eff2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78726 Reviewed-by:
-
Andreas Fernandez authored
This commit deprecates some methods in `DebugUtility`. `debugRows()` and :php:`printArray()` both have a duplicated method and `debugInPopUpWindow()` is discouraged with the same reasonings as with the removed of the Debug Console in #98069. Resolves: #100653 Releases: main Change-Id: I3bd986901435f4aa7a4e33fea5a614fe7a238264 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78719 Tested-by:
-
Oliver Bartsch authored
Due to the TYPO3\CMS\Core\Type\Map implementation, the key of a collection entry can also be an object. This is now handled properly in DebuggerUtility. Resolves: #100655 Releases: main Change-Id: I9d3a66e8cb08f369383297dcd80bc685ec03d6e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78724 Reviewed-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100646 Releases: main Change-Id: Id3c06d35a25177f9edf90ab0a9ca7fba8ce96361 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78713 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
In some scenarios, it may happen that the DOM isn't ready while the form editor is already booted, leading to JavaScript errors as DOM nodes are not available yet. The `dispatch*` methods in EXT:form's helper now wait for a ready state before booting the form editor. Resolves: #100651 Releases: main Change-Id: Ic3f331d58fd9ae74e1d7dc121b6ae51c89c89cfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78716 Tested-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100645 Releases: main Change-Id: I22f3aec7fd18eb20409dc0d8cd7af8d8bb2f822b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78695 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Reviewed-by:
-
Andreas Fernandez authored
The icon used to collapse / expand a node in the form editor tree is now streamlined with the other trees (SVG tree, "static" tree). Resolves: #100648 Releases: main Change-Id: I09ffa90996ba277c1f7dc72694d3b991a3e01c24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78715 Reviewed-by:
-
- Apr 17, 2023
-
-
Oliver Bartsch authored
Both EXT:felogin controller extended the AbstractLoginFormController class, which however only contained one single method. To simplify class abstraction, the abstract class is removed by moving corresponding functionality directly into the controllers. This also allows to properly inject the used PageRepository service. Resolves: #100640 Releases: main Change-Id: I8e43779293601356ab7691aee15fb9d3d9a41d32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78688 Reviewed-by:
-
Chris Müller authored
Additionally, remove outdated manuals from list in Settings.cfg. Resolves: #100641 Releases: main, 11.5 Change-Id: Idc09d4da5a0131ae9d4554790d6f782a87d8da5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78689 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #100606 Releases: main Change-Id: Ia53ba43a4668f2f6e06c02fb6be0137d510fcf56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78690 Reviewed-by:
-
Frank Naegler authored
Replace all `<a> ` tags having `href=“javascript:;“` as target with `<button>` tags of type `button` and appropriate classes. Resolves: #99917 Releases: main Change-Id: Ic46df405db3f52cb94b06632b638652ab98d50c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78663 Reviewed-by:
-
Chris Müller authored
Resolves: #97916 Related: #95456 Releases: main Change-Id: I5bf875d11fc91b687b9fba36c2d8c23f5eae1756 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78687 Reviewed-by:
-
Benjamin Kott authored
We are dropping the `.card-table` styling and adjusting `table-fit` to also work in cards the same way they work in panels. Instead of using Utility-CSS to give cards a state different, we now include card states like other components already have. Card containers now only introduce space to bottom. Cards now also have an increased border radius assigned, to match the other components in the backend. Resolves: #100636 Releases: main Change-Id: I17532e58d46e52210f42c5b3b9e333ce4611e50e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78683 Tested-by:
-
Oliver Bartsch authored
To simplify extension configuration and to fully follow the current conventions is the ext_icon.* file location now deprecated. Resolves: #98093 Releases: main Change-Id: I73bd81d31ffbc3db955b5d96511fa39ac56b9241 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78685 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Christian Kuhn authored
In addition to #98281 in TYPO3 v12.0, "pibase" AbstractPlugin now actively logs a deprecation message. Resolves: #100639 Related: #98281 Releases: main Change-Id: Ib8d17f745c9cefa7bfb76a9acfeac96c8a20234f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78686 Tested-by:
-
Christian Kuhn authored
There are two ways of handing over the current request to ContentObjectRenderer after instantiation: By calling setRequest() and by handing the request to start() as third argument. To further streamline request handling, the patch deprecates the second way. Change-Id: I4304e05924ac81a49ce0495bb8de91c70117e804 Resolves: #100637 Resolves: #98632 Related: #92984 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78684 Tested-by:
-
Christian Kuhn authored
EXT:core/Resources/Private/Language/locallang_wizards.xlf contains a series of labels that are not used anymore. Let's remove them. The file is loaded into JS at various places, keeping it smaller is better. Resolves: #100629 Related: #100626 Releases: main Change-Id: I5bc8a2e8827d44a4e4991727ded58532b8984e75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78677 Tested-by:
-
Benjamin Kott authored
With the migration from `text-muted` to `text-body-secondary` the descriptive text for clearing cache actions became unreadable in darkmode. The dropdown component is already respecting the preferred color scheme of the user. Since we have no global support for darkmode and only have some components react, we need to adjust these manually for now. Resolves: #100628 Releases: main Change-Id: Iffffdd7675dc28c026cb650a0897b921c2fbc30f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78676 Reviewed-by:
-
Christian Kuhn authored
The TypoScript parser has to load TypoScript from globals ($GLOBALS['TYPO3_CONF_VARS']['FE']['defaultTypoScript_') and TypoScript from extension static files (ext_typoscript_*.typoscript) at some point. It usually adds this before the first "root" sys_template row. This is fine in frontend. Extbase backend modules rely on frontend TypoScript for configuration as well. This decision from the dark ages hurts us plenty, but is very hard to get rid of. The extbase BackendConfigurationManager does a lot of guesswork to calculate such frontend TypoScript: There are various special cases, especially when an extbase backend module is not loaded within page context. The ext:form extension triggers such a special case: When there is only a single page marked as "is_siteroot" without a sys_template record, configuration from globals is not included. The configuration is then incomplete and the module fails. The old TypoScript parser had a dedicated hack and toggle for this, which forced it to still include global configuration. The new TypoScript parser does not contain this hack. Instead, the extbase BackendConfigurationManager "fakes" a sys_template row to trigger the global inclusion. This works if there is no "is_siteroot" page at all, but is not triggered when a page could be determined. The patch slightly changes the extbase logic to also add the fake row if a page could be determined, but no sys_template record exists. Additionally, the ext:form backend controllers now throw a dedicated exception if configuration is incomplete. Resolves: #99458 Related: #97816 Releases: main Change-Id: Ie48cd5c97704c9c4a0ad7a5e555f49f181f88006 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78650 Tested-by:
-
linawolf authored
Resolves: #99394 Releases: main Change-Id: Ie1fabd4e86bd20dbcfb2bbce6e3431397614c119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78678 Reviewed-by:
-
Frank Naegler authored
The class MagicImageService is deprecated, since it's unused since version 10, due to removal of EXT:rtehtmlarea. Resolves: #99237 Releases: main Change-Id: I2d03315a06abaf618e7cd8544a0ee1d06b1c1100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78662 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Christian Kuhn authored
The last business method of the abstract became unused when the table wizard has been moved to an element with #95036. It is not needed anymore, and is removed, thus the inheritance pattern can be avoided. Resolves: #100631 Related: #95036 Releases: main Change-Id: I9a8540521e771328ad2f57dbc0718021d08182f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78679 Tested-by:
-
Benni Mack authored
With CKeditor table elements are in RTE fields now for tables, however, they need to be added to parseFunc as well. Resolves: #98933 Relates: #99273 Releases: main Change-Id: I51e70a4f6380f2d32e6118e9b303ca46572bd065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78646 Reviewed-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100627 Releases: main Change-Id: Iaac8c84bd1bf951703a38176e9b634da44df42a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78674 Tested-by:
-
Albrecht Köhnlein authored
Set the variable `$linkParts['tableName']` even if the currently linked record could not be found. The variable is required in later step to show information, which also should be present for deleted records. Resolves: #100611 Releases: main, 11.5 Change-Id: I3f5d1e53d8c6889c8907af5ff56c76eb74efa5fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78654 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja Leichsenring authored
The extension does not use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100625 Releases: main Change-Id: I653b2d47efd0fe8ece707e0b362edd33790befd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78671 Tested-by:
-
Benni Mack authored
Resolves: #98985 Releases: main, 11.5 Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78675 Reviewed-by:
-
Anja Leichsenring authored
The wizards don't use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100626 Releases: main Change-Id: I317869dec080e8ce59c4a0903e9564bc5fe96ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78673 Reviewed-by:
-
- Apr 16, 2023
-
-
Albrecht Koehnlein authored
The HTML parser failed to correctly detect single tags with closing `/` and without white space, e.g. `<br/>`. The old tag name detection only splitted the tag content by white spaces, which is not enough to correctly find these valid tags. So the new way is to also remove trailing slashes from the tag name. Resolves: #96347 Related: #96307 Releases: main, 11.5 Change-Id: I3acefcbf046600bf118764b873f15b2a1678932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72641 Tested-by:
-
Albrecht Köhnlein authored
Set the array index `$linkDetails['typoLinkParameter']` in `\TYPO3\CMS\Redirects\Service\RedirectService` to pass it through. That information is needed for the LinkBuilder. For example, `DatabaseRecordLinkBuilder` would trigger an array key access error, in case the linked record cannot be found and no link can be generated. This array value is use there for the thrown exception message. The team play between `LinkService->resolve()` and the `LinkBuilder->build()` should be reviewed in a dedicated change. It may be useful, that the resolver directly adds this information to the result, making the manual adding at several placed through out the core obsolete. Comments are added to document this. Resolves: #100612 Releases: main, 11.5 Change-Id: I74cbf5cbb1b91e0045207873554aec4477986c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78656 Reviewed-by:
-
Christian Kuhn authored
Extbase has an own feature toggle system. This is based on TypoScript configuration and the awful ConfigurationManager. TYPO3 v10 introduces a core-based feature toggle system based on TYPO3_CONF_VARS, so extbase overlaps here, and we should get rid of it. Current extbase uses feature toggles for two ancient details, and one option that has been added with TYPO3 v12. The patch deprecates the PHP API and all toggles. In case extbase implements functionality again that needs to be toggled, it should be based on the core feature toggle API instead. Doing this per-extension can be done by prefixing them accordingly if needed. Resolves: #100622 Related: #97096 Releases: main Change-Id: I5776c57af85aa01c97bc0d7fe7eeaf148a3e5016 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78670 Tested-by:
-
Christian Kuhn authored
extensionmanager/ext_typoscript_setup.typoscript file is obsolete since it only sets an extbase feature toggle to the same value as the default value. Resolves: #100620 Releases: main Change-Id: Id05de448194f85adf887c0b4b9f5a7cdfc1077a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78667 Reviewed-by:
-
