- Sep 11, 2021
-
-
Wouter Wolters authored
The following dependencies are missing from main composer.json Add them. * doctrine/event-manager * psr/http-server-handler * guzzlehttp/promises composer req doctrine/event-manager:^1.0.0 --no-update composer req psr/http-server-handler:^1.0 --no-update composer req guzzlehttp/promises:^1.4.0 --no-update composer req doctrine/event-manager:^1.0.0 -d typo3/sysext/core/ --no-update composer req psr/http-server-handler:^1.0 -d typo3/sysext/core/ --no-update composer req guzzlehttp/promises:^1.4.0 -d typo3/sysext/install/ --no-update composer u --lock Resolves: #95142 Releases: master Change-Id: Ibb17d9bb6d752ad1921b4bae36f774a92ea5932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70793 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Nikita Hovratov authored
$rowsByLang[0] is not set, if editing a content element without a language source. A check for existence is added to prevent warnings in PHP 8. Resolves: #95059 Releases: master Change-Id: I200175d4127d8925973022c6b3eed86ce1f575b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70846 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Brings preparations for PHP 8.1 and some further minor goodies. composer req --dev typo3/testing-framework:^6.11.0 Change-Id: I4e8d4b31a66c7775801d7abb6243e98c00d2833b Resolves: #95185 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71018 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Chris Müller authored
Resolves: #95184 Releases: master Change-Id: I28f194f06890085a9d9297356d83e4027ab80113 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71025 Tested-by:
-
Oliver Klee authored
Also polish the language of the related ReST file a bit. Relates: #94996 Releases: master Change-Id: Id5cc50bcb518db37323bb15602fb56b9ae699861 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71024 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Sep 10, 2021
-
-
Oliver Hader authored
This reverts commit 2d40f748. It has been discovered that the change enforced html-sanitizer again and contradicted recent changes in issue #94786. Resolves: #95158 Related: #67556 Releases: master Change-Id: Icaead77b007553cef68bec3ad23e15fe853bbc05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71021 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stefan Bürk authored
Executing frontend request calls in tests has been transformed to the new subrequest support of v11. One test has been added with old executeFrontendRequest() which is deprecated in the testing-framework and is changed to the new executeFrontendSubRequest() ability. This patch acts as post-patch to change this for master. Resolves: #95178 Releases: master Change-Id: I773b0131d6bec1e2191cd861f9c65db0fff0c81a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71017 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
The extbase ActionController is already using the PSR-17 ResponseFactoryInterface for creating PSR-7 responses. The body however was still set in a PSR-7 "fashion". This is now changed to also use PSR-17 for setting the response body. More precisly, the PSR-17 StreamFactoryInterface is used explicitly instead of letting the body stream be created implicity by getBody(). The PSR-17 StreamFactoryInterface is therefore from now on available in every extbase action controller. Besides the `createStream` method, the interface also features `createStreamFromResource` and `createStreamFromFile` methods. The latter is really useful for responses that contains files, e.g. a ZIP download. This also adjusts the corresponding changelogs and replaces examples, which used the internal `HtmlResponse` class. Resolves: #95170 Releases: master Change-Id: Ib35046c061afbbc371bec0461953a55720583dee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70986 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Sep 09, 2021
-
-
Oliver Bartsch authored
Multi record selection was first introduced to filelist, where only one "table" exists. Therefore, it was sufficient to toggle all actions, after registering their events. With #95017, multi record selection got extended to be able to handle multiple instances on the same page. Since then, toggling of actions always requires to take the corresponding instance identifier into account. This is properly handled in the "restoreTemporaryState()" method. Therefore the toggling, initiated after the event registration, having no identifier information, is removed. This fixes toggling the actions of all instances as soon as one checkbox is checked. Besides, an unused selector is removed. Resolves: #95167 Related: #95017 Releases: master Change-Id: Id46b5ba51afbb1f6ad9ccd020b1820229f4aa3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70984 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Jochen Roth authored
The editPageTitle acceptance test sometimes fails for no reason. This seems to be a timing issue and will hopefully prevented by waiting for the title to appear. Resolves: #95165 Releases: master Change-Id: Ib8a21694830f60828b54c2cacd6abc348ec8fec8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70983 Tested-by:
-
Oliver Bartsch authored
In #95037 the "rootUid" option has been deprecated in favour of "startingPoints", which now allows to add multiple root nodes for a tree. However, for backwards compatibility, the "rootUid" option is still used in core. The corresponding setter and getter methods should therefore not trigger a deprecation log entry. Extension scanner still finds usages in extension code as weak match. Resolves: #95163 Related: #95037 Releases: master Change-Id: I6a974861949dfc2163a93e2e4fc60f27caafc7c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70982 Tested-by:
-
Claus Due authored
This patch fixes an issue with mod.web_layout.defLangBinding = 1 which when enabled would cause the page layout module to render the "new content" buttons when this was not desired. The fixes consist of: * A change to make sure that Fluid variable {column} contains the right language ID in the PageLayoutContext associated with the column; by re-assigning {column} within the loop over {languageColumns} in LanguageColumns.html * Re-overwriting the {column} variable after the loop to ensure it holds the default language column which holds the default language column's content records that are iterated over. * Overwriting the {column} variable within the loop that renders each content record to ensure it holds the correct language ID in the column's PageLayoutContext. * Assigning the right PageLayoutContext to translated versions of content records to ensure that the "new content" button below each translated content element points to the right language UID. * A visual alignment fix setting valign="top" on TD elements to ensure the alignment of each content record and the column header, when the "new content" button is not shown. Resolves: #94047 Releases: master, 10.4 Change-Id: Ia169f9c649db8df9b1ec11aeeb23cebed27308e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70718 Tested-by: -
Oliver Bartsch authored
Switching from "Languages" to "Columns" mode in the page module, while having "All languages" selected, the grid was previously empty, due to a missing fallback. The special "-1" is no valid language id in the "Columns" mode and has to be replaced in the module settings. We therefore fall back to the default language, which is in this case already visually selected for the user, since it's the first module menu entry. Resolves: #95161 Related: #92460 Releases: master Change-Id: I68d242d1fc85fcc9fb48daf7d28298ee70fc7fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70981 Tested-by:
-
Larry Garfield authored
PHP 8.1 now includes types on built in class's properties, which means redeclaring them without types breaks. Let's not do that. This patch resolves all hard-fatals in unit tests, but not all errors. Resolves: #95155 Releases: master Change-Id: Ied1b8c3c9f35692f0fe2a793972f06cb3ef79d7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70972 Reviewed-by:
-
Larry Garfield authored
libsodium doesn't support multi-threading. It's unclear why this code didn't fail previously on 8.0, but sending a thread count to password_hash() while ext/sodium is enabled is not supported regardless. I believe this is the least-invasive fix. Resolves: #95159 Releases: master Change-Id: I0e46ad46bc1440efcc118abd9d1dd82e9de4d2b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70975 Tested-by:
-
Oliver Bartsch authored
DatabaseRecordList is used at various places, e.g. in the Record Selector, but also for the TableList view helper. Recently, a lot of patches touched DatabaseRecordList, leading to some problems for the usages. Therefore this patch does the following: * Include required language file in TableListViewHelper * Handle "readOnly" setting correctly in TableListViewHelper * Remove record download action in DatabaseBrowser * Replace call to non-existing method in RecordDownloadController * Add missing JavaScript modules for RecordLinkHandler * Restore "showLimit" property in DatabaseRecordList Resolves: #95120 Resolves: #95138 Releases: master Change-Id: If35d71698741c10e9b7d54f222f9fbb95e61e414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70957 Tested-by:
-
Oliver Bartsch authored
In single table view, there was previously the option to edit all shown fields of the listed records. This option got unintentionally removed in #95068 and is therefore now restored. Resolves: #95134 Related: #95068 Releases: master Change-Id: I65e31907032a164bd1bbad20b5fa154fbb93243a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70954 Tested-by:
-
Oliver Bartsch authored
It's possible to assign additional attributes to context menu items. Those attributes are then available in the corresponding JavaScript callback method. Therefore, there is no need to add settings, only used in the callback methods, globally via BackendController hooks. This patch removes such hook usages from EXT:filelist and EXT:impexp, while adding the corresponding settings as attributes to the context menu items. Resolves: #95131 Releases: master Change-Id: I4972fb93a6c0007e19b848be1659553008f2c5ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70914 Tested-by:
-
Oliver Bartsch authored
This patch does two things. 1. Fixes the display of CSH in the the setup module. More precisely, the wrapping of the field label is changed, so that styles are properly applied again. 2. Adds CSH for newly introduced fields + avatar Resolves: #95143 Releases: master Change-Id: I74c636d54a3c7fd88a615e248aa3ba21133ee456 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70961 Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
Rick Septer <rick.septer@maxserv.com> Tested-by:
-
Christian Kuhn authored
The Extbase ControllerContext is a dependency between Extbase and Fluid to communicate state. It is wired into various view related classes. To further decouple fluid from extbase, this class needs to fall. A couple of previous patches deprecated parts of the class already, this patch deprecates the rest. The fluid RenderingContext can be used in view helpers in almost all cases as substitution, especially since extbase request implements PSR-7 ServerRequestInterface. The core itself has no direct usages of ControllerContext anymore, it is only moved around at various places. Change-Id: Ic4af492b9818003321ceeb6c9e6dcd29c5662271 Resolves: #95139 Related: #93019 Related: #93016 Related: #94428 Related: #92826 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70956 Tested-by:
-
Mathias Brodala authored
Also introduce groups for the HTTP status items to make the distinction between 301/302/303 (may change HTTP method to get) and 307/308 (keep HTTP method) clear. Resolves: #94922 Releases: master, 10.4 Change-Id: Ifdbe4e73146a4510abe1ebae6bb435cd78a457cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70677 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Jorgen van der Kroon <jurgen@alternet.nl> Tested-by:
Jeroen Schutte <jeroen@besitegroup.nl> Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Sep 08, 2021
-
-
Oliver Bartsch authored
The ClipboardComponent JavaScript module is no longer used, since the introduction of multi record selection in #95068. Therefore, it's now removed. Resolves: #95156 Releases: master Change-Id: I3d3b1ae3f53651ec91ac9de0075c741e92ea959d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70974 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Bartsch authored
Using tables in panels requires the tables to avoid any margin-bottom, since the panel already defines such. A special case is using the wrapper class "table-responsive", placed between the panel and the table element. This use case was previously handled by bootstrap directly, but got removed with v5. We therefore, handle this case now on our own. Resolves: #95147 Releases: master Change-Id: I9c27bf9f5100b1ee1037ea30519a9a6ad7f7d77d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70969 Tested-by:
-
Andreas Fernandez authored
The first release of the v2 branch of guzzlehttp/psr7 was in June 30th 2021, which is around two months from now at the time of writing this commit message. Many 3rd party libraries are not compatible to version 2.0 of guzzlehttp/psr7 yet, which makes updates impossible without using nasty hacks. For this reason, the constraint is loosened to allow both, 1.7 and 2.0 of guzzlehttp/psr7. Executed commands: composer req guzzlehttp/psr7:"^1.7.0 || ^2.0" composer req guzzlehttp/psr7:"^1.7.0 || ^2.0" -d typo3/sysext/core --no-update Resolves: #95136 Related: #94454 Releases: master Change-Id: Ic1efe3da5f6aede215720e7a86ab24475922f0a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70955 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Oliver Bartsch authored
Having a numeric pad selected, pasting of a single element did previously not work, using the "paste" button in the page layout due to the missing "pad" parameter in the ajax call. This is now fixed by adding the "pad" parameter, which changes the current pad to "normal" before executing the paste command. Resolves: #87118 Releases: master, 10.4 Change-Id: If96859f3ee1fad3c7c6b0f026c420f715b75626f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70963 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Oliver Hader authored
This change extracts dynamically added frontend JavaScript `openPic` and `linkTo_UnCryptMailto` which are extracted to static file `EXT:frontend/Resources/Public/JavaScript/default_frontend.js`. Mentioned file is loaded automatically as async script element. As a result, view-helper `<f:uri.email>` became obsolete, which is deprecated and considered to be removed with TYPO3 v12.0. Resolves: #95041 Releases: master Change-Id: Ic1a17e11e5acfab4a1e3fe60d921a0ddc647f83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70827 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Sep 07, 2021
-
-
Stefan Bürk authored
PHP 8.1 introduces language features and deprecations. As always, the first step is having a green test suite. Testing container typo3/core-testing-php81 has just been released, coming with PHP 8.1.0 RC1. Some issues are obvious when running the test suites, they will be fixed with upcoming patches. This patch adds support for PHP 8.1 to runTests.sh, example: Build/Scripts/runTests.sh -p 8.1 -s unit Resolves: #95141 Releases: master Change-Id: Ia5d09ddc2a3114e07a8f87aa9ef14740be2785af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70960 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Helmut Hummel authored
This replaces a lot of string-based comparisons spread around the code, which have been even wrong. Having a single place for this kind of checks is beneficial. The method is added to PathUtility as similar methods are already present there. Releases: master Resolves: #95121 Change-Id: Ic73aac5d8c758dee5e0424bf2d54cd62b4b09e0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70913 Tested-by:
-
Andreas Fernandez authored
Update browserslist package to update the browser versions we're supporting and respect their capabilities when building assets. Executed commands: npx browserslist@latest --update-db grunt build Resolves: #95130 Releases: master Change-Id: I0dd9634648a1df72c1449047d601ac52b758917c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70922 Tested-by:
-
Oliver Bartsch authored
The mentioned hook has been deprecated with #95105 and is therefore replaced by the corresponding PSR-14 event. Resolves: #95140 Related: #95105 Releases: master Change-Id: I16cb92f46c0e06243e55ce86bd39572e83609293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70958 Tested-by:
-
Jochen Roth authored
Processing of "Manage Reference Index" actions (check/update) can take quite some time. To give the user better feedback of the current state a loading indicator has been added and buttons are disabled during processing. Resolves: #95094 Releases: master Change-Id: Ia1d19eb6d63c4d980e548820cc795b5c0b892164 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70879 Tested-by:
-
Benni Mack authored
Change-Id: I0c887b2b4dadead96e315c0b4f5153d391e7ea94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70953 Tested-by:
-
Benni Mack authored
Change-Id: Ibae91e9f44a65697321611f49eef10ddb1a39ba9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70952 Tested-by:
-
Jochen Roth authored
Sometimes during testing the imported page 404 can't be found. The import acceptance test has been improved using the given "getPageXPathByPageName" method so it will hopefully behave in the future. Resolves: #95116 Releases: master Change-Id: Ic37d5afa014ee1c823b34f1a3700338d78c8a3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70912 Tested-by:
-
Oliver Hader authored
Composer command: composer u 'doctrine/annotations' --with-all-dependencies; \ composer u 'doctrine/event-manager' --with-all-dependencies Output: - Upgrading doctrine/annotations (1.12.1 => 1.13.2) - Upgrading doctrine/event-manager (v1.0.0 => 1.1.1) Resolves: #95129 Releases: master Change-Id: I0f0ba6221ed28b38e388cdc66e49d87ce1869b01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70923 Tested-by:
-
Oliver Hader authored
Composer command: composer update 'symfony/*' 'guzzlehttp/*' --with-all-dependencies Output: - Removing symfony/intl (v5.0.7) - Upgrading guzzlehttp/promises (1.4.0 => 1.4.1) - Upgrading symfony/cache (v5.3.0 => v5.3.7) - Upgrading symfony/config (v5.3.0 => v5.3.4) - Upgrading symfony/console (v5.3.6 => v5.3.7) - Upgrading symfony/dependency-injection (v5.3.0 => v5.3.7) - Upgrading symfony/event-dispatcher (v5.3.4 => v5.3.7) - Upgrading symfony/expression-language (v5.3.0 => v5.3.7) - Upgrading symfony/finder (v5.3.4 => v5.3.7) - Upgrading symfony/http-foundation (v5.3.1 => v5.3.7) - Upgrading symfony/lock (v5.3.2 => v5.3.4) - Upgrading symfony/mailer (v5.3.0 => v5.3.4) - Upgrading symfony/mime (v5.3.0 => v5.3.7) - Upgrading symfony/options-resolver (v5.2.1 => v5.3.7) - Upgrading symfony/polyfill-intl-icu (v1.15.0 => v1.23.0) - Upgrading symfony/process (v5.2.1 => v5.3.7) - Upgrading symfony/property-access (v5.3.0 => v5.3.7) - Upgrading symfony/property-info (v5.3.1 => v5.3.7) - Upgrading symfony/rate-limiter (v5.3.0 => v5.3.4) - Upgrading symfony/routing (v5.3.0 => v5.3.7) - Upgrading symfony/stopwatch (v5.2.1 => v5.3.4) - Upgrading symfony/string (v5.3.3 => v5.3.7) - Upgrading symfony/var-dumper (v5.3.0 => v5.3.7) - Upgrading symfony/var-exporter (v5.3.0 => v5.3.7) Resolves: #95126 Releases: master Change-Id: I9cdfee15dbcdf6c07813cdacff03dccf7b061308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70921 Tested-by:
-
- Sep 06, 2021
-
-
Oliver Hader authored
Update to CKEditor v4.16.2 which addressed browser compatibility issues and known security vulnerabilities: https://ckeditor.com/blog/ckeditor-4.16.2-with-browser-improvements-and-security-fixes/ Commands: cd Build yarn add 'ckeditor4@^4.16.2' yarn build Resolves: #95128 Releases: master, 10.4, 9.5 Change-Id: Ic0c10f2d72bb7d107f53c58dbc0668d19275914b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70917 Tested-by:
-
Oliver Hader authored
The RST file used the review ID instead of correct issue #94861. For convience, all breaking changes were collected for TYPO3 v11.0, and this RST is moved accordingly - the behavior has been deprected correctly in TYPO3 v10, however actually removing it in v11.0 was forgotten. Related: #94861 Releases: master Change-Id: I03c9d3062dcd640cce9396805f99873d4be14d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70920 Tested-by:
-
Oliver Bartsch authored
Resolves: #95124 Related: #95009 Releases: master Change-Id: I41319bd20432a55a668e10b62634c82839677ea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70915 Tested-by:
-
Oliver Hader authored
Composer commands: composer req 'christian-riesen/base32:^1.6'; \ composer update 'bacon/bacon-qr-code' --with-all-dependencies Output: - Upgrading christian-riesen/base32 (1.5.2 => 1.6.0) - Upgrading bacon/bacon-qr-code (2.0.3 => 2.0.4) References: * https://github.com/ChristianRiesen/base32/releases/tag/1.6.0 "Major bugfix [...] please require at a minimum ^1.6 in your project" Resolves: #95127 Releases: master Change-Id: Iccd3681a278667cb0438cd04c15af4ac828b7be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70916 Tested-by:
-
