- Jun 21, 2021
-
-
Benni Mack authored
When setting up permissions and a good folder structure, admins should be able to create new sys_filemounts from the context menu of a folder, so they do not have to use the list module (or the be_groups wizard) but can conventiently use the file list module OR the file tree. Resolves: #94374 Releases: master Change-Id: Idb9781136eb24cb266eb61cd9f3138ab9b91650e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69516 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Jochen Roth authored
Will fix creation/edit content as well as publishing workflow for workspaces and add a basic ac test for page change, switch workspace and publish Also EXT:workspaces is now enabled in test environment Resolves: #94361 Releases: master Change-Id: I9f85a4edaa90e77cbdfc5f988007917263ed51ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69508 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 19, 2021
-
-
Robert Vock authored
Some documentation files containted incorrect :issue:`#XXXX` links instead of :issue:`XXXX` (without #). Releases: master Resolves: #94385 Change-Id: I1946426e8c5464d890b62238cd863a314cc8a0e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69532 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jun 18, 2021
-
-
Christian Kuhn authored
Most ObjectManager->get() calls in FormRuntime can be moved to makeInstance() directly without further impact. For FormFactoryInterface, a b/w compat layer is established, but shouldn't be problematic since this will be ArrayFormFactory in almost all cases. Change-Id: I354d582260307986cb386506fa5e006646ca816a Resolves: #94370 Related: #90803 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69515 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benni Mack authored
This change moves the CSV Export in the header of each table within the record list. This contains multiple UX improvements: * CSV Exports are now possible in each list view, not just in single table view * CSV Export Buttons are visually connected to the actual records and the output * The CSV Button now has a proper label next to the icon instead of just an icon in the docheader In addition, the RecordListController is thinned out as all logic is separated and moved into a new RecordExportController. Resolves: #94366 Releases: master Change-Id: Ia64b513636799368a39b5028b6cad7ebac6fe835 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69512 Tested-by:
-
Oliver Bartsch authored
This change ensures that deleting selected records (when clipboard is activated) only happens for POST requests in the RecordListController. Also, the given "cmd" argument from the request is not longer overwritten by the DataHandler command array. Resolves: #94380 Releases: master Change-Id: I8c4c728469fd60b9a41dd48c63c46837c9c9dbf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69522 Tested-by:
-
Christian Kuhn authored
When extbase has been changed to PSR-7 responses, class ReferringRequest has been nearly obsoleted: It is only used to be immediately turned into a ForwardResponse. To further prepare towards PSR-7 requests, usage of ReferringRequest which extends extbase Request is dropped and the class marked as deprecated. Change-Id: If16c09b0601792f6702fbacee064cd4d514c70c6 Resolves: #94367 Related: #92502 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69513 Tested-by:
-
Christian Kuhn authored
ObjectManager->getEmptyObject() is only used in extbase persistence DataMapper when domain objects are "thawed": An existing DB row is fetched and a model object is created from it. From extbase PoV, a domain object lifecycle is "creation" ("own a new car"), then eventually "freezing" it in DB, "thawing" it from DB to update it's state ("washed today, it's now clean"), and eventually deletion ("brought to scrapyard, don't own it anymore"). Extbase now says that "thawing" and "creation" are two different things and thus decided that programmatically, __construct() on thawed objects should NOT be called, because, well, it's not new, just thawed! Don't assume __wakeup() is called instead, though: It's not. Extbase of course has to hop through quite some loops to violate this PHP language construct. It even needs the 3rd party dependency doctrine/instantiator to achieve suppressing __construct() call, since the previous 'unserialize hack' broke somewhere during PHP 5 times. Additionally, even though extbase Domain Model objects *should* be plain old PHP objects, they still allow inject* methods and are dependency injection aware. This is a problem when moving away from ObjectManager towards symfony DI, because symfony does not support this creative extbase view of supressing __construct() when instantiating objects. We can't get rid of this easily in extbase, though. There is no good way to deprecation-log this behavior. A feature toggle seems to be overkill - probably not too many extbase devs are aware of this implementation detail in the first place, and the impact if __construct() is properly called when an object is thawed should be relatively small: First, models are usually relatively stupid in extbase (which is good, they should be), and if they have a __construct() method at all, chances are, everything that is done there is overriden during the following mapping process anyways. We thus decided against a feature toggle for this. Instead, we *keep* the current instantiation logic in v11, just mark the code places as deprecated, configure the extension scanner to look for additional getEmptyObject() calls in extensions, and add a depreation reST file pointing out the situation and stating __construct() will be called in v12 for thawed objects. Resolves: #94377 Related: #90803 Releases: master Change-Id: Ied3da8b9d885be2f635b9bc6c66b37fc9825decc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69520 Tested-by:Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Oliver Bartsch authored
The FileProvider tries to retrieve the file / folder object on initialization. In case the requested folder or storage is temporarily offline, a ResourceDoesNotExistException is thrown. This is now fixed by catching the exception an setting the $record to NULL. This allows to still render the context menu with the remaining options, such as edit the storage record or display the records information. Resolves: #94372 Releases: master, 10.4 Change-Id: I2ef6437b0d6e22462d73c9536433d7dc1914f680 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69517 Tested-by:
-
Oliver Hader authored
Extracts TypoScript instruction handling to test trait, which enables to reuse corresponding methods. Resolves: #94354 Releases: master, 10.4, 9.5 Change-Id: I34f25070d926f1236b1f7bbd623e0060760b0819 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69501 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
One warning was triggered by an inline JavaScript assignment, which is unused since at least v9. It's therefore removed. Resolves: #94364 Releases: master Change-Id: I8c680d393ce7449be17e68757aa1bc8698360667 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69511 Tested-by:
-
- Jun 17, 2021
-
-
Larry Garfield authored
The 'event:' tag in Services.yaml can be omitted since, the wiring is done automatically by reflecting the target method at compile-time. Resolves: #94345 Releases: master Change-Id: I58c9072efec3dd70c8d8768dc290cf1aa6543902 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69495 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Christian Kuhn authored
Finish the ObjectManager usages in ext:fluid. With #94285 we made the ViewHelperResolver a singleton service, which is not ok since it holds state: Namespaces are added at runtime and they additionally depend on request. The solution is similar to RenderingContext from #94285 though: Have a factory to create fresh instances for each parsing cycle for this failsafe mode enabled class. View helper instance prototypes itself are then retrieved using GeneralUtility::makeInstance(). Resolves: #94292 Related: #94285 Related: #90803 Releases: master Change-Id: I08018b57e3bd5b293be999d7c5415578604c7897 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69419 Tested-by:
-
Daniel Goerz authored
EXT:lowlevel EXT:recordlist EXT:recycler EXT:reports EXT:rte_ckeditor Resolves: #94265 Releases: master Change-Id: I4e5e94f3e9f041e4ee8bab93a7ced73077250ee9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69371 Tested-by:
-
Daniel Goerz authored
EXT:scheduler EXT:tstemplate EXT:workspaces Resolves: #94266 Releases: master Change-Id: I60705f3667602575ec841bcc8e5d24a899093a03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69370 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Jochen Roth authored
Will add a test for Help -> TYPO3 Manual and it's subpage to see if pages actually loaded Resolves: #94360 Releases: master Change-Id: I88296dcb775ed2797d078f6efa9400177d0df990 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69506 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Jochen Roth authored
This will add a basic acceptance test for reports module because the page was not loaded using php 8.0. Another test is slightly changed to stabilize a test we had a recent change in. Resolves: #94358 Related: #94346 Releases: master, 10.4 Change-Id: I1d73e58c1f767799e0e9ecd71db8d41ecdada6b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69504 Tested-by:
-
Andreas Fernandez authored
The action `deleteMessageAction` of the controller `\TYPO3\CMS\Belog\Controller\BackendLogController` now returns a proper `ForwardResponse` to keep the desired redirect behavior. Resolves: #94359 Releases: master Change-Id: I757aff29b4f6104ef16d3bd5f4b61579fc2f97f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69505 Tested-by:
-
Martin Kutschker authored
The method specCharsToASCII expects its input in Canonical Composition (NFC) otherwise it will produce incorrect results. The commit also makes sure that a failed normalization (incl. the slug helper) does not lead to data loss. Resolves: #93883 Releases: master, 10.4 Change-Id: If6decdd9d2980bee11188fffc6b73c81b06b7e6a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69144 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Jun 16, 2021
-
-
Jochen Roth authored
In EXT:rte_ckeditor, EXT:form, EXT:recordlist, EXT:setup, EXT:backend, EXT:frontend, EXT:reports Added acceptance test for About and User Settings module loading Resolves: #94346 Releases: master Change-Id: Icbf6c952b51587ed71bbe3fd855d368bf1163147 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69496 Tested-by:
-
Jan Stockfisch authored
Adds examples of how to override core templates. Resolves: #90566 Releases: master, 10.4 Change-Id: I09f7b89542cc7f22c56b6689b9e9b6d0d066fc74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63478 Tested-by:
-
Larry Garfield authored
Assorted cleanup and tidying of the Logger system. There's more to do later but that's for later. Resolves: #94352 Related: #94356 Releases: master Change-Id: I0ce949fbdd692a2bb073732d234af76e68757735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69500 Tested-by:
-
Larry Garfield authored
PSR-3 has specific rules around interpolation: Messages may provide placeholders like {foo} and writers should substitute these in the messages if a context array with such a key is provided. Let's use placeholders correctly. Resolves: #94315 Related: #94356 Releases: master Change-Id: I2c285e84f1832c80828861369e99af9aff6cd267 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Tested-by:
-
- Jun 15, 2021
-
-
Christian Kuhn authored
There are three possible cases an extbase controller action can come up with: a) Return a casual psr-7 response (html, json, ...) b) Return an extbase specific ForwardResponse to dispatch extbase-internally to another action. c) Have a redirect the client should receive to call some other Url. a) and b) are simple in v11 - the action returns a PSR-7 ResponseInterface. c) however throws StopActionException instead, which is caught by extbase Dispatcher and then returned. This is ugly. The patch changes this and deprecates the StopActionException. We can not drop the throw call since that would be breaking, but we prepare towards a clean v12 solution, which leads to the sitation that *all* extbase actions return a response. Resolves: #94351 Releases: master Change-Id: Ie5a53109959a008ab1666f52d5a81e6e7ba3efdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69498 Tested-by:
-
Oliver Bartsch authored
Resolves: #94348 Releases: master Change-Id: Ia8c1f5041057f629ea9dfcc3cde6feba5a1cbe2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69497 Tested-by:
-
Patrick Schriner authored
If a field has a '''double''' eval, '''upper''' and '''lower''' range checks don't work as expected as the value is always cast to an int before comparison. Switching to floor and ceil helps with these edge cases while retaining the casting to int behaviour. Resolves: #94103 Releases: master,10.4 Change-Id: I28b77e2360b86e27e0297a08c5b6d20e0637a0dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69098 Tested-by:
-
- Jun 14, 2021
-
-
Christian Kuhn authored
"<html><head><meta http-equiv="refresh" ..." is discouraged by w3.org [1] and should be implemented as server-side 3** response. Extbase redirectToUri() already sets 303 (default) and adds the Location header. The meta http refresh is obsolete and can be dropped together with the delay argument. [1] https://www.w3.org/TR/WCAG20-TECHS/H76.html Resolves: #94341 Releases: master Change-Id: Ic3c037b0ee9edbc0eebf9f1b50180ca6c3f98ba2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69491 Tested-by:
-
Benni Mack authored
TYPO3 v11 will require symfony 5.3.0 (and hopefully further versions once they will be released). Used composer command: > composer req -W "symfony/config:^5.3.0" \ "symfony/console:^5.3.0" \ "symfony/dependency-injection:^5.3.0" \ "symfony/expression-language:^5.3.0" \ "symfony/finder:^5.3.0" \ "symfony/http-foundation:^5.3.0" \ "symfony/mailer:^5.3.0" \ "symfony/mime:^5.3.0" \ "symfony/property-access:^5.3.0" \ "symfony/property-info:^5.3.0" \ "symfony/routing:^5.3.0" \ "symfony/var-dumper:^5.3.0" \ "symfony/yaml:^5.3.0" Resolves: #94340 Releases: master Change-Id: I3777975d144b3424910043f2445d576f885f0e41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69490 Tested-by:
-
Alexander Schnitzler authored
When a ClassSchema is created for a class, all methods inside said class are analyzed along with their parameters. Ever since extbase existed, the parameter type has been read from the doc block. ``` /** * @param \Foo\Bar\Baz $baz */ public function injectBaz($baz); ``` Since the whole reflection api and PHP itself have been improved in the recent past, parameter types can be detected without looking at doc blocks. It is recommended to use native type hints as follows: ``` public function injectBaz(\Foo\Bar\Baz $baz); ``` The doc block is neiter needed nor supported in the near future. Of course, developers may add a doc block but TYPO3 will no longer evaluate that as of version 12.0. Releases: master Resolves: #94115 Change-Id: Ifc68c0cb8a42b8ab589043afbaebf5dd5763eee5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59450 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #94342 Releases: master, 10.4 Change-Id: Ia3d10d9b934788228ceb7c6ec0d3e1a67474b9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69492 Tested-by:
-
Christian Kuhn authored
After a long way of fixing our code base to have all our tests (unit, functional, acceptance tests) green, TYPO3 now officially runs with PHP 8.0. TYPO3 v11 LTS thus will support PHP 7.4 and PHP 8.0 (and hopefully PHP 8.1 once the dependencies support PHP 8.1). There might be a few PHP notices throughout TYPO3 Frontend and Backend, but all base functionality is now available for PHP 8.0 as well. Resolves: #93631 Related: #94057 Releases: master Change-Id: I5798e6f49ee637b794df096fd44b8157d96b74bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69489 Tested-by:
-
Oliver Bartsch authored
Bootstrap beta3 introduced a regression, which reversed the slide direction. This therefore broke our implementation, since we are using an event listener, evaluating the direction. Because we were not aware of this being "just" a regression instead of an intended API change, we switched the direction in our event listener in #94037, too. In the final 5.0 release, we updated to in #94089, the regression has been fixed, breaking our event listener once again. This is fixed by restoring the initial and correct direction check. Related bootstrap PRs: - https://github.com/twbs/bootstrap/pull/32913 - https://github.com/twbs/bootstrap/pull/33499 Resolves: #94338 Releases: master Change-Id: I0bc4dc2dfd37935fc43e04f311bd850916c31004 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69486 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Christian Kuhn authored
Acceptance tests now properly configure graphics magick, so image generation works for them. This triggeres different and more relevant code paths. composer req --dev typo3/testing-framework:^6.8.4 composer req --dev typo3/testing-framework:^6.8.4 -d typo3/sysext/core --no-update Change-Id: I65dd2061c13479fb031373973860d3204dfe4bbf Resolves: #94339 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69484 Tested-by:
-
Christian Kuhn authored
This fixes a bunch of PHP 8.0 warnings found by acceptance testing. image processing and ext:scheduler are affected for the main part. This makes the ac test suite green with PHP 8.0. The gitlab activation and another testing-framework raise will follow with dedicated patches. The patch brings an additional acceptance test for install tool 'Environment->Image Processing' since this worked well to nail lots of issues with GifBuilder and friends. Change-Id: Id22c7636da76778b75f087d20d7b7260cd2637ee Resolves: #94333 Related: #94057 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69476 Tested-by:
-
Oliver Bartsch authored
Following methods in HttpUtility are deprecated, since they call `die()` / `exit()` and furthermore directly manipulate the HTTP header via `header()`. - `redirect()` - `setResponseCode()` - `setResponseCodeAndExit()` Resolves: #94316 Releases: master Change-Id: Ica1970baf43c7cccb70b3564b229c882c1fe493c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69464 Tested-by:
-
Benni Mack authored
This change aims to reduce all left-over strict type changes, and backwards-incompatible changes in our own code base making sure that TYPO3 can run smoothly with PHP 8. Resolves: #94335 Releases: master Change-Id: I9d1c8966a56a80bb68216ae535547e0bf55e50c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67243 Tested-by:
-
- Jun 13, 2021
-
-
Christian Kuhn authored
The @ error control operator suppresses all errors raised by the expression, right? Well ... If an error handler has been registered, and an error is raised by an @-prepended expression, the error handler is still called with this error. The TYPO3 core error handler thus detects if the error comes from an @-prepended expression to not log / throw. In PHP < 8.0, this can be achieved by checking error_reporting() === 0. With PHP >= 8.0, the @ error control operator has been changed to not suppress fatal PHP errors anymore, which in turn changed the error_reporting() level to 4437 for an error raised "inside" an @-prepended expression. Adapt core to deal with the PHP 8 variant, too. See also: https://www.php.net/manual/en/language.operators.errorcontrol.php#125938 Resolves: #94329 Related: #94057 Related: #94269 Releases: master Change-Id: Ie926685349beae3bdc9edbb288bc674d3115a64c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69475 Tested-by:
-
Christian Kuhn authored
Brings a composer conflict setting to prevent incompatible doctrine/dbal versions, and an acceptance test related fix. composer req --dev typo3/testing-framework:^6.8.3 composer req --dev typo3/testing-framework:^6.8.3 -d typo3/sysext/core --no-update Resolves: #94332 Releases: master, 10.4 Change-Id: Ib1192c5135c02d485c8f28b54755c22a1a50c10f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69481 Tested-by:
-
Christian Kuhn authored
Brings a PHP 8.0 related fix, backend module bug fixes and features representing more v11 related markup. composer req --dev typo3/cms-styleguide:~11.3.0 composer req --dev typo3/cms-styleguide:~11.3.0 -d typo3/sysext/core --no-update Change-Id: I716237ad6256db87f6b6e20081a67fa674c203d5 Resolves: #94331 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69479 Tested-by:
-
Christian Kuhn authored
It's TYPO3\CMS\Core\Tests\Acceptance\Backend\Site\SiteModuleCest not TYPO3\CMS\Core\Tests\Acceptance\Backend\Redirect\SiteModuleCest Resolves: #94330 Releases: master, 10.4 Change-Id: I0661feec976aeeddce179d9177e36e729fc0b72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69477 Tested-by:
-
