[TASK] Deprecate extbase StopActionException
There are three possible cases an extbase controller action can come up with: a) Return a casual psr-7 response (html, json, ...) b) Return an extbase specific ForwardResponse to dispatch extbase-internally to another action. c) Have a redirect the client should receive to call some other Url. a) and b) are simple in v11 - the action returns a PSR-7 ResponseInterface. c) however throws StopActionException instead, which is caught by extbase Dispatcher and then returned. This is ugly. The patch changes this and deprecates the StopActionException. We can not drop the throw call since that would be breaking, but we prepare towards a clean v12 solution, which leads to the sitation that *all* extbase actions return a response. Resolves: #94351 Releases: master Change-Id: Ie5a53109959a008ab1666f52d5a81e6e7ba3efdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69498 Tested-by:core-ci <typo3@b13.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94351-ExtextbaseStopActionException.rst 60 additions, 0 deletions...aster/Deprecation-94351-ExtextbaseStopActionException.rst
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php 9 additions, 17 deletions...ysext/extbase/Classes/Mvc/Controller/ActionController.php
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php 8 additions, 0 deletionstypo3/sysext/extbase/Classes/Mvc/Dispatcher.php
- typo3/sysext/extbase/Classes/Mvc/Exception/StopActionException.php 7 additions, 0 deletions...ext/extbase/Classes/Mvc/Exception/StopActionException.php
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php 4 additions, 1 deletion...ager/Classes/Controller/UploadExtensionFileController.php
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php 13 additions, 30 deletions...sysext/form/Classes/Domain/Finishers/RedirectFinisher.php
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php 7 additions, 0 deletionstypo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php 2 additions, 2 deletions...form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php
Please register or sign in to comment