[TASK] Avoid ObjectManager in ext:fluid ViewHelperResolver
Finish the ObjectManager usages in ext:fluid. With #94285 we made the ViewHelperResolver a singleton service, which is not ok since it holds state: Namespaces are added at runtime and they additionally depend on request. The solution is similar to RenderingContext from #94285 though: Have a factory to create fresh instances for each parsing cycle for this failsafe mode enabled class. View helper instance prototypes itself are then retrieved using GeneralUtility::makeInstance(). Resolves: #94292 Related: #94285 Related: #90803 Releases: master Change-Id: I08018b57e3bd5b293be999d7c5415578604c7897 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69419 Tested-by:core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
Showing
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php 1 addition, 0 deletions.../sysext/fluid/Classes/Core/Rendering/RenderingContext.php
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContextFactory.php 13 additions, 11 deletions.../fluid/Classes/Core/Rendering/RenderingContextFactory.php
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php 39 additions, 18 deletions...sext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php 55 additions, 0 deletions...uid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php
- typo3/sysext/fluid/Classes/ServiceProvider.php 8 additions, 4 deletionstypo3/sysext/fluid/Classes/ServiceProvider.php
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php 1 addition, 4 deletions...ysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php
- typo3/sysext/fluid/Configuration/Services.yaml 83 additions, 0 deletionstypo3/sysext/fluid/Configuration/Services.yaml
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/ViewHelperResolverTest.php 12 additions, 16 deletions...uid/Tests/Unit/Core/ViewHelper/ViewHelperResolverTest.php
Please register or sign in to comment