- Aug 01, 2022
-
-
Christian Kuhn authored
Bump a series of casual dependencies to youngest versions. Left out: composer, psr, symfony > composer req bacon/bacon-qr-code:^2.0.7 > composer req bacon/bacon-qr-code:^2.0.7 -d typo3/sysext/core/ --no-update > composer req doctrine/event-manager:^1.1.2 > composer req doctrine/event-manager:^1.1.2 -d typo3/sysext/core/ --no-update > composer req lolli42/finediff:^1.0.2 > composer req lolli42/finediff:^1.0.2 -d typo3/sysext/core/ --no-update > composer req nikic/php-parser:^4.14.0 > composer req nikic/php-parser:^4.14.0 -d typo3/sysext/core/ --no-update > composer req nikic/php-parser:^4.14.0 -d typo3/sysext/install/ --no-update > composer req typo3/html-sanitizer:^2.0.15 > composer req typo3/html-sanitizer:^2.0.15 -d typo3/sysext/core/ --no-update > composer req --dev friendsofphp/php-cs-fixer:^3.9.5 > composer req --dev php-webdriver/webdriver:^1.12.1 > composer req --dev phpstan/phpstan:^1.8.2 > composer u typo3/cms-styleguide Change-Id: Ia1848985be5aba038b8971ccee9f58f0b049b84c Resolves: #98062 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75343 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jul 31, 2022
-
-
Andreas Fernandez authored
Bootstrap is updated to 5.2.0. Due to a behavior change (perhaps a regression), carousels need adoption if they shouldn't slide automatically as the old approach results in indefinitely sliding: ``` - <div class="carousel slide" data-bs-interval="0" data-bs-ride="carousel"> + <div class="carousel slide" data-bs-ride="false"> ``` However, this is also documented at [1]. Executed commands: cd Build nvm use yarn add bootstrap@^5.2.0 yarn add --dev @types/bootstrap@^5.2.0 grunt build [1] https://getbootstrap.com/docs/5.2/components/carousel/#options Resolves: #98051 Releases: main, 11.5 Change-Id: Ic9c284d9edb3881b4cc8663fad3747c19f078613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75329 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Larry Garfield authored
Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98006 Releases: main Change-Id: If809683db556c2c91ae5f560a4a796c9477d3631 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75268 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
TCA fields having displayCond='HIDE_FOR_NON_ADMINS' can not be selected as "exclude" fields in user group setup access rights setup. It does not make sense to mark those exclude=true, the patch removes that from affected fields. Change-Id: Ia75248122bb645bd24c7948c7b4b82d2555ed9ee Resolves: #98046 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75324 Reviewed-by:
-
Christian Kuhn authored
When executed in random order, a parent directory may not exist. Take care it's created when needed. Resolves: #98060 Releases: main Change-Id: I102aedc8013157527759111d8080a8ee012c7c8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75338 Tested-by:
-
Christian Kuhn authored
The old TypoScript parser allows implementing own functions for the := operator using a hook: someIdentifier := myCustomFunction(myFunctionArgument) The new TypoScript parser does not implement this hook and adds a new event instead. Resolves: #98016 Related: #97816 Releases: main Change-Id: I66dd4e393333c239b75a5935aacdbde46b1518e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75280 Tested-by:
-
Stefan Bürk authored
Codeception released new major version 5, which unblocks upgrading to symfony 6 components. This patch raises codeception only, thus acting as a pre-patch to raise symfony requirements. Codeception 5 is hard to impossible with core v11, so this patch is v12 only: Codeception 5 requires PHP 8.0, so we'd have to support both 4 and 5 in v11 to allow testing with older PHP versions. This would result in various headaches since some API changes in codeception 5 are hard breaking in PHP, especially due to changed class property type hints. We'll thus keep codeception 4 in v11 and go with codeception 5 in v12. Minor acceptance test related adaptions are needed: * Replaced config option `path.log` with `path.output` * Added proper property type because of inheritance to codeception setup classes * Ensure method return type compatibility * Use `actor`instead of `class name` in suite config * Create acceptance split files in proper folder to ensure group filtering keeps working. Adjust clean up scripts and gitignore for this Used commands: > composer req --dev -w \ typo3/testing-framework:dev-main \ codeception/codeception:^5.0.0 \ codeception/module-asserts:^3.0.0 \ codeception/module-cli:^2.0.0 \ codeception/module-filesystem:^3.0.0 \ codeception/module-webdriver:^3.1.2 \ codeception/lib-asserts:^2.0.0 Resolves: #98047 Releases: main Change-Id: I5cea60c2641988cc032b30ed1fbe3d8b0ed3b3d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75317 Tested-by:
-
Peter Kraume authored
Resolves: #98059 Releases: main, 11.5 Change-Id: I078db9039c2f0acb05933fa6a86ca5d73b3fb5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75337 Reviewed-by:
-
Christian Kuhn authored
Fluid 2.7.2 brought optional TemplateAwareViewInterface. This is used in two places for proper signatures and makes phpstan a bit more happy. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98057 Related: https://github.com/TYPO3/Fluid/pull/586 Releases: main Change-Id: I8b55af0d58b86a0f68dc3772e3ba66716ea32202 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73611 Tested-by:
-
- Jul 30, 2022
-
-
Stefan Bürk authored
Using database queries without deterministic sorting definition may lead to unreliabe resultsets in some dbms type and version, which also may change over time. Thus it's good practice to have proper defined sorting for queries, at least if result relies on a constant and reliable result sorting. With #96512 and #97774 additional tests has been added, which showed the unreliable of these database queries, blocking the bugfix backport to TYPO3 v10.4. This patch adds sorting definition to two db queries in `\TYPO3\CMS\Backend\Tree\Repository\PageTreeRepository` to ensure consistent results in a deterministic manner and make it possible to provide the related bugfix for TYPO3 v10.4. Resolves: #98056 Related: #96512 Related: #97774 Releases: main, 11.5, 10.4 Change-Id: I8a1bf3b93bcfcaec4c3de3ea6321db62847d0c21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75333 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Larry Garfield authored
The $result property's doc type is causing issues for PHPStan. Switching it to a typed property and state resolves them. Other types have been filled in as well as they're private so safe. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98002 Releases: main, 11.5 Change-Id: Ic960858eee4cd40ed010762a44dec944f5114e4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75263 Tested-by:
-
- Jul 28, 2022
-
-
Benni Mack authored
When using routing and custom enhancers to find out what page translation was exactly used to build special logic for Page resolving, the two language-related properties "sys_language_uid" and "l18n_cfg" are now loaded (and thus, added to the "_page" property of a Route) as well. This is useful as l10n_parent is already loaded anyways. Resolves: #98042 Releases: main, 11.5, 10.4 Change-Id: I23f964d5d22f27a9affebfeae87906d9549efda0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75311 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Raising from 2.7.1 brings: * A couple of bug fixes, especially ternary should work much better when cached * Basic PHP 8.2 support * A couple of minor additions and more relaxed handling. Some of these will materialize in v12 with upcoming patches > composer req typo3fluid/fluid:^2.7.2 > composer req typo3fluid/fluid:^2.7.2 -d typo3/sysext/fluid --no-update > composer req typo3fluid/fluid:^2.7.2 -d typo3/sysext/adminpanel --no-update > composer req typo3fluid/fluid:^2.7.2 -d typo3/sysext/redirects --no-update > composer req typo3fluid/fluid:^2.7.2 -d typo3/sysext/core --no-update Resolves: #98048 Releases: main, 11.5 Change-Id: Ibc94b02823913347465245201442277f048c5c0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75325 Tested-by:
-
Daniel Hettler authored
Another PHP 8 sanitation checking for array key existance. Resolves: #98040 Releases: main, 11.5 Change-Id: I3f76f619fa9d58b1ce8c6b63314b617be10f8ac5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75315 Reviewed-by:
-
- Jul 27, 2022
-
-
Nikita Hovratov authored
It is convenient to see the languageId directly in the overview, without having to click on the edit button. This is especially useful for sites with a huge amount of languages. Resolves: #97954 Releases: main, 11.5 Change-Id: Ie6f0afd9f30b1b1dc680cfd0af5bf0710d4a9b8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75202 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.2 old and unreliable methods `utf8_encode()` and `utf8_decode()` have been deprecated and will be removed in PHP 9.0. There are several ways to replace these methods, although none of them are "ensured" to be native enabled in PHP. We need to replace these methods in tests only, and as we have testing setup fully under control, this patch use `mb_convert_encoding()` from php extension `mbstring` to avoid deprecated methods and corresponding native php deprecation messages in functional test. Resolves: #98038 Releases: main, 11.5 Change-Id: I8a70a203eeae6a314e30cedab8668541145ef6c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75312 Tested-by:
-
Stefan Bürk authored
With PHP 8.2 setting undefined properties in class instances is deprecated and emits corresponding deprecation notice. This patch removes a superflous test, setting a undefiend property in `TypoScriptFrontendController` to avoid PHP 8.2 deprecation message. Resolves: #98039 Releases: main, 11.5 Change-Id: I0944a13f6c87c95db01577dbdb499c39675691be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75313 Tested-by:
-
Andreas Fernandez authored
To provide a consistent look&feel and to eventually phase out FontAwesome in the TYPO3 backend, all remaining fa-* icons are replaced with their counterparts from the @typo3/icons package. The CSS class `icon-emphasized` is introduced as a drop-in replacement for the `fa-stack` construct: ``` <span class="icon-emphasized"> <core:icon identifier="my-icon-identifier" size="small"/> </span> ``` The removal of the FontAwesome integration will follow in a separate patch. Resolves: #97877 Releases: main Change-Id: I0e9ca1e4a918b3f44969ea9886ec0cd1e56d78be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75041 Tested-by: -
Nikita Hovratov authored
Since the removal of css_styled_content the TypoScript snippet `lib.stdheader` is gone. This patch removes some leftovers in the `addPItoST43` method and some other places. Resolves: #98012 Related: #80876 Releases: main Change-Id: I3e1b2795c05b464f4210abc0968f507f20f9fba7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75273 Tested-by:
-
Oliver Klee authored
This avoids problem when GU::trimExplode is switched to native type declarations. Also fix some possible invalid array accesses. Resolves: #97960 Relates: #97602 Releases: main Change-Id: I6a08b7a20f12475fbee7a5a817f1618e9466087c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75210 Tested-by:
-
Larry Garfield authored
Not marking this as breaking since it's a test fixture only. Resolves: #98034 Releases: main Change-Id: Id2dd650c617f5be807d3615751466102d274cea3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75309 Tested-by:
-
- Jul 26, 2022
-
-
Larry Garfield authored
Doing so also allows for a bit of code cleanup. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97982 Releases: main Change-Id: Id351fda2040fd7de3931a109b77ff0c947c552b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75251 Tested-by:
-
Larry Garfield authored
Also switches to constructor property promotion in the process. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98004 Releases: main Change-Id: Ic55548afe59654da4ab7fc7ab5a4cfb408ab38d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75266 Tested-by:
-
Larry Garfield authored
This was most likely a very old copy-paste error. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98025 Releases: main, 11.5 Change-Id: Idacf7ca70895a9fd1be9c765e714a68ab6e44032 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75292 Tested-by:
-
Larry Garfield authored
Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98008 Releases: main, 11.5 Change-Id: Iecadad3cc1e5089f0ab7282f5b5302ead66ce6a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75270 Tested-by:
-
Larry Garfield authored
v11 introduced support for using a Channel attribute to define what log channel should be injected into a class, either via the constructor or the LoggingAwareInterface. However, the initial patch lacked any tests. This patch adds basic tests to verify that the attribute works, and indirectly document it. Resolves: #97695 Related: #95079 Related: #95044 Releases: main, 11.5 Change-Id: I7cc97fc839ccd4015ac20b1bce787d4cbbc40a26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74750 Tested-by:
-
Larry Garfield authored
The docblock for QueryObjectModelFactory::comparison() expects a string, specifically one of the QueryObjectModelConstants.JCR_OPERATOR_* constants. However, that class seems to no longer exist, and what it actually uses is an integer. (Passing a string through would break in subsequent sub-calls.) This corrects the type to the correct integer constants that are actually used in practice, and uses a language type to ensure it is used properly. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98007 Releases: main, 11.5 Change-Id: Id00e30370a1944a3158cb46825ccc4e15174f7ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75269 Tested-by:
-
Larry Garfield authored
ExtensionStatus::getStatus()'s doc type does not account for the use of [] as a sentinel value. The extra doc type declaration in FolderBasedFileCollection::fromArray() is incorrect, as it does not account for null return values. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98003 Releases: main, 11.5 Change-Id: Ifaad71a8e65836e943b1a3813f3294e7421c5402 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75264 Tested-by:
-
Christian Kuhn authored
Property setValidatedInstancesContainer does not exist in ObjectValidatorInterface and its implementations and is never read in extbase since ever. Drop it. Change-Id: I64b5e1c4e297322fb057f2c6a1cf6f1f8103b90e Resolves: #98031 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75300 Tested-by:
-
Christian Kuhn authored
Add CI unit testing setup with PHP 8.2 in pre-merge and nightly "locked" builds: Nightly "max" and "min" builds are blocked by prophecy for now. Resolves: #98030 Releases: main, 11.5 Change-Id: Ia6814465ade7efd33eaafe9850aa62d2e907ec21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75298 Tested-by:
-
Christian Kuhn authored
Prophecy has a minor PHP 8.2 issue as reported with https://github.com/phpspec/prophecy/issues/555 This seems to be triggered by willBeConstructedWith() when SuT has constructors in its inheritance chain. Luckily, we can simplify the test a bit and circumvent the issue for now. Change-Id: I6e50de3345b5d27ec3e46fe78c4855a7a0fb7d43 Resolves: #98028 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75296 Tested-by:
-
Christian Kuhn authored
Brings PHP 8.2 fixes. Setting mikey179/vfsstream as explicit dependency since testing-framework dropped the dependency. Raising testing-framework. > composer req --dev mikey179/vfsstream:^1.6.11 > composer req --dev typo3/testing-framework:dev-main Change-Id: I4761948bd8827ab4638f280d5b69403d300afcb1 Resolves: #98026 Releases: main, 11.5, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75291 Tested-by:
-
Benni Mack authored
TYPO3's TCA definition has a setting called `cruser_id` which automatically is filled with the current TYPO3's Backend User ID, if created via DataHandler. However, this information is also available in the RecordHistory (since its extraction from sys_log in v9) and can be queried, when needed, directly from there. This way, all TCA-based tables, having the setting "cruser_id" do not need to carry this value anymore, as it is duplicated in TYPO3's data model. This change removes the evaluation of "cruser_id", and removes the filling of this property via DataHandler. The DB field is also not set anymore automatically. The Info popup (ElementInformationController) now shows the information from the RecordHistory information. Resolves: #98024 Releases: main Change-Id: I1fe54b0ecfc0ee9b2d1867011dd960e1906fd2d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75123 Tested-by:
-
- Jul 25, 2022
-
-
Nikita Hovratov authored
In a scenario, where a backend user has two entry points, in which the second one intersects the first one (is a direct sub-page), pages were shown multiple times. The reason behind this was, that inside PageTreeRepository->groupAndSortPages() every page was added regardless if it was already added in a previous run. This is the case, when the same pages are found in different depth levels. E.g. 1 - Home (DB mount 1) 2 - Page 1 2 - Page 2 (DB mount 2) 3 - Subpage 1 // will be added for level 2 and 3 3 - Subpage 2 To prevent this, a guard clause was added, which checks whether the page was already added by comparing the uid value. Resolves: #96512 Resolves: #97774 Related: #96367 Releases: main, 11.5, 10.4 Change-Id: I65439011b894f05faef9cb507d905b3d7d3b709f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74258 Tested-by:Silvia Bigler <silvia@dunkelweiss.li> Tested-by:
-
Larry Garfield authored
PHPStan says all of these are unnecessary. On visual inspection, it appears to be correct. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98001 Releases: main, 11.5 Change-Id: Ic18ce25997357c786b17bc5be02cfdb3617c6eef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75262 Tested-by:
-
Torben Hansen authored
This change adds type definitions for all class properties in ext:felogin. Resolves: #98009 Releases: main Change-Id: I0c8c504a4b669e7a3e7d2f47c87a5847db59cb07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75271 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Christian Kuhn authored
Second main usage of the new TypoScript parser is the ext:tstemplate Object Browser. In contrast to the Template Analyzer patch that brought a fully revamped view with new features, this Object Browser patch is mostly just a modernization of the view, so this patch is not marked as feature. The Object Browser now renders both setup and constant tree at the same time. Other than that, most existing features are kept and streamlined along the way. As example, searching for a constant name now reveals constant usages in setup, plus similar small gems. The only missing features are currently the comments rendering, plus rendering of parser errors. Comments are a bigger issue that will be implemented with a revamped Constant Editor, Object Browser will then add comment rendering as side effect. Parts of the parser errors (detecting invalid lines) will be added to Template Analyzer with a dedicated patch soon, further details will be added to Object Browser when suitable. Change-Id: I08b2d7a1c1f60d2ab2184fb005dc1132b261f1aa Resolves: #98013 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75259 Tested-by:
-
Christian Kuhn authored
Not setting $GLOBALS['TCA']['myTable']['ctrl']['crdate'] or $GLOBALS['TCA']['myTable']['ctrl']['cruser_id'] or $GLOBALS['TCA']['myTable']['ctrl']['tstamp'] leads to rather obvious PHP 8 "Undefined array key" warnings in DataHandler. Sanitize them. Resolves: #98018 Releases: main, 11.5 Change-Id: Ia3e94ac65feede4668fd1247cd29562f3215f328 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75283 Tested-by:
-
Christian Kuhn authored
Some of the more advanced fields of sys_template records are rather hard to understand without additional description. The patch moves all more complex fields to an "Advanced Options" tab and uses the TCA "description" feature to add some explanations and hints if and when integrators should bother with them in typical scenarios. Resolves: #98017 Related: #97816 Releases: main, 11.5 Change-Id: Ifb4166dd225ec1c74339726f97ec7d7391e6996e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75281 Tested-by:
-
- Jul 24, 2022
-
-
Christian Kuhn authored
The issue has been resolved in sysbox, we don't need the patch level pin anymore. Resolves: #98015 Related: #97570 Releases: main, 11.5, 10.4 Change-Id: I1a2080ec3e8609350c9975bad8f65e69513d5f48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75277 Tested-by:
-
