- Nov 29, 2023
-
-
Oliver Bartsch authored
The link attributes of a field control are added to the link tag using implodeAttributes() with the second parameter `xhtmlSafe` set to `true`. To prevent double encoding, previously applied "hsc" calls are removed. Resolves: #102541 Releases: main, 12.4 Change-Id: If7b4f036b9cea71162a5265458e53dc05b91b7b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82010 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Oliver Bartsch authored
Adds the loading="lazy" HTML attribute to a couple of img tags, used to display thumbnails in the backend. This will improve performance, especially for larger listings, e.g. in the filelist module. Resolves: #102501 Releases: main, 12.4 Change-Id: I5f4b7c37786e8f4283bb997f40c501f09984e410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82011 Tested-by:
-
Mathias Brodala authored
Aside from being disabled itself, a form field can also be placed in a container which is disabled statically or using variants. In either case the field must not be validated since it is not rendered and thus cannot be filled by the user. Resolves: #102083 Releases: main, 12.4 Change-Id: I8f2bcd45d3563907bf5737628020ab8bf50a68bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82004 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Willi Wehmeier authored
Max values have been set to the input fields in the TCA of the sys_file_metadata table. The settings have been adjusted to the set varchar length in the ext_tables.sql file. Additionally the language column length has been adjusted to the other fields. The length is set from 12 to 45. Resolves: #102456 Releases: main, 12.4 Change-Id: Id2b7d510c16b5c2659fa0a7367edeb4f49b782f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82003 Reviewed-by:
-
Oliver Bartsch authored
Since #101859, the `setFields` property of the record list, which contains the fields to show / download is initialized in the start() method. To enable the "all columns" option again, overwriting of the property is now done after calling start(). Additionally, the module data call is removed as this is done by record list already. Resolves: #102538 Related: #101859 Releases: main, 12.4 Change-Id: I39d7348b4eaa848f012cf238abc54e3a0e5d2e31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82002 Tested-by:
-
Christian Kuhn authored
The new version fixes a false positive, adds a second warning for a problem that already is logged in the baseline, and sadly introduces one new false positive. > composer req --dev phpstan/phpstan:^1.10.46 > composer req --dev phpstan/phpstan-phpunit:^1.3.15 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102544 Releases: main, 12.4 Change-Id: I79e3854458f1061b4943d0b3fab78b1a7502b13f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82001 Tested-by:
-
- Nov 27, 2023
-
-
Christian Rath-Ulrich authored
Resolves: #102534 Releases: main, 12.4 Change-Id: I09c5cc656702c7c262638a95a28d6d0f0cf79cf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81911 Tested-by:
-
Christian Kuhn authored
> composer require --dev phpstan/phpstan:^1.10.45 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102536 Releases: main, 12.4 Change-Id: Ie529eba3c951d20bf4d0b6f2b838d329ac771805 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81982 Tested-by:
-
Christian Kuhn authored
Patch for issue #101364 came with a bug using a wrong visitor. This leads to potentially broken nested condition matching calculation and cache files being written too often. Resolves: #102531 Related: #101364 Related: #97816 Releases: main, 12.4 Change-Id: Ica84e17da9ddf4671d0f1197248eb5b396d7e8b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81910 Tested-by:
-
Benjamin Franzke authored
With #100885 the availability of the normalizedParams request attribute became a requirement for user sessions initialized with a custom PSR-7 request. Extensions like EXT:container relied on the fact that a plain request object could be passed to `Bootstrap::initializeBackendUser()`. This will be fixed in EXT:container[1] but in case other extensions relied on this as well, a fallback is now provided. [1] https://github.com/b13/container/pull/461 Resolves: #102520 Related: #100885 Releases: main, 12.4 Change-Id: Idbf5a6b3d72ecab4a9943d7bb2febf41fa4b6635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81908 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Georg Ringer authored
To avoid exceptions during the ckeditor migration the type is forced to be a string. Resolves: #102521 Releases: main, 12.4 Change-Id: Icfdedb5b6ef74720e8f7da205a66115bc6d7a39a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81909 Tested-by:
-
- Nov 26, 2023
-
-
Oliver Bartsch authored
In case an extension should be installed via the extension manager, containing code which might stop the PHP request, e.g. the common "defined('TYPO3_MODE') or die();" check, the corresponding JS component does no longer generate a SyntaxError on calling .json() on the empty response body. Instead, the error is caught and the integrator is being informed via a flash message. Resolves: #102512 Releases: main, 12.4 Change-Id: I4acc6f972be91b137c943edfec51d283e9268426 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81966 Tested-by:
-
- Nov 25, 2023
-
-
Andreas Wolf authored
Resolves: #102479 Releases: main, 12.4 Change-Id: Ic708efab47c319d60d3137c0630944bdece0bfb3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81963 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
madaxel authored
The request attribute 'frontend.typoscript' might not be initialized at the point of calling `$request->getAttribute` and will return null. Even if this indicates that something is trying to access extbase to early in the stack without taking care to bootstrap it properly, the core should avoid a fatal error at that point. Therefore, a access guard is added in the `getTypoScriptSetup` method of the `FrontendConfigurationManager` to mitigate the fatal php error. The added guard does not fix the invalid state at that point as this is impossible, so extensions messing around in that early state may now not fatal but left with an invalid and incomplete state anyway. Note: This will replaced with a dedicated meaningfull exception in v13 only in followup. Resolves: #102457 Releases: main, 12.4 Change-Id: I00ec0e95d3f5b92abf9ee5dabcf24369b5d6374b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81962 Reviewed-by:
-
- Nov 24, 2023
-
-
Oliver Hader authored
In favor of applying content security policies, inline JavaScript is dropped when navigating back to the previous form step. Resolves: #102460 Releases: main, 12.4 Change-Id: I2822067968f9b35b2f41598787b0ff6b52f20c72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81960 Tested-by:
-
Jasmina Ließmann authored
In the "References from this item" area of the "Element Information" modal, there is s preview link for references of type page. In #101276 a problem with the preview links was solved but another one introduced so that the preview links were now always deactivated. This patch now sets the correct variable in the fluid template. Resolves: #102515 Related: #101276 Releases: main, 12.4 Change-Id: I4e129c98a067e015c7dd4e56af9eb006044bab83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81907 Tested-by:
-
Jasmina Ließmann authored
The “Element information” modal displays, among other things, references to and from the selected record. In the "References from this item" area, the icon of the current data record was incorrectly always displayed. With this patch, the appropriate icon of the referenced record is now always displayed. Resolves: #102514 Releases: main, 12.4 Change-Id: I707f2c73d7d94cf02311868cbef480ff6e3cd121 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81961 Tested-by:
-
Oliver Bartsch authored
In some cases the element might not be available, making the data attributes not accessible. To prevent type errors, proper checks are added. Resolves: #102510 Releases: main, 12.4 Change-Id: I061fcb3fe4f153ff45230a86ed11edf1dfb76cd8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81906 Reviewed-by:
-
Stefan Bürk authored
Used command(s): > composer req --dev \ "typo3/testing-framework":"^8.0.7" Resolves: #102506 Releases: main Change-Id: Ib0ca2770420cdcb7ff4464a785f44e01bf02e192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81914 Reviewed-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Elias Häußler authored
When downloading or updating extension using extension manager, the resulting extensions are now properly iterated using `Object.keys`. This is necessary since the extensions are provided as objects instead of simple arrays. In addition, the relevant methods in ExtensionManagementService now have proper type declarations and annotations. Resolves: #101430 Releases: main, 12.4 Change-Id: I112d59326ed5cb788bad919a7b556f7ee95b2b41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81953 Tested-by:
-
Benjamin Franzke authored
Bash hashtables are not supported in bash v4, so we rather use a lookup function. Resolves: #102502 Related: #102450 Releases: main, 12.4, 11.5 Change-Id: Id5c875b78ec655e15d225914626769720bbc3a81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81903 Reviewed-by:
-
Oliver Bartsch authored
This follows #100227, which outsourced common multi record selection actions into dedicated JS components to be reusable in the different backend modules. This is now also done for the template part, which is therefore outsourced into a partial, coupled with a dedicated new Action object component. Resolves: #102493 Related: #100227 Releases: main, 12.4 Change-Id: I57de98240ea7479f1ab00d46a964463b9a4d1eda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81947 Tested-by:
-
Andreas Kienast authored
This reverts commit 75b558b6. The proposed and merged solution decreases the overall usability in the TYPO3 backend as users are now forced to press the <TAB> key twice to actually switch the focus to another field. One could also argue that the change that is reverted is not suitable for the target group that mostly uses keyboard navigation as said users were already able to clear fields previously. Once we have a solution that satisfies both target groups, another patch will be pushed. Change-Id: I2cfea2aee81d2c67cba91eb5eb6d5675d6d999c6 Resolves: #102504 Reverts: #102372 Releases: main, 12.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81905 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
- Nov 23, 2023
-
-
Benni Mack authored
When a hidden page is previewed in the Backend, the PreviewSimulator has a valid BE_USER object in place. However, when a preview link is generated, the PreviewUser does not have a group, thus the PreviewSimulator is not activated. For this reason, the check if the PreviewSimulator is active, needs to consider if we are in an offline workspace Resolves: #102216 Releases: main, 12.4 Change-Id: I95aadaad1de69ce6eed91acd82f4d42171a6500d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81901 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
moveDaniel authored
Releases: main, 12.4 Resolves: #102489 Change-Id: I2e0c190366bd052fdafa2d8b3e91ff7064c2465a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81941 Reviewed-by:
-
Oliver Bartsch authored
By constructing a correct command object, it's now possible to delete multiple records using multi record selection in the backend modules, using the corresponding JavaScript component, which are currently redirects, reactions and webhooks. Resolves: #102475 Releases: main, 12.4 Change-Id: Iee0a88e062df042f5835ecc8e984532b3ca940d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81936 Tested-by:
-
Benjamin Franzke authored
Allows to auto-update local images for feature-updates simply by raising them in runTests.sh (like we do for external images as well). That means `runTests.sh -u` is only needed in case patch updates are desired or needed. Resolves: #102450 Releases: main, 12.4, 11.5 Change-Id: Id9bdd679e430d57794e5d9e48f18ea67ed17d46c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81937 Tested-by:
-
Stefan Bürk authored
Resolves: #102482 Releases: main, 12.4 Change-Id: Id1b92d3b42f52a48e657dc6f53fcf6cef403841e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81932 Tested-by:
-
Benjamin Franzke authored
Removing all containers will remove their dangling volumes automatically and we can drop the manual cleanup. Parameters have been applied via: sed -i '/CONTAINER_COMMON_PARAMS/!s/\${CONTAINER_BIN} run/& --rm/' \ Build/Scripts/runTests.sh Resolves: #102449 Releases: main, 12.4, 11.5 Change-Id: I77b4166cbad427afef5c87173428433881e9eb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81927 Reviewed-by: -
Stefan Bürk authored
The php namespace integrity check uses a symfony finder to determine which files should be checked. The used pattern to ignore extension configuration folder `Configuration` excluded every file, which has `Configuration` in the path or filename. This change avoids using the nifty magic `exclude()` finder method and replace it with a more reliable `notPath()` configuration. Resolves: #102483 Releases: main, 12.4, 11.5 Change-Id: Ic0ae6eaae736b86412f8a430f11ea5b0a8e9dca9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81924 Tested-by:
-
Jasmina Ließmann authored
In the "LinkValidator" scheduler task, you need to select a start page. The button to select this page does not match the FormEngine markup. which is fixed with this patch. Resolves: #102462 Releases: main, 12.4 Change-Id: I213fde08a8a13bee462cdc3371514ce27c9e3e97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81926 Tested-by:
-
Stefan Bürk authored
The environment variable `COMPOSER_ALLOW_SUPERUSER` has been set for composer command runs to avoid the warning that you are root in the container. It has been added to the core-testing-phpXY images so it is now superflous to set it explicitly on container invocation and can be removed. Resolves: #102466 Releases: main, 12.4 Change-Id: Ib91bf883385c524a756b8d2af0fcd80b3d42bc5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81900 Reviewed-by:
-
Markus A authored
With #99048 the site settings API has been introduced and reading parts modified. However, the `ext:redirects` related site settings for auto-redirect creation missed to adjust the nested settings name for the http status code. This change uses the correct settings identifier path to retrieve the http status code used for created auto redirects again. Resolves: #102476 Related: #99048 Releases: main, 12.4 Change-Id: I6763523cdbd9f10ed41a9f03d646c08f707178de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81890 Reviewed-by:
-
Christian Kuhn authored
Avoid a second fetch of TS 'setup include tree' in TypoScriptFrontendController when it just has been calculated a couple of lines before. Resolves: #97816 Releases: main, 12.4 Change-Id: If93d796158ffd51b02eefe68ff102fbf0834821f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81899 Tested-by:
-
Andreas Kienast authored
Resolves: #102459 Related: #102331 Releases: main, 12.4 Change-Id: Id0d21abf3142577a0a2486ee1c8c42a0907e6d46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81898 Tested-by:
-
Oliver Bartsch authored
This adds the missing multi record selection with basic functionality (edit and delete records) to the redirects module. Resolves: #99567 Releases: main, 12.4 Change-Id: Id6cfef8c7e03701b47f8cc77095fe2c3f79e219c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81922 Tested-by:
-
Marcin Sągol authored
By having a high z-index on the #alert-container, notifications appear above the main interface elements, including dropdowns from the topbar. However, this may lead to a usability issue, as the notifications could obstruct user interaction with dropdowns and docheader buttons like 'Share', 'Refresh', etc. This commit updates the CSS to position the #alert-container element at the bottom of the screen. For small screens it will be centered, while for larger positioned to the right side. Resolves: #102331 Releases: main, 12.4 Change-Id: If55bc67ca14d00d77c5bc53f624334a19cf0365d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81897 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #102473 Releases: main, 12.4 Change-Id: Iac4b1884e5a4c4f49c3e346b96795366f5bccdd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81896 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Nov 22, 2023
-
-
Nikita Hovratov authored
$tokenizedContent could be null and would already cause an undefined array key warning. When passed to the strlen method, this even causes an exception. This patch adds a null coalesce operator with an empty string as default and replaces the odd strlen bool expression with a strict comparison to an empty string. Resolves: #102461 Releases: main, 12.4 Change-Id: I88464956395240990a51bdb334502cd58da347bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81895 Tested-by:
-
Andreas Kienast authored
When deleting a main record in the record list, only the first translated record was removed from the list. This affects the visual representation only. This commit changes the code to take all translated records into consideration. Resolves: #102454 Related: #101569 Releases: main, 12.4 Change-Id: I5f31ebd6e1bc9bc2bae23dbb1f7ecb49d12144bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81894 Tested-by:
-
