- Jun 13, 2024
-
-
Nikita Hovratov authored
The goal here is to have a generic PreviewRenderer, which is not tt_content specific. The StandardContentPreviewRenderer could then extend this generic renderer. This is a pre-patch to make the refactoring easier in the next patch. For this to work, GridColumnItem now exposes methods to retrieve the table from the context, the type column and the record type. Additionally, some drive-by refactorings have been done like early return statements and stricter checks. The unused variable $infoArr has been removed as well. Resolves: #102825 Releases: main, 12.4 Change-Id: I38eab3c095e06b789915600e79b7831556a25ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84705 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Feb 16, 2024
-
-
Oliver Bartsch authored
To allow `BackendUtility::getProcessedValue()` to properly resolve the labels for select options, added via TSconfig, the `pid` is now provided by `StandardContentPreviewRenderer`. Resolves: #103076 Releases: main, 12.4 Change-Id: I20777ae532b66800ea61143e1824c895c7673042 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82978 Tested-by:
-
- Feb 11, 2024
-
-
Torben Hansen authored
The language labels for `noPluginSelected` and `edit` in StandardContentPreviewRenderer can not be resolved, because the extension path is wrong. This change fixes the extension path and additionally streamlines one label output, by using `htmlspecialchars` to escape the generated label similar to the other label output in this class. Additionally a similar wrong extension path in `ExampleLinkType.rst.txt` has been adapted. Resolves: #103095 Related: #100675 Releases: main, 12.4 Change-Id: I4882133025c938fc3b6928b36237e782e9465dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82846 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Feb 09, 2024
-
-
Yann authored
An editor can trigger a TypeError exception leading to a 503 error message `trim() expects parameter 1 to be string, null given` in the backend page module by creating `menu_categorized_content` objects with `selected_categories` and then turning them into `menu_section` objects. This change mitigates the type error by using a null-coalesce fallback passing an invalid type to the `trim()` method in `StandardContentPreviewRenderer::generateListForMenuContentTypes()`. Resolves: #103052 Releases: main, 12.4, 11.5 Change-Id: I4c0ecbd20c7cdfee22fa324f6b80391be47a1b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82845 Tested-by:
-
- Dec 08, 2023
-
-
Oliver Bartsch authored
A couple of BackendUtility methods dealing with resolving labels do now also evaluate a configured `itemsProcFunc` to properly resolve the corresponding labels. Resolves: #100855 Resolves: #102616 Releases: main, 12.4 Change-Id: Ic4efe1cc2a68e7ee938ca994649e074ddbba0819 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82118 Tested-by:
-
- Dec 04, 2023
-
-
Oliver Bartsch authored
By using named parameters a couple of unused parameters can be omitted on calling BU::thumbCode(). Resolves: #102577 Releases: main, 12.4 Change-Id: Ic53ae287aab63a083e19662e217764defb3712ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82020 Tested-by:
-
- Nov 21, 2023
-
-
Oliver Bartsch authored
In case a user does not have content edit permissions, the content preview does no longer link to FormEngine, which previously lead to a couple of error messages on open. Resolves: #102421 Releases: main, 12.4 Change-Id: I0435ed67c629fdf163fabdfb1c61d5b8aacfe28e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81786 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
- Apr 20, 2023
-
-
Anja Leichsenring authored
Using sL() instead of getLL() shows direct dependencies on labels and their label files within the code. This change replaces all usages in * backend * linkValidator * rte_ckeditor with sL() calls. Resolves: #100675 Relates: #100668 Releases: main Change-Id: I76b030263987951f232caf50e7d2cd6526480215 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78759 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Apr 14, 2023
-
-
Benjamin Kott authored
- Drop default override styling for <hr> without classes - Drop unused/obsolete scss variables - Drop variable `$text-color` in favor of `$body-color`. - Drop class `.text-muted` in favor of `.text-body-secondary` - Drop class `.form-inline` from usage in the backend - Icons are now displayed correctly next to text for login provider Note: Some spacings were hotfixed for now. It is planned to clean the `mb-*` classes up at a later point. Resolves: #100437 Releases: main Change-Id: I88f1d891a18acaba6a82ca498fef45b37117758e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78448 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
- Nov 20, 2022
-
-
Christian Kuhn authored
Method return annotations identical to the return signature are useless and can be omitted. Resolves: #99143 Releases: main Change-Id: I5f268dfd166667df9df23e504575fcd904678b16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76740 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Method parameter annotations identical to the parameter signature are useless and can be omitted. Resolves: #99142 Releases: main Change-Id: I907113b7049d551113c84aadec74c93597252069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76734 Tested-by:
-
- Nov 19, 2022
-
-
Christian Kuhn authored
Resolves: #99139 Releases: main Change-Id: I398300c9db862f4207c21386fc461d98a1e6fc6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76707 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Sep 19, 2022
-
-
Benni Mack authored
The three legacy hooks * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['record_is_used'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'][PageLayoutView::class]['modifyQuery'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawItem'] are replaced by new PSR-14 Events: * TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent * TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent * TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent Additionally, the hooks * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['list_type_Info'] * $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawFooter'] are removed as the same functionality can be achieved with the existing PreviewRenderer functionality since TYPO3 v10. The previous "main class" PageLayoutView is now removed (was marked as internal) along with the interfaces for the removed hooks * TYPO3\CMS\Backend\View\PageLayoutViewDrawFooterHookInterface * TYPO3\CMS\Backend\View\PageLayoutViewDrawItemHookInterface Resolves: #98375 Releases: main Change-Id: Iac4a76dce934de31c9749076d8054ae83ac45edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75778 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 12, 2022
-
-
Oliver Bartsch authored
The StandardContentPreviewRenderer still contained special handling for the tt_content.select_key field, which however was already removed in #77934. The leftover is now removed together with related locallang labels. Resolves: #98125 Related: #77934 Releases: main, 11.5 Change-Id: I38ae07a4eced0cbd3f5ed3076661b70081252321 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75420 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jul 11, 2022
-
-
Oliver Bartsch authored
A couple of debug information, e.g. the field- and tablenames in FormEngine, are displayed depending on the user status and the debug settings. To simplify the codebase, this condition is now centralized in BackendUserAuthentication. Resolves: #97894 Releases: main, 11.5 Change-Id: I5173c48180fbf96f7408c008eeb3c71c25686d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75102 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- May 04, 2022
-
-
Annett Jähnichen authored
The patch simplifies and optimizes the readability of the page module interface. It is based on the UX Team's concept of improving user experience for editors: https://typo3.org/article/structured-content-initiative-feedback-wanted Included changes: * refactored and optimised underlying CSS for future adaptions * visually simplified content element boxes and their header buttons * visually differenciated hidden content elements with better opacity and dotted border * placed the "new content element" buttons centered in preparation for further concept implementations in dedicated patches * added a new button for content element context menu in the content element header right button bar This patch was initiated by the UX Team and implemented by Benjamin Kott. Resolves: #97306 Resolves: #95247 Related: #94629 Releases: main Change-Id: I9b4e21a7fc68ebcb17d18f65bf00096f3a295cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74254 Tested-by: Benj...
-
- Apr 08, 2022
-
-
Benjamin Franzke authored
This reverts commit a42649bd. Reasons for revert: * Missing commit message description: It deserves a description of the global scope/direction and a reference to the preparation by the UX initiative * The change was merged too quickly Resolves: #97319 Reverts: #97306 Releases: main Change-Id: I51eceefa913e13d169cafd69e9e04d08a77d1443 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74200 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Lidia Demin <typecat@gmx.net> Tested-by:
-
- Apr 05, 2022
-
-
Benjamin Kott authored
Resolves: #97306 Releases: main Change-Id: I54c6e90bf8b63e7d24fd25d62332f97a79bbe0ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74182 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
André Kraus <info@andrekraus.com> Tested-by:
-
Benjamin Kott authored
The "label" class was removed in bootstrap 5 and replaced through "badge". The "label" class was kept in place for a while to keep the compatibility as high as possible, but it's time to move on. Since bootstrap 5 also dropped support for severities on certain components, we are adding them again for the badge to keep the convenience as high as possible and avoid promoting the "utility css" approach that was introduced with these decisions as we try to keep markup changes as low as possible. This patch also reverts the SCSS includes back to relative paths. While it is possible to define additional lookup paths for the parser, so you can have shorter includes - it comes at a cost. The included sources are opaque to the user and the IDE, this means there is no support for auto-completion, quick navigation through included files and can lead to unintended overrides by the user. Resolves: #97291 Releases: main Change-Id: I9007af705a90db567353379146df1d76b2366a62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74163 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Feb 16, 2022
-
-
Oliver Bartsch authored
The StandardContentPreviewRenderer runs through a list of fields, whose value should be processed and displayed in the footer. Some of those field values might be a reference to a foreign table, e.g. in the "fe_group" field. Due to changes in getProcessedValue(), it's necessary to provide the records' uid, to be able to resolve values of fields with a "foreign_table" configuration. Resolves: #96920 Releases: main, 11.5 Change-Id: I0d8739710e478a7cb264be1d5b90b70af31de964 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73563 Tested-by:
-
- Nov 15, 2021
-
-
Christian Eßl authored
Previously, when creating a translated content element of type `shortcut`, the preview in the page module would always show the title of the reference from the original language. In case the referenced record has been translated as well, the preview now shows the translated title instead. Resolves: #92523 Releases: master Change-Id: I5dd5de3a63db916311ede94a07bb7fb3209795f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66090 Tested-by:
-
- Oct 12, 2021
-
-
Nikita Hovratov authored
The (ugly) statement strpos($haystack, 'needle') !== false can be safely replaced with str_contains($haystack, 'needle'). This is possible, as a symfony polyfill for php 8.0 functions is in place. Resolves: #95466 Releases: master Change-Id: I313f47832a254c23c6815b6b44557a01019e59e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71429 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Sep 24, 2021
-
-
Benni Mack authored
The rule trailing_comma_in_multiline is added to the PHP CS fixer configuration. This reduces possible merge conflicts in the future. The commands to apply the rules over the code base was ./bin/php-cs-fixer fix \ --path-mode intersection \ --config=Build/php-cs-fixer.php \ typo3/sysext And then: ./bin/php-cs-fixer fix --config=Build/php-cs-fixer.php Resolves: #94553 Releases: master Change-Id: I0ebbfa9edbbcde19aaeb44219a71f2f093ab705e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69825 Tested-by:
-
- Sep 17, 2021
-
-
Nikita Hovratov authored
Since commit e09082f7 (v10 release) the possibility to override the preview header was gone. This patch moves the drawItem hook out of the renderPageModulePreviewContent method to be able to pass the before rendered previewHeader to it. Resolves: #91760 Relates: #90906 Releases: master Change-Id: Ia7d29333543d764f4ebaec0330df1817032dc8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68953 Tested-by:
-
- Jun 16, 2021
-
-
Larry Garfield authored
PSR-3 has specific rules around interpolation: Messages may provide placeholders like {foo} and writers should substitute these in the messages if a context array with such a key is provided. Let's use placeholders correctly. Resolves: #94315 Related: #94356 Releases: master Change-Id: I2c285e84f1832c80828861369e99af9aff6cd267 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Tested-by:
-
- Apr 19, 2021
-
-
Georg Ringer authored
Deleted pages must be excluded at content element previews in the page module to avoid exceptions. Resolves: #93938 Related: #93659 Releases: master, 10.4 Change-Id: I8786a6a93eac354684542d54ca1270d58cb05530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68798 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
- Mar 24, 2021
-
-
Oliver Bartsch authored
With the introduction of fluid styled content in #79622, the former CType `menu` with its subtypes was splitted into dedicated content types. Since the content element preview was not adjusted, it still checked for the `menu` CType, which did not longer exist in Core, leading to no preview for any menu type was displayed in page module. The issue is fixed by adjusting the code to check for the correct content types, making the preview work again. This also replaces the last usages of LLL:EXT:lang. Resolves: #93659 Releases: master, 10.4 Change-Id: I55d40d57da5edd7083cc5c37674f3fa85039e8e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68563 Tested-by:
-
- Mar 16, 2021
-
-
Oliver Bartsch authored
The content element preview for menus displays the menu type label along with the record title of the defined pages and categories. Since the output was not properly encoded, this led to a XSS vulnerability in the page module. The issue is addressed by properly encoding user input. Note: Because of a bug in `PreviewRenderer`, the vulnerable code was most likely not executed in any TYPO3 installation after v8.6.0. Resolves: #93664 Releases: master, 11.1, 10.4, 9.5 Change-Id: I56ec17f5f07ff4d7c28f2241e0c9eeee9affd71f Security-Bulletin: TYPO3-CORE-SA-2021-008 Security-References: CVE-2021-21370 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68453 Tested-by:
-
Andreas Fernandez authored
The PreviewRenderer pattern introduced with #78450 makes use of the TCA feature `descriptionColumn` to render the content of this column in a content element's preview in the page module. The content of the column however was not properly escaped allowing a persistent XSS abuse. This patch adds a `htmlspecialchars()` to the output to escape the content properly Resolves: #93562 Related: #78450 Releases: master, 11.1, 10.4 Change-Id: I144c6c2d7f4f61f4479fac3c2d400a21f5d72405 Security-Bulletin: TYPO3-CORE-SA-2021-007 Security-References: CVE-2021-21340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68452 Tested-by:
-
- Jan 07, 2021
-
-
Anja Leichsenring authored
If a reqest object already is around, $request->getAttribute('normalizedParams')->getRequestUri() can be used as a drop in replacement. As a fallback $GLOBALS['TYPO3_REQUEST'] is almost always available and contains the request object. Resolves: #93178 Releases: master Change-Id: I2bb13a54e6b8705be5783042a4f67f9735c627a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67255 Tested-by:
-
- Nov 06, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92111 Change-Id: I28058d9e9e9886f1156a0124f0b360d9788dfdc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Oct 19, 2020
-
-
Daniel Goerz authored
BackendUtility::wrapClickMenuOnIcon() has a boolean flag to let the method return an array with tag parameters instead of a fully build HTML tag as string. As this are two completely different things and cause problems when analysing return types it should not be done in the same method. Calling BackendUtility::wrapClickMenuOnIcon() with the 7th and last argument $returnTagParameters set to true has been deprecated alongside the 5th and 6th arguments that are already unused. Resolves: #92583 Releases: master Change-Id: Ia536aa3a52085e4ebe7956997b505047340102e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66161 Tested-by:
-
- Sep 20, 2020
-
-
Stefan Froemken authored
Allow individual Fluid templates for each Plugin while Feature toggle "Fluid based page module" is activated. Resolves: #91920 Releases: master, 10.4 Change-Id: I52537dc2fcb61e16d78ed9bf71945a250a3f2f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65150 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
- Jun 14, 2020
-
-
Daniel Siepmann authored
A wrong label was used when using "Fluid based page module". This resulted in "[]" instead of "[Hidden]" for records with hidden headline. This is fixed by using the proper label reference. Resolves: #91628 Releases: master, 10.4 Change-Id: I7749cbf4441335f8493eadbb9386d95835dff9a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64850 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Apr 21, 2020
-
-
Christian Eßl authored
The fluidbased page layout refactoring done in #90882 missed two spots, where the no longer existing function getBackendLayout() is called on a GridObject. Resolves: #91162 Related: #90882 Releases: master Change-Id: I7d381fe35a02c4f1464f9c4bb9fc31b27ef02b1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64297 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Apr 20, 2020
-
-
Claus Due authored
Refactoring with the goal of: * Restoring entity-like nature of BackendLayout * Decreasing coupling between components of the page module processing and rendering. Implements a PageLayoutContext to hold all context-related objects and methods and passes the context to objects instead of passing the BackendLayout. Reduces number of methods on DrawingConfiguration so the configuration object only holds output- and behavior-related options and does not hold things like permission checks. Releases: master Resolves: #90882 Change-Id: I09f1d97a53a76ea96d6cbc18bb5549127b5a1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Apr 01, 2020
-
-
Benni Mack authored
The code that executes the drawItem hook must be called before the fluid-preview is rendered, in order to allow rendering of custom variables within the Fluid preview. This way, it behaves the same way as in the non-Fluidbased page module. Resolves: #90906 Releases: master Change-Id: Id7998446b211763da3d3b7be89a4d7016f2fb54f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64020 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
