- Jun 13, 2024
-
-
Nikita Hovratov authored
The goal here is to have a generic PreviewRenderer, which is not tt_content specific. The StandardContentPreviewRenderer could then extend this generic renderer. This is a pre-patch to make the refactoring easier in the next patch. For this to work, GridColumnItem now exposes methods to retrieve the table from the context, the type column and the record type. Additionally, some drive-by refactorings have been done like early return statements and stricter checks. The unused variable $infoArr has been removed as well. Resolves: #102825 Releases: main, 12.4 Change-Id: I38eab3c095e06b789915600e79b7831556a25ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84705 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104071 Releases: main, 12.4 Change-Id: I9e0958168cf9812e20fbd3d3be2ce8dab80a8bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84641 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Nedbal authored
With the rework of moving the "Show clipboard" toggle into the view mode dropdown for the list and filelist module, the functionality of the user TSconfig "options.file_list.enableClipBoard" and the page TSconfig "mod.web_list.enableClipBoard" has been broken. This commit fixes the functionality, aligning it with the documented behaviours. Resolves: #102145 Releases: main, 12.4 Change-Id: I17e3677638ea9d2f950a9f8d6c33ad089fc813c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84642 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Georg Ringer authored
SuggestWizard should also find records in workspace. Resolves: #81732 Releases: main, 12.4 Change-Id: Ic552cd3329174632eb5be92ff9f7876959a454f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84640 Reviewed-by:
-
Oliver Bartsch authored
The toggle button to open the selection options of the multi record selection component does now provide an aria-label to make it accessible for screen readers. Resolves: #104089 Releases: main, 12.4 Change-Id: I89af5e4f5a0f8dd87be5d532bdd894bd2636502e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84689 Reviewed-by:
-
Andreas Nedbal authored
Before it was not really clear if/where a select check box header was collapsible. This patch unifies the layout with the one of the recordlist tables, adding a button specifically responsible to collapse/expand the group. Resolves: #98683 Releases: main, 12.4 Change-Id: I6b47cdc9cd2673a85aaa0bfb85dd70534e4ffc33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84638 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104025 Releases: main, 12.4 Change-Id: I32b509644018eaa4de452f499d525c6822addad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84636 Reviewed-by:
-
Jasmina Ließmann authored
The TYPO3 backend has a bookmark function with which records can be saved as bookmarks. Since any other record type can be saved in addition to pages, the corresponding link titles are now adjusted. Resolves: #104053 Releases: main, 12.4 Change-Id: If8c894bdcd6e2aa0cbe3c29276a32ac18355a370 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84678 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jun 12, 2024
-
-
Michael Telgkamp authored
The rootpages in the site configuration do not have intendation any longer. The computation of the margin value and the unused inline style are removed. Resolves: #104066 Releases: main, 12.4 Change-Id: Ic75d7e10638b2ee3fb06f42add1a36c180f754e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84635 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104060 Related: #104046 Releases: main, 12.4 Change-Id: I2b7b8c8911cd3f5552a287a73942c11806f4b8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84634 Tested-by:
-
Christian Rath-Ulrich authored
To improve accessibility, an aria-label is added to all context menu buttons to allow assistive technologies to announce them correctly. Resolves: #102490 Releases: main, 12.4 Change-Id: Ia397ab17a8fcbfe3a1ea75e86733a6a5a778653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84667 Tested-by:
-
Oliver Bartsch authored
The "revert selection" action of the SelectCheckBoxElement does now properly handle the current element's "checked" state. This way, the action button gets visible once the initial state is changed (by checking / unchecking checkboxes) and is disabled again, in case the initial state gets restored. Resolves: #104062 Releases: 12.4 Change-Id: Iad14f36c1b8c0de23f4c152a5fd4ba1a4fbee6da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84628 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jun 11, 2024
-
-
Oliver Hader authored
Change-Id: I86360df1a2a39b3fb1ebca927fe2a714bc887691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84600 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Change-Id: If61da3b4e4166c368989faab63ae87c26330e588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84599 Tested-by:
-
Andreas Kienast authored
The drag&drop issue reported in #103877 also affects the icons in the page tree, which was not fixed back then. This commit now takes care of the page tree icons as well. Resolves: #104033 Related: #103877 Releases: 12.4, 11.5 Change-Id: I92381a07bfba2d90d7fc1a85097c54f0d4a7b282 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84593 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
Avoid redirecting to /typo3/empty, which is not helpful to the context. As long as there is not module context in shared record-edit links, it's best to show the first backend module on close of such a view. Resolves: #104028 Releases: main, 12.4 Change-Id: Ia7d50f4e906e92b7f93b6e444f7b18fafcc1ea1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84577 Tested-by:
-
- Jun 10, 2024
-
-
Garvin Hicking authored
When the configuration for `mod.web_layout.BackendLayouts` contains column definitions with an empty content, this will make both the list view and the normal page view in the backend fail. This makes using the GUI editing of the 'backend_layout' records impossible to be fixed/addressed. This patch now does a more lax check on the 'columns.' array to prevent PHP error notices on invalid array key access. Resolves: #103425 Releases: main, 12.4, 11.5 Change-Id: I68c9b5a1ee8f0a70e3808338aa9dd2ed6f12c882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84572 Tested-by:
-
Oliver Bartsch authored
When inserting a record via the element browser, the value argument needs either to be formatted manually or left empty, allowing the element browser to format the identifier automatically. By omitting the value in the `PageBrowser` module, the value is now correctly formatted by the element browser to "pages_<uid>". This makes the "node-action" usable for TCA group fields, which allow more than one record type. The same logic is also used by the `BrowseDatabase` module, which also omits the value argument. Resolves: #103700 Releases: main, 12.4 Change-Id: I80e2cc696d85b5ec83432c35a263b19f9752b0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84553 Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104016 Releases: main, 12.4 Change-Id: I509554667d6aa5a97a51419ecef79fd60ccb377a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84471 Reviewed-by:
-
Thomas Hohn authored
This patch extends the access checks for modules. This is done by checking both the module identifier and potential aliases. Resolves: #103967 Releases: main, 12.4 Change-Id: Ifc534356f75244ccac81b763bd624fe13f68aa72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84468 Reviewed-by:
-
- Jun 06, 2024
-
-
Andreas Kienast authored
With Chrome 125, changes in the drag&drop handling were introduced [1] that trigger a text selection when dragging nodes from the page tree toolbar. In the `dragstart` handler, the default action is now prevented. [1] https://developer.chrome.com/release-notes/125#interoperable_mousemove_default_action Resolves: #103877 Releases: 12.4, 11.5 Change-Id: Iad75db78bba3e7b5ad01a568dcab2eb770f1c4a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84483 Reviewed-by:
-
- Jun 04, 2024
-
-
Andreas Kienast authored
The stylesheet loading process in IRRE was kept for several years and moved from version to version. A recent change in #103375 migrated a usage of `delete` to `.splice()`, breaking stylesheet loading as the original iterated object was modified. Since the code was quite dated and had other potental bugs, the whole loading sequence has been transformed to functional programming style to reduce complicated, potentially error-prone, array operations. Resolves: #103971 Related: #103375 Releases: main, 12.4 Change-Id: I18caafc68ceebce53723b7208270043faafc7458 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84488 Tested-by:
-
- Jun 03, 2024
-
-
Imko Schumacher authored
The value of the `time` input is sent as an ISO date to the FormEngine, except for the time "00:00", which is just submitted as "0". This has lead to the input field not getting populated by the JavaScript initialization, and the input "00:00" was lost. In cases where such a `time` input is set as a required field, the validation would then fail because of the field getting interpreted as being empty/unset. With this patch, a "0" value is also interpreted as a valid "1970-01-01T00:00:00+00:00" string, that is parseable by FormEngine. Note this only affects display within the FormEngine; the format of the stored data is not changed (converted by DataHandler to proper values and covered by existing tests). IMPORTANT: This only applies to NULLABLE time|timesec inputs. Only for this configuration it is possible to decide, that a stored "0" value in the database is actually "00:00" and not an unset entry. Integrators/developers need to set 'nullable' TCA key to 'true' of the corresponding 'config' array, in case they want to make a time/timesec input picker be able to store and retrieve "00:00" as a valid timestamp. Resolves: #102602 Releases: main, 12.4 Change-Id: Id5dae6564a5da9ab3abd99bdc14b718cc7064464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84459 Tested-by:
-
- May 31, 2024
-
-
Andreas Kienast authored
With migration away from prophecy during v12 development, the variable `$siteMockRevelation` is not needed anymore as phpunit mocks don't know the concept of revelations. Resolves: #103958 Releases: main, 12.4 Change-Id: I92497737dfbba3ef1cd99e4fbd96751e00057a16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84457 Tested-by:
-
- May 29, 2024
-
-
Georg Ringer authored
If no icon is provided for submodule, use a fallback to the icon of the parent module instead of directly using the empty-empty icon. Resolves: #103904 Releases: main, 12.4 Change-Id: I4e989483880fd88df904e9028f1d2cf6cd5c29f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84454 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 27, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change removes the `null` default value and adds the `?` nullable operator to the previousException parameter for the `\TYPO3\CMS\Backend\Form\Exception\DatabaseRecordException` constructor. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #103926 Releases: main, 12.4, 11.5 Change-Id: I4d1506b24b3113a74b37b986fa4f23f24e6219fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84360 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- May 26, 2024
-
-
Christian Kuhn authored
And rename the method since those general getButtons() methods are ugly. Resolves: #103914 Related: #103903 Releases: main, 12.4 Change-Id: Iaa428d711b98d2bf178aa0ba54ab507f7ca1c09b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84358 Tested-by:
-
- May 25, 2024
-
-
Georg Ringer authored
The shortcut button requires the resolved name as display name and not the LLL path. Resolves: #103903 Releases: main, 12.4 Change-Id: I59e38bf9c40f0a940fecb6ac3178b2976f168069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84398 Tested-by:
-
Georg Ringer authored
The configuration `foreign_table` of the type `select` is optional. Add a check to avoid PHP warnings. Resolves: #103825 Releases: main, 12.4, 11.5 Change-Id: I65925bae287a0ed340c67923ac4e4a2c72ce9d28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84395 Tested-by:
-
- May 24, 2024
-
-
Stefan Bürk authored
This change adds some tests for the `EXT:backend` ThumbnailViewHelper, mainly to cover fix #102571. Resolves: #103846 Related: #102571 Releases: main, 12.4 Change-Id: Id1acf6ddf6bc68c2dff0bfb7875859e07768e2af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84353 Tested-by:
-
- May 21, 2024
-
-
Oliver Bartsch authored
The value of an `label_alt` field might be an array, e.g. for TCA type `select` fields. Those values must not be formatted as this is done by `BU::getProcessedValue()` after resolving the correct record relation. Resolves: #103838 Releases: main, 12.4 Change-Id: Ibfec36d2df94661fde2d82eb60bb2736205d17c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84352 Reviewed-by:
-
- May 14, 2024
-
-
Andreas Kienast authored
The label for the delete action was encoded twice, leading to text issues in case special characters are involved. This commit makes use of `GeneralUtility::implodeAttributes()` to solve this issue properly. Resolves: #103827 Releases: main, 12.4, 11.5 Change-Id: Ia9f7ba5adf46b470a33b9065e49b8599a24fdfad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84274 Tested-by:
-
Benni Mack authored
This change allows for search for UIDs of versioned records in the page tree, which have been created within the workspace. Resolves: #103237 Releases: main, 12.4 Change-Id: Ia836d6ff50a9a8dccce69666a1f3614e959a2b19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84292 Tested-by:
-
Oliver Hader authored
Change-Id: I38c57b5342892945c8b91bb72570faa9b5a28665 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84271 Tested-by:
-
Oliver Hader authored
Change-Id: Iedbda8b0217bab62bb7647a7c962f564faaf003e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84270 Tested-by:
-
- May 13, 2024
-
-
Benjamin Franzke authored
When a content element (CE) gets edited or the visibility is toggled, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #103381 it was not possible anymore to click the "+ Content" button above such CE. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, `overflow: hidden` was removed to make the `box-shadow` of the CE visible, finally causing this bug. To solve this issue the pseudo element add it #97036 is replaced by the CSS option scroll-padding-top. It incorperates the maximum docheader size plus a slight margin that is slightly lower than the grid margin – but not equal to – to move shadows of adjacent elements out of sight. Resolves: #103672 Related: #103381 Related: #97036 Releases: main, 12.4 Change-Id: I8d5c9eadd45e5507e39b1fb728de65d31c1d6689 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84234 Reviewed-by:
-
- May 03, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/element/table-wizard-element` is tightly coupled to FormEngine's `TextTableElement`, therefore said module is moved to the FormEngine namespace. Additionally, the element gets renamed to `typo3-formengine-table-wizard`. Resolves: #103725 Releases: main, 12.4 Change-Id: I1c020a4ec6045007ab4c1f42289fe0a9c842f794 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84117 Reviewed-by:
-
- May 02, 2024
-
-
Willi Wehmeier authored
The clear-input button now has a proper title and additionally an aria-label to guide visually impaired users. The button isn't read out by screenreaders when navigating the site linearly (due to tabindex="-1") but when hold-pressing the button with the mouse pointer, a screenreader will search for a human readable label. We therefore add an aria-label attribute. The title attribute is added for sighted users but will be ignored by screenreaders since it's value equals the value of the aria-label attribute. Resolves: #103417 Releases: main, 12.4 Change-Id: I4cbbe5200476a7d84ef1d675911ddd51f5899e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84106 Tested-by:
-
- Apr 30, 2024
-
-
Frank Naegler authored
This patch adjusts the flash message and notifications elements by removing the h4 tag to prevent incorrect header flow throughout the content structure, allowing for better flexibility based on different use cases. Resolves: #103762 Releases: main, 12.4 Change-Id: Ide330150145d5c4965410fbf61973ef682bb96b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84093 Tested-by:
-
Frank Naegler authored
This patch adjusts the infobox/callout element by removing the h4 tag to prevent incorrect ordering in the content structure, allowing for better flexibility based on different use cases. Resolves: #103761 Releases: main, 12.4 Change-Id: I2556ea0df0e55ffcdf752c9c0574b843ffea44ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84094 Tested-by:
-
