- Oct 05, 2023
-
-
Nikita Hovratov authored
This event can be used to dynamically generate TCA and add it as additional base TCA. This is especially useful for "TCA generator" extensions, which add TCA based on another resource, while still enabling users to override TCA via TCA overrides as usual. Resolves: #102067 Releases: main Change-Id: I6d96e18b94f2a53693037b46e3b23d3b7f657154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81297 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
core-ci <typo3@b13.com>
-
Stefan Froemken authored
While migrating CKEditor5 property buttons.link.properties.class.allowedClasses the CKEditor5Migrator will now respect multiple classes. Resolves: #100841 Releases: main, 12.4 Change-Id: I245e8b0c8b2d14ee7917471963f29a9d65480245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78994 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Chris Müller authored
Resolves: #102088 Related: #101970 Releases: main Change-Id: I56c8975956fdc9dcc08a0cd61e283e46530f8033 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81321 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Torben Hansen authored
The redirects module does currently not allow to filter redirects based on the `protected` state. This making it hard to effectively administrate protected redirects on websites with a huge amount of redirects. This change introduces a new filter option in the redirect administration module which makes it possible to filter redirects based on the `protected` state. Protected redirects are now also visually highlighted by a lock-icon in the list of redirects. Additionally, unit- and functional-tests have been extended to cover redirect filtering based on the `creation_type` and `protected` state. Resolves: #102072 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I4537c2a4ab09e78ac72cc63a393fa28558180e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81303 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Josef Glatz authored
This patch improves the record history view of an element by showing the realName on top of the username if available. Resolves: #102091 Releases: main, 12.4 Change-Id: I14387e6113ea632615cddd537136660d310819a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81322 Tested-by:
-
- Oct 04, 2023
-
-
Anja Leichsenring authored
Tables with TCA columns set to type="text" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=text. Resolves: #101986 Related: #101553 Releases: main Change-Id: Id5d5ba863e83fcfdb2d716cb09e55b3fc996800b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81127 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Benni Mack authored
The internal "stripProfile" check, and the checks for "processor_enabled" are now encapsulated into GraphicalFunctions. Resolves: #102048 Releases: main Change-Id: Ied1bd2e21410c77b45f0a6f83122ce9f5020a7e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81123 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de>
-
Christian Kuhn authored
We are auto-creating more and more table columns from TCA automatically with our works on #101553. ext_tables.sql can now end up defining no column of a table at all anymore. The schema parser currently stumbles when a table definition is completely left out in ext_tables.sql. The patch allows omitting a table definition in ext_tables.sql entirely. Resolves: #102085 Related: #101553 Releases: main Change-Id: I4d63250e3baa15e094f011ed21c813bc6cb12fb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81181 Tested-by:
-
Garvin Hicking authored
The scheduler detail view offers a "delete" button to delete a task from that view. This button now properly triggers a POST request, which is required by the controller to actually handle the delete action. Resolves: #102078 Releases: main, 12.4 Change-Id: I8553994f0e0a8b0967e3d93c2c5ceba84b96cc22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81310 Tested-by:
-
- Oct 03, 2023
-
-
Simon Schaufelberger authored
In order to test local composer packages, they need to be placed under the "packages" directory in "Build/composer". To autoload these packages automatically, the necessary setup is adjusted. Resolves: #102054 Releases: main, 12.4 Change-Id: I6c40a06142efaf13493a149efc636da9837c3598 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81268 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Oct 02, 2023
-
-
Benjamin Franzke authored
Download CSS via fetch() and apply CSS scoping and URL rebasing on the client in order to avoid the need for a server side SASS wrapper that: * can not relocate relative paths * can not easily check if the resource is web accessible * had to use regex-replacements instead of straight forward replacements on a properly parsed syntax tree Commands executed: composer remove scssphp/scssphp composer remove scssphp/scssphp -d typo3/sysext/core --no-update cd Build npm install --save css-tree npm install --save-dev @types/css-tree npm run build Resolves: #101918 Resolves: #100768 Resolves: #101380 Releases: main, 12.4 Change-Id: I34dfd76c07584a482f9012de1c693f0e7f9a2cb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81295 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Franzke authored
Do not operate on the view model, but always read link attributes from the data model. Do this to avoid conflicts with the (pre)view representation of the contents which may not represent the plain data 1:1. Examples: * CKEditor5 renderes phone links in the editor preview as `href="#"`. That means `href` must not be parsed from the link (#101303). * Link classes may be alterated with stateful style classes and had therefore be filtered server side previously (#101959). This is workaround could now be removed. To make it clear that the result of getSelectedLinkElement() must not be used as data source, the (more) correct return type `ViewAttributeElement` is defined now (upstream does so too). Note that CKEditor5 uses commands somewhat like data-models, where the data is to be collected in the refresh() method. This is why we process all link-related registered attribute in there, (based on the CKEditor5 schema). Releases: main, 12.4 Resolves: #101303 Related: #101959 Change-Id: I04ee9a07c7444cd197f70d658e856d6824254020 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81266 Tested-by:
-
Oliver Bartsch authored
Resolves: #102063 Releases: main, 12.4, 11.5 Change-Id: I0ee1a4ec00ee972e9a2c8c3db442883125dacacd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81301 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Simon Schaufelberger authored
Resolves: #102073 Releases: main, 12.4 Change-Id: I18e0d9758f7d18c3d44086286b8bed8f722dd57d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81304 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Sep 30, 2023
-
-
Torben Hansen authored
There are currently 3 conditions in `PageLinkBuilder` which use loose type comparison. All 3 conditions can safely be replaced by strict type comparison. Resolves: #102071 Releases: main Signed-off-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Sep 28, 2023
-
-
Andreas Fernandez authored
This patch updates the `alwan` color picker library to the recent version 1.4, allowing us to implement localization at a later point. Executed commands: npm install --save alwan@^1.4.0 npm run build Resolves: #102061 Releases: main Change-Id: I9d30b575ad936a10c63ead7bec5e1e5c504981e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81293 Tested-by: -
Georg Ringer authored
Make the controller a bit more slim by moving database related code to the repository. Resolves: #101958 Releases: main Change-Id: I6a6f52236dcb6190d20e77f4356424e846702476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81091 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #102060 Releases: main, 12.4 Change-Id: I22acca2ecdff371a88c3cf060ac5c6707735bf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81292 Tested-by:
-
Benjamin Franzke authored
Adapt to the user expection for a style selector to only show applicable styles. The list becomes overwhelming in case a lot of specific styles (like table formatting) are shown for unrelated elements. Resolves: #99673 Related: #101627 Releases: main, 12.4 Change-Id: I482935e91c863b601676b078fab0e9ba3acd62fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81269 Tested-by:
-
Stefan Bürk authored
Sending a redirect response with a empty `Location` is invalid per RFC. Browser vendor are dealing differntly with it. * Firefox executes a redirect to the current url, leading to an `endless` redirect chain - stopping it after some recursions with a coresponding notice in the network tab. * Chrome determines this and is doing nothing at all with it - leading to a white page. From the [1] RFC regarding invalid URI spec for `Location`: > Note: Some recipients attempt to recover from Location > fields that are not valid URI references. This > specification does not mandate or define such > processing, but does allow it for the sake of > robustness. A matching redirect record with a manually entered `/` as redirect target leads in TYPO3 v11 to this behaviour. This can be mitigated by selecting the corresponding site root. For TYPO3 v12 and upwards a change in the LinkHandling has been introduced which properly handles the `/` in the link generation and correctly returning a `/` as redirect url. That change has quite some impact and is not reasonable to be backported to TYPO3 v11 within #100958. This change adds an additionally guard to the `RedirectHandler` to handle empty redirect urls as endless loop, just logging it and not responding with an redirect. This helps in v11 and keeps a safety guard for the future in this place. [1] https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.2 Resolves: #100791 Related: #100958 Releases: main, 12.4, 11.5 Change-Id: I2af2d5bf759a277ade45bd0f7740ffe0099003b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80983 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
-
- Sep 27, 2023
-
-
Torben Hansen authored
The feature toggle `security.usePasswordPolicyForFrontendUsers` has been introduced in TYPO3 12.3 to provide a smooth migration path for websites using the deprecated TypoScript based password validation in the password recovery process of ext:felogin. Since the TypoScript based password validation in ext:felogin has been removed with #101097, the previously introduced feature toggle has become obsolete. This change removes the feature toggle `security.usePasswordPolicyForFrontendUsers` and all related code. Resolves: #102023 Related: #97390 Related: #101097 Releases: main Signed-off-by:
-
Stefan Bürk authored
With #98375 hooks in the `Page Module` has been replaced by modern PSR-14 events to customize the `Page Module` rendering. The related PSR-14 events are: * TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent * TYPO3\CMS\Backend\View\Event\ModifyDatabaseQueryForContentEvent * TYPO3\CMS\Backend\View\Event\PageContentPreviewRenderingEvent This change adds some basic example how to implement event listener for these events to the corresponding feature ReST changelog file. Resolves: #102046 Related: #98375 Releases: main, 12.4 Change-Id: Ie7bdd8f365accc0224c28365da2f54e908520bd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81263 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Oliver Klee authored
Also streamline some comments. Resolves: #101988 Releases: main Change-Id: Ia1a592dd58c950a48c37f6b8fa80168a22a1ce41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81128 Tested-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Andreas Fernandez authored
When the form is in "Preview" mode and an integrator either saves or switches to the form settings, the stage itself is updated to be in "Edit" mode again, but the internal state remains in "Preview" mode, causing glitches in the UI. This patch now disables the preview state in the form model everytime the "stage area", containing the editing interface, is rendered. Resolves: #102031 Releases: main, 12.4, 11.5 Change-Id: I84b0817bb99201527dbd4b950e560631e7b1d94f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81253 Reviewed-by:
-
Stefan Bürk authored
Storages using the local storage driver with a non existing base folder are put offline automatically. However, the file list module displays a to generic error message not pointing to that fact. This change adds a concrete check for this case and displays a more specific error flash message in the file list module now. This can be tested by creating a additional local storage with a non-existing relative path, for example: `fileadmin/not-existing-folder/` Resolves: #85323 Releases: main, 12.4, 11.5 Change-Id: Ie3ad64a99c0871d258470ffc858639dee4de1108 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81155 Tested-by: -
Andreas Fernandez authored
This commit updates all Symfony components to version 6.3, as 6.2 ran out of support. Please see the upgrade document at [1]. Executed command: composer require \ symfony/config:^6.3 \ symfony/console:^6.3 \ symfony/dependency-injection:^6.3 \ symfony/doctrine-messenger:^6.3 \ symfony/expression-language:^6.3 \ symfony/filesystem:^6.3 \ symfony/finder:^6.3 \ symfony/http-foundation:^6.3 \ symfony/mailer:^6.3 \ symfony/messenger:^6.3 \ symfony/mime:^6.3 \ symfony/options-resolver:^6.3 \ symfony/property-access:^6.3 \ symfony/property-info:^6.3 \ symfony/rate-limiter:^6.3 \ symfony/routing:^6.3 \ symfony/uid:^6.3 \ symfony/yaml:^6.3 \ -W [1]: https://github.com/symfony/symfony/blob/6.3/UPGRADE-6.3.md Resolves: #102043 Releases: main, 12.4 Change-Id: Ia306d0ad34cc3fdb72a51259464491dc64fbdbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81257 Tested-by: -
Andreas Fernandez authored
The context menu component now uses the `URLSearchParams` API to build a query string for AJAX requests, being a replacement for manual string composition. Resolves: #101963 Releases: main, 12.4 Change-Id: Ifa5f46df04dc9a66f80e3d414ac0aeaa7ecb1368 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81094 Reviewed-by:
-
Stefan Bürk authored
The doctrine team realeased `doctrine/dbal 3.7.0` recently and this change raises the dependency to that version. Extension authors activating `doctrine/dbal` deprecation will then get the newest `doctrine/dbal` deprecations included in that release. That helps in preparation for planned `doctrine/dbal 4.x` upgrade with TYPO3 v13 to avoid stumpling into breaking changes. Used command(s): > composer require --no-update \ -d typo3/sysext/core \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/install \ "doctrine/dbal":"^3.7.0" ; \ composer require --no-update \ -d typo3/sysext/redirects \ "doctrine/dbal":"^3.7.0" ; \ composer require \ "doctrine/dbal":"^3.7.0" Resolves: #102042 Releases: main, 12.4 Change-Id: I34ee939fc94078df2006ad338d1e7ff1cac14a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81258 Reviewed-by: -
Andreas Fernandez authored
Resolves: #102040 Related: #101790 Releases: main, 12.4 Change-Id: I7a6a21fd98d1a9506da864d983b1f40b03f4259e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81256 Reviewed-by:
-
- Sep 26, 2023
-
-
Sven Proffe authored
Releases: main, 12.4 Resolves: #102039 Related: #97449 Change-Id: I5f7d314e40e53d09505bad92b5ce49bcc3ea8f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81254 Tested-by:
-
J. Peter M. Schuler authored
Feature #76085 introduced an admin panel option which shows red boxes with section and partials for easier debugging. However sometimes no partial name is shown in the output, because the retrieved name is not cleaned correctly. Resolves: #97509 Related: #76085 Releases: main, 12.4, 11.5 Change-Id: I087e3688fa8d5703c621e182f80b594492c11115 Signed-off-by:
J. Peter M. Schuler <j.peter.m.schuler@uni-due.de> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74484 Reviewed-by:
-
Thomas Hohn authored
Remove fallback for CKEditor removePlugins as a string. It must now be an array. Resolves: #101192 Related: #98613 Releases: main Change-Id: Ifd1bb7591c63f7e5e02bce18caea21c4c42ccff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79554 Tested-by:
-
Benjamin Franzke authored
In case a link with an invalid CSS class is edited, the class value is not simply invalidated and shown as empty (which isn't true), but a virtual select option "[ INVALID VALUE (…) ]" is added (and selected) that documents the fact that the current value invalid, but will be preserved upon updates. (as in FormEngine) This allows the editor to choose between preserving, removing or changing to another css class value. With this change applied, we can not properly remove empty value. Note that empty values previously implicitly preserved existing values, which made it impossible to remove a link title or target. Resolves: #102012 Resolves: #102013 Releases: main, 12.4 Change-Id: Iefae377a9e18467e8eb9111ef3ef7a96c89b6ce1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81176 Reviewed-by:
-
Andreas Nedbal authored
Another GFX-setting that enables PNG generation for temporary files. PNG files offer many benefits, one of them being faster generation using image processors. We previously held back on removing this setting because the temporary images using gdlib_png were significantly darker than the GIF files, but this stems from the TYPO3 default configuration using the RGB colorspace (if nothing else is set) in combination with ImageMagick. The sRGB colorspace, as recommended in the preset, should be used. If GraphicsMagick is used, generating temporary images using the RGB colorspace works fine. With this knowledge it is safe to remove the setting, but a migration notice has been left notifying users of each image processor of required migration steps. Resolves: #102020 Releases: main Change-Id: I4be795406cbb010d4b668a2de588c4591c443cf3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81184 Tested-by:
-
Chris Müller authored
Outdated manuals which are not supported anymore are removed. The missing system extensions manuals are added. Some special cases: - t3install was renamed to t3upgrade (as the Installation Guide was also renamed to Upgrade Guide) - t3l10n and t3translate are duplicates, t3l10n was removed The current list of manuals is maintained in https://github.com/TYPO3-Documentation/TYPO3CMS-Example-ExtensionManual Resolves: #102035 Releases: main, 12.4 Change-Id: I344f8a17d1c5de9dbcdc5148bed5322518d72b0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81218 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Chris Müller authored
Additionally, convert a paragraph into an attention directive to be more outstanding. Resolves: #102037 Related: #101113 Releases: main Change-Id: Ifcc5b86d844f8043784e5a251977216578a8c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81219 Reviewed-by:
-
- Sep 25, 2023
-
-
Ramón Schlosser authored
Resolves: #102029 Releases: main, 12.4, 11.5 Change-Id: Idfa299ece1011727da09421ee148a820dc4e0326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81234 Reviewed-by:
-
Chris Müller authored
Resolves: #102019 Releases: main, 12.4 Change-Id: Ib65eaf32d3bff91b943d965684eb2f0fcf25a44d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81182 Tested-by:
-
Chris Müller authored
With the change in #101933 the AfterUserLoggedInEvent is also dispatched when a frontend user is successfully logged in. Therefore, this event is added to the list of available events (although that event is not in the felogin namespace) to ease the access for the developer who looks for appropriate events regarding felogin. Resolves: #102030 Related: #101933 Releases: main Change-Id: I26bcc1cbc7648e91eeef9b9bd2564afcb8ebc268 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81216 Reviewed-by:
-
Benjamin Franzke authored
The karma unit testing framework has been deprecated and suggests to use modern alternatives instead. We use one of the recommended alternatives named @web/test-runner which is toolset by the modern-web.dev and open-wc.org initiatives. It is based on mocha and es-dev-server, which allows to run our JavaScript modules natively in the browser (without having to bundle them via rollup). Note that compiled test files have been removed from the source tree, since we configure es-dev-server to transpile them on demand, allowing error output from tests to be using original line numbers and unmangled identifiers. The tests are executed in chrome by default (locally and CI). They can be executed via: # Run once npm run test # Run tests whenever files change npm run watch:build npm run watch:test # Open browser with devtools and debug mode activated MODE=dev npm run watch:test -- --debug Configuration is prepared to run in other ...
-
