- Mar 15, 2024
-
-
Oliver Bartsch authored
Resolves: #103385 Releases: main, 12.4, 11.5 Change-Id: Ifd93dfa4049d0d3550d052fa960ae79cc5a27c34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83451 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Willi Wehmeier authored
This change makes the toggle button accessible via keyboard and sets the focus manually, so that the pagetree can be toggled via pressing space or enter on the keyboard. Resolves: #102426 Releases: main, 12.4 Change-Id: I6916cf1f19de288e961ecb0dab85c76241097d33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81817 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Willi Wehmeier authored
This patch adds a label to the action-menu used by most of the core extensions. Resolves: #102548 Releases: main, 12.4 Change-Id: I57db0e4d35b439e8841d7f4281bc09b593bb9dc4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82008 Reviewed-by:
-
Oliver Hader authored
Several tests for URI route generation are stricter and assert that either the whole URI matches, or that at least the `?cHash=` suffix is applied for the corresponding test permutations. Besides that, individual URI assertions are streamlined to use AbstractEnhancerLinkGeneratorTestCase::assertGeneratedUriEquals. Resolves: #103396 Releases: main, 12.4, 11.5 Change-Id: I65ae10fa2984021da653bac33579feb6d10a6464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83463 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Kienast authored
If an exception cannot get written into the database, e.g. due to connectivity issues, exceptions are already caught. However, this doesn't work on low-level errors that may arise if e.g. the DI container is defunct, required by `ConnectionPool` internals. The exception handling is changed to cover all `\Throwable`s. Resolves: #103402 Releases: main Change-Id: I52ce0e91e7f3297893928d6d1b79616b34e85798 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83471 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
- Mar 14, 2024
-
-
Willi Wehmeier authored
The thumbnail images in the inline file relations have the properties alt and title set to "id=x" which is only helpful when used to show the record uid in the tooltip. For screenreader users the info in the alt attribute isn't helpful at all. That's why the alt text should be empty so the thumbnail doesn't get read out by screenreaders at all. Resolves: #103397 Releases: main, 12.4 Change-Id: I233a54705c9c81e31b8852a8454165593fa8e061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83467 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Garvin Hicking authored
Two errors were made in 13.1 changelogs: Filename Features-93942-CropSVGImagesNatively.rst has an extra "s" and should be "Feature". Feature-103309-AddMoreExpressionMethodsToExpressionBuilder.rst used non-existant "info::" admonition, should be "note::". Resolves: #103394 Releases: main Change-Id: I377f523f966332541ceaef6af10efae710d14b02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83461 Reviewed-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/prefer-string-starts-ends-with` [1] into account, enforcing the usage of `startsWith()` and `endWith()` over index checking in strings. [1] https://typescript-eslint.io/rules/prefer-string-starts-ends-with Resolves: #103374 Releases: main, 12.4 Change-Id: I88640f71cbe960db2a2e2b162410ff5a79e7c55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83437 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Mar 13, 2024
-
-
Willi Wehmeier authored
The "+" labelled button in the File selector modal was just labelled with the filename as the title which doesn't give any meaning to screenreader users. To show the purpose of the button to screenreader users the title has been changed to additionally describe the action. Also an aria-label with the same value has been added. This is not ideal, because some screenreaders will read out the title twice, but on the other hand other screenreaders ignore the title or the aria-label attribute. Resolves: #103292 Releases: main, 12.4 Change-Id: Ia53fd77623e3cbd3a63a48f1bd4edc457f453c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83224 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Oliver Bartsch authored
This prevents the element browser from closing as soon as one file or folder was added. This restores previous behaviour, allowing the user to add multiple references without having to open the browser again and again. Resolves: #103369 Releases: main, 12.4 Change-Id: Id57ebe3ed115c0929beb06fd7dd136fe0f08e415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83434 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Ayke Halder authored
In the backend CEs are elevated by a surrounding box-shadow. This box-shadow was clipped off on top, left and right side. Resolves: #103381 Releases: main, 12.4 Change-Id: I3052ff7ced18e509aefb2f05c6b1bde8725572b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83445 Reviewed-by:
-
Kevin Appelt authored
Resolves: #103392 Related: #103117 Releases: main, 12.4 Change-Id: I97f9c68b6ad1c6b3ded4c70a82dbfe20eb5a9f20 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83456 Tested-by:
-
Benjamin Franzke authored
With #103197, a loading indicator was added to the context menus, which rendered a stub context-menu. The position of the context-menu needs to be recalculated once the data has been loaded (the context-menu becomes taller) in order to avoid rendering outside the visible window area. Releases: main, 12.4 Resolves: #103382 Related: #103197 Related: #103294 Change-Id: I75e3659c619d4b98c773faa4dab9bbf184471065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83450 Tested-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
Benni Mack authored
This change adapts some places around Backend Layouts, which is a pre-patch in order to centralize previously used code from 2013 to move towards a more generic concept, which needs to go into EXT:core as the structure should also be useful and evaluated in EXT:frontend. This change now cleans up places which are non-breaking but hardens PHP code without changing the underlying logic. Resolves: #103365 Releases: main Change-Id: I77382d93342e5c2e45966f96bf485619c79f25f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83362 Reviewed-by:
-
Michael Hitzler authored
Resolves: #102139 Releases: main, 12.4 Change-Id: I9eb3b759de4af5c322aedc96df169aa7c603add6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81405 Tested-by:
-
Marcin Sągol authored
When installing TYPO3, the final step (5) has been updated to include an additional checkbox. This checkbox will allow the user to decide if they want to have 2 default backend groups, Editor and Advanced Editor, installed. These groups will be created with predefined permission presets defined through YAML files in `EXT:install/Configuration/PermissionPreset/`: - be_groups_editor.yaml - be_groups_advanced_editor.yaml In these files, access is defined to to modules, dashboard widgets, table listings and editing, allowed exclude fields, etc. A new dedicated CLI command is also introduced to create these groups later if they were skipped during the TYPO3 installation process. The command can be executed by calling: ./bin/typo3 setup:begroups:default It supports both interactive and non-interactive modes and allows the creation of both groups or only one selected group. Resolves: #103187 Releases: main Change-Id: Ifd42e2e59acd6eb5808d6c754b0a2c8f6daa7c28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83087 Tested-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/restrict-plus-operands` [1] into account, prohibiting merging of type-incompatible operands. [1] https://typescript-eslint.io/rules/restrict-plus-operands Resolves: #103378 Releases: main, 12.4 Change-Id: I267272e4f384cbcabc245cd85ea493886134b026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83439 Reviewed-by:
-
Benni Mack authored
Some code in ContentObjectRenderer is not needed anymore as the query parts are not parsed anymore. Resolves: #103371 Releases: main Change-Id: Ie313c7006d2f103c48c9bac97abbd4343d277052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83408 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Mar 12, 2024
-
-
Andreas Kienast authored
The `@typescript-eslint` packages are updated for TypeScript 5.4 support. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.2.0 \ @typescript-eslint/parser@^7.2.0 \ @typescript-eslint/typescript-estree@^7.2.0 npm run build Resolves: #103370 Related: #103354 Releases: main, 12.4 Change-Id: I2c173437e1119dccb148e9eaa426cfdcdc94f682 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83435 Tested-by: -
Christoph Lehmann authored
Since #98377 it is not possible to use `f:link.page` ViewHelper in the ConfirmationFinisher template. This adds the server request to the standalone view to make it work again. Also removed wrong comment and direct usage of global request object. Resolves: #103368 Releases: main, 12.4 Change-Id: I3822cda0bb5fde9feb992696775051ec676592c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83433 Reviewed-by:
-
Andreas Kienast authored
The eslint configuration now takes the rule `@typescript-eslint/no-array-delete` [1] into account, prohibiting element removal from an array via `delete`. The problem with `delete` is that the element to be removed is in fact replaced with an `empty` slot, effectible keeping the array's size. Using `splice()` [2] is the preferred way to remove elements from an array. [1] https://typescript-eslint.io/rules/no-array-delete/ [2] https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice Resolves: #103375 Releases: main, 12.4 Change-Id: Ic742a43d44cbd8c5cc323f629cc82ad606a9858f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83438 Tested-by:
-
Oliver Hader authored
The new methods AbstractUserAuthentication::getUserName() and AbstractUserAuthentication::getUserId() can be used to resolve the corresponding values (instead of using the $user->user array). In addition, the pure system-maintainer checks have been moved into to central BackendUserAuthentication::isSystemMaintainer(). The term "pure" refers to ignoring the development context and not applying any fallbacks in case the setting is empty. Resolves: #103323 Releases: main, 12.4 Change-Id: Ia7db222dac32acc2ef13a34ded4545ba1aedefc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83306 Reviewed-by:
-
Frank Naegler authored
This change adds support for Irish Gaelic to be selected as TYPO3 Language and to connect to TYPO3 Localizations (XLF files, Site Configuration) by default. Irish Gaelic language is spoken in Ireland. [1] https://en.wikipedia.org/wiki/Irish_language [2] https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes Resolves: #103372 Releases: main Change-Id: I2259717a8fccb9baf1596f0b632287875b662df4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83436 Tested-by:
-
Georg Ringer authored
Resolves: #103362 Releases: main, 12.4 Change-Id: Ibbd242d886a9cedc3ec1ba055ec6887b6943bfa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83407 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Andreas Kienast authored
Due to merged features #103255 and #103331, the ISO language database became outdated as the introduced languages "gd" and "mt" were unknown before. This commit updates the language database. Resolves: #103366 Related: #103255 Related: #103331 Releases: main Change-Id: Ia847a5934bd9b18f1211a2dd376e1607cf1244ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83409 Tested-by:
-
- Mar 11, 2024
-
-
Ayke Halder authored
The commit messages line-length is documented as 72 characters. The commit-msg hook checks for 72 characters now. Before the hook checked for 74 characters. Resolves: #103363 Releases: main, 12.4, 11.5 Change-Id: I15138831a73e84f275e85a5cd88f0b33319f9c1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83406 Tested-by:
-
Christian Weiske authored
When the processed files are saved in a different storage, calling `$this->getStorage()->getFileInfoByIdentifier()` on a ProcessedFile that uses the original file will fail. This patch proxies the calls to the original file if necessary, just as it is already done for e.g. exists() and getPublicUrl(). Resolves: #102267 Releases: main, 12.4 Change-Id: I862340e377eef306c906bf35bf171a82876fdc01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81593 Reviewed-by:
-
Garvin Hicking authored
This change adds support for SVGs to be processed. They can be scaled and cropped, without them being rasterized (converted to pixel formats like PNG). This way, SVGs are now natively used for cropping and scaling without quality loss. All cropping operations on SVGs will create a processedFile variant, just like their pixel counterparts. The processed files will contain SVG wrappers to reset coordinate systems and apply the cropped viewBox. This way, responsive styling can be applied to generated images, and processed SVGs can also be used as background images via <f:uri.image>. Tests are added for the fluid ViewHelpers as well as TypoScript- based rendering of assets. Note that SVG cropping is solely based on the "crop" argument, either passed to a viewHelper or inferred via the sys_file_reference entry, that the image editor creates. Other arguments like `width="100c-10"` which are used for pixel cropping are not evaluated (because they rely on pixel operations). maxWidth and maxHeight attributes (like used in the backend) will accordingly force a specific size for the <img> tag and the inner SVG width/height specification. Browsers can still override this via CSS to enforce lossless resizing. This change preserves the possibility to rasterize a SVG to PNG by setting a file extension explicitly. (Remember, not all image processors support converting SVG to pixel formats; GraphicsMagick should work, ImageMagick needs additional helpers.) Example to keep PNG output format via TypoScript: ``` 10 = IMAGE 10.file = 2:/myfile.svg 10.file.crop = 20,20,500,500 10.file.ext = png ``` or via Fluid: ``` <f:image image="{image}" fileExtension="png" /> ``` Resolves: #93942 Releases: main Change-Id: Ibac79b14738294252b527e66eefa91cccac4e5b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80617 Tested-by: -
Benjamin Franzke authored
Image cropping has been performed in two steps in case a cropArea (e.g. be the editor) and a crop scale modifier (e.g. "400c" set be the integrator) was combined. These two similar values are now normalized into one cropArea, which simplifies image processing by requiring one crop+scale step instead of one pre-crop plus a second crop-scale step. Note that some tests had to be adapted either because of rounding fixes (we now use round() instead of cast-floor or ceils) and some previous unexpected results (flagged with "why!?") do now produce expected and logical results. (minWidth caused distortion instead of aspect-ratio-preserving scaling) There is one additional behavior adaption: masked sizes (e.g. "400m") no longer upscale images that are smaller. That means masked sizes effectively behaves as `maxWidth` always did. A new testcase is added for this case. Resolves: #103351 Resolves: #91855 Releases: main Change-Id: I0420144879e61072c7c53bc7edbc43541f8f795a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83299 Tested-by:
-
Oliver Hader authored
* rename `masked` to `inline-max` * add tests for image upscaling Resolves: #103361 Releases: main Change-Id: I7c89027c459947e1a8c56dad8f5f3d996c793141 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83405 Reviewed-by:
-
Christian Kuhn authored
Resolves: #103360 Releases: main, 12.4 Change-Id: I6331f4ed9d061a06962d0e70affa43bc239a78a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83401 Tested-by:
-
Can Adrian Karadag authored
If a workspace is active, the URI for a record preview link did not consider to prefix additional arguments with a "&" separator. Resolves: #103346 Releases: main, 12.4 Change-Id: I255c557593fab44482769c19f8c91d7f1980e20d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83395 Tested-by:
-
Sybille Peters authored
The action buttons in the Linkvalidator module are disabled in case all checkboxes are unchecked. In case one of the checkboxes changes its state, the state of the corresponding action button is now properly updated. Resolves: #103100 Releases: main Change-Id: I9a479df294da32f30600287ac76fe7252a23cb1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82896 Reviewed-by:
-
Benjamin Franzke authored
Improve the CLI command `setup` to allow instance creation without enforcing admin user and password to be defined. This enables to create tiny test setups where no admin user is needed or where users are imported from fixtures. Resolves: #103358 Releases: main, 12.4 Change-Id: Idb5e309eb873ade7fee153a1e9b1398e4e99bfb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83397 Reviewed-by:
-
Patrick Schriner authored
If a file relation's field config is missing the import now adds an error that makes identifying the broken TCA possible. Resolves: #103282 Releases: main, 12.4 Change-Id: I622b98fc256df2a994f0ff1477aebdd9b3953a4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83211 Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
-
Benjamin Franzke authored
The public URL resolution in lazy loaded TCA forms (e.g. inline records) is aligned to use the same path resolution mechanism as in PageRender. Releases: main, 12.4, 11.5 Resolves: #103296 Change-Id: I981af29b34393302c49dd16216f0baa580d60767 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83230 Tested-by:
-
Frank Naegler authored
This change adds support for Scottish Gaelic to be selected as TYPO3 Language and to connect to TYPO3 Localizations (XLF files, Site Configuration) by default. Scottish Gaelic language is spoken in Scotland. [1] https://en.wikipedia.org/wiki/Scottish_Gaelic [2] https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes Resolves: #103255 Releases: main Change-Id: I182ca93c38dc3a9d652e63d1c576cb37f7b36e3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83318 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:backend are replaced by the new HashService. Resolves: #103247 Related: #102761 Related: #103245 Releases: main Change-Id: I99abec6d68397bd6c9623a9a3de776b0f6cd4a8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83253 Reviewed-by:
-
Frank Naegler authored
This change adds support for Maltese to be selected as TYPO3 Language and to connect to TYPO3 Localizations (XLF files, Site Configuration) by default. Maltese language is spoken in Malta. Also see https://en.wikipedia.org/wiki/Languages_of_Malta Resolves: #103331 Releases: main Change-Id: Ib8bb4112f094f9379e8d46c90291b281335ade4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83319 Reviewed-by:
Marvin Buchmann <marvin_buchmann@web.de> Tested-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:form are replaced by the new HashService. Resolves: #103249 Related: #102761 Related: #103245 Releases: main Change-Id: I636d224764890e31ef33038eb7ec2dd0472786c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83266 Tested-by:
-
