- Jun 29, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null type to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104250 Releases: main, 12.4, 11.5 Change-Id: Ic0842784b1a647fbde6e0472a8efef934ce03663 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85005 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Garvin Hicking authored
When the TCA type "group" or "folder" is rendered in FormEngine, under certain circumstances the HTML structure would close add `<div>` elements without opening those first. This will lead to a record not being editable, because variables are wrongly transferred due to the browser-rendering of wrong HTML nesting levels. This behaviour is an edge case and only happens with this TCA configuration: * either `config[hideMoveIcons]` is set to `true` * or `config[hideDeleteIcon]` is set to `true` Resolves: #98436 Releases: main, 12.4, 11.5 Change-Id: Ibb28c6130051b3dae92b3285df0831e84634e210 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84960 Tested-by:
-
- Jun 28, 2024
-
-
Torben Hansen authored
With symfony property-info 7.1.2, the type resolving for collections has been hardened. https://github.com/symfony/property-info/commit/d0bbc495f11ab99a1e2cbf04699331b88b3c1293 Our extbase ObjectConverter test for collections uses an anonymous class with an ObjectStorage property. The annotation for the property as well as the native property type is however not a FQCN. So the anonymous class has no information about, what FQCN the `ObjectStorage` class is. The change adds the FQCN for the ObjectStorage in the anonymous class, which resolves the failing test, and adds a test with a non-anymous class to test short namespaces still work. Resolves: #104254 Releases: main, 12.4, 11.5 Change-Id: Idc64e2533e0bc6d2dccc9724643247772f4f5d11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85001 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Resolves: #104249 Releases: main, 12.4 Change-Id: I2e56c967ab27ddc855261ff53f654d5916f3dce6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84999 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104247 Releases: main, 12.4, 11.5 Change-Id: I71d8f59eaba6dd22b00f8eb7400f2b49d748e430 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84991 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104246 Releases: main, 12.4, 11.5 Change-Id: Id7713c10014da20bcd4e7976e64434c71d319bda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84988 Reviewed-by:
-
Oliver Bartsch authored
Also adds the type to the corresponding test. Resolves: #104230 Releases: main, 12.4 Change-Id: Ica9e6b63d5a2fe52cc775642562cf8f9036db081 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84958 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Some FormEngine related JS components, e.g. the slug element rely on input and text fields to have the field name set via either the special `data-formengine-input-name` - if pointing to a hidden input field - or via the standard `name` attribute. All those FormEngine elements support the readonly state, which renders only the field with the `disabled` attribute set by omitting any JS functionality. For this use case no `name` attribute is required. However, to use them in combination with other fields, e.g. as generator field for TCA type slug, the field name is now added as `name` attribute in readonly state. Resolves: #104178 Releases: main, 12.4 Change-Id: Ibd28c563c8184078805a64aa123f86d538077180 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84959 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104238 Releases: main, 12.4, 11.5 Change-Id: I340f35379b74d1ca05527a6950eab5ba66ffaae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84977 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104237 Releases: main, 12.4, 11.5 Change-Id: Ieb8d05b2e44dc448f7a2142c5ad6a91e68cf98c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84974 Tested-by:
-
Georg Ringer authored
Provide an additional test to check for correct usage of numeric keys. Resolves: #94852 Releases: main, 12.4 Change-Id: I01c73fb3e1aa0f4d458e9d349484856cb416387d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84957 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104236 Releases: main, 12.4, 11.5 Change-Id: Iba5e99b526ca37d7bb36044cd6ee1027b6c5245a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84951 Tested-by:
-
Garvin Hicking authored
Currently only `siteLanguage` was documented as usable, now also `site` is explained with the most common public getter methods and an example. Resolves: #99723 Releases: main, 12.4 Change-Id: I8cb6de70b481322c31bd6fa7b3319c74f8af517a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84956 Reviewed-by:
-
- Jun 27, 2024
-
-
Garvin Hicking authored
The migration wizard BackendGroupsExplicitAllowDeny ('Migrate backend groups "explicit_allowdeny" field to simplified format') returns Symfony formatted error messages for specific single rows. Before this patch, it was still reported as a successful migration, and the success message is formatted with "everything is great" green background, so that errors may not receive attention. This patch changes the wizard to return a failure state. This will then return the messages formatted as errors. Since the wizard migrates all rows (even the faulty ones), the wizard can then be re-executed to be marked as "done". This is not ideal, but because of the way Symfony output streams cannot reveal if they contain an error when the stream is retrieved, there is little other choice. Otherwise the Wizard API would need to receive a breaking API change to allow to carry additional meta information about "warnings" rather than just errors, which is beyond scope for current development state. Resolves: #104208 Related: #104225 Releases: main, 12.4 Change-Id: Ibde1d977bc8747a053da1360aea6c0e3f8b77f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84955 Reviewed-by: -
Georg Ringer authored
Resolves: #104216 Releases: main, 12.4 Change-Id: Ifbd5499fe8c50661cec4ec198b479978bd839084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84949 Tested-by:
-
Jasmina Ließmann authored
The "Owner" information in "Recycler" backend module is broken and never shows a valid value. This patch ensures that the correct owner information such as user name and UID is now displayed. Resolves: #104228 Releases: main, 12.4 Change-Id: Ib1ddd570e1bfe2fe86e114e946cb57413a766692 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84954 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Garvin Hicking authored
The CKEditor YAML files support a lot of configuration options to adjust the Link Browser appearance, adding additional CSS class selection, link-target selection, title attribute and others. The Link Browser configuration is mostly revealed through TCA configuration, but the YAML format was not documented yet. The documentation is updated to reflect all configuration options, and an example YAML file `EXT:rte_ckeditor/Configuration/RTE/Editor/LinkBrowser.yaml` has been added. Resolves: #104157 Resolves: #101711 Releases: main, 12.4 Change-Id: Iffed9f87a35038c01d43947e6e57a0c363cf7c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84953 Reviewed-by:
-
Benni Mack authored
12.0 allowed the option to show "scheduled records", that is: Records that are timed with starttime / endtime. However, the backend should always show records (based on the Context) with starttime / endtime ignored, but that was simply forgotten in the original patch. Resolves: #104235 Related: #91082 Releases: main, 12.4 Change-Id: I2fbc2023efbcd1039cfa0ee37b7f1c32ed743b94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84948 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Oliver Bartsch authored
This makes passing the PSR-7 Request to the PolicyMutatedEvent optional, since there are use cases where the available request is not relevant for CSP / the Event. Those usages are adjusted accordingly. Resolves: #104141 Releases: main, 12.4 Change-Id: Id4597e26850f42a444a16fe986e2136b6a543075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84952 Tested-by:
-
- Jun 26, 2024
-
-
Georg Ringer authored
Apply the latest rules of cs-fixer also on the Build directory Resolves: #104227 Releases: main, 12.4 Change-Id: Ief38397cb0870e358caa43ca505f04fbb89a86c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84851 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104210 Releases: main, 12.4, 11.5 Change-Id: Id20216f2b920b5f5c0d665a370536c447590f53c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84916 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104211 Releases: main, 12.4, 11.5 Change-Id: Ic086fc77872c54f763d774f4118517658d8d52e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84919 Tested-by:
-
Stefan Bürk authored
Since recently upgraded PHP-version the 10mb big xml unit test failes. The `\LIBXML_PARSEHUGE` xml option could be used to mitigate this case but would not explain the change from PHP yet. Thus the decision has been made to disable the failing data set as a temporary solution to avoid disturbance for core contribution until this issue has been investigated and reported to PHP itself. Resolves: #104218 Releases: main, 12.4, 11.5 Change-Id: Ifef4f18818e661312b9e56e013bb8f479146b806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84849 Reviewed-by:
-
Oliver Bartsch authored
For additional context does the PolicyMutatedEvent now provide the current PSR-7 Request. Resolves: #104141 Releases: main, 12.4 Change-Id: I1817366e77f20f6c43eef0ee209fbb419e7237e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84848 Tested-by:
-
Christian Kuhn authored
> composer req --dev typo3/testing-framework:^8.2.0 A minor release upgrade of TF needs minor type hint adaptions to keep phpstan happy. Resolves: #104212 Releases: 12.4 Change-Id: I1af6f9eca81962719878fa56394520897a6fa01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84922 Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104206 Releases: main, 12.4, 11.5 Change-Id: I0d82e0474143f63870f772002de52d26c6c960fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84907 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104205 Releases: main, 12.4, 11.5 Change-Id: Iaca12350ce8b28943fd5ce8181d42b91feb471e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84904 Reviewed-by:
-
Andreas Kienast authored
All FormEngine field types shipped in TYPO3 core use a CSS class `hasDefaultValue` that was never defined or referenced since its introduction in TYPO3 4.7 with #33235. This commit removes the remaining traces of said CSS class. Resolves: #104207 Related: #33235 Releases: main, 12.4 Change-Id: I10d70fb61f79a0c0974a6d101efb3b4cb5463060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84847 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Reifenscheid authored
The AbstractModule class is located within the 'ModuleApi' folder, so the namespace must be \TYPO3\CMS\Adminpanel\ModuleApi\AbstractModule. This patch fixes the issue. Releases: main, 12.4 Resolves: #104204 Change-Id: I28dc1777fe8900665e8a3d43a8655674dbb82185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84846 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In case of union type the null is added as additional type. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104203 Releases: main, 12.4, 11.5 Change-Id: I1e264d242e53e4d258abe82831e612ee43234d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84899 Tested-by:
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84894 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84844 Tested-by: -
Oliver Bartsch authored
The ext:form EmailFinisher allows to retreive recipients via different ways. Next to the default yaml configuration is it also possible to set recipients via flexform or via TypoScript. In such cases there might be additional whitespaces added, which would lead to the function not returning the recipients address since GU:validEmail() would fail. Since recipients are mandatory, this leads to an exception in the finisher. To prevent such "false positives", the address is now trimmed before being checked. Resolves: #104198 Releases: main, 12.4 Change-Id: Ia66cc73d477507aee6c954995d6afd6a771e6354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84841 Tested-by:
-
Stefan Bürk authored
This change adds a `@` silence operator to the usage of `preg_match()` in the `RedirectService`. This prevents errors in case of manually-entered malformed regexp patterns and follows existing similar usages of the service. Additionally, a todo comment is added to evaluate future early pattern evaluation in record creation/editing so that a proper response to invalid patterns can be emitted. Resolves: #102176 Releases: main, 12.4, 11.5 Change-Id: I88687c128986ae6fa1e2b7a3a4bf414ee8f952f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84842 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104196 Releases: main, 12.4, 11.5 Change-Id: Iec724407eed8edefed48c2e032b2105b42cabc94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84884 Tested-by:
Fabien Udriot <fudriot@omic.ch> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104197 Releases: main, 12.4, 11.5 Change-Id: Ie2fbd6369e6c59c275939c42daa8c45c22334e48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84887 Tested-by:
-
- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84840 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104185 Releases: main, 12.4, 11.5 Change-Id: I12462595d622efa1bbe2a479f159d68a984bda23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84868 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104187 Releases: main, 12.4 Change-Id: I80b1494413016658e6c5ed88485cce887178fdbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84874 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104188 Releases: main, 12.4 Change-Id: I3a3273b9176fce9b0e64a084654acf17c8738da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84876 Reviewed-by:
-
