- Nov 28, 2021
-
-
Christian Kuhn authored
Change-Id: I417f0f896e07b05d4577c865195724955fa7bc45 Resolves: #96113 Related: #92080 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72334 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Sybille Peters authored
This patch handles problems which occured with a large number of pages and also for a large number of records to be checked for broken links. The problems previously resulted in "Prepared statement contains too many placeholders" exceptions and consumption of too much RAM and (possibly) out of memory errors. Technical details about the implementation follows because this is handled slightly differently than in other areas of the core. LinkValidator used named placeholders to build database queries, and the EditableRestriction class also used a number of placeholder. Technically 'doctrine/dbal' explodes named placeholders for array values with quote type 'PARAM_INT_ARRAY' or 'PARAM_STR_ARRAY' to single unnamed placeholders for each value, using one placeholder for each array value. If multiple array value placeholder are used with a large number of values this could quickly emit the "Prepared statement contains too many placeholders" error as the limit is reached. The limit differs beetween the various database systems. One way to work around this issue is to do database operations in chunks, but it could become quite difficult to calculate the chunk size beforehand. Array values are mainly used for 'in()' or 'notIn()' query expressions, which naturally do not not have direct limits for the value count in it through all supported dbms systems. This opens the possibility to use direct value lists for these expressions. There are other dbms limitations depending on the used dbms (for example on mariadb/mysql 'max_allowed_packets', max query size setting for SQLite), which may be adjusted in some cases. However we could not safely expect that these values are monitored and adjusted, so we still need to do database operations in chunks, but make it a little easier for 'chunksize' calculations. During testing on an instance with a large number of pages, it was found that LinkValidator used up a lot of memory, reaching the configured memory limit of 2G on that system, which itself was very high already (and far beyond the recommended 256MB limit). Instead of collecting unlimited results in an array before checking links against this array, doing this for each record directly avoids excessive memory consumption during link checking. It was decided to do this in this patch directly instead of a separate patch, as this patch otherwise would not be testable in real instances. This patch does the following: * introduce two method to implode value arrays in QueryHelper * replace placeholder in EditableRestriction with quoted values * replace placeholder in BrokenLinksRepository with quoted values * introduce chunk database operations in BrokenLinkRepository * introduce chunk database operations in LinkAnalyzer * move $results array and call checkLinks() on it to the inner loop to process this for each record (instead of accumulating the results in a huge array. In the future we need to investigate and find a more generic way to handle such scenarios for larger instances. This may take some time and investigation to do this properly and in a reusable way. To not stall the bugfix further, we are doing the workarounds in this patch to solve these issues in the meantime. Resolves: #92493 Releases: master, 11.5 Change-Id: I9a596df6749d07afee9c5ac37266b876ddc6e297 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66896 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Nikita Hovratov authored
The JavaScript method "scrollIntoView" does not work for elements inside a modal or similar. It only scrolls the main page. A quick and easy alternative is to set "scrollTop" to a very high value. Resolves: #96070 Releases: master, 11.5 Change-Id: Ic5cea96177442acc57ea78cfa66b698c0dfd0f81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72280 Tested-by:
-
Stefan Bürk authored
The json_response functional test extension will soon avoid returning json encoded responses. This will make the functional frontend test suite fully transparent regarding responses. This patch prepares a couple of frontend functional tests towards this change. Resolves: #96112 Releases: master, 11.5 Change-Id: I8116caf08e4b8b76ad5d23b49954d9cb78d1c4de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72319 Tested-by:
-
Torben Hansen authored
When performing a search in the configuration module, a JavaScript error will occur, if a possible expanded tree node is not part of the search result. This patch adds checks for existence of the scrollElement variable. Resolves: #96097 Releases: master, 11.5 Change-Id: I5977dd48487563ae30407f8cf126724acc9bcb0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72320 Tested-by:
-
Jochen Roth authored
The NoteController, used to display system notes in a couple of modules, e.g. page layout, does now properly check the corresponding user permissions (show/edit/delete). Resolves: #96037 Releases: master, 11.5 Change-Id: Ic0e6670f7befa23802382c0818454c4e7c34a253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72237 Tested-by:
-
Helmut Hummel authored
Remove unnecessary bloat from the composer.json Releases: master Resolves: #96102 Change-Id: Id5353c509ec2af23baae555f63cd3f123403364e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72332 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #96111 Releases: master, 11.5 Change-Id: Id8b381371ea257eb85e2ff59d5aeb1fbb7786db7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72333 Reviewed-by:
-
Henrik Elsner authored
Resolves: #95486 Releases: master Change-Id: I6f9927e524e9d44e4e976ec948614d02d3a24edc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71452 Tested-by:
-
- Nov 27, 2021
-
-
Nikita Hovratov authored
The method getVal now always returns an array with a string at index 0 and an array at index 1. Resolves: #96001 Releases: master, 11.5 Change-Id: Ia1b321694767fa01b1de9176b87470522511d150 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72195 Tested-by:
-
Christian Kuhn authored
When TYPO3 is 'natively' called by a web server call, the main application entry point is AbstractApplication run(). When using a PSR-15 from within some other application, a request should be hand over to Application->handle(), expecting a response object. Now we have that ImmediateResponseException thrown by TYPO3 at some places. ImmediateResponseException is only caught within run(), not within handle(). A PSR-15 call to handle() will thus not catch ImmediateResponseException, it bubbles up to the calling application. PSR-15 section 1.4 of https://www.php-fig.org/psr/psr-15/: "It is RECOMMENDED that any application using middleware includes a component that catches exceptions and converts them into responses." The patch changes AbstractApplication to follow this: The ImmediateResponseException is a TYPO3 internal management exception, a calling application should never need to deal with it, but can expect to receive a response object instead. Change-Id: I2857efd2b575a9b324d3d7a23df0bca5763a8839 Resolves: #96099 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72321 Reviewed-by:
-
Sybille Peters authored
The title and description texts as well as the README.rst for system extensions are unified and some texts updated to reflect changes. Since the description and README.rst are also displayed on Packagist, the text should be chosen so that it helps people not familiar with TYPO3 know what the package is about (e.g. by preceding the description with "TYPO3 CMS"). Descriptive texts for extensions are in these files: - composer.json - ext_emconf.php - README.rst The information is displayed in the Extension Manager (ext_emconf.php), on extensions.typo3.org, on Packagist (composer.json and README.rst) and on GitHub (README.rst). We reuse the same text blocks in the following manner: 1. Extension title - used in ext_emconf.php:title and composer.json: description 2. Extension description (short) - used in ext_emconf.php:description and composer.json:description 3. Title and extension description (long) - used in README.rst. In most cases, the short description is reused, in some cases it is augmented with more information. In composer.json, the description consists of: '<title> - <description>' Also, - In the title all words are capitalized (common name) - The title always starts with "TYPO3 CMS" - The description ends with a period. Resolves: #96059 Releases: master Change-Id: I57388ff96c5fcf9a8e64cd86ed8427f70d7ef23d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72288 Tested-by:
-
Jochen Roth authored
Currently language:update command fails when a translation of a extension is missing. This has been fixed by returning a successful status code even though the file was not found on the translation server. With the additional option '--fail-on-warnings' the command fails if the download of a language pack was not successful. Missing files are still reported in CLI stdout and it still fails if the server is not reachable. Also missing translations are now logged. Resolves: #95700 Resolves: #96054 Resolves: #96055 Resolves: #96053 Releases: master, 11.5 Change-Id: I9a19de919e99b591dcf02a5cf70465ad9c5c76b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72274 Tested-by:
-
Torben Hansen authored
The feature page.includeCSS.inline checks the existence of the given file with `is_file()`. This does not work for files included with the EXT: prefix, since the path to the filename is not fully resolved any more since https://review.typo3.org/c/Packages/TYPO3.CMS/+/71457 This patch processes the given file using the `getStreamlinedFileName` function in order to resolve the relative path to the file. Resolves: #96098 Releases: master, 11.5 Change-Id: I2958eb13228622e724b5d4db1919a982fcd6247e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72324 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Daniel authored
Array access with undefined key emits undefined index warning. This patch sanitize the calls to mitigate these warnings. Releases: master, 11.5 Resolves: #96072 Change-Id: Ic86781728fcb61b4dc3d9442fe5228c6b8a81474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72282 Tested-by:
-
Christian Kuhn authored
Deprecation removal main boilerplate .rst file with a dummy entry for each section. Resolves: #96108 Related: #96107 Releases: master Change-Id: Id94f0b33ff93885caf61814d93d14965e4566b04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72330 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Helmut Hummel authored
In preparation of renaming the main development branch, the alias for the new name is added. This makes it possible to rename the branch and have a working alias, without needing to add further commits to it. composer up --lock Releases: master Resolves: #96102 Change-Id: Id01c6d562a2bdd0c42a7b6ad69019b19181c94ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72325 Tested-by:
-
Christian Kuhn authored
* TYPO3_TESTING_FUNCTIONAL_REMOVE_ERROR_HANDLER is obsolete * phpunit 9.5 is minimum requirement * An acceptance test setup detail has been activated in testing-framework by default Change-Id: Idaafa923fe8544fdd9f20395de6557be709562cb Resolves: #96106 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72329 Tested-by:
-
Christian Kuhn authored
* Obsolete importScenarioDataSet() by using importCSVDataSet() directly with absolute paths. IDE's now resolve these paths so they can be clicked to open, which is *much* more convenient when working with the .csv files. * Similar, obsolete assertAssertionDataSet() by using assertCSVDataSet() directly. * Protected constants. * Late static binding for workspace init in setUp() to simplify and streamline workspace test inheritance. * A couple of minor streamlinings. Change-Id: I9e814335b863da278e814641f6995a24778da95b Resolves: #96104 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72326 Tested-by:
-
Sybille Peters authored
Different labels for various fields of a redirect record were used in redirect list and redirect edit form. For example, both "Destination" and "Target" were used for the same field. This patch unifies the labels, preferring labels from the edit form (locallang_db.xlf). This frees up some language labels which can be removed in v12. Resolves: #95832 Related: #96015 Releases: master, 11.5 Change-Id: I2950a29ed5f20f74de3091d391e44bba292563af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72217 Tested-by:
-
Christian Kuhn authored
testing-framework got a series of v12 related deprecation removals and streamlinings already that we should fetch. It also switched branch name from master to main, which we should use from now on. composer req --dev typo3/testing-framework:dev-main Change-Id: I9bef4857ff7bec502ec5d5eaacf013d111b6d645 Resolves: #96100 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72322 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Daniel Windloff authored
Toolbar items are now automatically tagged and registered, based on the implemented `ToolbarItemInterface`, using the autoconfiguration feature from the DI container. The registration via `$GLOBALS['TYPO3_CONF_VARS']['BE']['toolbarItems']` has been removed. Resolves: #96041 Related: #62928 Releases: master Change-Id: Ic3d84752f30444d5a6be67ecbfe39e525c68e9ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72241 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Marco Ziesing authored
Add MIME types avif(s) and jxl. Update caching and compression of current and new MIME types. Releases: master, 11.5 Resolves: #96051 Change-Id: I8c0cfffe82e17ea4ae2a15981e08016a3b0a4fec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72251 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Jochen Roth authored
Currently the inline edit button is shown even though a user does not have necessary edit permissions. This has been fixed by adding the necessary checks. As a side effect, the corresponding t3js class is no longer added to the header for modules, not representing an editable record title. Resolves: #96030 Releases: master, 11.5 Change-Id: I630e97263a950cf00229ce0613e2c4d35a11425e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72233 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Nov 26, 2021
-
-
Chris Müller authored
With #95888 icon identifiers provided by TYPO3.Icons are used for module icons, where they were not already in place. The previously referenced icons are now removed for TYPO3 v12.0. Resolves: #96094 Related: #95888 Releases: master Change-Id: I6d33538c2f04770a23f634b307b42e0712e36c7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72316 Tested-by:
-
Stefan Bürk authored
A new feature has been added with #89917 to provide the possibility that user/group informations and permissions are used from parent page where the new page is created, instead of eventually configured defaults through long standing TSconfig options, or even fallback to current signed in backend user/user group. The patch extend the test cases to make more clear how this new feature is intended to work and improves the feature .rst file to show how it can be leveraged. Resolves: #96091 Related: #89917 Releases: master Change-Id: I5f4478229af69f1abda9aa9e95f1e620743d07ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72290 Tested-by:
-
Chris Müller authored
The work on this interface was 7 years ago, time to remove the todo. Resolves: #96093 Related: #62928 Releases: master, 11.5 Change-Id: Ieaf08a17eb02c60109f9fcdaf279c608f3a4a146 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72315 Tested-by:
-
Christian Kuhn authored
Our PSR-7 Uri implementation has a bug when string casting an Uri object: Creating a Uri from for instance 'https://example.com//' leads to 'https://example.com/' when string casting that object. The double slash at the end is perfectly valid and of course should not be removed. The fun part is now that we have frontend functional slug tests that test 'https://website.local//' error handling and redirect behavior. Due to the old functional test behavior that had to communicate the Uri through a PHP process, the above Uri string cast bug has been triggered. This leads to the situation that the test looks as if it tested the double-slash, while in fact it didn't. When changing v11 from php-forking based frontend site test handling to sub request handling, we actively implemented this behavior in testing-framework to stay compatible. In order to drop that hack from testing-framework, the patch now: * Fixes the bug in Uri * Adds a unit test to ver...
-
Georg Ringer authored
Instead of using `GeneralUtility::mkdir` the method `GeneralUtility::mkdir_deep` should be used to avoid errors if the parent directory does not yet exist. Resolves: #96029 Releases: master, 11.5 Change-Id: Ic5005df117ddedd8fcae5b9c41c092f8328c8a57 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72236 Tested-by:
-
Christian Kuhn authored
Table sys_language is legacy since language setup is bound exclusively to site config in v11. We don't need to import sys_language rows and assert their state in functional tests anymore. In preparation of the soon starting v12 deprecation removals, the patch drops sys_language table row imports and table state asserting in all functional tests that use .csv file based fixtures. Resolves: #96089 Related: #94165 Releases: master, 11.5 Change-Id: Iea752cf03bba690b5a04de7ce5718de274172e43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72313 Tested-by:
-
Christian Kuhn authored
The ext:linkvalidator functional tests work with a fictional domain name to test if the code finds broken external links. This can be unfortunate since it triggers DNS lookups that can be slow - such stuff should be avoided in functional tests anyway. Solution is to use localhost as test domain with an invalid path instead. This is more expressive, too. The result can be stunning: My DNS resolver for whatever reason takes ages to (not) resolve that domain using dockerized runTests.sh. I got a similar result from another coredev. The linkvalidator tests run nearly five minutes without the patch and are down to two seconds with patch. Resolves: #96087 Releases: master, 11.5 Change-Id: Idbb32ac57925c52d4cef9e8d412d56347f09a04e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72312 Tested-by:
-
- Nov 25, 2021
-
-
Christian Kuhn authored
When an element is discarded in workspaces that is referenced by another record in a group CSV field, those referencing records need to be updated to no longer list the discarded record. The patch adds a method to DataHandler discard logic to take care of that. This resolves the very last call setting assertCleanReferenceIndex to false. That test property has been a temporary solution and is dropped now, tests extending AbstractDataHandlerActionTestCase can no longer (easily) prevent the tearDown() refindex check and should never do that again. Change-Id: Ifd2e5893d2d39b77762920b8b41ab547ed20ecd7 Resolves: #96080 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72287 Tested-by:
-
Oliver Bartsch authored
Resolves: #96083 Releases: master, 11.5 Change-Id: I76d486d1b817832cbf7c62252fe4a5e3f9f94391 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72289 Reviewed-by:
-
Oliver Bartsch authored
In case a record from a no longer existing table is stored as recently opened in the user session, a PHP warning is triggered whenever the toolbar items are updated (e.g. because user opens another record). This is fixed by adding corresponding fallbacks. Resolves: #96075 Releases: master, 11.5 Change-Id: Ia99371711f2a8ef9fa6a96844476148674b5b843 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72285 Tested-by:
-
Oliver Bartsch authored
Resolves: #96069 Releases: master, 11.5 Change-Id: I2d883ebb7682ac7f402cdcb91b015ca74bdb72b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72283 Tested-by:
-
Christian Kuhn authored
Functional tests that extend AbstractDataHandlerActionTestCase test for correct sys_refindex in tearDown(). This can be avoided by setting assertCleanReferenceIndex to false, which is only a temporary solution until reference updating fully works. The patch changes some import fixtures that come without proper sys_refindex rows to avoid setting this property to false. One last call needs a dedicated bug fix and will have a dedicated patch. Change-Id: I7daa4d961372812312389dda7af13a5ac9fe8cef Resolves: #96074 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72284 Tested-by:
-
Christian Kuhn authored
ext:backend Form/Element recently got a trait with #95954 that can be easily avoided by adding the method to AbstractFormElement, which all elements should extend. Resolves: #96071 Related: #95954 Releases: master, 11.5 Change-Id: I8dc73f17b976f8191bf39bae5b51f2609778797c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72281 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stefan Bürk authored
This patch fixes a bug where a t3 page URI with _language != 0 was resolved to a page in the default language. This caused automatically generated redirects to translated pages to redirect to the page in the default language. We now use the same override handling for the '_language' parameter (as already existed for 'L') when t3 page URIs are resolved. Also, we ensure that both parameters are always removed when the final URL is generated. Furthermore, this patch adds tests to cover these cases. Using the historical 'L' parameter still works and has been added to be handled as language override. Background information: The '_language parameter' is the preferred parameter to be used to specify the language in a t3 URI, not 'L'. The behaviour of creating auto redirects on slug changes was changed previously: The target was added as LinkHandler URI (instead of the path). Along with this change, the '_language' parameter was used to ensure the target URL is generated in the needed language (#89327). This introduced a problem where a redirect always redirected to the page in default language if a t3: page URI was used with '_language'. Resolves: #96043 Related: #89327 Releases: master, 11.5, 10.4 Change-Id: I95bdeff4827eed3be30528c02331b9c9ff2836b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72242 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Oliver Bartsch authored
Using "readOnly" for a TCA field with renderType "selectCheckBox" previously led to the fact, that nothing was rendered at all. This can be seen with `tx_styleguide_elements_select.select_checkbox_4`. This is now fixed, while the whole element got a light code cleanup. This will increase performance a bit, since unneeded JavaScript is no longer loaded. Additionally, this also fixes the "expandAll" option, which was broken due to the bootstrap 5 upgrade. Resolves: #96058 Resolves: #96068 Releases: master, 11.5 Change-Id: I762d328c9f4c83558dd8fd98683f8ccfe6c4b3f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72279 Tested-by:
-
- Nov 24, 2021
-
-
Christian Kuhn authored
This fixes issues regarding sys_refindex handling when dealing with workspace mm relations. Various DataHandler tests run with disabled refindex check after performing mm related operations. All those are enabled now, so all known issues in this area are fixed. The patch touches various areas in DataHandler, ReferenceIndex and RelationHandler to achieve this. The key changes are triggered by a database scenario that is unique for mm relations. Usually, when creating a workspace record or overlay, child record overlays (for instance inline children) are also created in this workspace. For mm records, this can be different: When the local or foreign side of a record is created in a workspace, it does not necessarily mean that a connected opposite side is also created as workspace overlay. This would otherwise create the need for a recursive operation that would basically end up with "everything" being created as workspace overlay. However, mm table entries are created for these relations, leading to a situation that a workspace record can point to a non-workspace record through the mm table. Reference index entries for mm table connections are always handled from the 'local' side. For instance, with categories, 'sys_category' table is the local side, with 'pages', 'tt_content' and others being the foreign side. If now one of the records on the foreign side gets a workspace overlay record, sys_refindex rows of all connected records of the affected local side need to be created. This can lead to the funny situation that we end up with refindex rows that point from a non-workspace to a non-workspace record, but have a non-0 workspace entry. Those additional rows are needed to have "the full set" and proper sorting when looking at refindex of such a relation from the local side. The patch basically handles especially these 'foreign side has a workspace overlay' scenarios, plus the side effects that have to be taken care of when discarding and publishing these records. Additionally, a couple of side effects are tackled: First, the ReferenceIndex->updateIndex() - that's the main logic when running cli referenceindex:update command - is tuned to drop reference index entries related to meanwhile deleted workspaces. This is covered with additional tests and is done now since the code needs to iterate over existing workspaces for local-side mm records that may have workspace overlays on the foreign side. So most of the code had to be created now anyways. RelationHandler->readMM() receives a fix for a long standing bug (Issue #83582, introduced by #57169), to no longer show workspace relations in live when looking at local-side records, for instance when looking at category items in live when one of the connected items has a workspace overlay. Next to lots of comments explaining details in place and referencing the test cases that nail specific scenarios, a couple of @todo's are added to point out things we may want to tackle in the future. All in all, the patch resolves a series of issues that will especially lead to 'categories' being much more reliable in workspaces. Change-Id: I24407f93665852fa761f6fbe6c5ab249473468d2 Related: #57169 Resolves: #83582 Resolves: #96067 Releases: master, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72250 Tested-by:
-
