Skip to content
Snippets Groups Projects
Commit 4bfdf830 authored by Christian Kuhn's avatar Christian Kuhn
Browse files

[BUGFIX] Speed up linkvalidator functional tests

The ext:linkvalidator functional tests work with a
fictional domain name to test if the code finds broken
external links.

This can be unfortunate since it triggers DNS lookups
that can be slow - such stuff should be avoided in
functional tests anyway.

Solution is to use localhost as test domain with an
invalid path instead. This is more expressive, too.

The result can be stunning: My DNS resolver for whatever
reason takes ages to (not) resolve that domain using
dockerized runTests.sh. I got a similar result from
another coredev. The linkvalidator tests run nearly
five minutes without the patch and are down to two
seconds with patch.

Resolves: #96087
Releases: master, 11.5
Change-Id: Idbb32ac57925c52d4cef9e8d412d56347f09a04e
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72312


Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 1e0e4f5f
Branches
Tags
No related merge requests found
Showing
with 39 additions and 39 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment