- Jan 26, 2021
-
-
Christian Kuhn authored
Allows: * Build/Scripts/runTests.sh -s docBlockCheck * Build/Scripts/runTests.sh -s phpstan These two have been added to bamboo with #89023, but not to runTests.sh. phpstan is tuned a bit to create it's cache in .cache rather than ephermal /tmp to survive between host reboots. Additionally the number of max CPU's is restricted in phpstan to be a better neighbor on local dev machines and on CI. Resolves: #93367 Related: #89023 Releases: master, 10.4 Change-Id: I5672370b51205266ee46888837f151de8e809edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67534 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
Georg Ringer authored
Restore the translations of pagination labels to make updates easier and to have some default labels which can be used by various pagination implementations. Resolves: #93365 Related: #92529 Releases: master Change-Id: I4b5d9da4bacff4c597b41efd2677ecd665fcaa87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67533 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Composer and yarn caches are now stored to .cache/ directory within the checkout when using runTests.sh suites like -s composerInstall or -s unitJavascript. This reduces complexity in the container setup, drops possible side effects from other projects, and simplifies caching in CI. Resolves: #93363 Releases: master, 10.4, 9.5 Change-Id: I5f81459e3cc8c6df16438e27a88808a1823e29cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67529 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jan 25, 2021
-
-
Benni Mack authored
The Record History module has been revamped: * The settings are now placed as inline-form, using less space * Several "buttons" are moved to the docheader, using less space * A proper wrap around the differences is added (thanks to Nicole Cordes for the suggestion) * PHP-API - Settings are now using "getModuleData()" and "setModuleData()" * Table items for each history item are now vertically-centered * All inline stylings have been replaced by custom CSS or CSS utility classes * Labels are streamlined As a next step, the rollback view needs improvements, but is tackled separately. Resolves: #93330 Releases: master Change-Id: I5f0e680ce199cae649230870c51fde1e870eafc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67494 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Peter Kraume authored
This patch makes felogin search through all user groups until it finds one in which a redirect page id is defined. Resolves: #93338 Releases: master, 10.4 Change-Id: I55831d4fcffb5be6b5b19db71d652150fa9d289a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67497 Tested-by:
-
Christian Kuhn authored
The '-c x/y' option for acceptance and functional jobs now allows to split the set of acceptance/functional tests into chuncks just like the CI does to share resources between multiple parallel jobs. Adding this to runTests.sh allows to replay the exact same list of tests that CI does. This example will execute tests of chunk 3 from 10 chunks with mariadb and php 7.4: Build/Scripts/runTests.sh -s functional -d mariadb -p 7.4 -c 3/10 Resolves: #93361 Releases: master, 10.4, 9.5 Change-Id: I5753a8f83a3ebec6823cb0b44d4ca35f3a64055f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67526 Tested-by:
Christian Kuhn <lolli@schwarz...>
-
Christian Kuhn authored
The 'summary' section at the end of runTests.sh is cluttered with command output if -v is given. Suppress this by setting 'set +x' before summary output. Resolves: #93360 Releases: master, 10.4, 9.5 Change-Id: I1a9d3126d160d25fc2b87b0b7c5ec0c0c59b689d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67523 Tested-by:
-
Oliver Bartsch authored
All buttons in the install tool cards footer do now use proper button tags instead of anchor tags with an empty target. Also the mark/umark buttons in "upgrade docs" do now use proper button tags. Resolves: #93347 Releases: master Change-Id: I4c079b56808b8167b0ddf30392d9cfb0ce36caf0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67505 Tested-by:
-
Andreas Fernandez authored
The user name and group name are stored as data attribute in the "reset" button in the permission module once somebody wants to change the owner/group of a page. If the button is clicked, the stored value is recovered. Since the value might contains HTML entities, these values get escaped before written back into DOM. Additionally, the unnecessary "not set" span element has been removed. Resolves: #93335 Releases: master Change-Id: I9255d8b263f6bacf7991913b004eb3c7acdebbaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67508 Tested-by:
-
Oliver Bartsch authored
The ListController now uses the correct parameter for fetching the TCEFORM TSconfig options. Furthermore is the `fieldName` now added as url parameter in the FieldControl. This allows replacing the pid based on the defined TSConfig for the current field in the ListController again. Resolves: #79936 Releases: master, 10.4 Change-Id: Ib8d902faeb625113b627c84a2125ede09ff7e71a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67448 Tested-by:
-
- Jan 22, 2021
-
-
Christian Kuhn authored
This reverts commit 84948b2c. The strategy to not have reference index entries for workspace delete placeholders does not work out (for now): * Workspace ElementEntity class relies on it and is used by DataHandler during workspace operations. * Patch was incomplete: While rows 'from' affected records were dropped in refindex, rows 'to' affected records were left. We may later pick this up again, but need more refactoring. Change-Id: I19b36d011b3cae2c3c17763ace8e5ff22f8dfe9b Resolves: #93285 Reverts: #93274 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67413 Tested-by:
-
Benjamin Franzke authored
Use flexbox for layouting to avoid transform/position based shifting of the content module. Also use `position: sticky` instead of `position: fixed`, as it allows to avoid padding hacks. Also remove manual Viewport.doLayout() hacks, as we can now use `width: auto` as replacement for a static snapped-module menu width. Resolves: #93353 Releases: master Change-Id: I7d56a3b3b405e36d65c9a87a03360074354c3d9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67502 Reviewed-by:
-
Mylene Kreiger authored
Add bootstrap class label-success to _element_label.scss. Font color set to black and background color to a 20% lighter $brand-success color. Resolves: #92650 Releases: master Change-Id: I1e37e742b13f534c13dc601159898f49aa6e2a75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66874 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Georg Ringer authored
Providing the pages of a pagination directly in the `SimplePagination` reduced the work of extension developers. In Fluid it is now possible to iterate over all pages without the need of providing this for every usage. Resolves: #93340 Releases: master, 10.4 Change-Id: Idefcc16c30f55b88b8c03a418fc7ef6a37380a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67500 Tested-by:
-
Oliver Bartsch authored
Resolves: #93349 Releases: master Change-Id: I72b5a590db6f1dbad3ca6279ef3d02029cf4549f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67507 Tested-by:
-
Benni Mack authored
This change migrates the responsive topbar to flexbox, getting rid of some ugly "position: fixed" functionality as well as manual calculation of width / padding via JS, making the scaffolding better to understand and to use. On top, this change fixes bugs related to styling when using the topbar in non-desktop clients Resolves: #93318 Releases: master Change-Id: I510fd15cfce3243c0a8e6d5dcfcbd438476bb630 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67465 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
- Jan 21, 2021
-
-
Benni Mack authored
The documentation for the deprecated constants is missing a word in a sentence. In addition, the documentation clarifies that the constant will be kept until TYPO3 v12, to ease the migration. Resolves: #93341 Releases: master, 10.4 Change-Id: I51dc044670bba678684781a2c90e59c06b87d671 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67501 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Benni Mack authored
A CSS hack was introduced with #f191477a see (https://forge.typo3.org/issues/66742) for a workaround with Chrome < 40 back in 2015, which is not needed anymore. https://bugs.chromium.org/p/chromium/issues/detail?id=412414 https://bugs.chromium.org/p/chromium/issues/detail?id=383261 Resolves: #93339 Releases: master Change-Id: I0c333f90d1dca019b45ff7b9f97e0c76d57a03b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67499 Tested-by:
-
Oliver Bartsch authored
The SysLogErrors widget now links to the belog module using `top.goToModule` to also change the state in the module menu. Resolves: #93333 Releases: master, 10.4 Change-Id: Icc19570585fdf785b296db21311f14955d6e91ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67496 Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Benni Mack authored
This change sorts out the link selector fields and additional fields, as well as the file selector to streamline the padding/margin between all boxes, cleans up the search box and adds some UX improvements to make the modal less cluttered. Some labels still need to be moved to a XLF file. In addition, some minor PHP cleanups are made to make the dependencies more visible. Resolves: #93322 Releases: master Change-Id: I5f191cefbf1e1fd8dae9e398d3001faf72193cb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67467 Tested-by:
-
Benni Mack authored
The popover (when clicking on a "?" icon) now properly sets the styling of the popover-header class. Resolves: #93323 Releases: master Change-Id: I1e89ed15e3823a362c9244187283821ffa8aed0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67470 Tested-by:
-
- Jan 20, 2021
-
-
Oliver Bartsch authored
The permissions module previously used a lot of anchor elements without a target defined. To improve accessibility and semantic correctness these selectors are now changed to button tags. Resolves: #93306 Releases: master, 10.4 Change-Id: I181264307294bd84e0896d1602ddd8c9dc313167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67460 Tested-by:
-
Patrick Schriner authored
Pages with a date visibility outside the current date had their preview link generated incorrectly as the runtime cache was already filled with the data of the current date. If the date aspect is taken into account proper preview links can be generated for future or past pages as well. Resolves: #92944 Releases: master, 10.4, 9.5 Change-Id: Icd5c1f8e1f0ddea07780d1ca1d1d050660443927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66934 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Martin Kutschker authored
The module menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for roles "menubar" and "menu". The first level menu has a "menubar" role, the second level submenus have a "menu" role. The buttons have the "menuitem" role. Both the "menubar" and the "menu" are oriented vertically for assistive technology matching the visual representation which affects the keyboard navigation. Space/Enter show the module unless the item has a submenu. Space/Enter and Right Arrow open a submenu and move focus to the first item. Up/Down Arrow and Home/End navigate within the current level of the menu. Ctrl + Home/End navigate within the first level of the menu (extension of the ARIA pattern). Left/Right Arrow moves to the parent item's predecessor/successor when on a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Escape moves to the parent item of a submodule item. The submenu will not be closed (deviation from the ARIA pattern). Tab and Shift + Tab move to the next item outside of the module menu. The help menu implements the keyboard navigation suggested by the ARIA Best Practices 1.1 for the role "menu". This is the same as the module menu but limited to a single level. The change detaches again the module menu's event listener from the document as in #91642, but reinitializes the event listeners to handle situations as described in #93008 properly. Resolves: #92704 Resolves: #92634 Resolves: #92613 Releases: master Change-Id: I58ae5caa81882ccebd4e2ae2d944eb99e15a4b18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66283 Tested-by:
-
Richard Haeser authored
When a canonical link is set in the page properties, this page or translation should not get a hreflang link in frontend as this might send conflicting signals to search engines. Resolves: #89878 Releases: master, 10.4 Change-Id: I4a2fb81b474bf155ba0beca5dfa3948f36edf840 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67328 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
-
Oliver Bartsch authored
In the bootstrap v5 migration the data attribute key which is used in JavaScript to perform actions depending on the toggle state, has changed. Now the correct data attribute key is used again. Resolves: #93320 Releases: master Change-Id: Icd80dc210dfa55176db1b7f1be30ad015783f6be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67468 Tested-by:
-
- Jan 19, 2021
-
-
Benni Mack authored
This change uses Twitter Bootstrap 5 usages across TYPO3 Backend, and fixes the toggle / icon toggle switch. Now the bootstrap-5 based toggle (form-switch) is used, and can be modified easily with a custom SVG later-on, but is kept as is for now, in order to make sure it is used consistently everywhere. Resolves: #93310 Releases: master Change-Id: If52d06932e1ee087d9c7d76cfb7d0f0c0e92276a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67461 Tested-by:
-
Kevin Appelt authored
Resolves: #93298 Releases: master Change-Id: Ic93d7e837fc3a19e78211bbe3b7562ac3cd51213 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67454 Tested-by:
-
Andreas Fernandez authored
The Permissions backend module and its JavaScript module now ditch jQuery in favor of native browser API and TYPO3 API. The JavaScript has been refactored a little bit; initially checking the permission checkboxes or writing back the calculcated permission value is now decoupled and executed in the Permission module only. To support for..of with NodeList collections, TypeScript now loads the internal "dom.iterable" library. Additionally, the interim solution to add `editform` to Document has been removed which made another change in LinkPopup necessary. Furthermore, a bug has been fixed, where the value of the first visible select element was used when saving any other select element with a completely different value. Resolves: #93301 Releases: master Change-Id: Iffede862a0eb36e805a5f127d7b19f32c899ce31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67457 Tested-by:
-
Benni Mack authored
The listing of extensions in the Extension Manager module now properly shows the inactive extensions again. Previous CSS changes didn't apply the inactive extensions again. In addition, if an extension does not have an Extension Icon in the Extension Manager list, it created an <img> tag with a path to the extension folder typo3conf/ext/my_ext/ resulting in an error in the browsers. This is now replaced with an empty icon. Resolves: #93311 Releases: master Change-Id: I723a0d603b36ad799c0c02869829742f19a69b37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67462 Tested-by:
-
Oliver Bartsch authored
To prevent broken records which reference a renamed folder, the AfterFolderRenamedEvent is now used to synchronize the corresponding relations as soon as such action took place. Furthermore does the AfterFolderRenamedEvent now contain the source folder, which is necessary to find those relations. A flash message informs the user about the synchronization when the action was performed in the backend, e.g. in the file module. Resolves: #78036 Resolves: #83054 Releases: master Change-Id: I9cc8bfbb5c8506c22dc4377fd3041b1113864182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67441 Tested-by:
-
Uwe Trotzek authored
When a user is editing a complex data structure with IRRE and if he just changes one entry of a structure then all the items will be shown as changed in the workspace module. Most users will wonder why an element is shown as changed even if the user didn't touch this particular entry. This change will hide the "show differences" button in the module for entries where no data was changed except for internal properties. Those items will also have a different color in the list. Now the user can easily identify the records where something was really changed and open the diff to see what has changed. Resolves: #91157 Releases: master Change-Id: Ib5ca5bb50360091813855bd8aef0b9e627e1e826 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64295 Tested-by:
-
- Jan 18, 2021
-
-
Johannes Rebhan authored
This adds the ability to wrap the content of an automatically generated typolink link text, e.g. when linking to internal pages, with markup using the typolink options `wrap` and `ATagBeforeWrap`. Resolves: #92338 Releases: master Change-Id: I1ecac8fe52384acef249177850662ebc90497b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65758 Tested-by:
-
Guido Schmechel authored
User and group names in the access module are no longer shortened after 20 characters. It is now possible to see the full 50 characters. In addition, a title attribute has been added. Resolves: #93089 Releases: master Change-Id: If37d24235ff445297548a2830e5745cb889d5a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67363 Tested-by:
-
Benni Mack authored
The opendocs toolbar item does not have a badge background anymore, this changes re-adds the background and also unifies the badge from the system information toolbar to use the rounded-pill class. Resolves: #93303 Releases: master Change-Id: Ie2ecc99fd5ad4ad8845923af018c051665ac6118 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67459 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- Jan 17, 2021
-
-
Jochen Roth authored
Will set equal height for checked checkbox and the empty button. The first button will now get a border-radius to streamline the buttons according to the action buttons Resolves: #93292 Releases: master Change-Id: I6479c968f77df41ed00d23d68c5ec23363ac64a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67449 Tested-by:
-
Thomas Löffler authored
When there is no specific preview renderer defined for a given subtype, the type-specific renderer can only be used if it's not an array. Otherwise, the default preview renderer defined in TCA crtl should be used. Releases: master, 10.4 Resolves: #92758 Change-Id: Ia88d262f52ddac174cbe6750c591898c84872a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66413 Tested-by:
-
- Jan 16, 2021
-
-
Elias Häußler authored
Using drag and drop, one can create new pages within the page tree. New pages can be created before, after or within existing pages. Currently, one could not provide a page title if the page was created within a page without subpages due to issues with unintended focus change after drag and drop. It is now ensured that a page title can be edited directly after dragging a page into the page tree. Some cases are also covered by acceptance tests now. Resolves: #92380 Releases: master, 10.4 Change-Id: I95391631f11552fc59e9252e904052d8288c5d91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67316 Tested-by:
-
Markus Klein authored
If some link handlers are hidden with "blindLinkOptions" then we still want to preserve the well-known order of the other tabs. This is solved by defining more dependencies on the link handlers, so that the ordering service still has a clue about the order. Releases: master, 10.4 Resolves: #86312 Change-Id: I60c3c7b1cbcb57b7774663732d7bd3aca9ef15c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67455 Tested-by:
-
- Jan 13, 2021
-
-
Benni Mack authored
The page module does not throw a fatal error anymore if a content type "text" has a bodytext of value "null" instead of "text". Resolves: #93283 Releases: master Change-Id: I23b5c508d1886dc2277e5d4a2010f8a57fd8bb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67443 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
