- Jan 30, 2022
-
-
Christian Kuhn authored
Having jangregor/phpstan-prophecy and including it in the phpstan config cuts the baseline by ~half. Details can now be sorted out with single patches. > composer req --dev jangregor/phpstan-prophecy:^1.0 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #96684 Releases: main, 11.5 Change-Id: I7a2a8fd4a40a1a791d7622b506680a53e73187f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73212 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 29, 2022
-
-
Christian Kuhn authored
Resolves: #96681 Releases: main, 11.5 Change-Id: I71ff411cd4cd639ad8d68dfcf02e46ac8818705d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73208 Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
* Too many arguments to __construct() * Inconsistent naming * Undeclared properties Change-Id: I16ac778db7afdeaa9348e01ef777598a48bc0d05 Resolves: #96682 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73210 Tested-by:
-
Christian Kuhn authored
Constant LANGUAGE_PRESETS must be defined in tests using SiteBasedTestTrait and needs to be accessible. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: Ie31a2d1fba88aabc182b3c477ff96cfb3f13c6c2 Resolves: #96679 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73205 Tested-by:
-
Christian Kuhn authored
The index.php entry point handling and package handling core scripts are composer plugins. As such, they rely on composer. To resolve dependencies in IDE's and phpstan, composer should be a core monorepo dev dependency. This resolves about 50 issues from phpstan baseline. > composer req --dev composer/composer:^2.2 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Change-Id: Iaaa4d327b7e82ca1e377d66cb1846a1699a20254 Resolves: #96676 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73201 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Bürk authored
We currently have the situation that phpstan is hard to update and maintain due to the phpstan config file that sets very specific rulesets. This is unfortunate since phpstan tends to change and rename rules at will. The general usage API of phpstan is basically as follows: Have a slim config file that sets the basic level. Then maintain a 'baseline' file that lists violations, using the --generate-baseline command option. The todo job for people working on phpstan errors is then to look at the baseline file, pick up some issues, fix them, then re-generate baseline. When baseline is small enough, the level is raised, a new baseline is generated, and the fix-job starts again. The patch does exactly this: The existing config is dropped and runTests.sh receives a command to generate baseline. With this in place, we can easily raise phpstan to a PHP 8.1 compatible version: > composer req friendsoftypo3/phpstan-typo3:"^0.9.0" --dev > composer req phpstan/phpstan:"^1.4.3" --dev > Build/Script/runTests.sh -s phpstanGenerateBaseline This initialy adds about 4000 ignores to the baseline with level 3, but we can reduce this drastically with just a couple of dedicated patches, soon. The config is heavily streamlined and for instance does *not* ignore tests anymore, which actually finds a ton of misuses and bugs within tests and classes. Resolves: #96675 Releases: main, 11.5 Change-Id: I0e7ff7aa796e59a2c5eedde0b673f741f8b87dea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73198 Tested-by:
-
- Jan 28, 2022
-
-
Robert Kärner authored
Since the element information window can also be opened from an IRRE within a Flexform element, the table name might be empty and a fallback has to be added when accessing TCA. Resolves: #96649 Releases: main, 11.5 Change-Id: I5d98e838290ff21b46c764a687703f010f1a50aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73165 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
'LanguageService->sL()' could be called with an empty input string, thus reading language files and caching the result is superflous. This patch adds an early check and return to 'sL()' to mitigate that. Resolves: #96666 Releases: main, 11.5 Change-Id: Ib97958be6f4ffbd96cdfc158c9307f5007d31f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73163 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Oliver Hader authored
Method JavaScriptModuleInstruction::addFlags used plain arithmetic calculation on bit-masks. In case corresponding flags were just given once, that would not have lead to problems. However, enabling the same bits multiple times would have lead to side-effects like disabling the added bit or enabling others. Resolves: #96662 Releases: main, 11.5 Change-Id: Id4d61884b116b07891ac99d0cc2814969529b7fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73164 Tested-by:
-
Benni Mack authored
TYPO3 should never expose its EventDispatcher implementation but only work with the PSR-14 interface (SOLID principle). Also avoid GeneralUtility::getContainer() as that's internal and non recommended API in favor of makeInstance where dependency injection is not yet possible. Resolves: #96665 Releases: main, 11.5 Change-Id: Ifacb7e64bc55bcfdf58a8de454a3cebc4e602817 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73190 Tested-by:
-
Stephan Großberndt authored
This change removes the `@internal` declaration from two exceptions thrown by `ExtensionConfiguration->get()` which is used by extension authors when fetching the extension configuration as those may be caught by extension code. Releases: master, 11.5 Resolves: #96657 Change-Id: I8c90cd62c5558487cd32a7b7bf4c0dec7bb5efb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73162 Tested-by:
-
- Jan 25, 2022
-
-
Christian Kuhn authored
The form tag in 'User Settings' is never closed since that tag is added too late to $this->content. Resolves: #96645 Releases: main, 11.5 Change-Id: Ief759bce5011fd404c02cbdf35dbfcfe120bc5c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73159 Tested-by:
-
Benni Mack authored
Resolves: #96643 Releases: main, 11.5 Change-Id: I561b4ccfc3722778c102460d4e79732be020a41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73158 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Hader authored
There have been reports that DOM elements that were assigned in the constructor of NavigationContainer actually were not available/ready in the corresponding DOM. Resolves: #96618 Releases: main, 11.5 Change-Id: Ic4e8aa4e960e46052e645be2380c015e42d3f86c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73133 Tested-by:
-
Oliver Bartsch authored
Resolves: #96642 Releases: main, 11.5 Change-Id: I2be1ae3fc90ab72e86c534b5f3e7406ae39e960f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73157 Tested-by:
-
Stefan Bürk authored
Extend PHPStorm meta file with further definitions for autocompletion support and avoid unnecessary php docblocks in the code base. * add request getAttribute() return types * add return type for 'SiteMatcher->matchRequest()' * add return type for 'PageRouter->matchRequest()' Resolves: #96636 Related: #95064 Releases: main, 11.5 Change-Id: I7c2aafc8a0230090e267d9c4eb2f3e5284d8ee0a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73156 Tested-by:
-
Benni Mack authored
This change also sets a "userGroups" record for a simulated user group, and also the user, in order to build a proper usergroup information, this way, the FE preview also works for restricted pages, because the userAspect is evaluated properly. Resolves: #96381 Releases: main, 11.5 Change-Id: Id70341c8967d67040e7ea611f404709b65bf399a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73154 Tested-by:
-
Susanne Moog authored
When dumping table data, the admin panel formats values dependent on their type. The boolean type was missing resulting in handling booleans as string and trying to translate them. The missing case has been added and the formatting adjusted to avoid displaying booleans as string casted numbers. Releases: main, 11.5 Resolves: #96622 Related: #96473 Change-Id: Id9e258980bd60da24bc1cc417281fa50b054d084 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73153 Tested-by:
-
Jochen Roth authored
Gitlab is able to give a nice overview of tests and how often a test failed recently which makes it easier to investigate flaky/failed tests. Also it takes away the pain of searching for the actual failing test in a job because it only displays information of the failed test (no bootstrap log details and such) Codeception AC test reports have been added to the Gitlab GUI using the --xml flag to generate a Gitlab readable report format and it has been added to the jobs artifacts:reports:junit. Resolves: #96628 Releases: main, 11.5 Change-Id: Id5ab5adfdc318c0c97143b0f05311f47fd1d37f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73141 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Georg Ringer authored
This fixes the sorting of backend layout rows and cols in the page module, depending on TSconfig. 1. The rows are now sorted by their key again 2. Using SHARED.colPos_list does no longer override the order, defined in the backend layout. Resolves: #96560 Resolves: #96609 Releases: main, 11.5 Change-Id: I9f4fce0296517686373f26a88870df2badf8672f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73152 Tested-by:
-
- Jan 24, 2022
-
-
Oliver Bartsch authored
Check if the decoded menu is iterable, before passing it to "foreach". Note: No early return is used, since this would be a change in behaviour. Resolves: #96563 Releases: main, 11.5 Change-Id: If291ace4f6fc9c897ecacc73a1e6cdd0c98617e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73091 Reviewed-by:
-
Nikita Hovratov authored
This is a partial revert for #96354. In order to prevent PHP 8.1 warnings when using built-in functions like "trim" with null values, the stdWrap function and stdWrap_field were changed to always return a string. This, however, led to other parts of the TypoScript functions to not work properly anymore, because some relied on stdWrap to return null. One of them are "if.isNull". A functional test is added to verify the regression. The original issue with the PHP 8.1 warnings must be solved differently. Every stdWrap result has to be casted to a string, where this is expected. This has been done for every occurrence, which phpstan has found. Resolves: #96571 Related: #96354 Releases: main, 11.5 Change-Id: I9b1f2f5f75e83d58261f74469c9fb8ab24b5d9c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73140 Tested-by:
-
Chris Müller authored
Resolves: #96630 Releases: main, 11.5 Change-Id: Id40930d70250b93c871917160de9173cdc59d750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73090 Tested-by:
-
Christian Kuhn authored
Matching method name render() with more than zero arguments is so generic that it gives tons of false positives in the extension scanner. We shouldn't scan for this. Resolves: #96567 Related: #93003 Releases: main, 11.5 Change-Id: I10f489df3fbb0e029e40e9c6e3d3c7e36d5eca32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73089 Tested-by:
-
Larry Garfield authored
The current version of PHP Parser we're using doesn't support all the new PHP 8.1 syntax yet. So update it. Used commands: composer req "nikic/php-parser":"^4.13.2" composer req "nikic/php-parser":"^4.13.2" \ -d typo3/sysext/core --no-update composer req "nikic/php-parser":"^4.13.2" \ -d typo3/sysext/install --no-update Resolves: #96612 Releases: main, 11.5 Change-Id: Ifb4afebccef0b2e7e6d28e597a85813d06bcb5d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73137 Tested-by:
-
- Jan 22, 2022
-
-
Benjamin Franzke authored
ExtensionConfiguration uses inline JavaScript for the ColorPicker initialization. Move the ColorPicker initialization into the ExtensionConfiguration management module. Resolves: #96619 Releases: main, 11.5 Change-Id: I6f1407f35c631d2d36d7f26fd0419b415d228a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73126 Tested-by:
-
Stefan Bürk authored
Using null coalescing operator with fallback to 'false' to avoid undefined array key access warnings when key 'casesensitiveComp' is not set. Using 'false' here as this matches the behaviour of <PHP8.0, and as this is used as method argument of type bool a bool typecase is added along the way to be on the safe side. Resolves: #96537 Releases: main, 11.5 Change-Id: I3c4df09b2adf5eec57e31947189f4a1e2aea4bd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73088 Tested-by:
-
Benni Mack authored
Due to a bug, the class properties did not override properly using alternative names as the TYPO3-internal "mergeRecursiveWithOverrule" was used in the wrong order. This patch now uses "array_replace_recursive" and adds the child properties at the very end. Resolves: #87566 Releases: main, 11.5, 10.4 Change-Id: I91799cfb6c2effb8440bd099502ae801c9a69d15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73086 Tested-by:
-
Benni Mack authored
Due to the fact that PageRepository->getRawRecord() can return an array OR 0 (int) Typo3DbBackend must check for an array in order to avoid a PHP warning. Resolves: #94140 Releases: main, 11.5 Change-Id: Ib957bbfa20e8aac1b7b232f877bba74a7cfa6ff5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73085 Tested-by:
-
- Jan 21, 2022
-
-
Benni Mack authored
This change properly fetches a record, even if the record was deleted in a workspace, so the TSconfig is still fetched to load the PageTSconfig for this removed page. Resolves: #93273 Releases: main, 11.5 Change-Id: I6f6219ac5047667d0b596e94fe716ea51b90dcf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73084 Tested-by:
-
Benjamin Franzke authored
The DragUploader module initializes itself by calling initialize() as last execution step, therefore the function does not need to be called a second time. Releases: main, 11.5 Resolves: #96566 Related: #96323 Change-Id: I5a91abb2d12f56fc955266c1723c98ffa024fc6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73116 Tested-by:
-
Andreas Fernandez authored
To workaround the issue that a focus area cannot get dragged anymore, the cropper now gets disabled if interaction with the focus area gets started and vice versa. Resolves: #92897 Releases: main, 11.5 Change-Id: Ibc1203b6fd5a63027c6b5e14135ec1479e526e91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73114 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Christian Kuhn authored
Change the default DBMS for functional tests in runTests.sh from mariadb to sqlite: sqlite is sigificantly quicker with functional tests and thus the preferred DBMS selection when running tests locally for us lazy devs since we can omit the '-d sqlite' option now. This has no impact on CI since the DBMS is always explicitly set in gitlab-ci configs. Resolves: #96585 Releases: main, 11.5 Change-Id: I93b68f48a409fc1afb14d8a2aecbc295dd2255e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73113 Tested-by:
-
- Jan 20, 2022
-
-
Georg Ringer authored
If the special menu type 'list' is used, the order must be kept as provided within the list configuration. Resolves: #96577 Related: #96358 Releases: main, 11.5 Change-Id: I99a0f93b71836644bdeab8adecb3171090359fab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73083 Tested-by:
-
Oliver Bartsch authored
The "View webpage" button in the docheader of the page module allows to view the page in the currently selected language. This means, the button always depends on the selected language. With #92460 the special "all languages" option was added to the language selector (in languages mode). Since this option is no valid language id, the button is now hidden, in case "All languages" is selected. Resolves: #96603 Releases: main, 11.5 Change-Id: If92b46541868b9cfd1c6aa7addd191d8f877056d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73082 Tested-by:
-
Sascha Egerer authored
The stdWrap function ifEmpty must return true if a PHP falsy value is given. That means e.g. an empty string or a "0". To make it more clear that stdWrap ifEmpty in fact uses the logic of the PHP function "empty", this function is now used. First, the value is trimmed, which means a string is returned, and then this value is passed to the empty function. As this works now properly, the getCurrentValue method needed a check against empty array keys. The stdWrap_current method now uses the getCurrentValue method as they both do the exact same thing. Resolves: #90908 Releases: main, 11.5 Change-Id: I3268fbaf68a2c56ae33ae499ad671e0a89fa7867 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73081 Tested-by:
-
Stefan Bürk authored
Long story short, through multiple refactorings along the road, from the inital introduction of the 'mod.newContentElementWizard.override' option with #70055 over streamlining the TSConfig api (#85016), a lot of stations in between which already broke reading that option, which was used for adding the 'new record button', this was refactored into a dedicated 'createAddButtonForTable()' method with #94456, ending up with even more broken code and leaving an undefined variable $tsConfig. Instead of removing the unused variable we load the pageTs here to be able to read this option again and restore the intended behaviour. Resolves: #96596 Related: #94456 Related: #85016 Related: #70055 Releases: main, 11.5 Change-Id: I91b24bf338c6531ea220a41dca2076b71a7da96f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73080 Tested-by:
-
- Jan 19, 2022
-
-
Benjamin Franzke authored
Resolves: #96565 Releases: main, 11.5 Change-Id: Iace92f424acf20fa9329dc5380facd30abe87b00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73097 Tested-by:
-
Oliver Bartsch authored
When previewing pages a null pointer exception is triggered in the frontend RequestHandler, in case $GLOBALS['LANG'] does not exist. This is the case when no user object exists (or is not a FrontendBackendUserAuthentication). This is now fixed by creating the LanguageService with the corresponding factory and no longer relying on $GLOBALS['LANG']. Additionally, another possible null pointer is fixed in the factory, since createFromUserPreferences() allows NULL for the first parameter "$user" but previously did not check the provided value before accessing. Resolves: #96590 Releases: main, 11.5, 10.4 Change-Id: I160a9dae9131973d681b392ee713d1fadcb9a24b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73079 Tested-by:
-
Stefan Bürk authored
Show columns selection functionality has been improved for issue #94474, but during refactoring some code it falsly tries to read the 'pageId' parameter from undefined '$parsedBody' instead of the available variable $queryArguments, which is used to pass to another method. This patch now fetch the pageId from query arguments and remove the usage of the undefined variable. Resolves: #96594 Related: #94474 Releases: main, 11.5 Change-Id: Idb0350b235c8dfc2b49b001d0394d9a27c20c3fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73078 Tested-by:
-
