- Apr 06, 2023
-
-
Christian Kuhn authored
Casual local systems should have young enough docker and docker-compose versions meanwhile, and PHP 8.2 runs with xdebug without issues. Resolves: #100496 Releases: main Change-Id: Ia8366ed33ac184a1d6bc1b9d1d06b492c1925a34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78505 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Stefan Bürk authored
This changed adjusts the `Build/Scripts/runTests.sh` support for the different database types and versions. That means, which version for which types can be selected for functional and/or acceptance tests. Additionally, the help text output is enhanced to list information about the support of database versions provided by the vendors, on actual published release informations: * https://mariadb.com/kb/en/mariadb-server-release-dates/ * https://www.postgresql.org/support/versioning/ * https://endoflife.software/applications/databases/mysql Available versions are choosen for supported versions of the TYPO3 core version, see following matrix as generic overview. **NOTE** Be aware, that this does not mean that tests are green with all version. This only enables execution through `Build/Scripts/runTests.sh` for now. `CI` adjustments are done afterwards in a dedicated shuffle change. mysql ----- * 5.5 unmaintained since 2018-12 (11.5, 10.4) * 5.6 unmaintained since 2021-02 (11.5, 10.4) * 5.7 maintained until 2023-10 (11.5, 10.4) * 8.0 maintained until 2026-04 (main, 11.5) mariadb ------- * 10.1 short-term, no longer maintained (11.5, 10.4) * 10.2 short-term, no longer maintained (11.5, 10.4) * 10.3 short-term, maintained until 2023-05-25 (main, 11.5, 10.4) * 10.4 short-term, maintained until 2024-06-18 (main, 11.5, 10.4) * 10.5 short-term, maintained until 2025-06-24 (main, 11.5, 10.4) * 10.6 long-term, maintained until 2026-06 (main, 11.5, 10.4) * 10.7 short-term, no longer maintained (main, 11.5, 10.4) * 10.8 short-term, maintained until 2023-05 (main, 11.5, 10.4) * 10.9 short-term, maintained until 2023-08 (main, 11.5, 10.4) * 10.10 short-term, maintained until 2023-11 (main, 11.5, 10.4) * 10.11 long-term, maintained until 2028-02 (main, 11.5, 10.4) * 11.0 development series (main) [not working] * 11.1 short-term development series (main) [not working] postgres -------- * 9.6 unmaintained since 2021-11-11 (11.5, 10.4) * 10 unmaintained since 2022-11-10 (main, 11.5, 10.4) * 11 maintained until 2023-11-09 (main, 11.5, 10.4) * 12 maintained until 2024-11-14 (main, 11.5, 10.4) * 13 maintained until 2025-11-13 (main, 11.5, 10.4) * 14 maintained until 2026-11-12 (main, 11.5, 10.4) * 15 maintained until 2027-11-11 (main, 11.5, 10.4) Resolves: #100492 Releases: main, 11.5, 10.4 Change-Id: Iac5d4f799fd05ed7b766d1a9db95481caea2f898 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78498 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Hader authored
Previously external media CSP declarations (e.g. to embed YouTube or Vimeo assets in an iframe) was only applied to the backend scope, when `ext:filelist` was installed. However, the same declarations are required in the frontend scope for actually rendering those external media content elements. The initiating components `YouTubeRenderer` and `VimeoRenderer` are located in `ext:core`. That's why the CSP declarations are moved there as well. Resolves: #100446 Releases: main Change-Id: I4bb11f106539cbbc536e9a0ef7f77eb4e727d753 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78459 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
Oliver Hader authored
Add the URL of the page to be shown in web > view backend module to the `frame-src` directive of the Content-Security-Policy. This is required in case the backend URL is different to the frontend URL that shall be used to preview that page. The new registry service `PolicyRegistry` is introduced to collect temporary adjustments to the Content-Security-Policy, which are applied in the central `PolicyProvider`. Resolves: #100460 Releases: main Change-Id: I3f6eb27fc261e4521940a6222499c1c33ae8015d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78473 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Kott authored
The title attribute is a native global attribute. Using it as a property could have unintended side-effects. Resolves: #100455 Releases: main Change-Id: I01bf714ada9580cfef721134322b076d19bf3130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78470 Reviewed-by:
-
Benjamin Kott authored
The class input-group-btn was removed in bootstrap 4.6, we are now dropping leftover usages. There is still a leftover in the form framework rendering we cannot remove that easily. We are keeping it as is for now since it would require refactoring of the form javascript. The other place in combination with typo3-mfa-totp-url-info-button is handled in a dedicated patch. Resolves: #100463 Releases: main Change-Id: I5dbed36ff2b4c1e3e652523c488ed12284f20379 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78475 Tested-by:
-
Benni Mack authored
This patch deprecates all old-style tree views that have been in use for over 15 years now without larger refactoring. As we now use the web-component-based tree in most places, these class and properties can now be deprecated, in order to phase out old logic. Resolves: #100454 Releases: main Change-Id: Ief99c73a72d50881375cc4e94f7947249e4d9088 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78315 Tested-by:
-
- Apr 05, 2023
-
-
Christian Kuhn authored
This is a temporary, a bit hacky solution to run the functional tests with phpunit 10 next to phpunit 9 for now. Goal is to ensure they don't break again. We'll later remove phpunit 9, but need to still sort out some further details. Resolves: #100490 Related: #100249 Releases: main Change-Id: I2b0d2b6abfec9236bc2f3f819b080338111b21ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78495 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Oliver Klee authored
Resolves: #100373 Releases: main Change-Id: I26b0a7a888d99a4bba6d9cc77184bff6589edab8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78347 Reviewed-by:
-
Stefan Bürk authored
Some tests created response objects the wrong way by hand. This change now uses the known factories to build them correctly. Resolves: #100487 Related: #100249 Releases: main Change-Id: Ic3de0e237fe0d9db9900b78ea88459e850c7bdbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78494 Tested-by:
-
Christian Kuhn authored
This test case of ext:webhooks is a bit weird. The patch relaxes this a bit: Extending a ext:core abstract is avoided, the setup is streamlined, and abusing ext:core fixture files is avoided. With phpunit 10, one of the three tests fails, probably because its broken, but the details are unclear. It's marked as skipped for now. Resolves: #100481 Related: #100249 Releases: main Change-Id: Id5ddc227296192f1efa8ed49366c8b5ff8115eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78488 Tested-by:
-
Christian Kuhn authored
phpunit 10 expects classes that end with "Test" to not be abstract. Resolves: #100484 Related: #100249 Releases: main Change-Id: Ifbcec828e56d781f8e2992b86cfd646372db1864 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78491 Tested-by:
-
Christian Kuhn authored
phpunit 10 expects classes that end with "Test" to not be abstract. Resolves: #100486 Related: #100249 Releases: main Change-Id: I846976ed76eb14ddb5e74d1927842feec4f8355e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78493 Tested-by:
-
Christian Kuhn authored
Should be AbstractFolderStructureTestCase. Resolves: #100485 Related: #100249 Releases: main Change-Id: I09b59fdf6a1d41fb42d5c28fc6f5be2e5965637c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78492 Tested-by:
-
Christian Kuhn authored
phpunit 10 expects classes that end with "Test" to not be abstract. Resolves: #100483 Related: #100249 Releases: main Change-Id: I8d3f4981d314b36f212c4368dd394c0ba2425088 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78490 Tested-by:
-
Christian Kuhn authored
"dummy" is not a valid method in the mocked class. Resolves: #100482 Related: #100249 Releases: main Change-Id: Ic0c13044350beae6cbc7bca67406e8d1c50cfe84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78489 Reviewed-by:
-
Christian Kuhn authored
Method "dummy" can not be mocked since it does not exist. Change to "don't mock anything" by using 'null' as argument instead. Resolves: #100473 Related: #100249 Releases: main Change-Id: I1b53db814e6a422c129a4ad019885342e6984c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78481 Tested-by:
-
Christian Kuhn authored
TypoScriptFrontendControllerTest uses itself as callback for USER and USER_INT functions. This does not work anymore since phpunit 10 TestCase has a basic constructor which fails when TYPO3 creates an object of this class. Extract those callbacks to an own class. Resolves: #100475 Related: #100249 Releases: main Change-Id: I2789bca20cc7fa086521aeb5799c3a9a20e03ab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78483 Reviewed-by:
-
Christian Kuhn authored
The tests should be refactored towards proper database fixtures, but for now, we get rid of withConsecutive(). Resolves: #100479 Related: #100249 Releases: main Change-Id: Ie2aeb7b8d2a9c170e9aae6c07a11d10f5492f137 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78486 Reviewed-by:
-
Christian Kuhn authored
Resolves: #100480 Related: #100249 Releases: main Change-Id: I256b6f6a8eae577033207df980c1b607d4226dae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78487 Tested-by:
-
Christian Kuhn authored
TranslationServiceTest tries to mock some methods that don't exist. Solving this reveals the test subject contains invalid calls to getProperties(), see issue #100477. The patch marks the two affected tests as skipped for now, and fixed the others to stop mocking not existing methods. > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100478 Related: #100477 Related: #100249 Releases: main Change-Id: Id02c4bfc57d4c4773def11b212fe462638fa1021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78484 Reviewed-by:
-
Christian Kuhn authored
This test is tricky since the subject triggers session_save_path() which is limited to one call per php process and emits a warning when called multiple times. This was mitigated by adding an own exception handler in the test setup, but this solution fails with phpunit 10, which is more picky and can't be tricked easily. The value added by the test is not *that* high and the overall setup is complex, so in this case, it's better to remove the test. Resolves: #100472 Related: #100249 Releases: main Change-Id: Iea0d4128cce9d804ce3d634e5095b19f5c9d8bed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78480 Tested-by:
-
Benni Mack authored
The "new" property config.doctype has been introduced in TYPO3 v6 and should be used now. It's time to unify all of our settings. Resolves: #100461 Releases: main Change-Id: I816ee4e9b2188626808a4bd2411eb64d801e5a03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78303 Reviewed-by:
-
Oliver Klee authored
This change fixes most of the remaining PHPStan warnings in this class. Resolves: #97409 Releases: main Change-Id: I25b6bfbe333e99d3df2df17990649df814ee2afa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74338 Tested-by:
-
Christian Kuhn authored
Resolves: #100470 Related: #100249 Releases: main Change-Id: Ia42e379ea1b29408e6bec4820a62190605660c42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78479 Tested-by:
-
Christian Kuhn authored
Avoid a useless abstract with an invalid class name, and make the data providers in this test case static. Resolves: #100469 Related: #100249 Releases: main Change-Id: I64b0ccb8c361032006cf3d95ad6a21d111db2d48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78477 Reviewed-by:
-
Benjamin Kott authored
The web component should behave like a button, there is no need to have another button nested inside. In addition we remove the usage of native attributes for custom properties to avoid unintended side effects. Resolves: #100453 Releases: main Change-Id: I2c5644144f545e7740dfc6bbf093d3ef00c26339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78468 Tested-by:
-
Benjamin Kott authored
The css classes icon and icon-size-small are unnessesary since the size property already sets and uses the correct internal classes. The attribute alternativeMarkupIdentifier does not exist. Resolves: #100438 Releases: main Change-Id: I1f1d311e7e572e373becba94bb18d0c95628cc45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78449 Reviewed-by:
-
Christian Kuhn authored
phpunit 10 mumbles when test data provider methods have arguments. This is used in SiteHandling functional tests various times. The patch refactors the data providers to avoid this and declares them static along the way. Resolves: #100464 Related: #100249 Releases: main Change-Id: Ia6c915f9e04da4e6f40893ed94ed6e2e175d6a52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78476 Reviewed-by:
-
Benjamin Kott authored
Firefox does not update the cursor position on the drag event. To workaround this issue we are moving the preview update to the dragover event. Resolves: #100458 Releases: main Change-Id: I70eed5196ca68fe2c42c984eeafbf4896e48c683 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78472 Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Benni Mack authored
This method is just a wrapper for a title="" attribute and is very inflexible. Thus, it is marked as deprecated. Resolves: #100459 Releases: main Change-Id: Ic8e7f5fca9176fdf76a9723a702705dd4fce56b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78321 Reviewed-by:
-
Christian Weiske authored
Resolves: #100457 Releases: main Change-Id: Ifa947d33af06b92486220b20afb57354870f0393 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78471 Tested-by:
-
Christian Kuhn authored
Solves simple cases: Make some helper methods static, call them statically, and declace consuming data providers static. There are more hairy cases in this section, those will be sorted out with further patches. Resolves: #100451 Related: #100249 Releases: main Change-Id: I927da99a598f74819247c83f395419b6021a730e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78465 Tested-by:
-
Christian Kuhn authored
Clean up and simplify a bit along the way. Resolves: #100450 Related: #100249 Releases: main Change-Id: I0f808487226689a701e9224c1e93daf2f2fbd7ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78464 Tested-by:
-
Benjamin Kott authored
npm i --save \ @codemirror/autocomplete@^6.4.2 \ @codemirror/commands@^6.2.2 \ @codemirror/lang-css@^6.1.1 \ @codemirror/lang-html@^6.4.3 \ @codemirror/lang-javascript@^6.1.4 \ @codemirror/lang-json@^6.0.1 \ @codemirror/lang-php@^6.0.1 \ @codemirror/lang-sql@^6.4.0 \ @codemirror/lang-xml@^6.0.2 \ @codemirror/language@^6.6.0 \ @codemirror/lint@^6.2.0 \ @codemirror/search@^6.3.0 \ @codemirror/state@^6.2.0 \ @codemirror/theme-one-dark@^6.1.1 \ @codemirror/view@^6.9.3 Resolves: #100429 Releases: main Change-Id: I8f6aafca025ddcc7f5f24968804a3b7cd69b4fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78437 Tested-by: -
Torben Hansen authored
The `PasswordChangeEvent` used in `notifyPasswordChange´ should not be used to validate user passwords, since it is not possible to visualize to the user why a password has been rejected. With TYPO3 v12, a custom password policy validator should be used to validate user passwords. Furthermore it is not usefull to modify the hashed password. The following methods of the `PasswordChangeEvent` PSR-14 event in ext:felogin have therefore been marked as deprecated: * `setAsInvalid()` * `getErrorMessage()` * `isPropagationStopped()` * `setHashedPassword()` Resolves: #100355 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I28841ff5d819b13eea238f2dfacdbff336e089ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446 Tested-by:
-
Stefan Bürk authored
PHPStan recenently released a new patchlevel version, fixing the one or other bug and changing the reported issue message texts. This change raises the phpstan dependency along with one extending package. The baseline file was regenerated to update to new message texts of some reported messages to mitigate issue flipping between composer locked and composer max testing. Used command(s): > composer require --dev \ "phpstan/phpstan":"^1.10.11" \ "phpstan/phpstan-phpunit":"^1.3.11" > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100452 Releases: main, 11.5 Change-Id: I307089d4b655e92eff2561c4e6d92cf79c20ea82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78466 Tested-by:Chris Müller <typo3@krue.ml> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
Make a helper method static to allow a static data provider. Resolves: #100449 Related: #100249 Releases: main Change-Id: I2fe4c4bf8125d40c8988ccce1927bc08d759b653 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78463 Tested-by:
-
Christian Kuhn authored
Avoid a useless helper method by having object creation within data provider directly. Resolves: #100448 Related: #100249 Releases: main Change-Id: I630a7f24fe0b5e295d924a83553c85d648d15390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78462 Reviewed-by:
-
Christian Kuhn authored
Use reflection instead of a mock in this functional test data provider to create data sets. Resolves: #100447 Related: #100249 Releases: main Change-Id: Ib73eb7153dd23f813c7e57b8928cfb006fb26efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78461 Tested-by:
-
