- Mar 09, 2020
-
-
Daniel Goerz authored
Resolves: #90688 Releases: master Change-Id: Ia8aad82a1c7a92891644786cd4d76d8a720bd0fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63638 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Richard Haeser authored
As the database column for the field configuration is missing and the field is not used anymore, the TCA configuration for this field is removed. Resolves: #90687 Releases: master Change-Id: I4510419deebf1183eaaabcc2a6078f126a8d58f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63636 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Christian Eßl authored
Parts of the cshmanual were never shown, because a language variable contained a <title> tag, that made the browser hide all of the manual content after that tag. Resolves: #90675 Releases: master, 9.5 Change-Id: I2d9cf15153f80bd5d0d8ed8cd0864807f30d31f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63607 Tested-by:
-
Oliver Bartsch authored
This fixes some missing or faulty checks related to the display and behaviour of the fluid based page module to bring it into alignment with the old PageLayoutView. * Correctly consider localization TSConfig settings * Add checks for content-editing allowed for user * Add check for presence of untranslated records * Pass all variables to record header/footer partial * Do not link preview content if user has no content edit access Resolves: #90559 Resolves: #90605 Related: #90608 Releases: master Change-Id: Ie2f200a280f60ed08b5850ead81644ee52508c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63615 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Georg Ringer authored
The statistic of EXT:indexed_search must be sorted by the count to avoid stripping of the most used search words. Resolves: #83062 Releases: master, 9.5 Change-Id: Id8008e0dc3a1ed2a837474fb954930395c80cc12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63630 Tested-by:
-
Susanne Moog authored
DatabaseRecordList adds an additionalWhereClause with an `OR` which may be extended by a hook. Usually, the hook is used to add additional clauses. As the `OR` part is not wrapped in braces, this may result in wrong priorities in the resulting query. As there might be pre-existing work-arounds handling the situation, the fix is done only on master. Resolves: #82283 Releases: master Change-Id: Id60d02cf671db2fffc2635764ebda809ae7cb1af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63620 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Markus Klein authored
Resolves: #90685 Releases: master, 9.5 Change-Id: Iae5d9242745a9dd5a1558d19cf84496dc128f557 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63633 Tested-by:
-
- Mar 08, 2020
-
-
Benni Mack authored
Resolves: #90165 Releases: master, 9.5 Change-Id: I6cd1f202c0293902b6444ccd23b30f0f92dbf748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63628 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
When having e.g. a composer-based installation in TYPO3 Core, the install tool still generates the "wrong" folder structure in TYPO3. When having e.g. "public" as subfolder where everything will be installed, then the DefaultFactory should actually create a /var/ folder (incl. /var/labels) and not keep the existing folder structure (e.g. typo3temp/l10n). Resolves: #89903 Releases: master, 9.5 Change-Id: Iaada837009be9e31dcb6969b1d424bf322841077 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63609 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Susanne Moog authored
TCA select fields have the capabilities for replacing ###CURRENT_PID### with the parent page ID of the current record. This should always be <table>.pid. In case of pages the wrong ID was used. This was now changed to always use the parent page ID indepentent of the current record. In case there is no parent page row, 0 is given. Resolves: #90645 Releases: master, 9.5 Change-Id: I8bc04891a009011f4c0d7fd9e59ab306d650b4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63603 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
The change of #88665 aimed to centralize the onchange behavior for all FormEngine fields. The result of this change is that this didn't work for all field types. Due to the fact the FormEngine rendering is rather cluttered (e.g. sometimes there are hidden fields that hold the actual value) and it's not possible to bind a global event delegation to such fields right now, this patch now uses the onchange handling again which was tried to be replaced. Resolves: #90672 Related: #88665 Releases: master Change-Id: I17d54edfc45dd39735bcc53ed0fd92e9fa061f13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63621 Tested-by:
-
Benni Mack authored
GeneralUtility::makeInstance() stores singleton instances in their overridden class names, however, when using setSingletonInstance (which is used in TSFE) this is not connected, making a setSingletonInstance break with another makeInstance call afterwards - returning a new, non XCLASSED object. Resolves: #73671 Resolves: #80399 Releases: master, 9.5 Change-Id: Ibb0005575db3fec55149a0624929c941c1491ed8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63618 Tested-by:
-
Georg Ringer authored
If ExtensionUtility::registerModule is called with a module configuration only containing an icon identifier the default icon of extbase is unset. Resolves: #80844 Releases: master, 9.5 Change-Id: I879b4fad2c6881fface0d64581c031b6ac7589eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63612 Tested-by:
-
Oliver Hader authored
When using a CGI wrapper to dispatch the PHP process `ORIG_SCRIPT_NAME` contains the name of the wrapper script (which is most probably outside the TYPO3's project root) and leads to invalid prefixes, e.g. resolving the `siteUrl` incorrectly as `http://ip10.local/fcgi/` instead of actual `http://ip10.local/`. Resolves: #89312 Releases: master, 9.5 Change-Id: Ib0732344deb0f2e71e06a4a1929bb712cd4f2239 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63602 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Christian Eßl authored
Since "free mode" has been introduced in #86762 for site languages, the previous onChange="reload" mechanism, when a fallbackType was changed, is now unnecessary and is now removed. Resolves: #90642 Relates: #86762 Releases: master, 9.5 Change-Id: I8bbf9a224dc47c14e4b4ec06961244b6903fbc69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63606 Tested-by:
-
- Mar 07, 2020
-
-
Georg Ringer authored
As the element `style` is listed in the removeTags section, there is no need to have it in the allowTags section as well. Resolves: #88561 Releases: master Change-Id: If0848c2c7533e876e500f2d7378c733f54e1f352 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63608 Reviewed-by:
-
Kevin Ditscheid authored
This commit fixes the setting of the select-attribute for menu items, that have a different arguments-array given to them, but the same controller => action combination as other menu items. Resolves: #87182 Releases: master, 9.5 Change-Id: I7f82be3fd3af73959f671aad781d88e4b0362fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59176 Tested-by:
-
As the preferred and future-proof way of creating commands is using symfony commands (as a base for scheduler tasks), the documentation has been adjusted to reflect that, by avoiding promoting the scheduler's own tasks. Resolves: #86089 Releases: master Change-Id: I12e385aaf433ad8caf5d4d43ecf41cf2ff7ceee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63600 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Georg Ringer authored
The variable ###SITEROOT### can only be correctly substituted if the DatabasePageRootline provider is used. There it is added to the flexFormSegment as well. Resolves: #81022 Releases: master, 9.5 Change-Id: I49ecc8cb3c98b7436a013c090618960368f2b37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63594 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
-
Andreas Fernandez authored
This patch replaces jQuery in the ClearCache module used in RecordList with Core APIs in regards of AJAX and event handling. Resolves: #90663 Releases: master Change-Id: I526a2136462c3cd494a8d3191b87f64257114b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63562 Tested-by:
Roland Golla <rolandgolla@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
Resolves: #90415 Releases: master, 9.5 Change-Id: Icb403e6ef2892ff7988a34652d6cdfa8f8bd1cfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63601 Tested-by:
-
Christian Eßl authored
Do not register InMemoryLogWriter in cli mode, as it is not needed here or used later in any way, and will just fill up the memory and slow down the script execution, if many log messages are written to it. Resolves: #89928 Releases: master, 9.5 Change-Id: I6500fe8a1ba534a669ee1a6b8a4df0857be54e38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63555 Tested-by:
-
Susanne Moog authored
When an argument definition of a console command changes for a scheduled task, it rendered the whole backend module unusable. We already had exception handling for options and missing arguments in place, now the InvalidArgumentException handling has been added as well. Resolves: #89057 Releases: master, 9.5 Change-Id: I8e182ed555a10672b0fd1c5c7249a3e8cfc5e6ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63599 Tested-by:
-
Jigal van Hemert authored
To prevent memory issues with huge sys_history tables and to prevent timeouts when handling large amounts of data the wizard processes small batches of records at a time, keeps track of its progress in the registry and this way allows repeated runs without losing data. If both the registry and sys_history share the same connection a database transaction is used to make sure that modifying data and progress tracking are in sync. Resolves: #88487 Releases: master, 9.5 Change-Id: I7d323ac3dae1d416f5883b2e52f94ee50bd66327 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61654 Tested-by:
-
- Mar 06, 2020
-
-
Georg Ringer authored
Urls starting with `//` should have a proper fallback to avoid warnings e.g. in InputLinkElement that this type of url is unknown. Resolves: #90171 Releases: master, 9.5 Change-Id: Ic3910f98c3993fb5db523ba1b360eabb49bf0696 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63543 Tested-by:
-
Benni Mack authored
Updating core's latest prophecy to v1.10 instead of v1.09 which then allows to enable phpunit v9 at a later stage. used composer command: composer update phpspec/prophecy --with-all-dependencies Updating phpdocumentor/reflection-common (1.0.1 => 2.0.0) Updating phpdocumentor/type-resolver (0.5.1 => 0.7.2) Updating webmozart/assert (1.6.0 => 1.7.0) Updating phpspec/prophecy (1.9.0 => v1.10.3) Resolves: #90671 Releases: master Change-Id: Idf4c2f559e769311c608bb69c46dedb9b4bdc549 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63571 Tested-by: -
Benni Mack authored
This feature adds a link on TYPO3 Backend's login form to reset a backend users' password if the user has forgotten the password. Key changes: * Only enabled for backend users with an email address and a password set * Enabled by default but can be disabled completely * Optionally only works for non-admins via TYPO3_CONF_VARS * Only send out emails to users within the system, but no information disclosure * If multiple valid users have the same email address, a different email is sent out * TCA be_users.email is not set to eval=email (due to backwards-compatibility) * Password resets are only valid for 2 hours (non-configurable) * Not extensible for third-party authentication methods yet * Rate limiting is enabled per email address for 3 attempts per 30mins (non-configurable) * When logging in, all previous tokens are removed * When requesting multiple resets, only the last email is valid * A CLI command "backend:resetpassword $backendUrl $emailAddress" sends out an email as well from admins * Admins can trigger a password reset for users in the BE User module Resolves: #89513 Releases: master Change-Id: I9a146d5a9db176d24f2223c5eafb0fb42861e93f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63385 Tested-by:
-
Susanne Moog authored
The scheduler exception handling on editing silently ignored most exceptions. The one exception was a specific exception that did not even exist anymore. The handling was changed to only ignore those exceptions with existing handling and adding messages for all others. Resolves: #80299 Releases: master, 9.5 Change-Id: I9b2a91f244bec99deb79da93a4e33680e862d16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63568 Tested-by:
-
Tymoteusz Motylewski authored
Added cache type definition Releases: master, 9.5 Resolves: #89340 Change-Id: I05634dc0e9ef22ad9764635965c197f494d3a14b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61853 Tested-by:
-
Christian Eßl authored
According to the documentation, the boolean checkbox for type "comment" should behave in the following way: - checked= “” - not-checked = “#” The handling of this behaviour was faulty in the TypoScript Constant Editor. This means, every time the constants were saved without changing the "comment" checkbox, its value was reversed. Further information: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/UsingSetting/TheConstantEditor.html Resolves: #82208 Releases: master, 9.5 Change-Id: I1473b435e37b47c4563f0d245e09b1680c738bcd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63518 Tested-by:
-
Susanne Moog authored
As the path to the TYPO3 binary in composer mode depends on composer bin dir and the sysext path should not be used the message displayed in the scheduler was changed to not provide faulty information. Resolves: #85468 Releases: master, 9.5 Change-Id: Ibbee8a417130a1235f419cef471c349ead59bf0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63566 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90665 Change-Id: I55c08b826d6e4560cbfbcde99e795f55036b049c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63565 Reviewed-by:
-
Christian Eßl authored
In a TabsContainer, if all the fields of a tab are hidden to the editor (by disabling them in PageTS), the tab would still become assigned in the 'items' fluid variable. The empty, but invisible, tab would then still be considered for determining the active tab in the view. If the first tab was disabled in this way, the editor would see no active tab at all. To prevent this from happening, the tab elements are now never assigned, if their content is completely empty. Resolves: #89094 Releases: master, 9.5 Change-Id: I3cbe98e7e25b7827fdc68583387343f5f0cb64ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63512 Tested-by:
-
Andreas Fernandez authored
To log the exception properly, the variable `$defaultLanguageUid` is now used instead of the undefined `$localizedUid`. Resolves: #90664 Releases: master, 9.5 Change-Id: I975868f95e7fb789ce31c260185b1a62654fd8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63564 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Gerrit Mohrmann authored
Argon2id should never be set automatically for compatibility reasons. At some places the array sorting will give the priority which password hashing type will be used, but the priority value from the preset is also used. To make sure Argon2i is set for new installations, priority of Argon2id is set below Argon2i. Resolves: #90643 Releases: master Change-Id: Idb96b17eda80a783d2de0d228f7381bfd674ce54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63550 Tested-by:
-
Susanne Moog authored
Add "distinct" into the whitelist of allowed select parts. Resolves: #43114 Releases: master, 9.5 Change-Id: I8ae6561ff6067117b9d5acb6c976966fecaee96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/38372 Tested-by:
-
Anja Leichsenring authored
The parent class states an integer value is returned, but most core commands did not follow that rule. Now they got according return statements to fulfill that contract. Resolves: #90652 Releases: master Change-Id: I58ad434404ce3537a4eb7ae34b88884b6962047f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63557 Tested-by:
-
Alexander Schnitzler authored
phpstan identified a bunch of possibly undefined variables which is fixed with this patch. Releases: master Resolves: #90581 Change-Id: If41bee3dcd972d26f8eff18dbcbc61ad1fe79e7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63483 Tested-by:
-
Benni Mack authored
Most access to the configuration options are made against AbstractFile objects in FAL, which is now centralized in one place in AbstractFile. This reduces errors when checking for file patterns. Resolves: #90305 Releases: master Change-Id: I7835d877bae1addf830ede3645ff8f1faa113052 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63155 Tested-by:
-
