- Nov 06, 2023
-
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to the latest version and fixes one issue within `RedisSessionBackend` where the Redis API claims to return a `\Redis` object when calling `->del()`. This indicates a usage of multi mode, where the delete state cannot get determined. Also, multi mode is not supported by our session backend, therefore we handle this case as "not successful" now. Executed command: composer require --dev phpstan/phpstan:^1.10.41 -W Resolves: #102320 Releases: main, 12.4 Change-Id: I6f4edb746c6e23d92d5147cc7c711d8da0309f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81691 Tested-by:core-ci <typo3@b13.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Jonas Eberle authored
This adds a line break between concatenated "inline" JavaScripts in order to keep JavaScript without trailing ';' valid. Resolves: #99503 Releases: main, 12.4, 11.5 Change-Id: Icf902679c715687c5be2e5f572526608ce31f882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81687 Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
- Nov 05, 2023
-
-
Justus Moroni authored
Resolves: #102192 Releases: main, 12.4, 11.5 Change-Id: I0cc48e27d32b6d6164d9d580121968610a9333b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81654 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Josef Glatz authored
This patch fixes some typos and adds a missing quotation mark in the code example. Resolves: #102316 Releases: main, 12.4 Change-Id: I4f234b028a6cb8ca7b6b151366cf575dfc86a90e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81653 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
- Nov 04, 2023
-
-
Oliver Bartsch authored
Since #94977, the record icon's markup is rendered in JavaScript, using the icon-element component. To display a possible overlay icon, the corresponding identifier is now also forwarded and passed to the element. Resolves: #102167 Relates: #94977 Releases: main, 12.4 Change-Id: I648112b8bd66efcd9935c0b32c987c1e7477ab90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81682 Tested-by:
-
Benjamin Franzke authored
@lit/task graduated from a 2-year @lit-labs phase, to an officially supported helper library for lit elements. We want to start using it as it embraces a tri-state model for async operations: * pending * complete * error …which is important in order to always handle error cases instead of silently ignoring them. Also existing or currently running requests are aborted and/or ignored when a newer state has already been activated. The icon-library deduplication caching strategy is refactored into a reusable helper instance that is a bit more generic and allows to abort (ref counted across duplicate requests) async operations. Commands executed: npm install --save @lit/task npm run build Resolves: #102308 Releases: main, 12.4 Change-Id: If068145a8bc87ae386af38aa6a63e4f19062345f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81683 Tested-by:
-
Benjamin Franzke authored
Use JavaScript object destructuring to "remove" all options from the configuration object, that are consumed by our CKEditor5 wrapper. Also cleanup RTE resource and config handling to not write unused options into the configuration array and to avoid resolving legacy (CKEditor4) resource paths which are dropped anyway. As a drive-by, dots are now substituted with '_' in RTE field IDs to avoid the following hassle: Dots are interpreted as CSS classes when the ID value is used in combination with a number sign (#) to create a CSS selector for the respective field ID. That means the selector will not match. The class selector additionally becomes invalid once there is a digit after the dot, as CSS classes need to start with strings. (Example: EXT:styleguide in_flex » tab » rte.2). Resolves: #100784 Resolves: #101437 Releases: main, 12.4 Change-Id: I076b838c03588ad6eb8ad075a9df58501f146376 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81535 Tested-by:
-
- Nov 03, 2023
-
-
Andreas Kienast authored
This commit updates bootstrap to version 5.3.2. Executed commands: npm install --save bootstrap@^5.3.2 npm run build Resolves: #102311 Releases: main, 12.4 Change-Id: I9aac1214c6f6024a61a317fe5b7576e8c03f7fd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81678 Tested-by:
-
- Nov 02, 2023
-
-
Achim Fritz authored
To prevents sql errors when inherit from SuggestWizardDefaultReceiver and adding a JOIN statement, the fields are now prefixed with the table name. Resolves: #102298 Releases: main, 12.4, 11.5 Change-Id: I608bd30df1b878aec8dbf611e70049c1be88778a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81650 Reviewed-by:
-
Julian Mair authored
The new v12 TypoScript parser removed one undocumented feature of the old parser in particular: Nested constants. The core does not implement this anymore since it is extremely hard to find a solution that scales well. The problem becomes complicated with recursive usage combined with values that may change at any point. There are however a couple of instances that need this feature and can't migrate away easily or at least not without giving them a longer transition timeframe. For this reason, the patch introduces an event in the Frontend rendering chain that allows listeners to manipulate the calculated constants AST structure. This gives event listeners a chance to traverse the calculated FE constants AST before it is cached and further processed. Implementing a resolver of nested constants should be possible this way, even though extensions probably restrict their implementation to limited scenarios. This event is essentially a "last resort" solution: It works in an environment where the AST is still marked internal, and where the dispatching may still be moved around to other places. As such, this event is *not* marked as official feature. It does not come with a ReST file, and it may change or vanish in future major versions in case it becomes a headache during further development. It is tailored for developers who can't move away from nested constants and need an intermediate solution right now. Resolves: #101752 Releases: main, 12.4 Change-Id: Idd6fb12e0bf53ae48d0f3f790f792655ab217b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81652 Tested-by:
-
- Oct 31, 2023
-
-
Benjamin Franzke authored
AjaxRequest uses an own AbortController instance in order to provide the abort() method. It therefore passes the corresponding AbortSignal instance as a forced option to fetch(), and overwrites any custom signal that is passed as request options. In order to support custom AbortSignal's passed as fetch option, the abort event of the custom AbortSignal is now forwarded to the internal AbortController instance. Resolves: #102286 Releases: main, 12.4 Change-Id: I8011c1794acc22a6d9d2e874a02c1a8c97e532dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81613 Tested-by:
-
Benjamin Franzke authored
Lit v3 is a new major release and contains breaking changes, but they do not affect us: It mainly drops IE11 support (which we already dropped) and switches to ES2021 modules (which we already use as well): https://lit.dev/blog/2023-10-10-lit-3.0/#breaking-changes npm install --save \ lit@^3.0 \ lit-html@^3.0 \ lit-element@^4.0 \ @lit/reactive-element@^2.0 npm run build Resolves: #101515 Releases: main, 12.4 Change-Id: I83878b0f78fb42d737f28c5c338759e1869b0181 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81634 Reviewed-by:
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to the latest version and fixes one quirk in our code in order to make our nightly test runs happy again. Executed command: composer require --dev phpstan/phpstan:^1.10.40 -W Resolves: #102294 Releases: main, 12.4 Change-Id: I22b691fbdab5a17cf1328b7613d9c97a98eae861 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81633 Tested-by:
-
- Oct 30, 2023
-
-
Benjamin Franzke authored
Use a string literal to automatically apply escaping to variables via selector``. The is essentially a formatted string with integrated escaping. Resolves: #102207 Releases: main, 12.4 Change-Id: Ieaa45e2efc8c14812ab281ca14b4a0a09cfc957b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81592 Tested-by:
-
Christian Kuhn authored
Minor CGL streamlinings from latest php-cs-fixer. > composer req --dev friendsofphp/php-cs-fixer:^3.37.1 > Build/Scripts/runTests.sh -s cgl Resolves: #102285 Releases: main, 12.4, 11.5 Change-Id: I0cc1fe3c0f81f62a49df00d62d57ef3c593c57df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81610 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Oct 27, 2023
-
-
Garvin Hicking authored
The `EXT:felogin/Classes/Service/RecoveryService.php` makes use of the local $uriBuilder instance building links, however it does not `reset()` it's state before building a URL. It seems this only creates an issue when used in conjunction with `EXT:vhs` (possibly due to adapted fluid/object caching behavior?). Fixing this by resetting the instance as recommended via https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ExtensionArchitecture/Extbase/Reference/UriBuilder.html should take care of this, even though uriBuilder should be a singleton only operating within the scope of a single ActionController. Resolves: #102203 Releases: main, 12.4, 11.5 Change-Id: Idb6089c4b43b6d3352fbbbbeedfa63770959def0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81560 Tested-by:
-
- Oct 26, 2023
-
-
Bastien Lutz authored
CLI commands had to be registered in the extensions `Services.yaml` file with the `console.command` tag. This change enables automatic cli command registration with the tag `console.command` by using the existing `\Symfony\Component\Console\Attribute\AsCommand` symfony PHP attribute. Thus providing an additional and simpler way, without deprecating or enforcing to change already existing registrations. Resolves: #101567 Releases: main, 12.4 Change-Id: I24edf5ad2291ab5b26e3023f13ef490b88dcc98c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81559 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Christian Kuhn authored
Resolves: #101543 Related: #71723 Releases: main, 12.4 Change-Id: If8bc3523b0f3ca1e589baf51f222c2ae476c0376 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81587 Reviewed-by:
-
Nikita Hovratov authored
EXT:form automatically generates FlexForm for form finisher overrides based on YAML configuration in the `finishersDefinition.FormEngine` sub-array. Since the removal of `TCEforms` for FlexForm (#97126), the regex to match valid FlexForm fields did a "too good" job and also added fields from section containers. These were guarded by a negative lookbehind `(?>!\.TCEforms)`. Note the dot. This basically means ignore anything, which has something else before TCEforms (=sections). This was mostly fixed with #101050 by ignoring anything with a dot before `config.type`. Sadly, this also ignored FlexForm identifiers with dots in their name. In this case `translation.language.config.type`. This whole regex thing is a mess and partially was the reason these issues started as soon as something changed in the FlexForm syntax. Now, in order to fix this, section containers are kicked from the array with plain old PHP logic. This way we don't need to come up with a super smart regex like "anything that ends with `config.type` but not preceded by `_arrayContainer`". I tried and I failed. Resolves: #102250 Related: #101050 Related: #97126 Releases: main, 12.4 Change-Id: I5549bdcfcda1b8dc014c11933b140d5c671c36e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81558 Tested-by:
-
Christian Kuhn authored
This may be triggered by invalid FlexForm values that does not contain a 'data' key for whatever reason. Resolves: #100733 Releases: main, 12.4, 11.5 Change-Id: I96924d65af56fd7cf2bb2a97fd4591b3c81f934f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81585 Tested-by:
-
Oliver Hader authored
To identify whether a nonce values was actually used (consumed), `ConsumableNonce` instances are used, instead of `Nonce` objects. The new `ConsumableNonce` inherits from `ConsumableString`. As a result, the `<f:security.nonce>` view helper would increase the consumption counter. This is important for additional cache handling in the frontend rendering context. Resolves: #101751 Releases: main, 12.4 Change-Id: Iea147b0130e3d350f5913dc75f33af61c18e8af3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81580 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Soren Malling authored
See if a object is a instance of \Stringable aswell as a TypeInterface. TypeInterface implements the __toString method but objects coming from extension can rely on either implements \Stringable or have the __toString method Resolves: #102263 Releases: main, 12.4 Change-Id: I840492b0011b60abc3754f215695154c90b7e707 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81579 Reviewed-by:
-
Oliver Hader authored
The new section "Content Security Policy Mutations" in the "Configuration" backend module shows the all available CSP scopes, the compiled CSP header value and all involved mutations in the order they are applied with their origins (static package configuration or dynamic resolution item). Resolves: #102017 Releases: main, 12.4 Change-Id: Id6d5f769400b340698fb463ad21f5e8af29a784a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81577 Reviewed-by:
-
Oliver Hader authored
MutationMode::Extend has some ambiguity when being invoked multiple times on modified ancestor source collections. This change introduces the new MutationMode::InheritOnce, MutationMode::InheritAgain and MutationMode::Append. The implicit behavior of MutationMode::Extend changes from the combination of MutationMode::InheritAgain + MutationMode::Append to MutationMode::InheritOnce + MutationMode::Append to avoid side effects with more configurations modifying the policy. Static mutations loaded from ContentSecurityPolicies.php are ordered accordoring to the packages dependency hierarchy. That is the reason, the configuration from ext:core had to be moved to both ext:backend and ext:frontend. Resolves: #101797 Releases: main, 12.4 Change-Id: I7ab8e9d3f5635783d026f585f15c27ff62189959 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81574 Reviewed-by:
-
- Oct 25, 2023
-
-
Andreas Kienast authored
FormEngine UI has a rather inconsistent markup. Fields within Flexforms may appear within another `div` container, causing issues when trying to mark an erroneous field as such. To solve this short-termed, additional CSS rules are added to cover such cases. In the long run, the FormEngine markup must get consolidated. Resolves: #102252 Releases: main, 12.4 Change-Id: I671fd8fe2edbd2b3592e7f4e1f205544a074ec51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81557 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Andreas Kienast authored
The module `@typo3/core/ajax/input-transformer` is used to automatically prepare payload to be sent via AJAX. One sub-routine converts nested objects into a flat list recursively. However, the check for objects was not sufficient as, in JavaScript, `null` is also of type `object`. This patch hardens the check to consider non-null values only. Resolves: #102256 Releases: main, 12.4 Change-Id: I6cf902f6a4fa045a4f8304059607f8a359a97186 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81556 Tested-by:
Francois Suter <sutfra@gmail.com> Reviewed-by:
-
Benjamin Franzke authored
And therefore maps into a JSON array instead of an object, preventing errors when CKEditor5 operated on the resulting confguration. Resolves: #102230 Resolves: #102245 Related: #102099 Releases: main, 12.4 Change-Id: Ia20e5927b10bbb56763e3fc01cc30c8c4d0252c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81538 Tested-by:
-
Markus Klein authored
A record may not have a t3ver_state, hence accessing this value must be safeguarded. Resolves: #102251 Releases: 12.4, 11.5 Change-Id: Ia2050171276891e08d2e84e750cfa894a7f3291f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81544 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Tested-by:
-
Benjamin Franzke authored
Enable all current PER-CS2.0 rules in order to reflect our current state of coding style. This was missed in #102240 because pre merge didn't perform a full CGL run when @PER was switched to @PER-CS1.0. Resolves: #102247 Related: #102240 Releases: main, 12.4, 11.5 Change-Id: I0e1c833ad99c4e06767dee8a2c4bcb2bdee6eb68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81554 Tested-by:
-
- Oct 24, 2023
-
-
Benjamin Franzke authored
PER-CS2.0 was added as clone of PER-CS1.0 in php-cs-fixer v3.27 in order to implement the new rules that are defined in PER Coding Style 2.0 [1]. The alias PER already points to PER-CS2.0 although the current set of rules are not implemented yet. [2] There is only one rule (single_line_empty_body) that is done by now and more will follow, so we rather pin to PER-CS1.0 for now (and enable single_line_empty_body which we already migrated to) in order to prevent having coding style changes with every php-cs-fixer raise. We rather wait until the 2.0 preset has been finished and is on par with the upstream php-fig definitions and then switch with one change. [1] https://www.php-fig.org/per/coding-style/ [2] https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7247 Resolves: #102240 Related: #102236 Releases: main, 12.4, 11.5 Change-Id: I33377e4e5016f1e5cc8ab08a9e71a933dcd41d93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81553 Tested-by:
-
Till Hörner authored
Since #99739 the foreign record selector for type select no longer shows the record labels but the uids. Change it to show the label again. Resolves: #102244 Related: #99739 Releases: main, 12.4 Change-Id: I91640769eb76cdba42e781588a68aa449cca70c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81537 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Christian Kuhn authored
It's time to update to latest changes of php-cs-fixer to align with current community rules. This brings a rather huge series of changes, main changes due to single_line_empty_body rule which now formats empty class and method body curly braces into a single line, plus changes from function_declaration rule which tends to avoid more whitespaces. The change has a slight impact on phpstan, we regenerate baseline. To reduce backport headaches, this change is backported to v12 and v11. > composer req --dev friendsofphp/php-cs-fixer:^3.35.1 > Build/Scripts/runTests.sh -s cgl > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #102236 Releases: main, 12.4, 11.5 Change-Id: Iea45b10667951672b2194033216c49f580799f55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81513 Tested-by:
-
- Oct 23, 2023
-
-
Jasmina Ließmann authored
The "Limit history to this record" link in the record history module is broken and always uses the same link value. With this patch the correct value will be used. Resolves: #102234 Releases: main, 12.4 Change-Id: Iaf013b82746b03892d295ed8b8a67c3f8c63fbc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81468 Tested-by:
-
Christian Kuhn authored
When a page with a content element that has images assigned is copied in workspaces, a PHP array access error is raised since sys_file_reference TCA has no sortby ctrl. Add an appropriate null fallback. Resolves: #102231 Releases: main, 12.4, 11.5 Change-Id: I453a612a62a359156c8be2e087d1d121f1b9c3ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81466 Tested-by:
-
Uwe Trotzek authored
This change transforms the processed record of FlexForms into a human-readable format. This is especially useful when comparing changes in the history module or the workspaces diff view. The diff needs to be formatted with line breaks and tabs as the output is passed through "htmlspecialchars" before it will be displayed. The white-space css setting needs to be changed to "pre-wrap", because this is the only setting where line breaks and tabs are kept and the text will still be word-wrapped. Resolves: #91148 Releases: main, 12.4 Change-Id: I189555f459a3a96594e9c708b4ee71c908efd970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75117 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christoph Lehmann authored
The PreviewSimulator might turn on the includeHiddenPages flag in VisibilityAspect due to hidden pages in current the rootline. The flag is now taken into account when generating the rootline cache identifier and thus the rootline cache doesn't need to get flushed. Resolves: #102205 Related: #17599 Releases: main, 12.4 Change-Id: If5246c9297d00071852968d48801d35f4060d110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81465 Reviewed-by:
-
Josef Glatz authored
This patch improves the readability of the record history view of an element which was edited in switchTo mode by showing the original user always on a new line. div tags are used instead of span tags, to reduce any dependency on bootstrap classes for displaying an element as display:block. Resolves: #102200 Related: #102091 Releases: main, 12.4 Change-Id: I873711d4be6651ff15ae82e0bd7cbc4c6bf16e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81464 Tested-by:
-
- Oct 22, 2023
-
-
Nikita Hovratov authored
RuntimeException is never thrown in the executed code of ImageViewHelper. Reason is, that the image either is inside the fallback storage "0" or it was already caught by InvalidArgumentException catch block. For reference: There is no way to find out, which RuntimeException the author meant to catch. I assume it was the one in AbstractFile->getStorage (code: 1381570091). Resolves: #102223 Related: #71686 Releases: main, 12.4 Change-Id: Ia08c085a13c29b4188f955887dcaa0410c2f47b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81463 Tested-by:
-
Nikita Hovratov authored
This is a follow-up patch for #102220. A dedicated fileadmin path has been added for ImageViewHelperTest and unnecessary fixtures are removed. In addition, error message checks are added for the invalidArgument test cases in order to clarify, what exactly is supposed to go wrong. Resolves: #102221 Related: #102220 Releases: main, 12.4 Change-Id: I03404c5f15f1a67032fce01febc4a9a5214373f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81462 Reviewed-by:
-
Nikita Hovratov authored
- Remove duplicate test case for src="" and image="null" - Avoid instantiating ImageViewHelper with "new" -> use TemplateView - Add missing scenarios for possible exceptions Resolves: #102220 Releases: main, 12.4 Change-Id: I18b5cdbe7471a53ebb57bbe5521fecc051a24d26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81461 Reviewed-by:
-
