- Jun 16, 2021
-
-
Larry Garfield authored
PSR-3 has specific rules around interpolation: Messages may provide placeholders like {foo} and writers should substitute these in the messages if a context array with such a key is provided. Let's use placeholders correctly. Resolves: #94315 Related: #94356 Releases: master Change-Id: I2c285e84f1832c80828861369e99af9aff6cd267 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Tested-by:core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jun 15, 2021
-
-
Christian Kuhn authored
There are three possible cases an extbase controller action can come up with: a) Return a casual psr-7 response (html, json, ...) b) Return an extbase specific ForwardResponse to dispatch extbase-internally to another action. c) Have a redirect the client should receive to call some other Url. a) and b) are simple in v11 - the action returns a PSR-7 ResponseInterface. c) however throws StopActionException instead, which is caught by extbase Dispatcher and then returned. This is ugly. The patch changes this and deprecates the StopActionException. We can not drop the throw call since that would be breaking, but we prepare towards a clean v12 solution, which leads to the sitation that *all* extbase actions return a response. Resolves: #94351 Releases: master Change-Id: Ie5a53109959a008ab1666f52d5a81e6e7ba3efdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69498 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #94348 Releases: master Change-Id: Ia8c1f5041057f629ea9dfcc3cde6feba5a1cbe2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69497 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Patrick Schriner authored
If a field has a '''double''' eval, '''upper''' and '''lower''' range checks don't work as expected as the value is always cast to an int before comparison. Switching to floor and ceil helps with these edge cases while retaining the casting to int behaviour. Resolves: #94103 Releases: master,10.4 Change-Id: I28b77e2360b86e27e0297a08c5b6d20e0637a0dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69098 Tested-by:
-
- Jun 14, 2021
-
-
Christian Kuhn authored
"<html><head><meta http-equiv="refresh" ..." is discouraged by w3.org [1] and should be implemented as server-side 3** response. Extbase redirectToUri() already sets 303 (default) and adds the Location header. The meta http refresh is obsolete and can be dropped together with the delay argument. [1] https://www.w3.org/TR/WCAG20-TECHS/H76.html Resolves: #94341 Releases: master Change-Id: Ic3c037b0ee9edbc0eebf9f1b50180ca6c3f98ba2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69491 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
TYPO3 v11 will require symfony 5.3.0 (and hopefully further versions once they will be released). Used composer command: > composer req -W "symfony/config:^5.3.0" \ "symfony/console:^5.3.0" \ "symfony/dependency-injection:^5.3.0" \ "symfony/expression-language:^5.3.0" \ "symfony/finder:^5.3.0" \ "symfony/http-foundation:^5.3.0" \ "symfony/mailer:^5.3.0" \ "symfony/mime:^5.3.0" \ "symfony/property-access:^5.3.0" \ "symfony/property-info:^5.3.0" \ "symfony/routing:^5.3.0" \ "symfony/var-dumper:^5.3.0" \ "symfony/yaml:^5.3.0" Resolves: #94340 Releases: master Change-Id: I3777975d144b3424910043f2445d576f885f0e41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69490 Tested-by:
-
Alexander Schnitzler authored
When a ClassSchema is created for a class, all methods inside said class are analyzed along with their parameters. Ever since extbase existed, the parameter type has been read from the doc block. ``` /** * @param \Foo\Bar\Baz $baz */ public function injectBaz($baz); ``` Since the whole reflection api and PHP itself have been improved in the recent past, parameter types can be detected without looking at doc blocks. It is recommended to use native type hints as follows: ``` public function injectBaz(\Foo\Bar\Baz $baz); ``` The doc block is neiter needed nor supported in the near future. Of course, developers may add a doc block but TYPO3 will no longer evaluate that as of version 12.0. Releases: master Resolves: #94115 Change-Id: Ifc68c0cb8a42b8ab589043afbaebf5dd5763eee5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59450 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #94342 Releases: master, 10.4 Change-Id: Ia3d10d9b934788228ceb7c6ec0d3e1a67474b9f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69492 Tested-by:
-
Christian Kuhn authored
After a long way of fixing our code base to have all our tests (unit, functional, acceptance tests) green, TYPO3 now officially runs with PHP 8.0. TYPO3 v11 LTS thus will support PHP 7.4 and PHP 8.0 (and hopefully PHP 8.1 once the dependencies support PHP 8.1). There might be a few PHP notices throughout TYPO3 Frontend and Backend, but all base functionality is now available for PHP 8.0 as well. Resolves: #93631 Related: #94057 Releases: master Change-Id: I5798e6f49ee637b794df096fd44b8157d96b74bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69489 Tested-by:
-
Oliver Bartsch authored
Bootstrap beta3 introduced a regression, which reversed the slide direction. This therefore broke our implementation, since we are using an event listener, evaluating the direction. Because we were not aware of this being "just" a regression instead of an intended API change, we switched the direction in our event listener in #94037, too. In the final 5.0 release, we updated to in #94089, the regression has been fixed, breaking our event listener once again. This is fixed by restoring the initial and correct direction check. Related bootstrap PRs: - https://github.com/twbs/bootstrap/pull/32913 - https://github.com/twbs/bootstrap/pull/33499 Resolves: #94338 Releases: master Change-Id: I0bc4dc2dfd37935fc43e04f311bd850916c31004 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69486 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Christian Kuhn authored
Acceptance tests now properly configure graphics magick, so image generation works for them. This triggeres different and more relevant code paths. composer req --dev typo3/testing-framework:^6.8.4 composer req --dev typo3/testing-framework:^6.8.4 -d typo3/sysext/core --no-update Change-Id: I65dd2061c13479fb031373973860d3204dfe4bbf Resolves: #94339 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69484 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
This fixes a bunch of PHP 8.0 warnings found by acceptance testing. image processing and ext:scheduler are affected for the main part. This makes the ac test suite green with PHP 8.0. The gitlab activation and another testing-framework raise will follow with dedicated patches. The patch brings an additional acceptance test for install tool 'Environment->Image Processing' since this worked well to nail lots of issues with GifBuilder and friends. Change-Id: Id22c7636da76778b75f087d20d7b7260cd2637ee Resolves: #94333 Related: #94057 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69476 Tested-by:
-
Oliver Bartsch authored
Following methods in HttpUtility are deprecated, since they call `die()` / `exit()` and furthermore directly manipulate the HTTP header via `header()`. - `redirect()` - `setResponseCode()` - `setResponseCodeAndExit()` Resolves: #94316 Releases: master Change-Id: Ica1970baf43c7cccb70b3564b229c882c1fe493c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69464 Tested-by:
-
Benni Mack authored
This change aims to reduce all left-over strict type changes, and backwards-incompatible changes in our own code base making sure that TYPO3 can run smoothly with PHP 8. Resolves: #94335 Releases: master Change-Id: I9d1c8966a56a80bb68216ae535547e0bf55e50c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67243 Tested-by:
-
- Jun 13, 2021
-
-
Christian Kuhn authored
The @ error control operator suppresses all errors raised by the expression, right? Well ... If an error handler has been registered, and an error is raised by an @-prepended expression, the error handler is still called with this error. The TYPO3 core error handler thus detects if the error comes from an @-prepended expression to not log / throw. In PHP < 8.0, this can be achieved by checking error_reporting() === 0. With PHP >= 8.0, the @ error control operator has been changed to not suppress fatal PHP errors anymore, which in turn changed the error_reporting() level to 4437 for an error raised "inside" an @-prepended expression. Adapt core to deal with the PHP 8 variant, too. See also: https://www.php.net/manual/en/language.operators.errorcontrol.php#125938 Resolves: #94329 Related: #94057 Related: #94269 Releases: master Change-Id: Ie926685349beae3bdc9edbb288bc674d3115a64c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69475 Tested-by:
-
Christian Kuhn authored
Brings a composer conflict setting to prevent incompatible doctrine/dbal versions, and an acceptance test related fix. composer req --dev typo3/testing-framework:^6.8.3 composer req --dev typo3/testing-framework:^6.8.3 -d typo3/sysext/core --no-update Resolves: #94332 Releases: master, 10.4 Change-Id: Ib1192c5135c02d485c8f28b54755c22a1a50c10f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69481 Tested-by:
-
Christian Kuhn authored
Brings a PHP 8.0 related fix, backend module bug fixes and features representing more v11 related markup. composer req --dev typo3/cms-styleguide:~11.3.0 composer req --dev typo3/cms-styleguide:~11.3.0 -d typo3/sysext/core --no-update Change-Id: I716237ad6256db87f6b6e20081a67fa674c203d5 Resolves: #94331 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69479 Tested-by:
-
Christian Kuhn authored
It's TYPO3\CMS\Core\Tests\Acceptance\Backend\Site\SiteModuleCest not TYPO3\CMS\Core\Tests\Acceptance\Backend\Redirect\SiteModuleCest Resolves: #94330 Releases: master, 10.4 Change-Id: I0661feec976aeeddce179d9177e36e729fc0b72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69477 Tested-by:
-
- Jun 12, 2021
-
-
Christian Kuhn authored
setControllerSubpackageKey(), getControllerSubpackageKey() and property controllerSubpackageKey of extbase Request are essentially an artifact from flow and unused in v11 core. The information is only carried around at one place but never actively used. This @internal handling is dropped with the patch. Change-Id: I546645b58cab351bac408e5772400f9cfe5d7b03 Resolves: #94326 Related: #86521 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69469 Tested-by:
-
Christian Kuhn authored
To further prepare towards a PSR-7 Request in extbase we have to get rid of as many setters as we possibly can. Both methods isCached() and setIsCached() were marked @internal in v10 and related to extbase internal handling. Internal usages have been dropped when extbase introduced PSR-7 Responses with #92502, the methods can be dropped now. Change-Id: I1b72cef669e4bc6bd75cac855bfb18fa47663b63 Resolves: #94319 Related: #94228 Related: #94231 Related: #94223 Related: #92502 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69466 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
One of the main classes. symfony DI does not support having a combination of constructor arguments plus autowired dependencies. This needs to be resolved for systems around FormDefinition: * FormDefinition itself looses its inject* method for ObjectManager. It's a class not meant to be sub classed by 3rd party extensions. The constructor arguments can be kept, FormDefinition is now instantiated using makeInstance(). * Domain/Model/FormElements/Page and classes extending this class and registering them using implementationClassName for a form must not rely on inject* and initializeObject methods since they need manual constructor arguments. A b/w compat layer detects this and falls back to ObjectManager, even though Page is marked as NOT to be extended by developers. * FormRuntime looses its inject* and initializeObject methods and is instantiated using makeInstance() keeping existing constructor arguments. The class is hardcoded and API does not consider overwriting, so no fallback layer. * Finishers are a bit more tricky: They are often extended in projects, reliable b/w compat is needed. They have one constructor argument and rely on injection. It's useful to keep the injection, so the constructor argument is dropped and substituted with a setter called after initializations. A compat layer detects not adapted classes and falls back to ObjectManager. Resolves: #94317 Related: #90803 Releases: master Change-Id: If157457a6bab568e1f8c32a6f09e60dba0b595f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69462 Tested-by:
-
Christian Kuhn authored
Resolves: #94318 Releases: master Change-Id: I89b74b105c59c9a873b57a6ff3c0a149f888ef94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69465 Tested-by:
-
Oliver Bartsch authored
The internal methods `generateItemList()` and `explodeItemList()` from `ExtensionManagementUtility` are unused since v7 and therefore now removed. Resolves: #94314 Releases: master Change-Id: I6db5cf6e198f7d69ecb58c5ca8dec1e24c9c55a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69463 Tested-by:
-
- Jun 11, 2021
-
-
Christian Kuhn authored
Class TYPO3\CMS\Core\Service\AbstractService as part of an ancient 'services' API has been rendered unused in core with #88646. To further streamline the authentication API and related helper methods, this class is marked deprecated now. This shouldn't have much impact for extensions in the wild, since the API never found many usages apart from core authentication related concerns. Resolves: #94313 Related: #88646 Releases: master Change-Id: I79e303937320f28667814644964acc4aeebd091e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69461 Tested-by:
-
Oliver Bartsch authored
Since removing the last remains of EXT:rsaauth in #94279 the `FE/loginSecurityLevel` and `BE/loginSecurityLevel` options became obsolete and are therefore now removed. Resolves: #94312 Related: #66997 Related: #87470 Related: #94279 Releases: master Change-Id: I03231f4ab798165e4820d67dea2cf44e32b8c4fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69460 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Bartsch authored
GeneralUtility::rmFromList is unused since v10. If at all, this method would better belong to StringUtility. Therefore, it's now deprecated in GeneralUtility, but could be reimplemented in a more performant way in StringUtility, when needed again. Resolves: #94311 Releases: master Change-Id: I2ea5ec57143d70fa2a0de2d2c34230764d3ce204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69459 Tested-by:
-
Oliver Bartsch authored
GeneralUtility::stdAuthCode is unused since at least v9. As more appropriate methods for generating hashes, e.g. GeneralUtility::hmac() exists nowadays, the method is deprecated. Resolves: #94309 Releases: master Change-Id: I3d3678cd8c8c76462cc74b28f629b6679a4aea93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69458 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Andreas Fernandez authored
The method `TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject->getUid()` is declared to return either an int or null, but the annotation mentions int only, which may cause issues with static code analysis tools. Therefore, the annotation is adjusted to reflect both return types. Resolves: #94305 Releases: master, 10.4 Change-Id: I71e8c407085708c473754a398ae2ecf08126274c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69457 Tested-by:
-
Oliver Bartsch authored
All tables were previously wrapped by one form in the recordlist. Since #94218 this leads to problems because all tables now define another form for the "Show columns" selector. Nested forms are invalid markup. Therefore, effectively only the first table was wrapped by the general form. The remaining tables were not longer wrapped into a form, leading to problems when using the clipboard actions. This is now fixed by replacing the all-embracing form with dedicated forms for each displayed table. Besides fixing the mentioned problems, this change results in further improvements: * The forms are now dedicated to their table * The "Show columns" selector does not longer need to define a form itself * When updating the "Show columns" selection or when executing a clipboard action, the recordlist jumps to the correct table after reload, using an anchor tag * The clipboard related JavaScript can be simplified in an follow-up patch Resolves: #94302 Related: #...
-
- Jun 10, 2021
-
-
Oliver Bartsch authored
This removes an invalid attribute from EXT:impexp default layout and furthermore removes unnecessary fluid namespace declarations, since they are defined globally. Resolves: #94306 Releases: master Change-Id: I0ec7181ccc5fb08708257499c969c1d27e783338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69456 Tested-by:
-
Christian Kuhn authored
Inject a singleton service, makeInstance() prototypes. Resolves: #94304 Related: #90803 Releases: master Change-Id: I0645c06a5f5ae2b10f5e14aee08ed01f16720bac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69455 Tested-by:
-
Christian Kuhn authored
Extbase ConfigurationManager is already configured to be injectable. Use this in TranslationService. Resolves: #94303 Related: #90803 Releases: master Change-Id: I6fa2a2e05a2c7b348b411142e8a44c2dad20c3f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69454 Tested-by:
-
Oliver Bartsch authored
Recordlist features the clipboard functionality. When activated, multiple clipboard actions, such as "copy" or "edit marked", are displayed in each tables' header. Since translated records can never be selected, this led to exceptions and JavaScript errors when using such action on the "Page Translations" table. This is now fixed by not rendering those actions for this special table. Resolves: #94296 Releases: master, 10.4 Change-Id: I47459cf1d82d90f634a4f8902ea04c958cbd1bdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69427 Tested-by:
-
Torben Hansen authored
Usage of FriendsOfTYPO3/rsaauth is pretty low and there is no reason to support the extension any more in TYPO3 11. This patch removes all ext:rsaauth related code. Resolves: #94279 Releases: master Change-Id: I8e318bcc3c04fcc66a033507d0dddb931529c17d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69397 Tested-by:
-
Oliver Bartsch authored
This fixes a regression introduced in #94057, which effectively removed the possibility to toggle the clipboard in the recordlist. Resolves: #94301 Related: #94057 Releases: master Change-Id: I6d6ffe9a33bd96f8a41c3f23f3367cf750d29472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69452 Tested-by:
-
Oliver Bartsch authored
Besides all available versions of a TER extension, the "Show all versions" view in EXT:extensionmanager also displays general information such as the category or the dependencies, making it more or less an extension detail view. Since those information are also relevant for already installed extensions, it's now possible to access this view in the "Installed extensions" list, using a new link on the extensions' version string. Resolves: #94298 Releases: master Change-Id: Iab131e5494f143315abd607de1a79f5f0571a2dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69429 Tested-by:
-
Christian Kuhn authored
Register an implementation and adapt consumers. Resolves: #94300 Related: #90803 Releases: master Change-Id: I43117cf3094e0784d05c97d7f28f3365d12bd1f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69431 Reviewed-by:
-
Christian Kuhn authored
An install tool upgrade wizard slated for removal has been forgotten during v11.0 cleanup: FormFileExtensionUpdate has been added for upgrade to v9 (and even backported to v8), has then been kept for update to v10 and can be removed now. Resolves: #94299 Releases: master Change-Id: I882e7ef3926895bcc1e455bc2c0cda287c822680 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69430 Tested-by:
-
Christian Kuhn authored
Make ext:form TypoScriptService injectable and adapt consumers. Fixes a broken $this->objectManager call from #94093 in ConfigurationManager. Resolves: #94297 Related: #90803 Related: #94093 Releases: master Change-Id: Ideaa5b0828d3148ba9cbd7287ab50ed51079ce21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69428 Tested-by:
-
Christian Kuhn authored
The namespace of core TypoScriptService is TYPO3\CMS\Core\TypoScript, not TYPO3\CMS\Core\Service. The entry is thus obsolete and can be dropped. The service with correct name is already handled by ext:core ServiceProvider.php. Change-Id: Ia4a3ef02dd3490547a9379ad57930afdd974a2de Resolves: #94295 Related: #94093 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69426 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
