- Aug 05, 2021
-
-
Benni Mack authored
PHPunit v9 allows to use further improvements to our testing API, and also offers extended support until at least Feb 2022. PHPunit v9 requires PHP 7.3+ which isn't a problem for us per-se. In addition, composer does not complain about an abandoned package anymore if we upgrade to PHPunit 9. In order to achieve this, we need to explicitly require "codeception/phpunit-wrapper:^9.0" which we can then remove later-on again. Used composer commands: > composer req --dev "phpunit/phpunit:^9.5" "phpspec/prophecy-phpunit" "codeception/phpunit-wrapper:^9.0" -W > composer req --dev "phpunit/phpunit:^9.5" "phpspec/prophecy-phpunit" -d typo3/sysext/core --no-update > composer remove --dev codeception/phpunit-wrapper Used rector to migrate all Unit tests to prevent warnings.. Resolves: #94706 Releases: master Change-Id: I68d9df07421149f4ad40964afc512f0f995b295b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69297 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
This fixes an array to string conversion and an undefined array key warning in EXT:form FinisherOptionGenerator. Resolves: #94686 Releases: master Change-Id: Ic6265c36ac0f53d70d85baabf9d1881263027207 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70179 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Referencing other records in workspaces usually works in a way that it is always pointing to the live pendant of a versioned record, never to the versioned record (t3ver_oid>0). However, for MM this is the exception - because MM does not have the workspace context. So when Extbase is resolving a separate query to resolve e.g. a category from a news record, the MM handling kicks in, but always showed the live version, because there was no chance to overlay. Extbase internally first fetches the aggregate root (e.g. news), then does the overlay and building of the object of the main object, and then fires another query to fetch e.g. all attached categories / relations. In case of MM relations for workspaces, they need to be using the versionedUid of the news record, and not the live version. However, since this also affects other relations (IRRE without MM, Select + Group), the RelationHandler is used for workspace'd relations, and adds one additional query to that. This change adapts the place where the query for the properties is built, and takes the UID of the versioned record to resolve the properties attached to it. Resolves: #88021 Resolves: #82750 Resolves: #82086 Resolves: #76993 Relates: #57169 Releases: master, 10.4 Change-Id: I57d34b46d17d504301f54071404d6169ec974676 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68913 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
Martin Tepper <martintepper@arcor.de> Tested-by:
cbugada <christian.bugada@ti.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
When using Online Media (Youtube, Vimeo) with FAL and with composer-mode, the preview images are put under var/transient/ which isn't accessible to the outside. This change adapts the change to be put in typo3temp/assets/online_media/ to be always accessible. In the future, this API should be refactored to have preview images based on processed files instead. Resolves: #93860 Related: #84545 Releases: master, 10.4, 9.5 Change-Id: I086b962a0efad2bcc0c67679838d3d973812462d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69472 Reviewed-by:
Jan Kornblum <jan.kornblum@gmx.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org>
-
- Aug 04, 2021
-
-
Oliver Bartsch authored
In #94622 the TCA type `category` was introduced as replacement for the CategoryRegistry. Therefore, the CategoryRegistry as well as the API method ExtensionManagementUtility::makeCategorizable() are now deprecated. Resolves: #85613 Related: #94622 Releases: master Change-Id: Ie12a643b97e2149981aec3fb1599bf8c8b4a8d64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70202 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Wouter Wolters authored
The labels are now Cut or Copy when the icon is shown is about releasing the content from the clipboard. Resolves: #94627 Releases: master Change-Id: If5f4784f117f02ae7808849aec540f8b322196ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70200 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Helmut Hummel authored
The implementation of the bugfix https://review.typo3.org/53360 was done by iterating over TCA during cache generation and correctly quoting SQL fragments that are provided, to after that store TCA in cache. This has disadvantages: 1. A DB connection is required to create TCA cache: This makes efforts for warming up caches upfront impossible, as cache warmup should be able to be performed on build systems without DB connection. 2. It separates code that executes a query from code that is preparing a query: Escaping arguments for a query in a different place than the actual query execution can be considered an anti pattern, because at other points it isn't clear in which context these values are used. Beside that, performing the actual query, undoing DB encoding and redoing a different encoding is impossible. Pre-processing / quoting identifiers upfront can be considered a similar anti pattern as well. Despite there are less use cases to perform operations on the original non quoted identifiers, post processing of such fields in an event is impossible with the current implementation. 3. The current implementation being buggy and the adoption in TYPO3 is sparse: While this could be tackled with according fixes, it shows that this feature, that has been implemented a couple of years ago and is a technical burden, is rarely used, and therefore the implementation can be simplified and cleaned up. The patch drops this TCA preparation and field name escaping is now done in places where the queries are actually built. Strictly seen this is a breaking change for implementers of the TCA post processing event or for custom code that directly uses TCA to perform query parts. It is unlikely though that such code exists in userland, nonetheless a feature flag "runtimeDbQuotingOfTcaConfiguration" is introduced to allow extensions to also use the feature flag and use the quoting on demand if not done before. For TYPO3 v12, this feature flag will be enabled at all times. Releases: master Resolves: #94697 Change-Id: Ie0e48054def29c6c1e2810c8d30528c719439d9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69507 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
Benni Mack authored
Currently Extbase ships with a custom CacheService which contains all PageIDs where the cache should be cleared once the plugin has been finished processing. In order to reduce the amount of injections within Typo3DbBackend, and decoupled Typo3DbBackend from the actual implementation of how caches are flushed, the cache clearing for pages of specific records is now moved into CacheService directly. This way, a better separation of concerns happens and custom StorageBackends can be implemented without needing to worry about TYPO3's internal cache flushing strategy. On top, it will become simpler to remove the SingletonInterface of Typo3DbBackend, if desired, as it does not keep state of the plugin via ConfigurationManager. Additionally, if we ever want to create a generic Cache Clearing logic (decoupled from DataHandler), we could simply combine CacheService with the new API. Resolves: #94703 Releases: master Change-Id: Ia79c01c35e6440634d2018f890f661acabacd852 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70186 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The "inSet" method is very useful for finding CSV values in fields, however there was never a "notInSet" method which is now available for TYPO3 Core. Resolves: #84115 Releases: master Change-Id: Ied84fa51cb37391c9b814a2cddd5dbeb212fdd44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70152 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
PSR3 ships with a LogLevel class, whereas TYPO3 Core ships its own logging API which is based on a numeric log level syntax. This change reduces the amount of usages of numeric usages of error / message magic (such as TimeTracker), thus, slowly migrating towards PSR3-based LogLevels everywhere. Resolves: #94702 Releases: master Change-Id: I359c88ce50ab94ef1022be975c07f4a7e3c25d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70168 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Georg Ringer authored
If the language mode is chosen in the page module and the default language is selected, only the elements of the default language must be chosen. Resolves: #92460 Releases: master Change-Id: Ieb472967e37d85095d0cdd7c1608c5f48adcfc49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65970 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 03, 2021
-
-
Andreas Fernandez authored
To avoid issues with Flexform section identifiers having any reserved character in CSS context, e.g. a dot, the identifier is now hashed to be able to find the container via `querySelector()`. Resolves: #94541 Releases: master Change-Id: Id2a63ae679e024835284672b2121af9003e58f51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69815 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
Scenario: * a site with another language being configured as "strict" * an Extbase plugin consuming a list of records identified by their respective uid * plugin and records are localized to the site's language Expectation: The plugin receives the UIDs of the original record UIDs having sys_language_uid = 0. The plugin uses a custom Extbase Repository and passes the UIDs as array to a ->in() clause: ``` $query = $this->createQuery(); $query->matching($query->in('uid', [1, 2, 3])); ``` According to the site configuration, Extbase should be able to find these records in the default language and either overlay if translated, or discard them if no translations are available. Actual result: Extbase is not able to find any record and thus returns an empty result set. The identified cause is that Extbase searches the database for the given record UIDs in conjunction with the current language id, returning an empty set by definition. To prove the wrong behavior, tests are added that show the broken behavior, the actual fix will come with another patch in #88137. Resolves: #94694 Related: #88137 Releases: master, 10.4 Change-Id: I9a7a6ec5d1b5cfb82e1fc05365fde6e45df12dfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70192 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Custom icons from extensions can now be registered via EXT:my_extension/Configuration/Icons.php. These files are now loaded and parsed during build-time, and stored in the core cache. Resolves: #94692 Releases: master Change-Id: I9f919510b8913103288e56e824c8a0148e045ad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70178 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Nikita Hovratov authored
The new property '_recursive' allows to define recursive properties of objects. These properties are transformed automatically, without the need to define every entry level manually. Objects can contain a list of the same type like themselves. Examples could be folders containing folders or comments having comments as replies. Resolves: #90347 Releases: master Change-Id: I29b34cf3666c5ad142e51371240501cb85941b5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63181 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Oliver Bartsch authored
In #89700, the page information view in the info module was extended for a new type, which displays the layout related (backend_layout, ..) fields for the corresponding pages. Since there might be field values which are not longer valid, because the referenced backend layout does not longer exist, the new type does now highlight such values with the already known `INVALID VALUE ("<value>")` string. Resolves: #94674 Releases: master Change-Id: I342fff7b8d76694831fa839901250b7d5da7e973 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70194 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
This change removes the internal "newlog()" method from DataHandler. All occurrences are replaced by DataHandler->log() methods, which newlog() acted as a wrapper for it. The main downside of newlog() is that the connection to the actual record (when writing to sys_log) is lost, and no contextual information is kept. This change solves that problem by properly setting the table and record uid to the log method. The main usages for DataHandler->newlog() are put into localization and workspaces/versionable handling. where the "action" is currently set to SystemLogGenericAction::UNDEFINED, because there is no specific type for them. Specific action types have been added for localize, versionize and publishing. The next step in this line of patches are: * Clean up the labels by always using %s or {} for replacements. Resolves: #94685 Releases: master Change-Id: If943dbaba39e1a9c16028b8c64e18b4b42aba902 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70171 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
This change registers FileController as backend controller in Services.yaml and allows to inject all needed dependency via constructor DI. Resolves: #94696 Releases: master Change-Id: Idc14d1ef86bcbd5c4da77f3101b5a97f2a6aa6c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70188 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
This fixes a TypeError by using the correct import. Resolves: #94689 Releases: master Change-Id: Ic54a1b1be27ab3809cfcf38e8aa2096433a771bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70180 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Resolves: #94690 Releases: master Change-Id: I341b73f0c8782c75ca3c4bcf5a7038e6a86fc5dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70127 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change replaces some of the linkThisScript calls to use the UriBuilder / Routing of TYPO3 Backend, and corrects existing UriBuilder calls. Resolves: #94663 Releases: master Change-Id: If2dcb7c4f57b7357087eb88b7383576f3aaede1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69916 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
When uploading an invalid file (or a folder), the message within the filelist now does not contain empty "()" (for the status text) anymore. Resolves: #94691 Releases: master Change-Id: I8fcf62c7bd8a7ef3413e44e787a56fb289e73b83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70184 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Aug 02, 2021
-
-
Oliver Bartsch authored
To ease the use of the new columns selector, especially when dealing with tables, having a large number of columns (e.g. pages or tt_content), a filter is added to the columns selector action bar. The remaining actions, such as "check all" are then bound to the current filter result. This allows to quickly select a specific group of columns. Resolves: #94680 Releases: master Change-Id: I348fcb9b043a2dd5697248be7aebd322c25cdf3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70169 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Extbase provides a couple of generic domain repositories and models, especially frontend / backend users and groups. Those are flawed by design: The main issue is that domain models have to be specific for the domain they are used in. By definition, a generic, opinionated model can't be "correct" since the domain it is used in, is unique: It might be that a backend user email has to be set and the domain does not model anything but email and firstname? Many usages don't need backend groups attached to a backend user model at all, or if they need them, then maybe in a recursive presentation, or a specific order or something similar. Having a default group resolution is thus at least misleading, if not wrong, and can be a performance issue on top. A generic model can never foresee its usages. The existing models thus try to 1:1 adapt the database fields, which is also misleading since a domain model is not and should not be a direct representation of a database table. It would only be by chance if the generic models fit a specific domain. Similar issues exist with the repositories: The CategoryRepository for instance assumes it is a good idea to set respectStoragePid(false), which is most likely not the right thing for an extension use. In the end, whatever extbase delivers here, is most likely wrong and does not fit the problem domain. The patch keeps the 'experimental' FAL related models since those can be actually useful for extensions and their final fate has not been decided, yet. The other generic models, especially those with lots of properties are marked as deprecated with the patch. Change-Id: I06629fddd0258c517f3fa8bdf2e9c4b342be9678 Resolves: #94654 Related: #83296 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70061 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
A new TCA type "category" is introduced, which allows to simplify the configuration of category TCA columns. Besides the benefit for integrators, this allows to deprecate the CategoryRegistry in the next step. The new type can also be used for other use cases. Therefore, the TCA option "relationship" is available for this TCA type. Besides "manyToMany" (default), this can also be set to "oneToOne" or "oneToMany". Using the new type, FormEngine will always render a category tree. This means, no additional `renderType` is defined. In such case, TCA type "select" can still be used as before, without any limitation. However, all relevant places in core are adjusted in this patch. The category element is rendered through a custom element (web component), reducing inline javascript. Resolves: #94622 Releases: master Change-Id: I1b95c42288b070fa6bac114266f5ad246a045b21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69899 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
This fixes wrong input configuration, wrong method calls and adds some missing test cases. - The first parameter of assertSame expects the expected value. All occurrences in DataHandlerTest, which had them mixed up, are corrected. - TCA configuration "type => input" corrected. - Missing test cases with empty string as input added. Resolves: #94682 Releases: master Change-Id: If31ad11bb1e958fd24b1cbdb7d525d056fe3111b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70175 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 30, 2021
-
-
Georg Ringer authored
If the creation date of a system news is cleared by an editor, the rendered news must skip the date. Resolves: #94576 Releases: master, 10.4 Change-Id: I93958ba0e858960dba4b99c0123cedce7dba5539 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69908 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Oliver Bartsch authored
Resolves: #94678 Related: #92953 Releases: master Change-Id: I33073717590a8561c9c5cfe4a1d76bfc627ff949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70164 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
The upstream wincache PHP module is unmaintained, a PHP 7.4 version came late and there is no work for a PHP 8 compatible version on the horizon. The ApcuBackend is a suitable alternative that works on windows platform as ram driven key/value store. The patch deprecates the wincache based cache backend implementation. Resolves: #94665 Releases: master Change-Id: I6e1eb551c048f73d48c85ed498d1cd4caab266d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70130 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The 'pdo' cache backend is of rather little use since the Typo3DatabaseBackend supports the casual DBMS via doctrine/dbal. The backend is also pretty much unmaintained and didn't receive any optimizations over the years in contrast to the Typo3DatabaseBackend. The patch deprecates PdoBackend. Resolves: #94664 Releases: master Change-Id: I584c150b754f0e3bb226dae998051eb389284e10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70129 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Sybille Peters authored
When matching IPv6 addresses (for example in IPmaskList) appending the address with * as wildcards will not work. The function GeneralUtility::cmpIPv6() uses validIPv6() which will fail on an address with *. Using addresses with CIDR-notation, will work for both IPv4 and IPv6 addresses (e.g. 2001:0DB8:1234::/48, 192.16.0.0/16). The description of TYPO3_CONF_VARS and comments for the function in GeneralUtility is updated accordingly. Resolves: #94620 Releases: master, 10.4 Change-Id: Ie068ca579a41cd3c6552e6a302bbe11b0ca2883a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70055 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Scenario: A tt_content default language record with images, assets or media is localized ("translate" / "connected" mode, not "copy") to another language. Attached images, assets and media will be localized, too. If later the default language record is changed to add another image, asset or media, the localized record now shows the additional default language record relation as shadowed box and allows localizing this additional record with a single click. This is done by setting for those TCA inline relations: ['appearance']['showPossibleLocalizationRecords']. Notes: * showPossibleLocalizationRecords works on l10n_parent and does NOT honor l10n_source (yet?): In a 'localization chain' (default is localized to dutch, dutch is localized to german), an additional image, asset or media on the dutch record *is not* shown in the german record, but an additional record in default language *is* shown in the german record. * showAllLocalizationLink: This is an optional additional button to localize all missing relations with one click, not only single ones. This is *not* enabled with the patch: The additional button bloats the already pretty complex interface even more, and editors often only need to deal with one or at least only a small list of additional relations. Instances where editors often deal with lots of such inline relations can easily enable that button on their own. * showSynchronizationLink: The behavior of that button is in practice very similar to showAllLocalizationLink and *not* enabled for similar reasons. Change-Id: I34e469171ac34b06ff0350e8e3725188f6de625b Resolves: #94623 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70058 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Jonas Eberle authored
Due to different handling of scrollbar positioning and layouting in user agents (most use the operating system's graphics stack to show scrollbars, Chrome its own) it could happen that the modulebar icons were shown partially only. It should not be relied on the width of scrollbars and if they affect the user agent's box model or not. In our case an inner element was pixel-perfectly relying on parent elements' box sizes since #93353. This dependency has been removed for the collapsed state. Resolves: #94633 Releases: master Change-Id: Ic573ade55af461935f0cada80a98bf3aaaf9a9c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70066 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Jul 29, 2021
-
-
Simon Gilli authored
For the covenience when creating files with code snippets the indent of .rst is changed to 4 spaces. This works for all cases also for lists where normally 3 spaces are used. Resolves: #94669 Releases: master, 10.4, 9.5 Change-Id: If1ed5927a1e5e17e56edf0696eb4c528599b788c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70159 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Allows to make use of custom properties in backend layouts, e.g. like shown below in Fluid templates: ``` <f:if condition="{column.definition.myFeature}"> <div data-colpos="{column.columnNumber}">...</div> </f:if> ``` Resolves: #94634 Releases: master Change-Id: I2dc2b7324bbcabc55a8896f74c3dd79768a0b87d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70067 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Lina Wolf authored
Fixes Layout problems: Malformed lists, malformed headlines, non-working links to documentation or other changelogs. Directive `:ts:` and `.. code-block:: ts` is only used for typescript, exchanged it into `:typoscript:` for typoscript examples. Resolves: #94534 Releases: master, 10.4, 9.5 Change-Id: I61e3c5910d6a5bc97f1ec887ce5b2c1e6d59a2db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69922 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Neufeind authored
Extend the HtmlParser to support srcset attributes, which can be found in img tags or source tags inside of HTML 5 picture elements, making it fully compatible with responsive images. Change-Id: If47af154b059c0744c3d660c760fb2cc2d703aeb Resolves: #71775 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/44901 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
The nifty ruleset for handling core changelog files described at https://docs.typo3.org/c/typo3/cms-core/10.4/en-us/Changelog/Howto.html sometimes gets violated by the one or the other patch. This happens, so we occassionally synchronize Changelog files between versions. Resolves: #94668 Releases: master, 10.4, 9.5 Change-Id: Ia02af5909687a6f200257b791fee098ced7f32b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70154 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The patch for issue #91123 was originally planned for having a v10 backport, but made it to master only and has been released as 11.0. The Important.rst file has been added to 10.4.x directory, but it should reside in 11.0 directory. Adapt that and fix a reference to it. Change-Id: Ia28b3b7d75b27b5f2d1ccd2fe9ec77a767eaeeae Resolves: #94667 Related: #91123 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70153 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
TYPO3 used RelationHandler for HMENU special=list to fetch all pages for this menu once, but fetched the full records again for MountPoint relation, and manual language + workspace overlay was taken care later-on. Once menus were generated with mountpoints and workspace and language overlays, the ordering was not in line, and existing queries were not used. Instead, the code is now simplified and fully relies on PageRepository functionality, just as most other Frontend-related code. Resolves: #94643 Releases: master Change-Id: Ib86116a74c7db6739c474e5efb13b77284e41b08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70112 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org>
-