Skip to content
Commit 4586d38c authored by Benni Mack's avatar Benni Mack Committed by Andreas Fernandez
Browse files

[BUGFIX] Remove DataHandler->newlog() functionality

This change removes the internal "newlog()" method
from DataHandler. All occurrences are replaced
by DataHandler->log() methods, which newlog() acted as
a wrapper for it.

The main downside of newlog() is that the connection
to the actual record (when writing to sys_log) is lost,
and no contextual information is kept.

This change solves that problem by properly setting
the table and record uid to the log method.

The main usages for DataHandler->newlog() are
put into localization and workspaces/versionable
handling. where the "action" is currently set
to SystemLogGenericAction::UNDEFINED, because
there is no specific type for them. Specific action
types have been added for localize, versionize and
publishing.

The next step in this line of patches are:
* Clean up the labels by always using %s or {} for replacements.

Resolves: #94685
Releases: master
Change-Id: If943dbaba39e1a9c16028b8c64e18b4b42aba902
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70171


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent fb59fbc9
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment