- Feb 24, 2017
-
-
Morton Jonuschat authored
Deprecate BackendUtility::getRecordsByField() as it has a flawed design due to passing SQL fragments. This contradicts the goal of using named parameters for all queries in the core and requires passing the original QueryBuilder object in addition to the stringified constraint. Replace all calls to the method with direct usage of the QueryBuilder and deprecate the method. Resolves: #79122 Releases: master Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003 Reviewed-on: https://review.typo3.org/51078 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benjamin Franzke authored
All redirect status codes (e.g. 201,301,303,307) are incorrectly sent as 302. We need to set the response code before setting the Location header, as a call to header('Location: ...'); sets the response code implicitly to 302 (unless it has already been set to 201 or 3xx) [1]. By settings the status code/header first, header('Location: ..') will not change the status code, if the PSR-7 response object contains a proper redirect status code. [1] http://php.net/manual/en/function.header.php The second special case is the "Location:" header. Not only does it send this header back to the browser, but it also returns a REDIRECT (302) status code to the browser unless the 201 or a 3xx status code has already been set. Change-Id: Ifa076e6393c6ed42d93959fe8c3a5b79cee145a4 Fixes: #79043 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51002 Tested-by:Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
Marco Huber <mail@marco-huber.de> Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Josef Glatz authored
Add a description field also for fe_users records which could be used as for already known other record types. Resolves: #79894 Releases: master Change-Id: Ia1d7ad7746a0b7dd3ebb809864e290db97ac228d Reviewed-on: https://review.typo3.org/51745 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Jasmina Liessmann authored
Use Bootstrap grid for arrangement of search form fields. Resolves: #79848 Releases: master Change-Id: Ied1b30a2ba81b339ac93a9a874720b43623e6e66 Reviewed-on: https://review.typo3.org/51812 Reviewed-by:
Jasmina Ließmann <code@frauliessmann.de> Tested-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- Feb 23, 2017
-
-
Helmut Hummel authored
Fix the changed path as well Resolves: #79980 Releases: master Change-Id: I5b23e4bb56f47d151b506439c4e46b9c0838bd87 Reviewed-on: https://review.typo3.org/51811 Reviewed-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Morton Jonuschat authored
Introduce dedicated fixures for the export data based on the database platform being tested. Due to mysqlnd and PDO based drivers returning different types of values (mainly int vs string) the resulting XML is dependent on the database. Change-Id: I776cfbc28c7355e72c21fa89097077f94225e223 Resolves: #79798 Releases: master Reviewed-on: https://review.typo3.org/51774 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
Christian Futterlieb authored
In order to avoid time-based hash-based attacks, the native PHP security functions are used instead of simple string comparisons, when comparing passwords with hashes. Change-Id: I0dbe2c12c5017f9d71ea7628ddd35d919510ac12 Releases: master Resolves: #79888 Related: #79795 Reviewed-on: https://review.typo3.org/51737 Reviewed-by:
Mads Lønne Jensen <mlj@systime.dk> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Thomas Hohn authored
During copying of pagetrees various sql statments are executed. One on sys_file_reference has a bad performance and can benefit from an index. Fixes: #79604 Releases: master Change-Id: I2caa83db6259ad6baad75427b5040a11ece768ba Reviewed-on: https://review.typo3.org/51512 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Christer V <cvi@systime.dk> Reviewed-by:
Claus Due <claus@phpmind.net> Tested-by:
Morten Pless <mpl@systime.dk> Reviewed-by:
-
Sascha Nowak authored
In the current implementation it is not possible to create a new translations outside of the default translation. So we can readd the new translation option when the record has a default translation. Change-Id: I89c4200ff847dadfdeec03b5f43a6577f40702e3 Resolves: #72797 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51092 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Stefan Froemken authored
It is not possible to change or override cropVariants via TSconfig for sys_file_reference (e.g. for a specific user or page tree branch), thus making the cropping functionality a pain for bigger sites. Setting a FormEngine option as expected like TCEFORM.sys_file_reference.crop.config.cropVariants.* does now work. Resolves: #79812 Releases: master Change-Id: I9d36f6661c2a5ca051b803f06485fdb4c8c8a437 Reviewed-on: https://review.typo3.org/51676 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Sascha Egerer authored
* Ensure that variables are correctly initalized. * Fix some php docs. * Initalizes for loop iterator variables before the loop if they are also used after the for loop is finished. * Remove superfluous function arguments. Resolves: #79892 Releases: master Change-Id: I75109b2914f2b05806a303837b7aad79be8e3707 Reviewed-on: https://review.typo3.org/51742 Reviewed-by:
-
Christian Kuhn authored
Change-Id: I89f5e73ab896d6cd4dac46ebc9e64e14643adbeb Resolves: #79725 Releases: master Reviewed-on: https://review.typo3.org/51800 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Mona Muzaffar authored
valuePicker appends and prepends now in the correct order. Change-Id: Ic97b8a66469d43d9269f67f1de3f0cb40d1e8321 Resolves: #79937 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51779 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Frans Saris authored
The introduction of the new crop variants #75880 broke the handling of cropped images when using typoscript to render file(reference)'s This patch fixes the rendering of cropped images and introduces the new cropVariant option to the typoscript object IMG_RESOURCE Releated: #75880 Resolves: #79883 Releases: master Change-Id: Icba77d76c6914d48dcc57d7e8c48471ed27c44b3 Reviewed-on: https://review.typo3.org/51753 Reviewed-by:
Johannes Goslar <jogo@kronberger-spiele.de> Reviewed-by:
-
Mona Muzaffar authored
Skip tests downloadALanguage() and activateAndDeactivateALanguage() Tests need to be fixed. Change-Id: I999359a83e0d8e092fda483a7799c70110eb10e4 Resolves: #79962 Releases: master Reviewed-on: https://review.typo3.org/51798 Tested-by:
-
Oliver Hader authored
In case TCA field values have not been migrated yet, but their TCA at the same time already being updated to allowLanguageSynchronization, then the field values are not considered in the upgrade wizard. This change now includes manually updated TCA settings as well. Resolves: #79950 Related: #79658 Releases: master Change-Id: Id239c569e3731691a54015642e56a6450c09badc Reviewed-on: https://review.typo3.org/51692 Tested-by:
-
- Feb 22, 2017
-
-
Benni Mack authored
There are still some properties and additional method call arguments that are not evaluated properly anymore and can be omitted. Resolves: #79959 Releases: master Change-Id: Ifc4ed71891394af4c80eaa9c4bb987f79c980a73 Reviewed-on: https://review.typo3.org/51793 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Claus Due authored
Solves three issues: * Namespace declaration output in templates without sections * Potential error from unexpected input argument in sanitizePath * Rendering of new HeaderAssets / FooterAssets sections in uncompiled templates. Adds two Fluid features: * Namespace detection is now in sync with TYPO3 CMS. * Escaping modifier `{escaping off}` now supported. And allows the removal of two custom Fluid integrations contained in TYPO3 which are now included in Fluid. Change-Id: Ic9cd73d1d05688139241c81e6a3fb78998fe9407 Resolves: #79847 Resolves: #79811 Releases: master Reviewed-on: https://review.typo3.org/51711 Tested-by: -
Benni Mack authored
Streamlined EXT:about extension as a first step to clean up the whole TYPO3 Core base: - Moved locallang file to EXT:about, as it is only used in this extension - Removed usage of TYPO3_LOADED_EXT/ext_emconf.php in favor of PackageManager (needed to add the authors into each Package) - Fully added all external libraries in use (not including -dev requirements) - Moved EqualHeight.js to EXT:about as it is only used in this extension - Proper usage of Fluid layouts - Streamlined code, variables, imports and comments - Reviewed comments in PHP Resolves: #79948 Releases: master Change-Id: Ia6c2d6b519bc34847131f06908c2c441b9248a8b Reviewed-on: https://review.typo3.org/51790 Tested-by:
-
Christian Kuhn authored
The ImageCropUpdater of the install tool does not need the not-yet-migrated TCA it does not rely on any TCA that may have changed. Remove that section from the code. Change-Id: I8ed4190fd53d87f368c978b183b99b562dba9444 Resolves: #79951 Releases: master Reviewed-on: https://review.typo3.org/51792 Reviewed-by:
-
Georg Ringer authored
- Use a div instead of an input field to avoid issues like tooltip not shown because of the disabled attribute. - Trigger onchange from LinkBrowser popup - If no value found, show the input field, which makes it easier to e.g. enter an external url. - Show helpful title for toggle button on hover Resolves: #79667 Related: #79670 Releases: master Change-Id: If00d892d0ae7aebe0dfc5f17f5d43af16d0ee730 Reviewed-on: https://review.typo3.org/51592 Reviewed-by:
-
- Feb 21, 2017
-
-
Christian Kuhn authored
Fix for issue #78628 fixed "addItems" for TCA trees, but broke them for select drop downs. Juggle icon providing around a bit to fix. Change-Id: I3a1077992a7db0d72bc2d7d0247292763cc25958 Resolves: #78747 Related: #78628 Releases: master Reviewed-on: https://review.typo3.org/51766 Tested-by:
-
Johannes Kasberger authored
This change fixes a regression after the doctrine migration and additionally fixes a wrong join condition which is also present in version 7 Resolves: #79931 Resolves: #79932 Releases: master Change-Id: I04a4ce174fb1da3baca9af8ba771a7db70d9a884 Reviewed-on: https://review.typo3.org/51782 Tested-by:
-
Benni Mack authored
There are some methods and properties which are conceptually in the wrong place or are outdated. $TSFE->compensateFieldWith (and config.compensateFieldWidth) are not in use anymore (since TYPO3 7), as this belonged to the very very old FORM cObject. $TSFE->excludeCHashVars was superseeded with cHash calculation in v6, but never removed. $TSFE->scriptParseTime (and $TSFE->setParseTime()) is a public property and solely there for one use, storing the calculated time between the request start and end. This does not need to be located inside TSFE, as the functionality can be the same, but built in the request handler, removing a cross-dependency. $TSFE->generatePage_whichScript() This alternative method to be used for including raw PHP include files via requireOnce and config.pageGenScript dates back to the plain PHP files index_ts.php and pagegen.php which can safely be marked as outdated now via better PHP class abstraction and hooks. The overall goal is to achieve better separation of concerns, and thus TSFE should only contain what it needs (dealing with rendering a page based on TypoScript settings). PageGenerator:: pagegenInit() Unlike the other methods in PageGenerator this method has one simple job: Setting $TSFE public properties based on TypoScript settings. This surely needs to be merged into TSFE, as this is one of the core jobs of TSFE. It also helps to avoid very unsuccessful attempts to override certain parts of the Frontend Request as the static calls to PageGenerator cannot be overriden at all. TSFE->encryptCharcode and TSFE->encryptEmail() Both are only needed in ContentObejctRenderer and are there moved as protected methods and used solely there. Resolves: #79858 Releases: master Change-Id: Iabd351a0b5fd7c8cc242f66ba1e9799377fb9390 Reviewed-on: https://review.typo3.org/51717 Tested-by:
-
Tomita Militaru authored
Notice message for lockDomain option that it can be circumvented by faking HTTP_HOST Resolves: #75104 Releases: master Change-Id: I9b83ab7380123a78a2b99b8ab8127a4fcc69beb4 Reviewed-on: https://review.typo3.org/49751 Tested-by:
-
Frans Saris authored
The internals of the LinkBrowser and LinkHandler depend on all the field specific info to be in the P parameter. Further the DatabaseBrowser used by the RecordBrowser fetches the table parameter form global url query scope what collides with the params set by the CKEditor RichTextElement. To prevent the parameter collision the params set by the RichTextElement are moved to the P prefix what is also more inline with the other LinkBrowser implementations. This patch also resolves the lasts issues related to the new recordHandler + CKEditor. Resolves: #79645 Releases: master Change-Id: Id7cab0f0a012c5de11a2038e1d579d87599d47cd Reviewed-on: https://review.typo3.org/51760 Tested-by:
-
- Feb 20, 2017
-
-
Nicole Cordes authored
This patch re-adds the possibility to manually trigger a reload of static database data an extension might ships. In the EM list view, an inconspicuous button is added for each extension which has an own ext_tables_static+adt.sql file. Furthermore the import is changed, so that a md5 hash of the file content is stored in the database. If the extension is updated and the content if the file changes, a more visible button is shown to indicate an update should be considered. Resolves: #60748 Releases: master, 7.6 Change-Id: I8ccb01d7e1f98a4adfc70a4d1aa80db4e76bbc9d Reviewed-on: https://review.typo3.org/51310 Tested-by:
Joerg Kummer <service@enobe.de> Reviewed-by:
-
Thomas Hohn authored
Fix that run-time error will be thrown if $dataStructureArray['sheets'] is not an array. Fixes: #79426 Releases: master Change-Id: I9b7549a5b79d0d5b8b2e27df407879812c1aa491 Reviewed-on: https://review.typo3.org/51399 Reviewed-by:
-
Sascha Egerer authored
There is a break statement missing in a switch case statement. Currently this does not have any side effects but to prevent wrong behavior in the future this should be fixed. Resolves: #79906 Releases: master Change-Id: I2adf40adb1f8df5dcfcdb31f8e9ccddd2b885961 Reviewed-on: https://review.typo3.org/51759 Tested-by:
-
Sascha Egerer authored
There is a css rule containing a `:has()` rule. This rule is not supported in any browser yet and there must be also no whitespace between the `:has` and the opening brace. Resolves: #79890 Releases: master Change-Id: Ief60c287f1bd0f95c6b61fde0e6f50704978357f Reviewed-on: https://review.typo3.org/51739 Tested-by:
-
Markus Klein authored
Since TYPO3_CONF_VARS may contain nested arrays and the array keys for those subarrays may collide with first-level citizens (e.g. BE) the current description parsing (parsing of PHP source code file) fail hard for those cases. The problem is not solvable without writing a dedicated full PHP parser in order to have proper notion of nesting levels. For this reason the regex-based parsing is completely removed and a new and dedicated file for the option descriptions is introduced, which stores the description into a PHP array. This frees us from the buggy PHP code parsing with regex and enables us in the future to enhance this array with more information. (e.g. extract data type into a dedicated subarray element) Resolves: #79920 Releases: master Change-Id: Idb5d3fdd2dee5f3150b52c66e65d06c028750893 Reviewed-on: https://review.typo3.org/51772 Reviewed-by:
-
Josef Glatz authored
Improve visual differentiation of content and copyright notice. A visual hruler is added. Font-size and color is slightly adopted. Resolves: #79895 Releases: master Change-Id: Idd7190d860c6083d3333b82dba9a796a0bce0e2c Reviewed-on: https://review.typo3.org/51746 Tested-by:
-
Frans Saris authored
Resolves: #79836 Releases: master Change-Id: I29fb6f0f31a54b6f20c937881a8b523b844dde69 Reviewed-on: https://review.typo3.org/51749 Tested-by:
-
Thomas Hohn authored
Setting the property $checkStoredRecords in DataHandler to false leads to missing information in sys_log for new records since the $newRecord array is empty. This patch fills the $newRecord array with the newly inserted or updated data - however the only thing that can't be retrieved is the title since this is fetched through the call to checkStoredRecord that is not executed. Resolves: #79669 Releases: master Change-Id: I2a53bc2880402fbb42fad859c9fef2dd7c5ae167 Reviewed-on: https://review.typo3.org/51568 Reviewed-by:
-
Morton Jonuschat authored
Fix ExpressionBuilder::inSet() to allow working with columns on a seondary table on Non-MySQL databases. Fix the usage of inSet() within Typo3DbQueryParser to properly quote the table identifier and ensure that all places that use inSet() use it to compare a string value or a field on a table. Fix assertions to take string/int differences into account and ensure consistent order when asserting lists of records. Change-Id: I9fecd228cde1a7d5a6202702616d806b4354eb4f Resolves: #79796 Releases: master Reviewed-on: https://review.typo3.org/51733 Tested-by:
-
Morton Jonuschat authored
MySQL has support for backslash escape sequences. Change the tests to have the expected results without the additional escaping and add the additional slashes to the expected result if the database platform running the tests is MySQL. Change-Id: Ib2e30e95db507501aaea095eb3764a0d37135ec9 Resolves: #79799 Releases: master Reviewed-on: https://review.typo3.org/51765 Tested-by:
-
Tymoteusz Motylewski authored
Since context menu refactoring the file deletion did not work. This patch fixes the issue, by adding missing line in JS. Resolves: #79916 Releases: master Change-Id: I939f153aa1d5eae22f821ede98329774e63a3757 Reviewed-on: https://review.typo3.org/51768 Reviewed-by:
Malte Koitka <malte@cytrus.de> Tested-by:
-
Morton Jonuschat authored
Replace the MySQL specific backtick quoting with the actual quote character in test checking for SQL fragments/quoting of fields. Change assertions that assume integer return values from the database driver to also accept string types using assertEquals(). Resolves: #79797 Releases: master Change-Id: I1f78b0b65cdcceeaefa23902d14fa0988198d849 Reviewed-on: https://review.typo3.org/51764 Tested-by:
-
Christian Kuhn authored
The "addAndDeletePage" acceptance test is still unstable, even with multiple people trying to stabilize that thing already. To raise acceptance of acceptance tests during core development, this one is skipped for now. Resolves: #79913 Releases: master Change-Id: I55ac9ede4b241a737046d1c0ee16618c314f9d79 Reviewed-on: https://review.typo3.org/51767 Tested-by:
-
Frans Saris authored
Resolves: #79854 Releases: master Change-Id: Ib7cc81efda1c59d54ab30af00622456955cf7397 Reviewed-on: https://review.typo3.org/51752 Reviewed-by:
-
