- Jun 18, 2024
-
-
Philipp Kuhlmay authored
This patch provides some examples for the type=uuid in ext:styleguides 'basic' table including a generator for this type. Resolves: #104117 Related: #100171 Releases: main Change-Id: Ifbf0abe28c6730e31c922992bbeadebe587c71a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84724 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
core-ci <typo3@b13.com>
-
Jochen Roth authored
Currently, the notification/alert container does not allow scrolling when multiple notifications exceed the viewport height and it is not possible to clear all displayed notifications. This has been changed to allow scrolling within the container. On top of this, it is now also possible to focus the container using tab and scroll up and down using the arrow keys and clear all notifications with a single click. Resolves: #104069 Releases: main Change-Id: I6f4c27bff84942a3f161310da85a04957648218d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84659 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
When using the "columnsOnly" mode to render just a subset of available fields of a record, while the subset includes a field of TCA type "slug", FormEngine needs to also render configured generator fields. Otherwise the slug fields won't work as expected, e.g. when recalculating. However, since it might be confusing for an editor to get fields rendered, which were not selected, are those fields now rendered as hidden fields. This is done by adding those fields to a hidden palette while omitting duplicates and performing sanitization. Resolves: #104115 Releases: main, 12.4 Change-Id: Ia31571bae9913028e81df910462d76dc4314644c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84721 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
Long VARCHAR() fields tend to eat up quite a bit of "65k bytes maximum row size" space, especially with utf8mb4. The patch changes TCA type="input" fields longer than 255 chars from VARCHAR() to TEXT (65k bytes). This looks like a sane tradeoff between limits and storage efficiency. Extension authors who need or want to override default TCA schema details for whatever reason, can of course do so by defining something specific in ext_tables.sql. Resolves: #104146 Related: #101553 Related: #104098 Releases: main Change-Id: I4a0b38e84ac1f12c9605c48188c6f28b400c59ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84774 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Wand <wand@itaw.de> Tested-by:
-
Benjamin Franzke authored
Improve document-service responsiveness by relying on `DOMContentLoaded` and `document.readyState` >= `interactive`. 1) Handle non-loading state as "ready" to avoid waiting for `complete`. `document.readyState` has three states: * `loading` The document is still loading. * `interactive` The document has finished loading and the document has been parsed but sub-resources such as scripts, images, stylesheets and frames are still loading. The state indicates that the DOMContentLoaded event is about to fire. * `complete` The document and all sub-resources have finished loading. The state indicates that the load event is about to fire. If DocumentService.ready was called in "interactive" state we have been skipping this state as we only considered `complete` to be the "ready" state in this case. This is wrong as we actually wait for the DOMContentLoaded if we are launched in the initial readyState (`loading`), that means an initial `interactive` must be understood as: `DOMContentLoaded` has already been fired as state is `interactive` We should actually avoid waiting for `complete` entirely, as document readyState `interactive` means "ready" in terms of document parsing. We're not interested in images or async scripts that are still loading and want event listeners to be registered as early as possible. With this improvement applied we can also drop the (now) unneeded `load` event-listener, as we are no longer skipping interactive state (this made the `load`-listener necessary previously). Note that the `load` workaround was previously needed for IE<=10 as those versions set `document.readyState` to `interactive` prior to the `DOMContentLoaded` event. This applied workaround becomes a race condition once `load` never happens and that is the case with a recent google chrome regression which causes iframe documents to never "complete": https://issues.chromium.org/issues/347724924 2) Drop the timeout logic. It is no longer needed now that we only need to wait for `DOMContentLoaded` – which will always fire (or already fired) – instead of the `load` event. 3) Avoid creation of new promises for every invocation of the ready-method. A promise can be reused without side effects by multiple consumers. This avoids creating a lot of event listeners (and previously timers). 4) Remove unneeded document and window references. Releases: main, 12.4, 11.5 Resolves: #104135 Related: #104139 Change-Id: I42c86961405f8a5c346c17ea429a288a85d58f8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84742 Reviewed-by:Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Benni Mack authored
Resolves: #103212 Releases: main, 12.4 Change-Id: If285a5cb1bb418ef7671ca6894827a059e5c1cb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84741 Tested-by:
-
Christian Kuhn authored
This was a VARCHAR(255) before #104098, which considers TCA 'max' property and thus reduced it to VARCHAR(80). To avoid upgrade issues, 'max' is now increased to 255, which makes it a VARCHAR(255) again. Resolves: #104143 Related: #101553 Related: #104098 Releases: main Change-Id: I96f36ed1259473550ae4bd29b646b1d23f74b706 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84772 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
Prefer TEXT over VARCHAR(2048) for pages:canonical_link. This gives more "room" for other bigger fields in this table. It is possible since #103578 allows to handle DEFAULT with TEXT. Resolves: #104138 Related: #104063 Related: #101553 Related: #104068 Related: #103578 Releases: main Change-Id: I1bd82ce016565d83fe654331b83c930f0da49cfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84748 Reviewed-by:
-
Christian Kuhn authored
Argument passing using `--` works well. It's time to remove the previous `-e` solution. Resolves: #104137 Related: #104131 Related: #102769 Releases: main, 12.4, 11.5 Change-Id: I99577a24dda77c4c96813f8ca14c2a27bdf7f2de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84745 Tested-by:
-
Georg Ringer authored
The backend layout wizard now uses a working example by using an existing icon. Resolves: #91910 Releases: main, 12.4 Change-Id: If6df3bd73d1ff6dc1a7a3e71cadf2e89b1a18bd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84529 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Lina Wolf authored
Resolves: #104134 Releases: main Change-Id: I810e9cd34d6b4e409386ecddf40549468456e24d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84740 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Stefan Bürk authored
This change requires PHPStan on the current newest version. Note: In v12 the phpstan baseline is regenerated to adopt for changed reporting behaviour. Used command(s): composer req --dev "phpstan/phpstan":"^1.11.5" Resolves: #104136 Releases: main, 12.4 Change-Id: I7f88c4c3942e22e1536e12a883411f66a3eee3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84743 Reviewed-by:
-
Christian Kuhn authored
Inline the 'random seed' option for -s unitRandom, replay a specific seed using: > runTests.sh -s unitRandom -- --random-order-seed=<number> Resolves: #104131 Releases: main, 12.4, 11.5 Change-Id: I84e1cc0a0c57a5132a592a140d1b58ceb6d3b059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84735 Reviewed-by:
-
Georg Ringer authored
Cast the value to strings before using strcasecmp for sorting. This allows to use integers for sorting the array. Resolves: #102573 Releases: main, 12.4 Change-Id: I2dea688e6e5a24e7292a1fede2ca294f8bbd3347 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84631 Reviewed-by:
-
Torben Hansen authored
This change resolves the `@todo` in `AbstractFormFieldViewHelper` by using the suggested method from `PersistenceManager`, which has been implemented with #42505. Resolves: #103749 Related: #42505 Releases: main Change-Id: I15a840568e80dacd8ce36aa1d6182eac6a3b74de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84072 Tested-by:
-
- Jun 17, 2024
-
-
Garvin Hicking authored
Once the ExtensionScanner hits a '@extensionScannerIgnoreLine' annotated code line, it internally sets a flag that is never reset. That causes all following lines to be ignored, not just one. This patch will reset the property `$isCurrentLineIgnored` to `false` again, once the annotated line has passed. Tests are adapted to verify this behaviour. Due to the behavioral change it is possible that the scanner now finds more hits in third-party scanned extensions that previously may have been ignored. Resolves: #100702 Releases: main, 12.4 Change-Id: Ib1cbb5e7758e7e302e4395d759e8585eeff15d8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84716 Reviewed-by:
-
Torben Hansen authored
This change removes redundant typecasts in ext:fluid, where the variable type already matches the type being cast. Resolves: #104122 Releases: main Change-Id: I9ff2f0eaeae1f931179dcfe85c99d877e67dd132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84728 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Christian Kuhn authored
The release comes with a nifty memory usage improvement and probably allows us to avoid a couple of hacks we've used, which we'll clean up later. Raise for now. Core v12 will raise phpunit 10 instead. > composer req --dev phpunit/phpunit:^11.2.2 Resolves: #104127 Releases: main, 12.4 Change-Id: I4faf1af0378e2996324b3db101709764a31419b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84730 Tested-by:
-
Christian Kuhn authored
Have a switch/case for the main per-type construct and avoid loops per type. Resolves: #104110 Related: #101553 Releases: main Change-Id: I8c4751a266c979fa96f78a6328e1a70e02e1b91f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84714 Tested-by:
-
Christoph Lehmann authored
BackendAccessDeniedException is thrown due to inproper client ip. BackendLockedException is thrown when the backend is locked. Both cases are desired behaviour, so they should not get logged. Resolves: #104120 Releases: main, 12.4 Change-Id: If29f4bb58d78a3a3dfcd6d1815ae1b0404311662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84726 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Andreas Kienast authored
When EXT:workspaces is installed, backend users with granted permissions may now search for workspaces in the LiveSearch and invoke certain, related actions. Resolves: #102869 Releases: main Change-Id: I6fd9a67708cdf70ef13f6395641c30fb51a7d4a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82516 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Jun 15, 2024
-
-
Philipp Kuhlmay authored
This fixes some labels in EXT:styleguide Resolves: #104107 Releases: main, 12.4 Change-Id: I04fb8067220879aca1341e93d7ab4e00990387fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84723 Reviewed-by:
-
Andreas Nedbal authored
Backend users can now search for the backend modules they have access to in the LiveSearch. Resolves: #92009 Releases: main Change-Id: I28d9593655989f064b7a7fac0ab80415eee4c6fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84654 Tested-by:
-
- Jun 14, 2024
-
-
Simon Praetorius authored
This patch adds a new condition-based Fluid ViewHelper which allows integrators to check for feature flags from within Fluid templates. Resolves: #104020 Releases: main Change-Id: I76d19f4ec4888268b51fb9358812a870d79db41c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84719 Tested-by:
-
Oliver Bartsch authored
A new multi record selection option is added to the filelist, which allows to edit the metadata of multiple records while respecting the currently defined columns list. Resolves: #104095 Releases: main Change-Id: Ib679628f280116de47e6f59ec5e3cec0e4f9535a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84695 Tested-by:
-
Oliver Bartsch authored
A new multi record selection option is added to the recordlist, which allows to edit multiple records while respecting the currently defined columns list. Resolves: #104085 Releases: main Change-Id: I740a8b31381bbc03c178e4b2048c760f5d31afd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84682 Tested-by:
-
Oliver Bartsch authored
Defining columnsOnly, which is used by the EditDocumentController to instruct the FormEngine to only render a subset of available fields for records is now table aware. This allows to render records from different tables in the same request, while respecting the fields to be rendered on a per-table basis. The "columnsOnly" parameter therefore now requires the fields as array under the corresponding table name: &columnsOnly[pages][0]=title A backwards-compatibility layer is in place, migrating the previous syntax to the new one by adding the configured fields for the tables from the edit configuration. Resolves: #104108 Releases: main, 12.4 Change-Id: I46500100eb369ad117a2cf5c61a9811c6fd5c7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84711 Tested-by:
-
Christian Kuhn authored
We've had quite a few patches to streamline and clean up indexed_search. This patch continues these efforts. ext_conf_template.txt debugMode from 2014: "Only for debugging since it slows down the system and fills the database with crap." This is still true: Enabled debugMode fills the database with crap. Looking closer at the functionality, we decided to remove it without substitution: * Persisting debug info triggered by FE scaling with the number of pages or worse isn't a great idea in the first place. * This debug is more log-like, we do have rotation handling of large logs, but of course not for something like this debug table. * It's risky enabling debugMode in dev and then accidentally deploying this to live, potentially ending up with a *huge* table. * The debug data is actually not really helpful: It basically logs the ext config (boring and redundant) over and over again, plus some close to never changing info which file parsers are registered, plus FE content. Important parts derived from this FE content is already stored in index_phash, and the content *itself* is cut at 1000 chars, which isn't helpful either. There is actually nothing fancy in this table that couldn't be discovered with true debugging tools by developers. The patch removes the ext_conf_template.txt debugMode setting, plus the table. This is not considered breaking since it's internal and not extendable ext:indexed_search functionality. Resolves: #104104 Releases: main Change-Id: I492cd63171d97c77b8f8d56d748d8e09123f4e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84708 Tested-by:
-
Christoph Lehmann authored
Local resources are currently not "cache-busted", for example, have no version in URL. TypoScript has no possibility to add the cache buster. When replacing them a new filename must be used (which feels little hacky), because web clients may have cached the old file version. This introduces 1) getText "asset" to cache-bust assets in TypoScript .. code-block:: typoscript page.20 = TEXT page.20 { value = { asset : EXT:core/Resources/Public/Icons/Extension.svg } insertData = 1 } # Result: typo3/sysext/core/Resources/Public/Icons/Extension.svg?1709051481 2) cache-busted assets with the :html:`<f:uri.resource>` ViewHelper .. code-block:: html <f:uri.resource path="EXT:core/Resources/Public/Icons/Extension.svg" /> Before: typo3/sysext/core/Resources/Public/Icons/Extension.svg Now: typo3/sysext/core/Resources/Public/Icons/Extension.svg?1709051481 The ViewHelper argument :html:`useCacheBusting` is enabled by default. Depending on FE/versionNumberInFilename the cache buster is applied as query string or embedded in the filename. Resolves: #99203 Releases: main Change-Id: Ie421a1a9b08b542686437bb65c8663e433045a58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018 Reviewed-by:Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Christian Kuhn authored
Add 'title' column to TCA to it auto created in DB. Resolves: #104109 Releases: main Change-Id: I246bb64825bae93d252937a04f32ebb9548212d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84713 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104065 Releases: main, 12.4 Change-Id: I48c121620bf84a9444ff3c9d79d1adfd1fa631f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84655 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
-
Benni Mack authored
In order to enable more possibilities in the events, the PSR-14 events in EXT:felogin are extended with the PSR-7 request object, otherwise the events are useless as $GLOBALS['TYPO3_REQUEST'] must be used. Currently, it is f.e. not possible to modify the view ModifyLoginFormViewEvent based e.g. on a site configuration. Resolves: #104100 Releases: main, 12.4 Change-Id: I9daa6481d71fd1cae98d0a7ab01fe1adc7602748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84696 Reviewed-by:
-
Bingquan Bao authored
The documentation contained a wrong registration code example, which now uses the proper array depth level notation. Releases: main, 12.4, 11.5 Resolves: #104105 Change-Id: Idb3c9b0e723af2f1bb579bc304637497e1272e36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84709 Tested-by:
-
Torben Hansen authored
Extbase validators do currently not provide the possibility to include PSR-7 request related data for validation. With this change, validators extending extbase `AbstractValidator` will include the PSR-7 request object when instantiated by `ValidationResolver`. Extension developers can use data available in the PSR-7 request object in custom validators. Resolves: #102951 Releases: main Change-Id: I3012c778078de1b69cecfb36f05ce8f9794adf88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82895 Reviewed-by:
-
Benni Mack authored
The StandardContentPreviewRenderer has some quirks, which allows to render the content via a Fluid Template via Page TSconfig. mod.web_layout.tt_content.preview.textmedia = EXT:site_mysite/Resources/Private/Templates/Preview/Textmedia.html This is now done via a PSR-14 EventListener. This was previously (back in v10) not possible while the legacy "Page module" and the "Fluid-based" page module existed and the PSR-14 event was not possible. This way, the StandardContentPreviewRenderer is trimmed down. Also, some additional logic is now restructured within the StandardContentPreviewRenderer in order to separate the class into smaller pieces. Also, the TextmediaPreviewRenderer as well as the ImagePreviewRenderer are not needed anymore. Resolves: #103603 Releases: main Change-Id: I879b913529c5928b67d2f98a438015719fc55f86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83744 Tested-by:
-
- Jun 13, 2024
-
-
Christian Kuhn authored
Field / column 'repository' is obsolete since #92457, but couldn't be removed at this point in time. It's possible now. Resolves: #104102 Related: #92457 Releases: main Change-Id: I5ebcc65f5f9520b065ad3bddba728566b1264325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84704 Tested-by:
-
Andreas Kienast authored
With the upgrade to Bootstrap 5, the panels have no explicit position anymore, breaking the progress bars in the Extension Scanner found in the Install Tool. This commit adds a relative positioning to the panels. Resolves: #104073 Releases: main, 12.4 Change-Id: Ie67989dbcfa859ebc3020dabaa27913de7ae4b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84663 Tested-by:
-
Nikita Hovratov authored
The goal here is to have a generic PreviewRenderer, which is not tt_content specific. The StandardContentPreviewRenderer could then extend this generic renderer. This is a pre-patch to make the refactoring easier in the next patch. For this to work, GridColumnItem now exposes methods to retrieve the table from the context, the type column and the record type. Additionally, some drive-by refactorings have been done like early return statements and stricter checks. The unused variable $infoArr has been removed as well. Resolves: #102825 Releases: main, 12.4 Change-Id: I38eab3c095e06b789915600e79b7831556a25ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82442 Tested-by:
-
Benni Mack authored
While cleaning up BackendLayout code, a "declare(strict_types=1);" line was introduced, which made existing v13-compatible PHP code break. This is now reverted in order to smoothen the upgrade path to v13 LTS. Resolves: #104099 Related: #103365 Releases: main Change-Id: Ic0de7e903da365178d5e417ff5eeb60c00f1b516 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84701 Reviewed-by:
-
Georg Ringer authored
The bookmark title within the following modules is enriched by the page id: - Info module Resolves: #103909 Releases: main, 12.4 Change-Id: I715a55dea86ac08f1a3dbeeff01e8d1b03712464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84523 Tested-by:
-
